patient_http 1.6.0 → 1.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 54ede397ae79574e7dd597ea642b4d039877d5d642ba49c68b76219b8b1c4a32
-  data.tar.gz: 83bb067b78912753791e6002abb3470ca70936f5fe862fc65ee65d7786e1ac53
+  metadata.gz: 3b3bb6335d47143a8f6e8123be222265651c3e3cee1c8a0084f3aae02b6f6444
+  data.tar.gz: 9c0a549ff00b9861073fd9853d82a6736c26bf34fca3ac689acf14008968abd5
 SHA512:
-  metadata.gz: 0302b8cdf7042fa545e49ab1ce565d5f7d1fd388a8413bc8a19249477d46d2fc9f732142d75afbb6cc52d0dd7a228e01c6f0c1cbaea2f7b151568472ccfaecb4
-  data.tar.gz: f418c2d7b5b48ba81ac73de35533143d7e99c75fb108a619f9cf9a55ca204f56f42ffec86ee4fc6d2796730703aad488014955603f87fc94ccf3e66d6b7b8593
+  metadata.gz: c13e5e339088c84e7977ba82c6484780a890076af083d2dbf2754bf1ff0eb05d6a28d585be4d56b13bf5a052d00b643b2c8d44b90a5766fab9cd426c03375830
+  data.tar.gz: cdf38eeac4823f3cb922001541c3d9425c993cc4ce075ca80ff427d2a79a6d38928999518cd690181aaa8d4064554ea087666a54bb426a829809135dc0c4bf35

data/CHANGELOG.md

@@ -4,6 +4,16 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 1.6.1
+
+### Fixed
+
+- Request headers with a `nil` or empty string value are no longer sent. `HttpHeaders` drops such entries when it is built from a hash (so `{"X-Header" => nil}` does not set the header) and removes the header when a value is set to `nil` or `""`, including through `merge`. Some servers reject requests that carry a header with no value.
+
+### Added
+
+- `HttpHeaders#delete` removes a header by name (case insensitive) and returns its value.
+
 ## 1.6.0
 
 ### Added

data/README.md

@@ -309,7 +309,7 @@ error = PatientHttp::HttpError.load(json_data)
 
 The `Response` object includes the HTTP status code, headers, body, and callback arguments. Error objects (`HttpError`, `RedirectError`, `RequestError`) include the error message, context about the request, and callback arguments.
 
-Response headers are case insensitive. Headers that appear multiple times in the response (such as `set-cookie`) are flattened into a single joined string value.
+Request and response headers are case insensitive. A request header with a `nil` or empty string value is never sent: setting a header to `nil` or `""` removes it, and a header hash such as `{"X-Header" => nil}` does not set the header at all. Headers that appear multiple times in the response (such as `set-cookie`) are flattened into a single joined string value.
 
 Response bodies are automatically encoded for JSON serialization. Binary content is Base64 encoded, and large text content is gzipped and then Base64 encoded to reduce payload size. Decoding is handled transparently when you access the `body` or `json` methods on the `Response` object.
 
@@ -868,6 +868,8 @@ Please use the [standardrb](https://github.com/testdouble/standard) syntax and l
 
 The [patient_http-sidekiq](https://github.com/bdurand/patient_http-sidekiq) and [patient_http-solid_queue](https://github.com/bdurand/patient_http-solid_queue) gems each provide a test application for integration testing.
 
+Running the full test suite requires running the included docker-compose.yml file to start up a valkey and s3mock server.
+
 ## Further Reading
 
 - [Architecture](ARCHITECTURE.md)

data/VERSION

@@ -1 +1 @@
-1.6.0
+1.6.1

data/lib/patient_http/http_headers.rb

@@ -5,16 +5,20 @@ module PatientHttp
   #
   # This class provides a hash-like interface for HTTP headers with case-insensitive
   # key access. Header names are normalized to lowercase for storage and lookup.
+  #
+  # Headers with an empty value are never stored. Setting a header to nil or an
+  # empty string removes it, so a request never sends a header with no value.
   class HttpHeaders
     include Enumerable
 
-    # Initializes a new HttpHeaders instance.
+    # Initializes a new HttpHeaders instance. Entries with a nil or empty value
+    # are skipped.
     #
-    # @param headers [Hash] initial headers to set
+    # @param headers [Hash, HttpHeaders] initial headers to set
     def initialize(headers = {})
       @headers = {}
       headers&.each do |key, value|
-        @headers[key.to_s.downcase] = value
+        self[key] = value
       end
     end
 
@@ -26,12 +30,26 @@ module PatientHttp
       @headers[key.to_s.downcase]
     end
 
-    # Sets the value for a header (case insensitive).
+    # Sets the value for a header (case insensitive). Setting a header to nil
+    # or an empty string removes it.
     #
     # @param key [String, Symbol] header name
-    # @param value [String] header value
+    # @param value [String, nil] header value
     def []=(key, value)
-      @headers[key.to_s.downcase] = value
+      name = key.to_s.downcase
+      if empty_value?(value)
+        @headers.delete(name)
+      else
+        @headers[name] = value
+      end
+    end
+
+    # Removes a header (case insensitive).
+    #
+    # @param key [String, Symbol] header name
+    # @return [String, nil] the removed value or nil if not found
+    def delete(key)
+      @headers.delete(key.to_s.downcase)
     end
 
     # Fetches the value for a header with an optional default.
@@ -102,5 +120,12 @@ module PatientHttp
     def hash
       @headers.hash
     end
+
+    private
+
+    # A header value is empty when it is nil or a string with no characters.
+    def empty_value?(value)
+      value.nil? || (value.is_a?(String) && value.empty?)
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: patient_http
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.6.1
 platform: ruby
 authors:
 - Brian Durand
@@ -146,7 +146,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.3
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Generic async HTTP connection pool for Ruby applications using Fiber-based
   concurrency