patient_http-sidekiq 1.4.0 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0f463cc156486ac04ea624baf032e3ebd37d219149a720fd5044a864a9abf201
-  data.tar.gz: 0b294c6cb0df108ca53fd872c71d284fd82ab0a42284769eb2af7f04ca25bd76
+  metadata.gz: e20cb0bf0d79d325dd9a236f246ceec4d9ab8c5cc948208ae33692d8e4d8b3cb
+  data.tar.gz: e3bb8edde618556e2a05e1f4d4269b1b2a547dd4df3d64d8ac18b5582a4dbdf4
 SHA512:
-  metadata.gz: b9ab7cebbc773fb92baba7d58212a8fd3733392b4a93d995bdfa7ad3b03d70e1cd3637d8ebddc68c7178ca400b1adc1219ab65ef8cd3c7b9e4b852a0245b11e3
-  data.tar.gz: 994e51c5f8d7df504f6be4ee32bdd1e32607e62672bf7f0d228d9758af8f2e1b473844063c20951726b4d2ccc37f5eae7549ce4a3796633004195a82af1bcc23
+  metadata.gz: ce53d2907c8f793ec468f02f747d9fb09b1386cdbaf47499158bfd5df14807d0d5599736da57b82b4c6d7d25422224fdfb92a338ae43e116479547911128d55d
+  data.tar.gz: 7e936ff57e3f6e71ee4bea13741d5e361b7d0f640187e33ce7309e08c18f605c5ec870c389cdf34dcbf53b2d97a3975fd543800cece6d30bb2e2ca90a338cd4e

data/CHANGELOG.md

@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 1.4.1
+
+### Fixed
+
+- The request handler is no longer unregistered when the processors stop. Sidekiq fires its `shutdown` event before its worker threads finish, so a job that submitted a request during the shutdown window raised `No request handler registered` and the request was lost. The handler now stays registered for the life of the process, and a request submitted after the processors have stopped is enqueued as a Sidekiq job and executed by the next process.
+
 ## 1.4.0
 
 ### Added

data/README.md

@@ -331,7 +331,7 @@ end
 
 For classes that make many async HTTP requests, you can include `PatientHttp::RequestHelper` to get convenient instance methods like `async_get`, `async_post`, `async_put`, `async_patch`, and `async_delete`. You can also define a request template at the class level using the `request_template` class method to set shared options like `base_url`, `headers`, and `timeout`.
 
-When using this gem, the request handler is automatically registered when the processor starts and unregistered when it stops — no manual setup is required.
+When using this gem, the request handler is automatically registered when you call `PatientHttp::Sidekiq.configure` or when the processor starts — no manual setup is required. The handler stays registered when the processor stops, so a request submitted while the process is shutting down is enqueued as a Sidekiq job and executed by the next process instead of being lost.
 
 ```ruby
 class NotificationService

data/VERSION

@@ -1 +1 @@
-1.4.0
+1.4.1

data/lib/patient_http/sidekiq.rb

@@ -383,15 +383,16 @@ module PatientHttp
         end
       end
 
-      # Stop all processors gracefully
+      # Stop all processors gracefully.
+      #
+      # The request handler stays registered. Sidekiq fires its shutdown event while
+      # jobs are still running, and a job that submits a request after the processors
+      # have stopped must have it enqueued as a job for the next process rather than
+      # raise. Only {.reset!} removes the handler.
       #
       # @param timeout [Float, nil] maximum time to wait for in-flight requests to complete
       # @return [void]
       def stop(timeout: nil)
-        if @request_handler
-          PatientHttp.unregister_handler(@request_handler)
-        end
-
         @lifecycle_mutex.synchronize do
           # Shared services can outlive the processors when a start failed part
           # way through, so tear them down whenever any of them exist.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: patient_http-sidekiq
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.1
 platform: ruby
 authors:
 - Brian Durand
@@ -122,7 +122,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.3
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Offload long-running HTTP requests from Sidekiq workers to a dedicated async
   I/O processor