pathway 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 04ddcc9225aeeabdd7e65aecad90097af5fd702f
-  data.tar.gz: 6814518d323632b5d65c0991ae84e286fd02678d
+  metadata.gz: eca65bc52c6fa39373453028d7d4224f6988b17d
+  data.tar.gz: 317ff6a30090f55e0924a3dfbdf211d9bfff2c4b
 SHA512:
-  metadata.gz: 9ee6f6f6254eb3c615e473c3ff6ba000df3d5538a8d31849d5d9161718fec3d79c9ba47ff9620658dbd3a7726d604fd858eb76f58f6f697640b35e9b1db246b2
-  data.tar.gz: 359b11969cd277940be18a94c7709acf514808b8816aa3172a2474932ad5f03c0ffcdb26e613e85be1acca685bc5a540e3e3db2a0e5948bb7ada94a519c09fcd
+  metadata.gz: 37fe53ced0b65f33cc1e2f69495d98de78236d77cf66e4209359f6f0730cd69d05a011f6edb12bb41eb12a4d31b4ec4fb5d83f2cb377f7c9e533ae48717c24f2
+  data.tar.gz: bc8d46dfb83c0dfecd78e94c9216c361b5bfa5e2030ff2cca74cfbf1c5ce3b405860ab71c5c179d5877314605e3c3184f9f7a8101e95493d4151c05b3ac4bf24

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## [0.5.1] - 2017-12-18
+### Changed
+- Change behavior for `:fetch_model` step option `search_by:` to override both the search column and the input key (combine it with `using:` if you need a different value for the input key as well)
+- `:fetch_model` step will no longer hit the database if the input key is nil and just return a `:not_found` error instead
+
 ## [0.5.0] - 2017-11-6
 ### Changed
 - Change base class for `Pathway::Error` from `StandardError` to `Object`
@@ -20,7 +25,7 @@
 
 ## [0.0.20] - 2017-10-17
 ### Changed
-- Renamed options `key:` and `column:` to `using` and `search_by`, for `:fetch_model` step, at `:sequel_models` plugin
+- Renamed options `key:` and `column:` to `using:` and `search_by:`, for `:fetch_model` step, at `:sequel_models` plugin
 
 ### Added
 - Added new option `to:` for overriding where to store the result, for `:fetch_model` step, at `:sequel_models` plugin

data/README.md

@@ -616,7 +616,7 @@ module Pathway
         def transaction(&steps)
           transactional_seq = -> seq, _state do
             ActiveRecord::Base.transaction do
-              seq.call
+              raise ActiveRecord::Rollback if seq.call.failure?
             end
           end
 
@@ -654,7 +654,7 @@ Let's now examine the `fetch_model` step body, is not really that much different
 
 We finally see a `DSLMethods` module defined to extend the process DSL.
 For this plugin we'll define a way to group steps within an `ActiveRecord` transaction, much in the same way the `:sequel_models` plugin already does for `Sequel`.
-To this end we define a `transaction` method to expect a steps block and pass it down to the `sequence` helper below which expects a callable (like a `Proc`) and a step list block. As you can see the lambda we pass on the first parameter is the one that makes sure the steps are being run inside a transaction.
+To this end we define a `transaction` method to expect a steps block and pass it down to the `sequence` helper below which expects a callable (like a `Proc`) and a step list block. As you can see the lambda we pass on the first parameter is the one that makes sure the steps are being run inside a transaction and to abort the transaction if the intermediate result is a failure.
 
 The `sequence` method is a low level tool available to help extending the process DSL and it may seem a bit daunting at first glance but it usage is quite simple, the block is just a step list like the ones we find inside the `process` call; and the parameter is a callable (usually a lambda), that will take 2 arguments, an object from which we can run the step list by invoking `call` (and is the only thing it can do), and the current state. From here we can examine the state and decide upon whether to run the steps, how many times (if any) or run some code before and/or after doing so, like what we need to do in our example to surround the steps within a DB transaction.
 

data/lib/pathway/plugins/sequel_models.rb

@@ -42,9 +42,10 @@ module Pathway
         delegate %i[model_class search_field] => 'self.class'
         delegate :db => :model_class
 
-        def fetch_model(state, from: model_class, using: search_field, search_by: search_field, to: result_key, overwrite: false)
+        def fetch_model(state, from: model_class, search_by: search_field, using: search_by, to: result_key, overwrite: false)
           if state[to].nil? || overwrite
-            find_model_with(state[:input][using], from, search_by)
+            wrap_if_present(state[:input][using])
+              .then { |key| find_model_with(key, from, search_by) }
               .then { |model| state.update(to => model) }
           else
             state

data/lib/pathway/version.rb

@@ -1,3 +1,3 @@
 module Pathway
-  VERSION = '0.5.0'
+  VERSION = '0.5.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pathway
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Pablo Herrero
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-11-07 00:00:00.000000000 Z
+date: 2017-12-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: inflecto