password_strength 0.3.0 → 0.3.1

data/CHANGELOG.rdoc

@@ -39,3 +39,7 @@
 * Increased required password length to 6 characters
 * Added support for custom validators
 * Added Windows 2008 validator
+
+== 0.3.1 - August 12 2010
+
+* The enabled option was ignored in some cases.

data/lib/password_strength/active_record/ar2.rb

@@ -45,9 +45,11 @@ module PasswordStrength
       raise ArgumentError, "The :level option must be one of [:weak, :good, :strong]" unless [:weak, :good, :strong].include?(options[:level])
 
       validates_each(attr_names, options) do |record, attr_name, value|
+        next unless PasswordStrength.enabled
+
         strength = options[:using].new(record.send(options[:with]), value, :exclude => options[:exclude])
         strength.test
-        record.errors.add(attr_name, :too_weak, options) unless PasswordStrength.enabled && strength.valid?(options[:level])
+        record.errors.add(attr_name, :too_weak, options) unless strength.valid?(options[:level])
       end
     end
   end

data/lib/password_strength/active_record/ar3.rb

@@ -6,6 +6,7 @@ module ActiveModel # :nodoc:
       end
 
       def validate_each(record, attribute, value)
+        return unless PasswordStrength.enabled
         strength = options[:using].new(record.send(options[:with]), value, :exclude => options[:exclude])
         strength.test
         record.errors.add(attribute, :too_weak, options) unless PasswordStrength.enabled && strength.valid?(options[:level])

data/lib/password_strength/version.rb

@@ -2,7 +2,7 @@ module PasswordStrength
   module Version # :nodoc: all
     MAJOR = 0
     MINOR = 3
-    PATCH = 0
+    PATCH = 1
     STRING = "#{MAJOR}.#{MINOR}.#{PATCH}"
   end
 end

data/test/active_record_test.rb

@@ -76,6 +76,7 @@ class TestActiveRecord < Test::Unit::TestCase
   end
 
   def test_ignore_validations_when_password_strength_is_disabled
+    User.validates_strength_of :password
     PasswordStrength.enabled = false
     @user.update_attributes :password => ""
     assert @user.valid?

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: password_strength
 version: !ruby/object:Gem::Version 
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors: 
 - Nando Vieira
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-08-11 00:00:00 -03:00
+date: 2010-08-12 00:00:00 -03:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency