passive_record 0.4.4 → 0.4.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3bbf676f1d3d94dce7e4b0b0d2faa89476149335
-  data.tar.gz: c1607589beb7a3f7cf199cf1f8bdaf67b12568bc
+  metadata.gz: 4650224c2791ed204faef1985b4ea12f646dae7e
+  data.tar.gz: 9a0af9c4a3d86353cffa3b1b860040de882a2e59
 SHA512:
-  metadata.gz: 158a69a9f39cb6cd8df9dae55f2a4554498af25d3044c94d3f1b3af69ed7ee810891efa365470ebb95fddfe151de963d8aa9abc94066638f46ee47259af44acd
-  data.tar.gz: 23c5791750f524c311a0e98f3849e7b399f28c883b174635289eb25d1ccfa09662c6b35d4c103d18f18321471feb6579465e9998db66e7ab2edb34232194cf0a
+  metadata.gz: 6a1c134e1dbac7da33ffe7055f31b7b263deb1c4e7be5cd02b91b252370a07c00c2a7918e1230ea83259ff19d7e10fd3b3705bdc22e6c9c049826d9abd00d368
+  data.tar.gz: f84219b4fbca873039a48d226e5b20d91854bc2a8083c67ed2e3d78f6f0e3ef5d6a49c85d1fd7e450a5d6d718b69af154425fe3257a36bc434577a6901b03445

data/README.md

@@ -184,7 +184,7 @@ PassiveRecord may be right for you!
   `conditions` here is expected to be a hash of attribute values. Note that there is special behavior for certain kinds of values.
 
   - Ranges select models with an attribute covered by the range (behaving like `BETWEEN`). For instance you might query for users with birthdays between yesterday and today with `User.where(birthday: 1.day.ago...1.day.from_now)`
-  - Arrays select models with an attribute whose value is in the array (behaving like `IN`), so for instance you may query for users whose job title is included in a list of job titles like: `User.find_all_by(job_title: ['manager', 'developer', 'qa'])`
+  - Arrays select models with an attribute whose value is in the array (behaving like `IN`), so for instance you may query for users whose job title is included in a list of job titles like: `User.where(job_title: ['manager', 'developer', 'qa'])`
   - Hash values (subhashes) select models with related models who attributes match the inner hash. So `Doctor.where(appointments: { patient: patient })` would lookup doctors whose appointments include an appointment with `patient`.
 
 ## Hooks
@@ -199,7 +199,7 @@ PassiveRecord may be right for you!
 # Prior Art
 
   - Approaches exist that use ActiveRecord directly, and then override various methods in such a way to prevent AR from trying to persist the model. The canonical example here is the [tableless model](http://railscasts.com/episodes/193-tableless-model?view=asciicast) approach, and the use case given there is a model that wraps around sending an email. This is maybe interesting because, similar to the round-trip with a database, sending mail is externally "effectful" (and so, for instance, you may wish to take additional care around confirmation or retry logic, in order ensure you are not sending the same message more than once.)
-  - These approaches are seen as somewhat hacky today, given that [ActiveModel](https://github.com/rails/rails/tree/master/activemodel) can give plain old Ruby objects a lot of the augmentations that ActiveRecord gives, such as validations, hooks and attribute management. However I don't really see a way to do relations that interoperate with ActiveRecord the way you could, at least to some degree, with tableless models.  
+  - These approaches are seen as somewhat hacky today, given that [ActiveModel](https://github.com/rails/rails/tree/master/activemodel) can give plain old Ruby objects a lot of the augmentations that ActiveRecord gives, such as validations, hooks and attribute management. However I don't really see a way to do relations that interoperate with ActiveRecord the way you could, at least to some degree, with tableless models.
   - It's not really clear to me yet if it's interesting for PassiveRecord to be able to interoperate smoothly with ActiveRecord relations. It seems like we might be able to pull some similar tricks as the "tableless" approach in order to permit at least some relations to work between them.  But their intentions are so different I can't help but think there would be very strange bugs lurking in any such integration -- so the encouraged architecture would be a complete separation between active and passive models.
 
 ## Copyright

data/lib/passive_record/associations/has_many.rb

@@ -19,6 +19,7 @@ module PassiveRecord
       def all
         child_class.where(parent_model_id_field => parent_model.id).all
       end
+
       def_delegators :all, :each, :last, :all?, :empty?
 
       def where(conditions={})
@@ -33,6 +34,14 @@ module PassiveRecord
       def singular?
         false
       end
+
+      def method_missing(meth,*args,&blk)
+        if child_class.methods.include?(meth)
+          where.send(meth,*args,&blk)
+        else
+          super(meth,*args,&blk)
+        end
+      end
     end
   end
 end

data/lib/passive_record/associations/has_many_through.rb

@@ -84,6 +84,13 @@ module PassiveRecord
           intermediary_relation.all
         end
       end
+
+      def where(conditions={})
+        child_class.where(conditions.merge(
+          intermediary_relation.association.children_name_sym.to_s.singularize.to_sym => {
+            parent_model_id_field.to_sym => parent_model.id
+          }))
+      end
     end
   end
 end

data/lib/passive_record/version.rb

@@ -1,4 +1,4 @@
 module PassiveRecord
   # passive_record version
-  VERSION = "0.4.4"
+  VERSION = "0.4.5"
 end

data/spec/passive_record_spec.rb

@@ -258,6 +258,30 @@ describe "passive record models" do
             end
           end
         end
+
+        context 'scopes on relations' do
+          let(:feed) { Feed.create }
+          let(:a_blog) { feed.create_blog } #.create }
+          let(:not_recent_post) { a_blog.create_post(published_at: 10.days.ago) }
+
+          let(:recent_post) do
+            a_blog.create_post(published_at: 1.day.ago)
+          end
+
+          describe 'should find related models through a has many' do
+            it 'should restrict as expected' do
+              expect(a_blog.posts.recent).to include(recent_post)
+              expect(a_blog.posts.recent).not_to include(not_recent_post)
+            end
+          end
+
+          describe 'should find related models on a has_many through' do
+            it 'should restrict as expected' do
+              expect(feed.posts.recent).to include(recent_post)
+              expect(feed.posts.recent).not_to include(not_recent_post)
+            end
+          end
+        end
       end
     end
   end

data/spec/spec_helper.rb

@@ -100,8 +100,20 @@ class Role < Model
 end
 
 ###
+#
+
+class Feed < Model
+  has_many :blogs
+  has_many :posts, :through => :blogs
+end
+
+class Blog < Model
+  has_many :posts
+  belongs_to :feed
+end
 
 class Post < Model
+  belongs_to :blog
   has_many :comments
   has_many :commenters, :through => :comments, :class_name => "User"
 
@@ -119,6 +131,12 @@ class Post < Model
   def self.published_within_days(n)
     where(:published_at => n.days.ago..Time.now)
   end
+
+  # hmmm -- why *exactly* do we need this?
+  def feed_id
+    raise 'not impl'
+    # blog.feed_id
+  end
 end
 
 class User < Model

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: passive_record
 version: !ruby/object:Gem::Version
-  version: 0.4.4
+  version: 0.4.5
 platform: ruby
 authors:
 - Joseph Weissman
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-21 00:00:00.000000000 Z
+date: 2016-07-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport