passive_record 0.4.2 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bd7a8be879b1a85836a8b2cb0267bbbeb1c7d4b6
-  data.tar.gz: 3d4255fe38bcc4215191a64dd0ed7ab0d3da2177
+  metadata.gz: 40a7223415652b0909737104ce89ef4b217ea868
+  data.tar.gz: 6c12988254b55576d5233dc5342efb57885d980d
 SHA512:
-  metadata.gz: 5d66d816841d803ad686444e9be0e92eca84c3b4edd16f8ab48afc85240b7f5cc6e29afa6f1d1f0b690560974acf3b97d297af3620e32b8e8d5521d12453017c
-  data.tar.gz: 39f2ebeef81f00a4e194fe67ee3f0914f36570d836cfb2e68beb0e37cdf5d2ce97280f0b2e8c31ed9ed5325701bdbcc168fb106cbfc7156fdfff4127c632bf57
+  metadata.gz: a7ace663d5d19795a44d2db854dbfb1d927d5f17b3f846efe2d7c8e6d360a99339f83045a12c041cadb85426fd3166230b08218dbb84a309d58047780bf1c202
+  data.tar.gz: 472bc65c4d271b5ee23913163734f1434b45948e7f78331dd55a33c2994cb16449c421bd32c5e1ce42ee42e2d256f1fe04affa8d64e139e95ced64ab578e1253

data/README.md

@@ -106,15 +106,15 @@ PassiveRecord may be right for you!
   A class `User` which is declared to `include PassiveRecord` will gain the following class methods:
 
   - `User.all` and `User.each`
-  - `User.create(attrs_hash)`
+  - `User.create(name: 'Aloysius')`
   - `User.descendants`
   - `User.destroy(id)`
   - `User.destroy_all`
   - `User.each` enumerates over `User.all`, giving `User.count`, `User.first`, etc.
   - `User.find(id_or_ids)`
-  - `User.find_all_by(conditions_hash)`
-  - `User.find_by(conditions_hash)`
-  - `User.where(conditions_hash)` (returns a `PassiveRecord::Query` object)
+  - `User.find_by(name: 'Aloysius')`
+  - `User.find_all_by(job: ['manager', 'developer', 'qa'])`
+  - `User.where(birthday: 1.day.ago...1.day.from_now)` (returns a `PassiveRecord::Query` object)
 
 ### Belongs To
 
@@ -183,9 +183,9 @@ PassiveRecord may be right for you!
 
   `conditions` here is expected to be a hash of attribute values. Note that there is special behavior for certain kinds of values.
 
-  - Ranges select models with an attribute covered by the range (behaving like `BETWEEN`)
-  - Arrays select models with an attribute whose value is in the array (behaving like `IN`)
-  - Hash values (subhashes) select models with related models who attributes match the inner hash. So `Doctor.where(appointments: { patient: patient })` finds doctors whose appointments include an appointment with `patient`.
+  - Ranges select models with an attribute covered by the range (behaving like `BETWEEN`). For instance you might query for users with birthdays between yesterday and today with `User.where(birthday: 1.day.ago...1.day.from_now)`
+  - Arrays select models with an attribute whose value is in the array (behaving like `IN`), so for instance you may query for users whose job title is included in a list of job titles like: `User.find_all_by(job_title: ['manager', 'developer', 'qa'])`
+  - Hash values (subhashes) select models with related models who attributes match the inner hash. So `Doctor.where(appointments: { patient: patient })` would lookup doctors whose appointments include an appointment with `patient`.
 
 ## Hooks
 
@@ -198,18 +198,8 @@ PassiveRecord may be right for you!
 
 # Prior Art
 
-  - Approaches exist that use ActiveRecord directly, and then override various methods in such a way to prevent AR from 
-    trying to persist the model. The canonical example here is the [tableless model](http://railscasts.com/episodes/193-tableless-model?view=asciicast)
-    approach, and the use case given there is a model that wraps around sending an email. This is maybe interesting because, similar to
-    the round-trip with a database, sending mail is externally "effectful" (and so, for instance, you may wish to take additional
-    care around confirmation or retry logic, in order ensure you are not sending the same message more than once.)
-  - These approaches are seen as somewhat hacky today, given that [ActiveModel](https://github.com/rails/rails/tree/master/activemodel) can 
-    give plain old Ruby objects a lot of the augmentations that ActiveRecord gives, such as validations, hooks and attribute management. However 
-    I don't really see a way to do relations that interoperate with ActiveRecord the way you could, at least to some degree, with tableless models.
-  - It's not really clear to me yet if it's interesting for PassiveRecord to be able to interoperate smoothly with ActiveRecord relations. It
-    seems like we might be able to pull some similar tricks as the "tableless" approach in order to permit at least some relations to work between them.
-    But their intentions are so different I can't help but think there would be very strange bugs lurking in any such integration -- so the encouraged
-    architecture would be a complete separation between active and passive models.
+  - Approaches exist that use ActiveRecord directly, and then override various methods in such a way to prevent AR from trying to persist the model. The canonical example here is the [tableless model](http://railscasts.com/episodes/193-tableless-model?view=asciicast) approach, and the use case given there is a model that wraps around sending an email. This is maybe interesting because, similar to the round-trip with a database, sending mail is externally "effectful" (and so, for instance, you may wish to take additional care around confirmation or retry logic, in order ensure you are not sending the same message more than once.)
+  - These approaches are seen as somewhat hacky today, given that [ActiveModel](https://github.com/rails/rails/tree/master/activemodel) can give plain old Ruby objects a lot of the augmentations that ActiveRecord gives, such as validations, hooks and attribute management. However I don't really see a way to do relations that interoperate with ActiveRecord the way you could, at least to some degree, with tableless models.  - It's not really clear to me yet if it's interesting for PassiveRecord to be able to interoperate smoothly with ActiveRecord relations. It seems like we might be able to pull some similar tricks as the "tableless" approach in order to permit at least some relations to work between them.  But their intentions are so different I can't help but think there would be very strange bugs lurking in any such integration -- so the encouraged architecture would be a complete separation between active and passive models.
 
 ## Copyright
 

data/lib/passive_record/associations.rb

@@ -72,7 +72,6 @@ module PassiveRecord
 
       define_method(:"#{child_name_sym}_id=") do |new_child_id|
         relation = relata.detect { |rel| rel.association == association }
-        # detach existing child...
         rel = relation.lookup
         rel && rel.send(:"#{relation.parent_model_id_field}=", nil)
 

data/lib/passive_record/associations/belongs_to.rb

@@ -6,7 +6,6 @@ module PassiveRecord
       end
 
       def parent_class
-        # look in same namespace as child class
 	module_name = child_class.name.deconstantize
 	module_name = "Object" if module_name.empty?
 	(module_name.constantize).const_get(parent_class_name)

data/lib/passive_record/associations/has_one.rb

@@ -38,11 +38,9 @@ module PassiveRecord
       end
 
       def child_class
-        # look in same module as parent...
 	module_name = association.parent_class.name.deconstantize
 	module_name = "Object" if module_name.empty?
-	(module_name.constantize).
-	  const_get(association.child_class_name.singularize)
+	(module_name.constantize).const_get(association.child_class_name.singularize)
       end
 
       def id

data/lib/passive_record/class_methods.rb

@@ -34,11 +34,7 @@ module PassiveRecord
     end
 
     def find_all_by(conditions)
-      if conditions.is_a?(Array) && conditions.all? { |c| c.is_a?(Identifier) }
-        find_by_ids(conditions)
-      else
-        where(conditions).all
-      end
+      where(conditions).all
     end
 
     def where(conditions={})
@@ -84,7 +80,7 @@ module PassiveRecord
     end
 
     def find_by_ids(ids)
-      instances_by_id.select { |id,_| ids.include?(id) }.values
+      instances_by_id.values_at(*ids)
     end
 
     private

data/lib/passive_record/version.rb

@@ -1,4 +1,4 @@
 module PassiveRecord
   # passive_record version
-  VERSION = "0.4.2"
+  VERSION = "0.4.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: passive_record
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.3
 platform: ruby
 authors:
 - Joseph Weissman
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-26 00:00:00.000000000 Z
+date: 2016-04-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport