passive_record 0.4.1 → 0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cc7b5c01b97c7fb6243e4b79d04d71bc0e78489f
-  data.tar.gz: dd52f6053d63cd4d0f59bc1e8b4325c6cc3a6a65
+  metadata.gz: bd7a8be879b1a85836a8b2cb0267bbbeb1c7d4b6
+  data.tar.gz: 3d4255fe38bcc4215191a64dd0ed7ab0d3da2177
 SHA512:
-  metadata.gz: 21a7cf31f52e5df9afd55319b12e4cc57df41d3fdb9615e468fedcb6a2ba41cb4dee6a1d78f01b1703af5f3524b4774f3c0875dee5044f570a065d928f27857d
-  data.tar.gz: 94cf9ee814cbb1de324ee1bd9283d4ed2d471034a3f36b06b8d34aee97421ec813d54583b09591b2f87f2197daf44e28c3dd4bd4cc29a1537287f8e7cffe1794
+  metadata.gz: 5d66d816841d803ad686444e9be0e92eca84c3b4edd16f8ab48afc85240b7f5cc6e29afa6f1d1f0b690560974acf3b97d297af3620e32b8e8d5521d12453017c
+  data.tar.gz: 39f2ebeef81f00a4e194fe67ee3f0914f36570d836cfb2e68beb0e37cdf5d2ce97280f0b2e8c31ed9ed5325701bdbcc168fb106cbfc7156fdfff4127c632bf57

data/lib/passive_record.rb

@@ -5,7 +5,6 @@ require 'active_support/core_ext/string/inflections'
 require 'active_support/core_ext/numeric/time'
 
 require 'passive_record/version'
-require 'passive_record/core/identifier'
 
 require 'passive_record/arithmetic_helpers'
 require 'passive_record/core/query'

data/lib/passive_record/class_methods.rb

@@ -15,11 +15,7 @@ module PassiveRecord
     def all
       instances_by_id.values
     end
-    def_delegators :all, :each
-
-    def last
-      all.last
-    end
+    def_delegators :all, :each, :last
 
     def find(id_or_ids)
       if id_or_ids.is_a?(Array)
@@ -54,7 +50,7 @@ module PassiveRecord
 
       instance.singleton_class.class_eval { attr_accessor :id }
 
-      instance_id = attrs.delete(:id) { SecureRandomIdentifier.generate(self) }
+      instance_id = attrs.delete(:id) { SecureRandom.uuid }
       instance.send(:id=, instance_id)
 
       register(instance)
@@ -84,7 +80,7 @@ module PassiveRecord
 
     protected
     def find_by_id(id_to_find)
-      find_by(id: id_to_find)
+      instances_by_id[id_to_find]
     end
 
     def find_by_ids(ids)
@@ -97,12 +93,9 @@ module PassiveRecord
     end
 
     def register(model)
-      instances_by_id[model.id] = model
+      id = model.id
+      instances_by_id[id] = model
       self
     end
-
-    def id_factory
-      PassiveRecord.configuration.identify_using
-    end
   end
 end

data/lib/passive_record/version.rb

@@ -1,4 +1,4 @@
 module PassiveRecord
   # passive_record version
-  VERSION = "0.4.1"
+  VERSION = "0.4.2"
 end

data/spec/passive_record_spec.rb

@@ -112,14 +112,11 @@ describe "passive record models" do
 
       context 'querying by id' do
         describe "#find" do
-          subject(:model) {  SimpleModel.create }
+          subject(:model) { SimpleModel.create(id: 'model_id') }
           it 'should lookup a record based on an identifier' do
             expect(SimpleModel.find(-1)).to eq(nil)
             expect(SimpleModel.find(model.id)).to eq(model)
-          end
-
-          it 'should lookup records based on primary key value' do
-            expect(SimpleModel.find(model.id.value)).to eq(model)
+            expect(SimpleModel.find('model_id')).to eq(model)
           end
 
           it 'should lookup records based on ids' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: passive_record
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
 platform: ruby
 authors:
 - Joseph Weissman
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-25 00:00:00.000000000 Z
+date: 2016-03-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -156,7 +156,6 @@ files:
 - lib/passive_record/associations/has_one.rb
 - lib/passive_record/class_inheritable_attrs.rb
 - lib/passive_record/class_methods.rb
-- lib/passive_record/core/identifier.rb
 - lib/passive_record/core/query.rb
 - lib/passive_record/hooks.rb
 - lib/passive_record/instance_methods.rb

data/lib/passive_record/core/identifier.rb

@@ -1,20 +0,0 @@
-module PassiveRecord
-  class SecureRandomIdentifier < Struct.new(:value)
-    def self.generate(klass)
-      new(generate_id_value_for(klass))
-    end
-
-    def self.generate_id_value_for(*)
-      SecureRandom.uuid
-    end
-
-    def ==(other_id)
-      self.value == other_id ||
-        (other_id.is_a?(SecureRandomIdentifier) && (other_id && self.value == other_id.value))
-    end
-
-    def inspect
-      value
-    end
-  end
-end