passive_record 0.3.20 → 0.3.21

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fe98ab7ab71c5ce3976bfc86076c2714714a164d
-  data.tar.gz: b239a92752e046940fb7e92d962126bedce4ca94
+  metadata.gz: 05fe6abf84205214c0d3779a4613948ba45d0b38
+  data.tar.gz: 850a284c872673bfce97d9d3aae3f3d8ad53ff63
 SHA512:
-  metadata.gz: 61ef80f5bbbfad3e139e6517feac7dc35b804e3c9571986da164e56013d9963b8c2dd103d7fa50ef2d758384b7bf31a882397619654d8626c3b173dfa9857fe9
-  data.tar.gz: 8f8fc1772b617aee99cc921a3e6eaded1c5f2ebeeca11b34f48ff6b95479bcecab2cd6702fee06164627c8e575b06a20a37b984dc3acdfc0865bfeffbd0fd173
+  metadata.gz: a6922efd24b8495fa04c469d94e47649b34503d8269834f5b06e3dee723f23cb8f89574ed44dcd581f6ce4abdde33b98b52a00fa916af595b05f9ecb34745c0e
+  data.tar.gz: a17f8bf707a0f6f1bae9cc40fee9a9fb659b8bc7c829f585783ef38caa591b7f4d8029684a1f3afc4876499961bb76df2a7542af4c4a43d294c894e931c5c76f

data/README.md

@@ -186,7 +186,6 @@ PassiveRecord may be right for you!
   - Ranges select models with an attribute covered by the range (behaving like `BETWEEN`)
   - Arrays select models with an attribute whose value is in the array (behaving like `IN`)
   - Hash values (subhashes) select models with related models who attributes match the inner hash. So `Doctor.where(appointments: { patient: patient })` finds doctors whose appointments include an appointment with `patient`.
- 
 
 ## Hooks
 
@@ -197,6 +196,16 @@ PassiveRecord may be right for you!
   - `before_destroy :something`
   - `after_destroy { something_else }`
 
+# Prior Art
+
+  - Approaches exist that use ActiveRecord directly, and then override various methods in such a way to prevent AR from 
+    trying to persist the model. The canonical example here is the [tableless model](http://railscasts.com/episodes/193-tableless-model?view=asciicast)
+    approach, and the use case given there is a model that wraps around sending an email. This is maybe interesting because it's
+    like the round-trip with a database, sending mail is externally "effectful" (and so, for instance, you may wish to take additional
+    care around confirmation or retry logic, in order ensure you are not sending the same message more than once.)
+  - These approaches are seen as somewhat hacky today, given that [ActiveModel](https://github.com/rails/rails/tree/master/activemodel) can 
+    give plain old Ruby objects a lot of the augmentations that ActiveRecord gives, such as validations, hooks and attribute management.
+
 ## Copyright
 
 Copyright (c) 2016 Joseph Weissman

data/lib/passive_record/associations.rb

@@ -31,7 +31,7 @@ module PassiveRecord
       end
 
       define_method(parent_name_sym) do
-        relation = instance_eval{relata}.detect { |rel| rel.association == association }
+        relation = relata.detect { |rel| rel.association == association }
         association.parent_class.find(relation.parent_model_id)
       end
 
@@ -40,7 +40,7 @@ module PassiveRecord
       end
 
       define_method(:"#{parent_name_sym}_id=") do |new_parent_id|
-        relation = instance_eval{relata}.detect { |rel| rel.association == association }
+        relation = relata.detect { |rel| rel.association == association }
         relation.parent_model_id = new_parent_id
       end
     end
@@ -55,12 +55,12 @@ module PassiveRecord
       end
 
       define_method(child_name_sym) do
-        relation = instance_eval{relata}.detect { |rel| rel.association == association }
+        relation = relata.detect { |rel| rel.association == association }
         relation.lookup
       end
 
       define_method(:"create_#{child_name_sym}") do |attrs={}|
-        relation = instance_eval{relata}.detect { |rel| rel.association == association }
+        relation = relata.detect { |rel| rel.association == association }
         relation.create(attrs)
       end
 
@@ -69,7 +69,7 @@ module PassiveRecord
       end
 
       define_method(:"#{child_name_sym}_id=") do |new_child_id|
-        relation = instance_eval{relata}.detect { |rel| rel.association == association }
+        relation = relata.detect { |rel| rel.association == association }
         # detach existing child...
         relation.lookup&.send(:"#{relation.parent_model_id_field}=", nil)
 
@@ -99,7 +99,7 @@ module PassiveRecord
         end
 
         define_method(:"#{collection_name_sym.to_s.singularize}_ids=") do |new_collection_ids|
-          relation = instance_eval{relata}.detect { |rel| rel.association == association }
+          relation = relata.detect { |rel| rel.association == association }
 
           intermediary = relation.intermediary_relation
 
@@ -129,7 +129,7 @@ module PassiveRecord
         associate!(association)
 
         define_method(:"#{collection_name_sym}=") do |new_collection|
-          relation = instance_eval{relata}.detect { |rel| rel.association == association }
+          relation = relata.detect { |rel| rel.association == association }
 
           # detach existing children...
           relation.all.each do |child|
@@ -143,14 +143,13 @@ module PassiveRecord
         end
 
         define_method(:"#{collection_name_sym.to_s.singularize}_ids=") do |new_collection_ids|
-          relation = instance_eval{relata}.detect { |rel| rel.association == association }
+          relation = relata.detect { |rel| rel.association == association }
           send(:"#{collection_name_sym}=", relation.child_class.find(new_collection_ids))
         end
       end
 
       define_method(collection_name_sym) do
-        relation = instance_eval{relata}.detect { |rel| rel.association == association }
-        relation
+        relata.detect { |rel| rel.association == association }
       end
 
       define_method(:"#{collection_name_sym.to_s.singularize}_ids") do
@@ -158,8 +157,8 @@ module PassiveRecord
       end
 
       define_method(:"create_#{collection_name_sym.to_s.singularize}") do |attrs={}|
-        relation = instance_eval{relata}.detect { |rel| rel.association == association }
-      relation.create(attrs)
+        relation = relata.detect { |rel| rel.association == association }
+        relation.create(attrs)
       end
     end
 

data/lib/passive_record/version.rb

@@ -1,4 +1,4 @@
 module PassiveRecord
   # passive_record version
-  VERSION = "0.3.20"
+  VERSION = "0.3.21"
 end

data/spec/passive_record_spec.rb

@@ -65,7 +65,7 @@ describe "passive record models" do
             to eq("Family::Dog (id: #{dog.id.inspect}, breed: \"#{dog.breed}\", created_at: #{dog.created_at}, sound: \"bark\", child_id: #{child.id.inspect})")
 
           expect(child.inspect).
-            to eq("Family::Child (id: #{child.id.inspect}, created_at: #{child.created_at}, name: \"Alice\", toy_id: nil, toy_quality_ids: [], dog_ids: [#{dog.id.inspect}], parent_id: nil, secret_club_ids: [])")
+            to eq("Family::Child (id: #{child.id.inspect}, created_at: #{child.created_at}, name: \"Alice\", parent_id: nil, toy_id: nil, toy_quality_ids: [], dog_ids: [#{dog.id.inspect}], secret_club_ids: [])")
         end
       end
 

data/spec/spec_helper.rb

@@ -39,10 +39,10 @@ module Family
   end
 
   class Child < Model
+    belongs_to :parent
     has_one :toy
     has_many :toy_qualities, :through => :toy
     has_many :dogs
-    belongs_to :parent
     has_and_belongs_to_many :secret_clubs
 
     attr_reader :name
@@ -62,7 +62,6 @@ module Family
     has_many :toys, :through => :children
   end
 end
-#include Family
 
 ###
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: passive_record
 version: !ruby/object:Gem::Version
-  version: 0.3.20
+  version: 0.3.21
 platform: ruby
 authors:
 - Joseph Weissman
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-04 00:00:00.000000000 Z
+date: 2016-03-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport