passive_record 0.3.9 → 0.3.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4f7bcf7c09ce2830df7940f8241d34b3dd79f3b0
-  data.tar.gz: 5d9844ff88d1aa22fc003765a4746ff1918d1e1b
+  metadata.gz: 7a864962f49adde921cd337981fea7046b072a91
+  data.tar.gz: f6dfa54709c92ab2628fbe07a2831f71f714b930
 SHA512:
-  metadata.gz: ea71ea386493db3d619f9cb1fa58d738004622a822e31c309b730d2742e5585728c2e9a59f44e4d44b3bc31bfd0728c1b09808089fc9dd539ff3f27a9fdc63e8
-  data.tar.gz: 92042f4052e8e79780bdcc182fc8b784d60aad57b435c7acd0cd5324683df34b38e9472dba3b86f24f50eeaf76ba21a7498f015d54e29421186c4f92cb79b566
+  metadata.gz: 9aba9642fa965b2b5460e5eec9521d426fe3041dfb53c5e234000eebb36d41caba198f88f011a399900dfdea4c6b68f721aa3421873d3a7edc26a3f54ee3ac04
+  data.tar.gz: 19fb03f821db6c570d24a546960d3b729c0b4e78f29189bee1c9ae820d87d227b74fb765b1eade54c6db602d903653d7683387f741c066253a6c6fb19b6b657e

data/lib/passive_record.rb

@@ -40,18 +40,4 @@ module PassiveRecord
   def self.drop_all
     (model_classes + model_classes.flat_map(&:descendants)).each(&:destroy_all)
   end
-
-  def self.configure
-    yield configuration
-  end
-
-  def self.configuration
-    @config ||= default_configuration
-  end
-
-  def self.default_configuration
-    OpenStruct.new(
-      :identify_using => Identifier
-    )
-  end
 end

data/lib/passive_record/class_methods.rb

@@ -53,7 +53,7 @@ module PassiveRecord
       instance = new
 
       instance.singleton_class.class_eval { attr_accessor :id }
-      instance.send(:"id=", id_factory.generate(self))
+      instance.send(:"id=", SecureRandomIdentifier.generate(self))
 
       register(instance)
 
@@ -73,7 +73,7 @@ module PassiveRecord
     end
 
     def destroy(id)
-      @instances = instances_by_id.reject{|k,_| id == k }
+      @instances.reject! {|k,_| id == k }
     end
 
     def destroy_all

data/lib/passive_record/core/identifier.rb

@@ -1,11 +1,11 @@
 module PassiveRecord
-  class Identifier < Struct.new(:value)
+  class SecureRandomIdentifier < Struct.new(:value)
     def self.generate(klass)
       new(generate_id_value_for(klass))
     end
 
-    def self.generate_id_value_for(klass)
-      klass.count+1
+    def self.generate_id_value_for(*)
+      SecureRandom.uuid
     end
 
     def ==(other_id)
@@ -16,10 +16,4 @@ module PassiveRecord
       value
     end
   end
-
-  class SecureRandomIdentifier < Identifier
-    def self.generate_id_value_for(*)
-      SecureRandom.uuid
-    end
-  end
 end

data/lib/passive_record/version.rb

@@ -1,4 +1,4 @@
 module PassiveRecord
   # passive_record version
-  VERSION = "0.3.9"
+  VERSION = "0.3.10"
 end

data/spec/passive_record_spec.rb

@@ -44,6 +44,7 @@ describe "passive record models" do
           doomed.destroy
           expect(SimpleModel.find(doomed_id)).to eq(nil)
 
+          SimpleModel.destroy_all
           expect{10.times{SimpleModel.create}}.to change{SimpleModel.count}.by(10)
         end
       end
@@ -423,23 +424,9 @@ describe "passive record models" do
 end
 
 describe "configuration" do
-  describe 'configuring id factory' do
-    context 'with default config' do
-      it 'should generate simple identifiers' do
-        expect(Model.create.id).to be_a(PassiveRecord::Identifier)
-      end
-    end
-
-    context 'with a new id factory configured' do
-      before do
-        PassiveRecord.configure do |passive_records|
-          passive_records.identify_using = PassiveRecord::SecureRandomIdentifier
-        end
-      end
-
-      it 'should generate uuids' do
-        expect(Model.create.id).to be_a(PassiveRecord::SecureRandomIdentifier)
-      end
+  context 'with default config' do
+    it 'should generate simple identifiers' do
+      expect(Model.create.id).to be_a(PassiveRecord::SecureRandomIdentifier)
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: passive_record
 version: !ruby/object:Gem::Version
-  version: 0.3.9
+  version: 0.3.10
 platform: ruby
 authors:
 - Joseph Weissman