passive_columns 0.2.1 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 56f6f5fdf5c333ca2fe7ba55e3974b21b67662362a21848b1b31cf6216e080a1
-  data.tar.gz: adbcac3dfba991402e20dc7fc3d2a616498af1998ae4b0d5b4a1a9895254b2c4
+  metadata.gz: 4c17e42bdf1a6871eb67811732872bfb4d4c280c91d2b6f4a76442efbf1379f5
+  data.tar.gz: dd7937cad9f31dabf925cd15dbf051b06682483bbfeb884a713c113281bce613
 SHA512:
-  metadata.gz: 9ca11045bc3d47d290e6797c3b834eb4f1d8770ffd955c3be392b51c5d796bd2049c2ae7c849e85f189ce4e91524928cad8a5d55463fc36c082bc54c74c47aa8
-  data.tar.gz: df054d53f99a0e292292fe6935ba4dc3e2d707856372043468de0afc121065d9ca515ffb528d7292aba9a5b7f378114ac55b7d8b7e640268ceae897351c18cb1
+  metadata.gz: 8c40fdcc4543ea47e4e945819a3e03328203d7157f17c0b2170cddadf45024b5dbafe7e6bf5fa8045678cf4f63b28b667f63fe49f3217ff9abffd9b2c0c9a4ef
+  data.tar.gz: 8d13c82243de48de75116e986ba12c96949c5ad9151801dcecc9fd2da0f6f6d8ecef5cad7c23125e98571c77af582771ed9e2cbba43d63a293fdbc4f030d8fb1

data/README.md

@@ -66,6 +66,43 @@ user.name
 By the way, it uses the Rails' `.pick` method to get the value of the column under the hood
 
 
+### Important
+
+If you want `passive_columns` to skip validation rules specific to the columns you exclude.<br>
+(in case they were not retrieved / modified)
+```ruby
+validates :huge_article, presence: true
+# Will be transformed into:
+# validates :huge_article, presence: true, if: -> { attributes.key?('huge_article') }
+```
+
+You must declare validation rules for `passive_columns` separately
+```ruby
+class Page < ActiveRecord::Base
+  include PassiveColumns
+  passive_columns :huge_article # Declare columns above the validation rules.
+
+  validates :name, presence: true
+  # Validation rules transformation will work
+  validates :huge_article, presence: true # It works for a separate rule.
+  # -> the rule is transformed into:
+  # -> validates :huge_article, presence: true, if: -> { attributes.key?('huge_article') }
+end
+```
+
+```ruby
+class Page < ActiveRecord::Base
+  include PassiveColumns
+  passive_columns :huge_article # Declare columns above the validation rules.
+
+  # Validation rules transformation WON'T work
+  validates :name, :huge_article, presence: true # It doesn't work for combined rules.
+  # -> the rule remains the same:
+  # -> validates :name, :huge_article, presence: true
+end
+```
+
+
 ## Installation
 Add this line to your Gemfile:
 
@@ -123,13 +160,19 @@ One way to avoid this is to check for the presence of the attribute before valid
 validates :huge_article, presence: true, if: -> { attributes.key?('huge_article') }
 ```
 
-Unfortunately, boilerplate code is needed for such a simple task.
-You just wanted to exclude some columns and be able to manipulate a model without extra steps.
+Unfortunately, boilerplate code is needed for such a simple task. <br>
+But the only thing you wanted was to exclude some columns and be able to manipulate a model without extra steps.
+
+By the way, after doing those steps, you still cannot retrieve the column when you need it after loading the scoped model...
 
-`passive_columns` tries to solve this problem by allowing you to exclude columns from the selection 
-and also allows you to retrieve them on demand when needed.
+So, `passive_columns` tries to solve this problem by allowing you to exclude columns from the selection and also allowing you to retrieve them on demand when needed.
 
+---
 
+#### Inspiration
+There are similar gems that were relatively popular but are no longer supported. Let's give them the honor they deserve:
+- [lazy_columns](https://github.com/jorgemanrubia/lazy_columns)
+- [columns_on_demand](https://github.com/willbryant/columns_on_demand)
 
 ## License
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

data/lib/passive_columns/loader.rb

@@ -26,7 +26,7 @@ module PassiveColumns
       value = pick_value(column)
       model[column] = value
       model.send(:clear_attribute_change, column)
-      value
+      model[column]
     end
 
     private

data/lib/passive_columns/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PassiveColumns
-  VERSION = '0.2.1'
+  VERSION = '0.2.3'
 end

data/lib/passive_columns.rb

@@ -83,9 +83,13 @@ module PassiveColumns
     # Otherwise, the passive column will be retrieved from DB before validation itself.
     def set_callback(name, *filter_list, &block)
       opts = filter_list.extract_options!
-      if name == :validate && opts[:attributes]&.one?
-        passive_column = opts[:attributes].map(&:to_s) & _passive_columns
-        opts[:if] = ([-> { attributes.key?(passive_column.first) }] + Array(opts[:if])) if passive_column.present?
+
+      if name == :validate
+        attrs = opts[:attributes] || filter_list[0].try(:attributes)
+        if attrs&.one?
+          passive_column = attrs.map(&:to_s) & _passive_columns
+          opts[:if] = ([-> { attributes.key?(passive_column.first) }] + Array(opts[:if])) if passive_column.present?
+        end
       end
       super(name, *filter_list, opts, &block)
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: passive_columns
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.3
 platform: ruby
 authors:
 - Dmitry Golovin
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-06-19 00:00:00.000000000 Z
+date: 2024-06-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord