passfort 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 11120072e170612a1a224a7e5494a78401ac7c840b9efd54e43c104948f0c9fd
-  data.tar.gz: 035174f509a2106dd5ea314517ec24b503d6d22b30100c64c935f360b6860396
+  metadata.gz: aad8b4d28916b07b98a185e5770cdde81ca59353d71284171eb8d4a5fa4c240b
+  data.tar.gz: ef28d85a96a8c5393deb1b8d4a0ba4ed477897239d43a0d5a73294648ffcea88
 SHA512:
-  metadata.gz: e5041f41f44de8502abe4b7d3c0b4d59570e5ad629b66c74b10980cad3333c4bb3ce19fbaeb050a3e4a9355caa394df365586c1f883a57746d6546470d290700
-  data.tar.gz: 94f245e7d800b9bfbf7ca0b40db72f5f37894bd56a8df125858c703cfcd742a00a324c50d28421fc3ccc60e09423ad9d198feae5d3d5b6bb2fef5595600b66a6
+  metadata.gz: cf10cfef404e40a8f935fa4e8b68f2f0a1a27517f5a5f4bda1f82ee98e9df192792089a01cd8f02a6a85f51a35088e0745081945c989d0ff887dfb40fc9c91e9
+  data.tar.gz: e31d726cf74c4d37b7f9626cf7c647e791ceac7dccfb5d00c49a62cd741249744aea26d7b768f8e740e830eeb303ac2471e771affbefaf7dd47c4f27811ad3e5

data/CHANGELOG.md

@@ -6,6 +6,11 @@ Unreleased
 
 No changes.
 
+0.2.1
+-----
+
+- Include detailed error information in any raised errors.
+
 0.2.0
 -----
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    passfort (0.2.0)
+    passfort (0.2.1)
       activesupport (~> 5.0)
       excon (~> 0.60)
 

data/lib/passfort/errors.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "passfort/errors/api_error"
+require "passfort/errors/unknown_api_error"
 require "passfort/errors/chargeable_limit_reached_error"
 require "passfort/errors/invalid_api_key_error"
 require "passfort/errors/invalid_input_data_error"

data/lib/passfort/errors/api_error.rb

@@ -4,11 +4,12 @@ module Passfort
   module Errors
     # Represents any response from the API which is not a 200 OK
     class APIError < StandardError
-      attr_reader :response
+      attr_reader :response, :errors
 
-      def initialize(msg, response = nil)
+      def initialize(msg, errors = [], response = nil)
         super(msg)
         @response = response
+        @errors = errors
       end
     end
   end

data/lib/passfort/errors/chargeable_limit_reached_error.rb

@@ -4,8 +4,8 @@ module Passfort
   module Errors
     # Specific error class for when the chargeable limit has been reached
     class ChargeableLimitReachedError < APIError
-      def initialize(response = nil)
-        super("Rate limit exceeded", response)
+      def initialize(*args)
+        super("Rate limit exceeded", *args)
       end
     end
   end

data/lib/passfort/errors/invalid_api_key_error.rb

@@ -4,8 +4,8 @@ module Passfort
   module Errors
     # Specific error class for when an invalid API key is used to access the service
     class InvalidAPIKeyError < APIError
-      def initialize(response = nil)
-        super("Invalid API key", response)
+      def initialize(*args)
+        super("Invalid API key", *args)
       end
     end
   end

data/lib/passfort/errors/invalid_input_data_error.rb

@@ -4,8 +4,8 @@ module Passfort
   module Errors
     # Specific error class for when an invalid input data is used to query the service
     class InvalidInputDataError < APIError
-      def initialize(response = nil)
-        super("Invalid input data", response)
+      def initialize(*args)
+        super("Invalid input data", *args)
       end
     end
   end

data/lib/passfort/errors/request_error.rb

@@ -4,8 +4,8 @@ module Passfort
   module Errors
     # Specific error class for when an HTTP request error has occurred
     class RequestError < APIError
-      def initialize(response)
-        super("Request API error - HTTP #{response.status}", response)
+      def initialize(errors, response)
+        super("Request API error - HTTP #{response.status}", errors, response)
       end
     end
   end

data/lib/passfort/errors/unknown_api_error.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+module Passfort
+  module Errors
+    # Specific error class for when an unknown error is returned
+    class UnknownApiError < APIError
+      def initialize(*args)
+        super("Unknown API error", *args)
+      end
+    end
+  end
+end

data/lib/passfort/http.rb

@@ -36,25 +36,22 @@ module Passfort
     # error codes: https://passfort.com/developer/v4/data-reference/ErrorCodes
     def handle_error(response, body)
       unless [200, 201].include?(response.status)
-        raise Passfort::Errors::RequestError, response
+        raise Passfort::Errors::RequestError.new([], response)
       end
 
       errors = body["errors"].is_a?(Array) ? body["errors"] : [body["errors"]]
 
-      handle_response_error(errors[0], response) if errors.any?
+      handle_response_error(errors, response) if errors.any?
     end
 
-    def handle_response_error(error, response)
-      case error["code"]
-      when 201
-        raise Passfort::Errors::InvalidInputDataError, response
-      when 204
-        raise Passfort::Errors::InvalidAPIKeyError, response
-      when 104
-        raise Passfort::Errors::ChargeableLimitReachedError, response
-      else
-        raise Passfort::Errors::APIError.new("Unknown API error", response)
-      end
+    def handle_response_error(errors, response)
+      error_class = case errors[0]["code"]
+                    when 201 then Passfort::Errors::InvalidInputDataError
+                    when 204 then Passfort::Errors::InvalidAPIKeyError
+                    when 104 then Passfort::Errors::ChargeableLimitReachedError
+                    else Passfort::Errors::UnknownApiError
+                    end
+      raise error_class.new(errors, response)
     end
   end
 end

data/lib/passfort/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Passfort
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/spec/passfort/http_spec.rb

@@ -18,45 +18,35 @@ RSpec.describe Passfort::Http do
       let(:status) { 404 }
       let(:error_class) { Passfort::Errors::RequestError }
 
-      it "raises a specific APIError" do
-        is_expected.to raise_error(instance_of(error_class))
-      end
+      it { is_expected.to raise_error(error_class) }
     end
 
     context "when returning an invalid API Key error" do
       let(:error_code) { 204 }
       let(:error_class) { Passfort::Errors::InvalidAPIKeyError }
 
-      it "raises a specific APIError" do
-        is_expected.to raise_error(instance_of(error_class))
-      end
+      it { is_expected.to raise_error(error_class) }
     end
 
     context "when returning an invalid input data error" do
       let(:error_code) { 201 }
       let(:error_class) { Passfort::Errors::InvalidInputDataError }
 
-      it "raises a specific APIError" do
-        is_expected.to raise_error(instance_of(error_class))
-      end
+      it { is_expected.to raise_error(error_class) }
     end
 
     context "when returning a chargeable limit reached error" do
       let(:error_code) { 104 }
       let(:error_class) { Passfort::Errors::ChargeableLimitReachedError }
 
-      it "raises a specific APIError" do
-        is_expected.to raise_error(instance_of(error_class))
-      end
+      it { is_expected.to raise_error(error_class) }
     end
 
     context "when returning an unknown API error" do
       let(:error_code) { 203 }
-      let(:error_class) { Passfort::Errors::APIError }
+      let(:error_class) { Passfort::Errors::UnknownApiError }
 
-      it "raises a specific APIError" do
-        is_expected.to raise_error(instance_of(error_class))
-      end
+      it { is_expected.to raise_error(error_class) }
     end
 
     context "when returning a successful result" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: passfort
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - GoCardless
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-14 00:00:00.000000000 Z
+date: 2018-03-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -135,6 +135,7 @@ files:
 - lib/passfort/errors/invalid_api_key_error.rb
 - lib/passfort/errors/invalid_input_data_error.rb
 - lib/passfort/errors/request_error.rb
+- lib/passfort/errors/unknown_api_error.rb
 - lib/passfort/http.rb
 - lib/passfort/resource.rb
 - lib/passfort/resource/base.rb