passenger 5.0.0.beta2 → 5.0.0.beta3

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    Yzc0NjVmNTJlYTZmYWExZjBmZTEyZDFjODliMDg2YTBiZWI5ZmQ2MA==
+    ZTQ0MDViNGU5MDc1Y2NiOTY1YThiMjQ3MjBlYTUwYjUxOWM0NGU5OA==
   data.tar.gz: !binary |-
-    YzJmMGQxZmU1NmY5ODcxNTBiZWZlZThmMjhiYTE1NjVmNThiYjkxNw==
+    N2ZiYTc1ZTAzOGY1ZmU1YWZmODU1NDg5ZjRiNTI4ZjgyZDQyZTZlNg==
 SHA512:
   metadata.gz: !binary |-
-    ZmY1NmQwMzNkZmFhYWQ1MWVjMDFkYWQwYzRlNDdhNzI1MjI3MjUwODUyOGI5
-    ZjFkMmRkOTY0NzE2YTUyYmI4YzEwNjJiOTIwZWNmNzMwMTc2YzM0NWEzMzY4
-    NGVhMjQ4MjA4MWRmMjkzMmMwOGE2MjdmNzVmY2M1ZWU2NmIxMTE=
+    MzNiODkxN2U5ODU5ODRlYWRjOTdjYjUwZjcyNmE3NjA2NDI4ZGNlNmNhOTVi
+    YmZlOTdlZWI5M2E2NmU1MDBlMDhmYTQwMGMyNjJkYzI2NGMxZmJlOGZhNWVm
+    NDFkMWUwMTM3MDUxNGI3YWM2MGEyMzJiNTc3ZjQwYmQ2YWY2YWE=
   data.tar.gz: !binary |-
-    MTA0ZGVkNjg2NWM1YzRkZTBmMjAwMDM0MmYyNjJjNTNiMmNiZWEzNTIyNTQw
-    ZDM0NzljODkwNWVlMjU5NDIxOWRkODMwNmJkNDc4MTE1ZmZmNjAxZTE3NmFj
-    YzE3ODgyOTM4N2EzYjg5NDJlNGRhMWQ3NjFmZTg2YWJjZmNlYTY=
+    MGQxNjFkZDJlNTY3MzFlNzg0OTg3M2FkZGQyOGM3NWFlMTEwZTE5MzNjYmNj
+    YzJlYzYxMjY0ZTFiY2U1NGI4NzBmMWE2NDhjMWM3YTM2YzM2NzAzYzExOWEw
+    ZTJiYWJmMzVkODRiYzkzNGZmYmRhZjQwYjQ3NmEzN2QxZmM0MTM=

checksums.yaml.gz.asc

@@ -2,11 +2,11 @@
 Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
 Comment: GPGTools - http://gpgtools.org
 
-iQEcBAABAgAGBQJUlA2PAAoJECrHRaUKISqMfFcH/RERmONzrpkI9JVi+JxjUFRf
-u9QT0kBu8VDYhaZEHQHvhVsTKKu+6+9qa0td1B9CFf2M+pdEakCIqIWCxb0dQVme
-/F4z+pprnCEUwc348iynv0evSQ7dUhQphNGL0cCXDGDuMrGxbQxP7DRiyc2h99un
-CVWuQGwZvnMGnJ4gmQjTKLalnMVHxEkEwukuhPFbuMEt6lzo4JXzTc3/STRSkt1J
-ZnXeFOR8ifkynyvNv7wgbIv1r4iAWSn0L2c1P2ou1MnghQhjBDs2XJDnZ1KjDuML
-f1AoWn/VyWi4HkyqAvVhFxCCr0WoyWmQ2uhD5vikwPHVrxoKbQGP2OJwk+FbltI=
-=CGbg
+iQEcBAABAgAGBQJU2MfxAAoJECrHRaUKISqMefAIALEqsDj8171WM+YPJkMt0Nx+
+MPGtiPoLrhwO0ctDfFz+AFOTmFC4/VZMmozBC6dgHPKMhDyTcg0q9h0OvIsOncjM
+eWx/V9t/9km1EeYVLY+9ZbMa2UtYFZv9PQeWSN9h3czv3O9mWNlK9WsyMEfag1xO
+3+aLjce9Zb8KCwEX/CoeE/X637ZADlEUk2homyg10xwfRloOUqQQWNQrWdU1I/XR
+3cjfwVQPbta+D5jJj7Ub6yXfOEZOtU5qTwFnHWelznfVo+PiFRN1wu6IBqfixZRl
+ddg4MkM1ywbzoMeRsG8rKrxOosJg7u+tk5YqSYP1jiG0GwfH8VHAsIhiHnGNjw4=
+=c49l
 -----END PGP SIGNATURE-----

data.tar.gz.asc

@@ -2,11 +2,11 @@
 Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
 Comment: GPGTools - http://gpgtools.org
 
-iQEcBAABAgAGBQJUlA2PAAoJECrHRaUKISqMKGAH/At3Qmxna8prw6C4gGN2quRk
-B29MiVrX/mt82dUhM4+ENRSN4Anxzj+ZiIzjts/ko4LO5z7imX6/Yg9yVu+JX2+K
-DPmmmvvAfFhwslVf3bbL5f9bmaS1AV9Vh0a0TJtN2kv+wKmOJ0olbA8mYmC3TQh+
-Ypg23/0FgGNESTM19RL5cr4govT8xd2/qYAn+WauXqmxaXLfRZFLXpDOrVQJztIu
-AZA7FfhEaFRUv+2YB2iiO474AUIdCNpksWIs/q3bKJHy+buMsytFCWD5UcBt5Cfu
-rli1TCrwxgnHTes5rrXWvAeQyJzmwQmhA6A8co6F6xOArfZmxZRfegD8Z82fY/M=
-=MeVu
+iQEcBAABAgAGBQJU2MfxAAoJECrHRaUKISqMa4oH/11YAlJ8yVRBplmhZNqOtsZ5
+glzpkrNE/2TSl82occQKHW/qZz8ay1iUOTjPrRiUkYJkgEYn7j8f3WmLUEoEjqNp
+ZZX3eTEOb6/x86A5Ejr2FZqjEmqxLv3v4MdiG8rXj2Cl9iRvK0MIDSBKhckPaMj7
+M+JFrJSvGWbpAuU1rilsmSK27oCrQDOYATd0U0J+muAckWkzUiTYK6XUmp894iXD
++QV4FsEe7pTptQOHZuewWtn8n+kwcrHfVP/iL4aqMJOh7LyK3KTAgFr6R4efiNL+
+3O4opHc1qg8TBXMf9DUl7s43HoyY4vY5MDWKwiUzPl8Z32t1Y1h0zrlbnTtcPtY=
+=2KEK
 -----END PGP SIGNATURE-----

data/CHANGELOG

@@ -1,3 +1,19 @@
+Release 5.0.0 beta 3
+--------------------
+
+ * The turbocache has received major updates and fixes based on excellent feedback Chris Heald and the community. First, several bugs w.r.t. the handling of caching headers have been fixed. Second, the turbocache has become slightly more conservative for security reasons. In previous versions, default cacheable responses (as defined by RFC 7234) were cached unless caching headers tell us not to. Now, default cacheable responses are only cached if caching headers explicitly tell us to. This change was introduced because there are many applications that set incorrect caching headers on private responses. This new behavior is currently not configurable, but there are plans to make it configurable in 5.0.0 release candidate 1.
+ * Introduced a new configuration option, `passenger_response_buffer_high_watermark` (Nginx) and `PassengerResponseBufferHighWatermark` (Apache), for configuring the behavior of the response buffering system. Closes GH-1300.
+ * Fixed more cookie handling issues. Closes GH-1310.
+ * Fixed various WebSocket issues. Closes GH-1306.
+ * Fixed some crashes caused by race conditions. Closes GH-1326.
+ * Fixed issues with handling POST data. Closes GH-1331.
+ * Fixed some issues on Heroku. Closes GH-1329.
+ * Fixed some integer overflows. Fix contributed by Go Maeda. Closes GH-1357.
+ * Fixed the `passenger-status --show=union_station` command. Closes GH-1336.
+ * Nginx versions earlier than 1.6 are no longer supported.
+ * Improved state introspection.
+
+
 Release 5.0.0 beta 2
 --------------------
 
@@ -44,6 +60,20 @@ Minor changes:
  * [Standalone] `passenger-standalone.json`/`Passengerfile.json` no longer overrides command line options. Instead, command line options now have the highest priority.
 
 
+Release 4.0.58
+--------------
+
+ * [Enterprise] Fixed a bug in the Debian packages which caused Flying Passenger to break when used with non-system Rubies.
+ * The Debian packages no longer require Ruby 1.9. Closes GH-1353.
+
+
+Release 4.0.57
+--------------
+
+ * Fixed a native extension compatibility problem with Ruby 2.2. Closes [ruby-core:67152](https://bugs.ruby-lang.org/issues/10656).
+ * Fixed compatibility with Nginx 1.7.9. Closes GH-1335.
+
+
 Release 4.0.56
 --------------
 

data/CONTRIBUTORS

@@ -15,6 +15,7 @@ Christoffer Sawicki
 Damien Le Berrigaud
 Dan Peterson
 Danial Pearce
+Daniel Knoppel (Phusion)
 Dave Parfitt
 David Keller
 David Sissitka
@@ -48,6 +49,7 @@ Joshua Lund
 jpatterson
 Jude Nagurney
 Luuk Hendriks (Phusion)
+MAEDA Go
 Magnus Holm
 Michal Papis
 Michał Pokrywka

data/Gemfile.lock

@@ -7,7 +7,7 @@ GEM
     diff-lcs (1.2.5)
     drake (0.9.2.0.3.1)
       comp_tree (>= 1.1.3)
-    json (1.8.1)
+    json (1.8.2)
     mime-types (1.25)
     mizuho (0.9.20)
       nokogiri (>= 1.4.0)

data/bin/passenger-status

@@ -1,6 +1,6 @@
 #!/usr/bin/env ruby
 #  Phusion Passenger - https://www.phusionpassenger.com/
-#  Copyright (c) 2010-2013 Phusion
+#  Copyright (c) 2010-2015 Phusion
 #
 #  "Phusion Passenger" is a trademark of Hongli Lai & Ninh Bui.
 #
@@ -116,7 +116,7 @@ def show_status(instance, options)
 			puts response.body
 		else
 			STDERR.puts "*** An error occured."
-			STDERR.puts response.body
+			STDERR.puts "#{response.code}: #{response.body}"
 			exit 2
 		end
 
@@ -128,7 +128,7 @@ def show_status(instance, options)
 			puts response.body
 		else
 			STDERR.puts "*** An error occured."
-			STDERR.puts response.body
+			STDERR.puts "#{response.code}: #{response.body}"
 			exit 2
 		end
 
@@ -145,7 +145,7 @@ def show_status(instance, options)
 			puts text
 		else
 			STDERR.puts "*** An error occured."
-			STDERR.puts response.body
+			STDERR.puts "#{response.code}: #{response.body}"
 			exit 2
 		end
 	
@@ -163,24 +163,22 @@ def show_status(instance, options)
 			end
 		else
 			STDERR.puts "*** An error occured."
-			STDERR.puts response.body
+			STDERR.puts "#{response.code}: #{response.body}"
 			exit 2
 		end
 
 	when 'union_station'
-		client = server_instance.connect(:role => :passenger_status, :socket_name => 'logging_admin')
-		begin
-			response = client.logging_agent_status
-		rescue SystemCallError => e
-			STDERR.puts "*** ERROR: Cannot query status for Phusion Passenger instance #{control_process.pid}:"
-			STDERR.puts e.to_s
+		request = Net::HTTP::Get.new("/status.txt")
+		request.basic_auth("ro_admin", obtain_read_only_admin_password(instance))
+		response = instance.http_request("agents.s/logging_admin", request)
+		if response.code.to_i / 100 == 2
+			puts response.body
+		else
+			STDERR.puts "*** An error occured."
+			STDERR.puts "#{response.code}: #{response.body}"
 			exit 2
 		end
-
-		puts response
 	end
-ensure
-	client.close if client
 end
 
 def print_header(io, instance)

data/build/cxx_tests.rb

@@ -1,5 +1,5 @@
 #  Phusion Passenger - https://www.phusionpassenger.com/
-#  Copyright (c) 2010-2014 Phusion
+#  Copyright (c) 2010-2015 Phusion
 #
 #  "Phusion Passenger" is a trademark of Hongli Lai & Ninh Bui.
 #
@@ -123,6 +123,10 @@ TEST_CXX_OBJECTS = {
 		ext/common/ServerKit/HttpRequest.h
 		ext/common/ServerKit/HttpHeaderParser.h
 		ext/common/ServerKit/HttpChunkedBodyParser.h),
+	'test/cxx/ServerKit/CookieUtilsTest.o' => %w(
+		test/cxx/ServerKit/CookieUtilsTest.cpp
+		ext/common/ServerKit/CookieUtils.h
+		ext/common/DataStructures/LString.h),
 	'test/cxx/DataStructures/LStringTest.o' => %w(
 		test/cxx/DataStructures/LStringTest.cpp
 		ext/common/DataStructures/LString.h),
@@ -141,6 +145,12 @@ TEST_CXX_OBJECTS = {
 	'test/cxx/DechunkerTest.o' => %w(
 		test/cxx/DechunkerTest.cpp
 		ext/common/Utils/Dechunker.h),
+	'test/cxx/ResponseCacheTest.o' => %w(
+		test/cxx/ResponseCacheTest.cpp
+		ext/common/agents/HelperAgent/ResponseCache.h
+		ext/common/agents/HelperAgent/RequestHandler/Request.h
+		ext/common/agents/HelperAgent/RequestHandler/AppResponse.h
+		ext/common/ServerKit/HttpRequest.h),
 	'test/cxx/UnionStationTest.o' => %w(
 		test/cxx/UnionStationTest.cpp
 		ext/common/agents/LoggingAgent/LoggingServer.h
@@ -227,6 +237,9 @@ TEST_CXX_OBJECTS = {
 	'test/cxx/ProcessMetricsCollectorTest.o' => %w(
 		test/cxx/ProcessMetricsCollectorTest.cpp
 		ext/common/Utils/ProcessMetricsCollector.h),
+	'test/cxx/DateParsingTest.o' => %w(
+		test/cxx/DateParsingTest.cpp
+		ext/common/Utils/DateParsing.h),
 	'test/cxx/UtilsTest.o' => %w(
 		test/cxx/UtilsTest.cpp
 		ext/common/Utils.h),

data/build/preprocessor.rb

@@ -1,6 +1,6 @@
 # encoding: utf-8
 #  Phusion Passenger - https://www.phusionpassenger.com/
-#  Copyright (c) 2013 Phusion
+#  Copyright (c) 2013-2015 Phusion
 #
 #  "Phusion Passenger" is a trademark of Hongli Lai & Ninh Bui.
 #
@@ -182,7 +182,9 @@ private
 		"quantal"  => "12.10",
 		"raring"   => "13.04",
 		"saucy"    => "13.10",
-		"trusty"   => "14.04"
+		"trusty"   => "14.04",
+		"utopic"   => "14.10",
+		"vivid"    => "15.05"
 	}
 	DEBIAN_DISTRIBUTIONS = {
 		"squeeze"  => "20110206",

data/debian.template/control.template

@@ -28,8 +28,8 @@ XS-Ruby-Versions: all
 Package: passenger
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends},
- ruby2.2 | ruby2.1 | ruby2.0 | ruby1.9.1 | ruby1.8 | ruby-interpreter,
- rubygems1.9.1 | rubygems1.9 | rubygems (>= 1.2),
+ ruby2.4 | ruby2.3 | ruby2.2 | ruby2.1 | ruby2.0 | ruby1.9.1 | ruby1.8 | ruby-interpreter,
+ rubygems-integration (>= 1.8) | rubygems1.9.1 | rubygems1.9 | rubygems (>= 1.2),
 #if is_distribution?('<= lucid') || is_distribution?('<= squeeze')
      librack-ruby,
 #else

data/doc/Security of user switching support.txt

@@ -64,7 +64,7 @@ If the answer is yes, then we cannot use this method.
 
 The advantage of this method is that setting up Apache to run as root is
 incredibly easy, and requires no new framework to be written. However, testing
-this method in automated unit tests will require running the unit test suit as
+this method in automated unit tests will require running the unit test suite as
 root.
 
 Using Apache's suEXEC
@@ -190,7 +190,7 @@ implemented. We rely on the system administrator to set the correct owner
 on that file.
 
 We have also not implemented suEXEC's security model. suEXEC's model is quite
-paranoid, and although paranoia is good to a certain extend, it can be in the
+paranoid, and although paranoia is good to a certain extent, it can be in the
 way of usability while proving little extra security. We are not entirely
 convinced that implementing suEXEC's full security model will provide
 significant benefits, but if you have good reasons to think otherwise, please

data/doc/Users guide Apache.idmap.txt

@@ -210,13 +210,15 @@
 
 7.7.2. PassengerBufferResponse <on|off>	=>	passengerbufferresponse-on-off--1y7ilka
 
-7.7.3. PassengerErrorOverride <on|off>	=>	passengererroroverride-on-off--1pq9nez
+7.7.3. PassengerResponseBufferHighWatermark <bytes>	=>	passengerresponsebufferhighwatermark-bytes--1kj32df
 
-7.7.4. PassengerMaxRequestQueueSize <number>	=>	passenger-max-request-queue-size-number--1f1uocd
+7.7.4. PassengerErrorOverride <on|off>	=>	passengererroroverride-on-off--1pq9nez
 
-7.7.5. PassengerStickySessions <on|off>	=>	passengerstickysessions-on-off--fx1jkt
+7.7.5. PassengerMaxRequestQueueSize <number>	=>	passenger-max-request-queue-size-number--1f1uocd
 
-7.7.6. PassengerStickySessionsCookieName	=>	passenger-sticky-sessions-cookie-name-stktkx
+7.7.6. PassengerStickySessions <on|off>	=>	passengerstickysessions-on-off--fx1jkt
+
+7.7.7. PassengerStickySessionsCookieName	=>	passenger-sticky-sessions-cookie-name-stktkx
 
 7.8. Compatibility options	=>	compatibility-options-8jve5a
 

data/doc/Users guide Apache.txt

@@ -1794,7 +1794,7 @@ happen in memory.
 Before we proceed with explaining this configuration option, we want to state the following to avoid confusion. If you use Phusion Passenger for Apache, there are in fact two response buffering systems active:
 
 1. The Apache response buffering system. `PassengerBufferResponse` turns this on or off.
-2. The Phusion Passenger response buffering system, a.k.a. 'real-time disk-backed response buffering'. This buffering system is always on, regardless of the value of `PassengerBufferResponse`.
+2. The Phusion Passenger response buffering system, a.k.a. 'real-time disk-backed response buffering'. This buffering system is always on, regardless of the value of `PassengerBufferResponse`, but its behavior can be tweaked with <<PassengerResponseBufferHighWatermark,PassengerResponseBufferHighWatermark>>.
 
 Response buffering is useful because it protects against slow HTTP clients that do not read responses immediately or quickly enough. Buffering prevents such slow clients from blocking web applications that have limited concurrency. Because Phusion Passenger's response buffering is always turned on, you are always protected. Therefore, `PassengerBufferResponse` is off by default, and you never should have to turn it on.
 
@@ -1864,6 +1864,25 @@ The <<PassengerBufferResponse,PassengerBufferResponse>> directive should be turn
 if responses can be huge. Because entire responses are buffered in memory when turned on.
 =====================================================
 
+[[PassengerResponseBufferHighWatermark]]
+==== PassengerResponseBufferHighWatermark <bytes>
+:version: 5.0.0
+include::users_guide_snippets/since_version.txt[]
+
+As explained in <<passenger_buffer_response,PassengerBufferResponse>>, Phusion Passenger has two response buffering mechanisms. This option configures the maximum size of the real-time disk-backed response buffering system. If the buffer is full, the application will be blocked until the client has fully read the buffer.
+
+This buffering system has a default size of *128 MB* (134217728 bytes). This default value is large enough to prevent most applications from blocking on slow clients, but small enough to prevent broken applications from filling up the hard disk.
+
+You can't disable real-time disk-backed response buffering, but you can set the buffer size to a small value, which is effectively the same as disabling it.
+
+Most of the time, you won't need to tweak this value. But there is one good use case where you may want set this option to a low value: if you are streaming a large response, but want to detect client disconnections as soon as possible. If the buffer size is larger than your response size, then Phusion Passenger will read and buffer the response as fast as it can, offloading the application as soon as it can, thereby preventing the application from detecting client disconnects. But if the buffer size is sufficiently small (say, 64 KB), then your application will effectively output response data at the same speed as the client reads it, allowing you to detect client disconnects almost immediately. This is also a down side, because many slow clients blocking your application can result in a denial of service, so use this option with care.
+
+If your application outputs responses larger than 128 MB and you are not interested in detecting client disconnects as soon as possible, then you should raise this value, or set it to 0.
+
+A value of 0 means that the buffer size is unlimited.
+
+This option may only occur once, in the global server configuration. The default value is '134217728' (128 MB).
+
 [[PassengerErrorOverride]]
 ==== PassengerErrorOverride <on|off> ====
 :version: 4.0.24

data/doc/Users guide Nginx.idmap.txt

@@ -232,11 +232,13 @@
 
 7.6.12. passenger_buffer_response <on|off>	=>	passenger-buffer-response
 
-7.6.13. passenger_buffer_size	=>	passenger-buffer-size-1jfkq87
+7.6.13. passenger_response_buffer_high_watermark <bytes>	=>	passenger-response-buffer-high-watermark-bytes--ranajv
 
-7.6.14. passenger_buffers	=>	passenger-busy-buffers
+7.6.14. passenger_buffer_size	=>	passenger-buffer-size-1jfkq87
 
-7.6.15. passenger_busy_buffer_size	=>	passenger-busy-buffer-size-124sj61
+7.6.15. passenger_buffers	=>	passenger-busy-buffers
+
+7.6.16. passenger_busy_buffer_size	=>	passenger-busy-buffer-size-124sj61
 
 7.7. Logging and debugging options	=>	logging-and-debugging-options-14e91ni
 

data/doc/Users guide Nginx.txt

@@ -1891,6 +1891,7 @@ This option may occur in the following places:
 
 In each place, it may be specified at most once. The default value is '512'.
 
+[[passenger_buffer_response]]
 ==== passenger_buffer_response <on|off> ====
 When turned on, application-generated responses are buffered by Nginx. Buffering will
 happen in memory and also on disk if the response is larger than a certain threshold.
@@ -1898,7 +1899,7 @@ happen in memory and also on disk if the response is larger than a certain thres
 Before we proceed with explaining this configuration option, we want to state the following to avoid confusion. If you use Phusion Passenger for Nginx, there are in fact two response buffering systems active:
 
 1. The Nginx response buffering system. `passenger_buffer_response` turns this on or off.
-2. The Phusion Passenger response buffering system, a.k.a. 'real-time disk-backed response buffering'. This buffering system is always on, regardless of the value of `passenger_buffer_response`.
+2. The Phusion Passenger response buffering system, a.k.a. 'real-time disk-backed response buffering'. This buffering system is always on, regardless of the value of `passenger_buffer_response`, but its behavior can be tweaked with <<PassengerResponseBufferHighWatermark,passenger_response_buffer_high_watermark>>.
 
 Response buffering is useful because it protects against slow HTTP clients that do not read responses immediately or quickly enough. Buffering prevents such slow clients from blocking web applications that have limited concurrency. Because Phusion Passenger's response buffering is always turned on, you are always protected. Therefore, `passenger_buffer_response` is off by default, and you never should have to turn it on.
 
@@ -1961,10 +1962,29 @@ This option may occur in the following places:
 
 In each place, it may be specified at most once. The default value is 'off'.
 
+[[PassengerResponseBufferHighWatermark]]
+==== passenger_response_buffer_high_watermark <bytes>
+:version: 5.0.0
+include::users_guide_snippets/since_version.txt[]
+
+As explained in <<passenger_buffer_response,passenger_buffer_response>>, Phusion Passenger has two response buffering mechanisms. This option configures the maximum size of the real-time disk-backed response buffering system. If the buffer is full, the application will be blocked until the client has fully read the buffer.
+
+This buffering system has a default size of *128 MB* (134217728 bytes). This default value is large enough to prevent most applications from blocking on slow clients, but small enough to prevent broken applications from filling up the hard disk.
+
+You can't disable real-time disk-backed response buffering, but you can set the buffer size to a small value, which is effectively the same as disabling it.
+
+Most of the time, you won't need to tweak this value. But there is one good use case where you may want set this option to a low value: if you are streaming a large response, but want to detect client disconnections as soon as possible. If the buffer size is larger than your response size, then Phusion Passenger will read and buffer the response as fast as it can, offloading the application as soon as it can, thereby preventing the application from detecting client disconnects. But if the buffer size is sufficiently small (say, 64 KB), then your application will effectively output response data at the same speed as the client reads it, allowing you to detect client disconnects almost immediately. This is also a down side, because many slow clients blocking your application can result in a denial of service, so use this option with care.
+
+If your application outputs responses larger than 128 MB and you are not interested in detecting client disconnects as soon as possible, then you should raise this value, or set it to 0.
+
+A value of 0 means that the buffer size is unlimited.
+
+This option may only occur once, in the 'http' configuration block. The default value is '134217728' (128 MB).
+
 ==== passenger_buffer_size ====
 ==== passenger_buffers ====
 ==== passenger_busy_buffer_size ====
-These options have the same effect as proxy_module's similarly named options.
+These options have the same effect as ngx_http_proxy_module's similarly named options.
 They can be used to modify the maximum allowed HTTP header size.
 
 

data/ext/apache2/Configuration.cpp

@@ -238,6 +238,7 @@ DEFINE_SERVER_INT_CONFIG_SETTER(cmd_passenger_log_level, logLevel, unsigned int,
 DEFINE_SERVER_STR_CONFIG_SETTER(cmd_passenger_debug_log_file, debugLogFile)
 DEFINE_SERVER_INT_CONFIG_SETTER(cmd_passenger_max_pool_size, maxPoolSize, unsigned int, 1)
 DEFINE_SERVER_INT_CONFIG_SETTER(cmd_passenger_pool_idle_time, poolIdleTime, unsigned int, 0)
+DEFINE_SERVER_INT_CONFIG_SETTER(cmd_passenger_response_buffer_high_watermark, responseBufferHighWatermark, unsigned int, 0)
 DEFINE_SERVER_INT_CONFIG_SETTER(cmd_passenger_stat_throttle_rate, statThrottleRate, unsigned int, 0)
 DEFINE_SERVER_BOOLEAN_CONFIG_SETTER(cmd_passenger_user_switching, userSwitching)
 DEFINE_SERVER_STR_CONFIG_SETTER(cmd_passenger_default_user, defaultUser)
@@ -410,6 +411,11 @@ const command_rec passenger_commands[] = {
 		NULL,
 		RSRC_CONF,
 		"The maximum number of seconds that an application may be idle before it gets terminated."),
+	AP_INIT_TAKE1("PassengerResponseBufferHighWatermark",
+		(Take1Func) cmd_passenger_response_buffer_high_watermark,
+		NULL,
+		RSRC_CONF,
+		"The maximum size of the response buffer."),
 	AP_INIT_FLAG("PassengerUserSwitching",
 		(FlagFunc) cmd_passenger_user_switching,
 		NULL,

data/ext/apache2/Configuration.hpp

@@ -1,6 +1,6 @@
 /*
  *  Phusion Passenger - https://www.phusionpassenger.com/
- *  Copyright (c) 2010-2014 Phusion
+ *  Copyright (c) 2010-2015 Phusion
  *
  *  "Phusion Passenger" is a trademark of Hongli Lai & Ninh Bui.
  *
@@ -187,6 +187,8 @@ struct ServerConfig {
 	 * idle before it gets terminated. */
 	unsigned int poolIdleTime;
 
+	unsigned int responseBufferHighWatermark;
+
 	unsigned int statThrottleRate;
 
 	/** Whether user switching support is enabled. */
@@ -220,6 +222,7 @@ struct ServerConfig {
 		debugLogFile       = NULL;
 		maxPoolSize        = DEFAULT_MAX_POOL_SIZE;
 		poolIdleTime       = DEFAULT_POOL_IDLE_TIME;
+		responseBufferHighWatermark = DEFAULT_RESPONSE_BUFFER_HIGH_WATERMARK;
 		statThrottleRate   = DEFAULT_STAT_THROTTLE_RATE;
 		userSwitching      = true;
 		defaultUser        = DEFAULT_WEB_APP_USER;