passaporteweb-client 0.0.12 → 0.0.13

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    passaporteweb-client (0.0.12)
+    passaporteweb-client (0.0.13)
       multi_json (~> 1.7.1)
       rest-client (~> 1.6.7)
 

data/lib/passaporte_web/notification.rb

@@ -76,13 +76,15 @@ module PassaporteWeb
     #     target_url: "https://app.passaporteweb.com.br",
     #     scheduled_to: "2012-01-01 00:00:00"
     #   )
-    # TOSPEC
     def initialize(attributes={})
       set_attributes(attributes)
       @errors = {}
     end
 
-    # TODOC
+    # Creates the notification on PassaporteWeb. The +body+ and +destination+ attributes are required. The
+    # +auth_type+ parameter defaults to 'user', meaning the notification is sent by the authenticated
+    # Identity. If +auth_type+ is 'application', than the notification is sent by the authenticated
+    # application.
     #
     # API method: <tt>POST /notifications/api/</tt>
     #
@@ -96,7 +98,7 @@ module PassaporteWeb
       end
     end
 
-    # TODOC
+    # Marks a notification as read.
     #
     # API method: <tt>PUT /notifications/api/:uuid/</tt>
     #
@@ -118,19 +120,27 @@ module PassaporteWeb
       false
     end
 
-    # TODOC
+    # Excludes a newly created notification. Only notifications scheduled for the future can be deleted.
     #
     # API method: <tt>DELETE /notifications/api/:uuid/</tt>
     #
     # API documentation: https://app.passaporteweb.com.br/static/docs/notificacao.html#delete-notifications-api-uuid
     def destroy
-      return false unless self.persisted?
+      unless self.persisted?
+        @errors = {message: 'notification not persisted yet'}
+        return false
+      end
       response = Http.delete("/notifications/api/#{self.uuid}/", {}, 'application')
       raise "unexpected response: #{response.code} - #{response.body}" unless response.code == 204
       @errors = {}
       @persisted = false
       @destroyed = true
       true
+    rescue *[RestClient::Forbidden] => e
+      @persisted = true
+      @destroyed = false
+      @errors = MultiJson.decode(e.response.body)
+      false
     end
 
     # Returns a hash with all attribures of the Notification.

data/lib/passaporte_web/version.rb

@@ -1,4 +1,4 @@
 # encoding: utf-8
 module PassaporteWeb
-  VERSION = "0.0.12"
+  VERSION = "0.0.13"
 end

data/spec/passaporte_web/notification_spec.rb

@@ -202,17 +202,22 @@ describe PassaporteWeb::Notification do
   end
 
   describe "#destroy" do
+    let(:notification) { described_class.new(body: 'novinha', destination: 'a5868d14-6529-477a-9c6b-a09dd42a7cd2', scheduled_to: '2013-04-06') } # 2.days.from_now
     it "should return false if the record is not persisted" do
-      notification = described_class.new(body: 'novinha', destination: 'a5868d14-6529-477a-9c6b-a09dd42a7cd2')
       notification.destroy.should be_false
+      notification.errors.should == {message: 'notification not persisted yet'}
     end
-    it "should destroy the notification on PassaporteWeb", vcr: true do
-      PassaporteWeb.configuration.user_token = "3e4470e59d76f748e0081b514da62ed621a893c87facd4a6"
-      count = described_class.count(true)
-      notification = described_class.find_all(1,20,nil,true).notifications.last
-      notification.should_not be_nil
+    it "should destroy the notification on PassaporteWeb if the notification has not been read and is scheduled", vcr: true do
+      notification.save('application').should be_true
+      notification.read_at.should be_nil
+      notification.scheduled_to.should == "2013-04-06 00:00:00"
       notification.destroy.should be_true
-      described_class.count(true).should == (count - 1)
+    end
+    it "should not exclude non-scheduled notification", vcr: true do
+      notification.scheduled_to = nil
+      notification.save('application').should be_true
+      notification.destroy.should be_false
+      notification.errors.should == "Only scheduled notifications can be deleted via API"
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: passaporteweb-client
 version: !ruby/object:Gem::Version
-  version: 0.0.12
+  version: 0.0.13
   prerelease: 
 platform: ruby
 authors:
@@ -276,7 +276,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -214247969600102075
+      hash: -2500500601371462639
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -285,7 +285,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -214247969600102075
+      hash: -2500500601371462639
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.25