partisan 0.2 → 0.2.1

data/LICENSE.md

@@ -1,22 +1,26 @@
-Copyright (c) 2013 Rémi Prévost
+Copyright (c) 2013, Mirego
+All rights reserved.
 
-MIT License
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions are met:
 
-Permission is hereby granted, free of charge, to any person obtaining
-a copy of this software and associated documentation files (the
-"Software"), to deal in the Software without restriction, including
-without limitation the rights to use, copy, modify, merge, publish,
-distribute, sublicense, and/or sell copies of the Software, and to
-permit persons to whom the Software is furnished to do so, subject to
-the following conditions:
+- Redistributions of source code must retain the above copyright notice,
+  this list of conditions and the following disclaimer.
+- Redistributions in binary form must reproduce the above copyright notice,
+  this list of conditions and the following disclaimer in the documentation
+  and/or other materials provided with the distribution.
+- Neither the name of the Mirego nor the names of its contributors may
+  be used to endorse or promote products derived from this software without
+  specific prior written permission.
 
-The above copyright notice and this permission notice shall be
-included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
-LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
+LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+POSSIBILITY OF SUCH DAMAGE.

data/README.md

@@ -122,12 +122,12 @@ The available callbacks are:
 
 #### Followable
 
-| Callback          | Reference to the follower        |
-| ------------------|----------------------------------|
-| `before_follow`   | `self.about_to_be_followed_by`   |
-| `after_follow`    | `self.just_followed_by`          |
-| `before_unfollow` | `self.about_to_by_unfollowed_by` |
-| `after_unfollow`  | `self.just_unfollowed_by`        |
+| Callback                  | Reference to the follower        |
+| --------------------------|----------------------------------|
+| `before_being_followed`   | `self.about_to_be_followed_by`   |
+| `after_being_followed`    | `self.just_followed_by`          |
+| `before_being_unfollowed` | `self.about_to_by_unfollowed_by` |
+| `after_being_unfollowed`  | `self.just_unfollowed_by`        |
 
 ## License
 

data/lib/partisan/follow.rb

@@ -24,7 +24,7 @@ module Partisan
     # Followable's :follow callbacks
     around_create do |follow, blk|
       self.followable.about_to_be_followed_by = self.followable.just_followed_by = self.follower
-      self.followable.run_callbacks :follow, &blk
+      self.followable.run_callbacks :being_followed, &blk
       self.followable.about_to_be_followed_by = self.followable.just_followed_by = nil
     end
 
@@ -38,7 +38,7 @@ module Partisan
     # Followable's :unfollow callbacks
     around_destroy do |follow, blk|
       self.followable.about_to_be_unfollowed_by = self.followable.just_unfollowed_by = self.follower
-      self.followable.run_callbacks :unfollow, &blk
+      self.followable.run_callbacks :being_unfollowed, &blk
       self.followable.about_to_be_unfollowed_by = self.followable.just_unfollowed_by = nil
     end
 

data/lib/partisan/followable.rb

@@ -7,8 +7,8 @@ module Partisan
 
     included do
       has_many :followings, as: :followable, class_name: 'Partisan::Follow', dependent: :destroy
-      define_model_callbacks :follow
-      define_model_callbacks :unfollow
+      define_model_callbacks :being_followed
+      define_model_callbacks :being_unfollowed
       attr_accessor :about_to_be_followed_by, :just_followed_by, :about_to_be_unfollowed_by, :just_unfollowed_by
     end
 

data/lib/partisan/version.rb

@@ -1,3 +1,3 @@
 module Partisan
-  VERSION = "0.2"
+  VERSION = "0.2.1"
 end

data/partisan.gemspec

@@ -6,11 +6,11 @@ require 'partisan/version'
 Gem::Specification.new do |spec|
   spec.name          = 'partisan'
   spec.version       = Partisan::VERSION
-  spec.authors       = ['Simon Prévost']
-  spec.email         = ['sprevost@mirego.com']
-  spec.description   = 'Partisan is a Ruby library that allows ActiveRecord records to be follower and followable, just like on popular social networks. It’s heavily inspired by the origin acts_as_follower which is no longer maintened'
+  spec.authors       = ['Simon Prévost', 'Rémi Prévost']
+  spec.email         = ['sprevost@mirego.com', 'Rémi Prévost']
+  spec.description   = 'Partisan is a Ruby library that allows ActiveRecord records to be follower and followable, just like on popular social networks. It’s heavily inspired by acts_as_follower which is no longer maintened.'
   spec.summary       = 'Partisan is a Ruby library that allows ActiveRecord records to be follower and followable'
-  spec.homepage      = 'https://github.com/simonprev/partisan'
+  spec.homepage      = 'https://github.com/mirego/partisan'
   spec.license       = 'BSD 3-Clause'
 
   spec.files         = `git ls-files`.split($/)

data/spec/followable_spec.rb

@@ -70,5 +70,62 @@ describe Partisan::Followable do
       it { expect(band.followers_count).to eq 1 }
     end
   end
-end
 
+  describe :Callbacks do
+    before do
+      class Buffer
+        def self.tmp_value=(tmp_value)
+          @tmp_value = tmp_value
+        end
+
+        def self.tmp_value
+          @tmp_value
+        end
+      end
+    end
+
+    describe :before_being_followed do
+      before do
+        followable 'Band' do
+          before_being_followed { Buffer.tmp_value = self.about_to_be_followed_by }
+        end
+      end
+
+      it { expect{ user.follow(band) }.to change{ Buffer.tmp_value }.to(user) }
+    end
+
+    describe :after_being_followed do
+      before do
+        followable 'Band' do
+          after_being_followed { Buffer.tmp_value = self.just_followed_by }
+        end
+      end
+
+      it { expect{ user.follow(band) }.to change{ Buffer.tmp_value }.to(user) }
+    end
+
+    describe :before_being_unfollowed do
+      before do
+        followable 'Band' do
+          before_being_unfollowed { Buffer.tmp_value = self.about_to_be_unfollowed_by }
+        end
+
+        user.follow(band)
+      end
+
+      it { expect{ user.unfollow(band) }.to change{ Buffer.tmp_value }.to(user) }
+    end
+
+    describe :after_being_unfollowed do
+      before do
+        followable 'Band' do
+          after_being_unfollowed { Buffer.tmp_value = self.just_unfollowed_by }
+        end
+
+        user.follow(band)
+      end
+
+      it { expect{ user.unfollow(band) }.to change{ Buffer.tmp_value }.to(user) }
+    end
+  end
+end

data/spec/follower_spec.rb

@@ -93,96 +93,48 @@ describe Partisan::Follower do
       end
     end
 
-    describe 'Follower callbacks' do
-      describe :before_follow do
-        before do
-          follower 'User' do
-            before_follow { Buffer.tmp_value = self.about_to_follow }
-          end
+    describe :before_follow do
+      before do
+        follower 'User' do
+          before_follow { Buffer.tmp_value = self.about_to_follow }
         end
-
-        it { expect{ user.follow(band) }.to change{ Buffer.tmp_value }.to(band) }
-      end
-
-      describe :after_follow do
-        before do
-          follower 'User' do
-            after_follow { Buffer.tmp_value = self.just_followed }
-          end
-        end
-
-        it { expect{ user.follow(band) }.to change{ Buffer.tmp_value }.to(band) }
       end
 
-      describe :before_unfollow do
-        before do
-          follower 'User' do
-            before_unfollow { Buffer.tmp_value = self.about_to_unfollow }
-          end
+      it { expect{ user.follow(band) }.to change{ Buffer.tmp_value }.to(band) }
+    end
 
-          user.follow(band)
+    describe :after_follow do
+      before do
+        follower 'User' do
+          after_follow { Buffer.tmp_value = self.just_followed }
         end
-
-        it { expect{ user.unfollow(band) }.to change{ Buffer.tmp_value }.to(band) }
       end
 
-      describe :after_unfollow do
-        before do
-          follower 'User' do
-            after_unfollow { Buffer.tmp_value = self.about_to_unfollow }
-          end
-
-          user.follow(band)
-        end
-
-        it { expect{ user.unfollow(band) }.to change{ Buffer.tmp_value }.to(band) }
-      end
+      it { expect{ user.follow(band) }.to change{ Buffer.tmp_value }.to(band) }
     end
 
-    describe 'Followable callbacks' do
-      describe :before_follow do
-        before do
-          followable 'Band' do
-            before_follow { Buffer.tmp_value = self.about_to_be_followed_by }
-          end
-        end
-
-        it { expect{ user.follow(band) }.to change{ Buffer.tmp_value }.to(user) }
-      end
-
-      describe :after_follow do
-        before do
-          followable 'Band' do
-            after_follow { Buffer.tmp_value = self.just_followed_by }
-          end
+    describe :before_unfollow do
+      before do
+        follower 'User' do
+          before_unfollow { Buffer.tmp_value = self.about_to_unfollow }
         end
 
-        it { expect{ user.follow(band) }.to change{ Buffer.tmp_value }.to(user) }
+        user.follow(band)
       end
 
-      describe :before_unfollow do
-        before do
-          followable 'Band' do
-            before_unfollow { Buffer.tmp_value = self.about_to_be_unfollowed_by }
-          end
+      it { expect{ user.unfollow(band) }.to change{ Buffer.tmp_value }.to(band) }
+    end
 
-          user.follow(band)
+    describe :after_unfollow do
+      before do
+        follower 'User' do
+          after_unfollow { Buffer.tmp_value = self.about_to_unfollow }
         end
 
-        it { expect{ user.unfollow(band) }.to change{ Buffer.tmp_value }.to(user) }
+        user.follow(band)
       end
 
-      describe :after_unfollow do
-        before do
-          followable 'Band' do
-            after_unfollow { Buffer.tmp_value = self.just_unfollowed_by }
-          end
-
-          user.follow(band)
-        end
-
-        it { expect{ user.unfollow(band) }.to change{ Buffer.tmp_value }.to(user) }
-      end
+      it { expect{ user.unfollow(band) }.to change{ Buffer.tmp_value }.to(band) }
     end
   end
 

metadata

@@ -1,11 +1,12 @@
 --- !ruby/object:Gem::Specification
 name: partisan
 version: !ruby/object:Gem::Version
-  version: '0.2'
+  version: 0.2.1
   prerelease: 
 platform: ruby
 authors:
 - Simon Prévost
+- Rémi Prévost
 autorequire: 
 bindir: bin
 cert_chain: []
@@ -92,10 +93,11 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 description: Partisan is a Ruby library that allows ActiveRecord records to be follower
-  and followable, just like on popular social networks. It’s heavily inspired by the
-  origin acts_as_follower which is no longer maintened
+  and followable, just like on popular social networks. It’s heavily inspired by acts_as_follower
+  which is no longer maintened.
 email:
 - sprevost@mirego.com
+- Rémi Prévost
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -122,7 +124,7 @@ files:
 - spec/spec_helper.rb
 - spec/support/macros/database_macros.rb
 - spec/support/macros/model_macros.rb
-homepage: https://github.com/simonprev/partisan
+homepage: https://github.com/mirego/partisan
 licenses:
 - BSD 3-Clause
 post_install_message: 
@@ -137,7 +139,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -352093583781721099
+      hash: -3563341390347157269
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -146,7 +148,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -352093583781721099
+      hash: -3563341390347157269
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23