partial_ks 0.4.1 → 0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 38febb0d43538e1c658e595dfa1b690669e9366b
-  data.tar.gz: f518ef601cb41bf1fc480e75269fdb2d7723c45e
+  metadata.gz: ad9df615166ffb1addb9feff9c7a0db7cc73c841
+  data.tar.gz: 9781d32d0230aa6e376822cd9803cfbea2938084
 SHA512:
-  metadata.gz: 8dba5fdfc838d88f1bac8900d1e7e119da31868acbbe54103753a4c8cf9d6f5181bc1358c66ba7c66cdb993dd483519c8cb63a1d041a91b602373d7887be4985
-  data.tar.gz: 5eb5e046f03bf8fc15b31ca96d50966a591d5496d95d24ce47a00df83427e9d39f620709cbe7f2ec415310fe67291a4347ed0c4e7e0d8518f1c5ea41e66c5dda
+  metadata.gz: 7445c9ebc62962e3ee09bd7650d79545a3af9477c89fdfdf0d81b530713ebe012e90c3abe007cbfeec24df28c1624bfe94935c1794929363ccbc75759d80d7ca
+  data.tar.gz: c5ea6e4a4d723d8e6f86e748bd7f969974bff2775bb18f38ca33c5d5f1a015a15b2df1ceb26e079337541381e8686a3cf5abc6d38c53d95962116007c640c974

data/CHANGES.md

@@ -1,5 +1,9 @@
 # Changelog
 
+# 0.4.2
+
+Fix an issue where we did not support the new ApplicationRecord convention
+
 # 0.4.1
 
 Fix issue where models which are missing their table would error out the whole process.

data/lib/partial_ks/all_rails_models.rb

@@ -4,6 +4,12 @@ module PartialKs
       ::Rails.application.eager_load!
       ::Rails::Engine.subclasses.map(&:eager_load!)
     end
-    ActiveRecord::Base.direct_descendants
+
+    concrete_classes.map(&:base_class).uniq
+  end
+
+  private
+  def self.concrete_classes
+    ActiveRecord::Base.descendants.reject {|klass| klass.abstract_class? || !klass.table_exists?}
   end
 end

data/lib/partial_ks/version.rb

@@ -1,3 +1,3 @@
 module PartialKs
-  VERSION = '0.4.1'
+  VERSION = '0.4.2'
 end

data/test/all_rails_models_test.rb

@@ -0,0 +1,19 @@
+require 'test_helper'
+
+describe "all rails tables" do
+  it "includes models that descend from ApplicationRecord" do
+    PartialKs.all_rails_models.must_include User
+  end
+
+  it "excludes abstract classes like ApplicationRecord" do
+    PartialKs.all_rails_models.wont_include ApplicationRecord
+  end
+
+  it "excludes subclass" do
+    PartialKs.all_rails_models.wont_include SubTag
+  end
+
+  it "returns the same number of models as the number of tables" do
+    PartialKs.all_rails_models.map(&:table_name).sort.must_equal ActiveRecord::Base.connection.tables.sort
+  end
+end

data/test/configuration_generator_test.rb

@@ -12,6 +12,7 @@ describe "generating dependencies" do
     ]
   end
 
+  # TODO remove redundant test (cf parent_inferrer_test)
   it "auto infers single belongs-to dependencies" do
     generator(manual_configuration, models: [User, BlogPost]).
       must_equal [
@@ -20,6 +21,7 @@ describe "generating dependencies" do
     ]
   end
 
+  # TODO remove redundant test (cf parent_inferrer_test)
   it "auto infers top level tables" do
     generator(manual_configuration, models: [User, Tag]).
       must_equal [
@@ -28,7 +30,7 @@ describe "generating dependencies" do
     ]
   end
 
-  it "can infer models with different table_name" do
+  it "can return models with different table_name" do
     model = OldEntry
     model.table_name.wont_equal model.name.tableize
 

data/test/setup_models.rb

@@ -1,4 +1,8 @@
-class User < ActiveRecord::Base
+class ApplicationRecord < ActiveRecord::Base
+  self.abstract_class = true
+end
+
+class User < ApplicationRecord
   has_many :blog_posts
 end
 
@@ -28,3 +32,6 @@ class NewModel < ActiveRecord::Base
   # no tables, e.g. migration not run yet
   belongs_to :user
 end
+
+class SubTag < Tag
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: partial_ks
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
 platform: ruby
 authors:
 - Thong Kuah
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-08 00:00:00.000000000 Z
+date: 2017-06-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -76,6 +76,7 @@ files:
 - lib/partial_ks/table.rb
 - lib/partial_ks/version.rb
 - partial_ks.gemspec
+- test/all_rails_models_test.rb
 - test/configuration_generator_test.rb
 - test/database.yml
 - test/filtered_table_test.rb
@@ -110,6 +111,7 @@ signing_key:
 specification_version: 4
 summary: Partial KS
 test_files:
+- test/all_rails_models_test.rb
 - test/configuration_generator_test.rb
 - test/database.yml
 - test/filtered_table_test.rb