partial_ks 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 27cf67a4ac72c019e9ce39c13be6949746d319cb
-  data.tar.gz: c8aaa05cf43a2c2a3bbc0d5076147ee2593f1d35
+  metadata.gz: 38febb0d43538e1c658e595dfa1b690669e9366b
+  data.tar.gz: f518ef601cb41bf1fc480e75269fdb2d7723c45e
 SHA512:
-  metadata.gz: 41c5e26c8792bc97720b97aae22da1f4f0ca39014fc7e99b3eb20529557ffeb1dedd2015b164174acca8bf66a683ea0f2cd167b425bff7b04c237ab0c8f55873
-  data.tar.gz: 4cbdfbb74cfb845bba856ff2db9bfead21222f42cb61df535404cb3b9b959ad44f8f56880615e9cf7c41770030ca6d15bf221828428e36fffd4b9e59d035bf6d
+  metadata.gz: 8dba5fdfc838d88f1bac8900d1e7e119da31868acbbe54103753a4c8cf9d6f5181bc1358c66ba7c66cdb993dd483519c8cb63a1d041a91b602373d7887be4985
+  data.tar.gz: 5eb5e046f03bf8fc15b31ca96d50966a591d5496d95d24ce47a00df83427e9d39f620709cbe7f2ec415310fe67291a4347ed0c4e7e0d8518f1c5ea41e66c5dda

data/CHANGES.md

@@ -1,5 +1,9 @@
 # Changelog
 
+# 0.4.1
+
+Fix issue where models which are missing their table would error out the whole process.
+
 # 0.4.0
 
 Allow lambdas to be used as a custom filter

data/CONTRIBUTING.md

@@ -2,7 +2,7 @@ This document should tell all you need to know for contributing to this project.
 
 # Testing
 
-Tested with activerecord 4.2.7.1, 4.2.8 and 5.0.1 (on Ruby 2.3.3)
+Tested with activerecord 4.2.7.1, 4.2.8 and 5.0.2 (on Ruby 2.3.3)
 
 
 To install and run tests :

data/lib/partial_ks/configuration_generator.rb

@@ -3,7 +3,7 @@
 # and attempts to automatically populate the table into the table graph
 module PartialKs
   class ConfigurationGenerator
-    attr_reader :manual_configuration, :models
+    attr_reader :manual_configuration
 
     def initialize(manual_configuration, models: nil)
       @manual_configuration = manual_configuration
@@ -19,6 +19,11 @@ module PartialKs
       @all_tables ||= models.map {|model| PartialKs::Table.new(model) }.select(&:model?).index_by(&:table_name)
     end
 
+    def models
+      tables_in_database = ActiveRecord::Base.connection.tables
+      @models.select{|model| tables_in_database.include?(model.table_name)}
+    end
+
     def filtered_tables
       synced_tables = {}
 

data/lib/partial_ks/version.rb

@@ -1,3 +1,3 @@
 module PartialKs
-  VERSION = '0.4.0'
+  VERSION = '0.4.1'
 end

data/test/configuration_generator_test.rb

@@ -38,4 +38,11 @@ describe "generating dependencies" do
       ["cms_table", nil, nil]
     ]
   end
+
+  it "does not choke on a table which has had its migration run" do
+    generator(manual_configuration, models: [User, NewModel]).
+      must_equal [
+      ["users", nil, User.where(:id => [1])],
+    ]
+  end
 end

data/test/setup_models.rb

@@ -23,3 +23,8 @@ end
 class OldTag < ActiveRecord::Base
   belongs_to :old_entry, :foreign_key => 'blog_post_id'
 end
+
+class NewModel < ActiveRecord::Base
+  # no tables, e.g. migration not run yet
+  belongs_to :user
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: partial_ks
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Thong Kuah
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-20 00:00:00.000000000 Z
+date: 2017-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord