partial_ks 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9f64ccee32ef2fecf6953f2916c03e7d13fc061a
-  data.tar.gz: 2666bf980392217edf9567bee84ebeee87601768
+  metadata.gz: 68505ca861cdb0855c62be32cd6b9377f5c6f687
+  data.tar.gz: 1dabcb9334a38d27ccbf823237a031aadc4c8b26
 SHA512:
-  metadata.gz: 4ac534888ca683de0f4e18d6fd97d9ff245440410dc405a79a126ad4c0ff291f283dfd71128b28b95ec6cc1e9e3cad66fde6ce81d07273731b999f6ad8d8ffe1
-  data.tar.gz: f10c7800637417c5a7f8c4a6cc76cdf53d2be2ad9536b208e22a96f6cd1e677fce2fd060123b6844ac021d38fa3389e90621178b9224ff0fac92ddc0f0f9fd48
+  metadata.gz: fcb48cf2bdcc7151bb99b69a684798185ff6344cc7c7f77fd4316642d0b8ff0eb93f3e00a1f3d41c47f02334473f3b11d9c1a842a32abe976e5cd46e0a6b54e7
+  data.tar.gz: 9e50c50f69aab5dff5a040943406d90e35241baa3adf0cef32ea8ce5abbb685a65839d236c9566cddcce5ab86408cb6227402c9bd04c4aa1c8c947c73e39fdc6

data/CHANGES.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.0.6
+
+Allow manual_configuration to transition to using model names (moving off from table names)
+
 ## 0.0.5
 
 API change for `ConfigurationGenerator` - removes `ignored_table_names` option.

data/lib/partial_ks/configuration_generator.rb

@@ -1,59 +1,62 @@
 # Given an initial table graph
 # goes through each table not already in the table graph,
 # and attempts to automatically populate the table into the table graph
-class PartialKs::ConfigurationGenerator
-  attr_reader :table_graph, :table_names
+module PartialKs
+  class ConfigurationGenerator
+    attr_reader :manual_configuration, :table_names
 
-  def initialize(table_graph, table_names: nil)
-    @table_graph = table_graph
-    @table_names = table_names || ActiveRecord::Base.connection.tables
-  end
+    def initialize(manual_configuration, table_names: nil)
+      @manual_configuration = manual_configuration
+      @table_names = table_names || ActiveRecord::Base.connection.tables
+    end
 
-  def call
-    @filtered_tables ||= filtered_tables
-  end
+    def call
+      @filtered_tables ||= filtered_tables
+    end
 
-  protected
-  def all_tables
-    @all_tables ||= @table_names.map {|table_name| PartialKs::Table.new(table_name) }.select(&:model?).index_by(&:table_name)
-  end
+    protected
+    def all_tables
+      @all_tables ||= @table_names.map {|table_name| PartialKs::Table.new(table_name) }.select(&:model?).index_by(&:table_name)
+    end
 
-  def filtered_tables
-    synced_tables = {}
+    def filtered_tables
+      synced_tables = {}
 
-    table_graph.each do |table_name, specified_parent_model, filter_for_table|
-      next unless all_tables[table_name]
+      manual_configuration.each do |table_name_or_model, specified_parent_model, filter_for_table|
+        table_name = table_name_or_model.is_a?(String) ? table_name_or_model : table_name_or_model.table_name
+        next unless all_tables[table_name]
 
-      parent_model = specified_parent_model
-      synced_tables[table_name] = PartialKs::FilteredTable.new(all_tables[table_name], parent_model, custom_filter_relation: filter_for_table)
-    end
+        parent_model = specified_parent_model
+        synced_tables[table_name] = PartialKs::FilteredTable.new(all_tables[table_name], parent_model, custom_filter_relation: filter_for_table)
+      end
+
+      all_tables.each do |table_name, table|
+        next if synced_tables[table_name]
 
-    all_tables.each do |table_name, table|
-      next if synced_tables[table_name]
+        begin
+          inferrer = PartialKs::ParentInferrer.new(table)
+          #TODO get rid of try!
+          parent_model = all_tables[inferrer.inferred_parent_table].try!(:model)
+          synced_tables[table_name] = PartialKs::FilteredTable.new(table, parent_model)
+        rescue PartialKs::ParentInferrer::CannotInfer
+          next
+        end
 
-      begin
-        inferrer = PartialKs::ParentInferrer.new(table)
-        #TODO get rid of try!
-        parent_model = all_tables[inferrer.inferred_parent_table].try!(:model)
-        synced_tables[table_name] = PartialKs::FilteredTable.new(table, parent_model)
-      rescue PartialKs::ParentInferrer::CannotInfer
-        next
       end
 
-    end
+      # TODO remove this side effect. Maybe yield or a different method call ?
+      puts "***************"
+      remaining_size = 0
+      all_tables.each do |table_name, table|
+        next if synced_tables[table_name]
 
-    # TODO remove this side effect. Maybe yield or a different method call ?
-    puts "***************"
-    remaining_size = 0
-    all_tables.each do |table_name, table|
-      next if synced_tables[table_name]
+        puts "#{table.table_name} - #{table.parent_tables.join(',')}"
+        remaining_size += 1
+      end
+      puts "WARNING: #{remaining_size} tables has no configuration"
 
-      puts "#{table.table_name} - #{table.parent_tables.join(',')}"
-      remaining_size += 1
+      synced_tables.values
     end
-    puts "WARNING: #{remaining_size} tables has no configuration"
 
-    synced_tables.values
   end
-
 end

data/lib/partial_ks/version.rb

@@ -1,3 +1,3 @@
 module PartialKs
-  VERSION = '0.0.5'
+  VERSION = '0.0.6'
 end

data/test/configuration_generator_test.rb

@@ -32,3 +32,27 @@ describe "generating dependencies" do
     ]
   end
 end
+
+describe "transition to model based dependencies" do
+  let(:manual_configuration) do
+    [
+      [User, nil, User.where(:id => [1])],
+    ]
+  end
+
+  it "auto infers single belongs-to dependencies" do
+    generator(manual_configuration, table_names: pks_tables("users", "blog_posts")).
+      must_equal [
+      ["users", nil, User.where(:id => [1])],
+      ["blog_posts", User, nil]
+    ]
+  end
+
+  it "auto infers top level tables" do
+    generator(manual_configuration, table_names: pks_tables("users", "tags")).
+      must_equal [
+      ["users", nil, User.where(:id => [1])],
+      ["tags", nil, nil]
+    ]
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: partial_ks
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Thong Kuah
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-23 00:00:00.000000000 Z
+date: 2016-12-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord