parliament-utils 0.8.4 → 0.8.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e9d242c466e583463358d74beb1c5655f77a46b2
-  data.tar.gz: cd664416336d28c0b905d494ccd9aa8984127704
+  metadata.gz: a93c4e7d7614401ed2be2cce1d75216064cb8a05
+  data.tar.gz: 6d4483d22db5f03fdbf05d93e1f9d8aee233b45c
 SHA512:
-  metadata.gz: d0eec92f910807f073bae3da16ed4bfd2dfead76405bd19224a81cb7f0745ecac4d097ce7bac4e3f5aebea37f1cd41049cefdc46a23f33afdc5e13a4d4dfd1f2
-  data.tar.gz: c1e86d2ed0a3a67bddc5a3fecdfefe01d193c573eb12a0ea330be13fb6d4825d9cf463d2e127416ac6d2697264b14deb9862f72372b32ee3be80c267d17ea04d
+  metadata.gz: 5ee2a42fb6a4f7bc3c03ed3f2c8be735a82a280adbe1f7f2a3a77a9f1fa0efe4d164de7dfdb82933cbcf8afeed1ebc932040cb27611443feac6a734054e6936d
+  data.tar.gz: bf8f28a614588820653311e0a56c0ad51a53acfc6f87001798e0f8497b6482bb89248f196e43ceacd5be3326c0fa8c3f24066212271f8ad480bea20ffc667f92

data/lib/parliament/utils/config/initializers/airbrake.rb

@@ -62,9 +62,7 @@ if defined?(Airbrake) && ENV['AIRBRAKE_PROJECT_ID'].present? && ENV['AIRBRAKE_PR
   # Airbrake. This can be based on type, message, file, region or any other part
   # of the error's JSON
   Airbrake.add_filter do |notice|
-    if notice[:errors].any? { |error| error[:type] == 'ActionController::RoutingError' }
-      notice.ignore!
-    end
+    notice.ignore! if notice[:errors].any? { |error| error[:type] == 'ActionController::RoutingError' }
   end
 
   # If you want to convert your log messages to Airbrake errors, we offer an

data/lib/parliament/utils/helpers/application_helper.rb

@@ -7,47 +7,47 @@ module Parliament
         # Note: All of the below are used to generate MIME types that our application will answer to, but NOT the
         # alternatives shown in our header. See ALTERNATIVE_MIME_TYPE_CONFIG.
         API_MIME_TYPE_CONFIG = [
-            {
-                nt: 'application/n-triples'
-            },
-            {
-                ttl: 'text/turtle'
-            },
-            {
-                tsv: 'text/tab-separated-values'
-            },
-            {
-                csv: 'text/csv'
-            },
-            {
-                rj: 'application/json+rdf'
-            },
-            {
-                jsonld: 'application/json+ld',
-                json:   'application/json'
-            },
-            {
-                rdfxml: 'application/rdf+xml',
-                rdf:    'application/xml',
-                xml:    'text/xml'
-            }
+          {
+            nt: 'application/n-triples'
+          },
+          {
+            ttl: 'text/turtle'
+          },
+          {
+            tsv: 'text/tab-separated-values'
+          },
+          {
+            csv: 'text/csv'
+          },
+          {
+            rj: 'application/json+rdf'
+          },
+          {
+            jsonld: 'application/json+ld',
+            json:   'application/json'
+          },
+          {
+            rdfxml: 'application/rdf+xml',
+            rdf:    'application/xml',
+            xml:    'text/xml'
+          }
         ].freeze
 
         # Use the above, minus the last two entries (json & xml), to build an alternative URL list.
         # Then re-create JSON and XML with the correct alternatives
-        ALTERNATIVE_MIME_TYPE_CONFIG = API_MIME_TYPE_CONFIG.take(API_MIME_TYPE_CONFIG.size-2).concat(
-            [
-                {
-                    json: 'application/json+ld'
-                },
-                {
-                    xml: 'application/rdf+xml'
-                }
-            ]
+        ALTERNATIVE_MIME_TYPE_CONFIG = API_MIME_TYPE_CONFIG.take(API_MIME_TYPE_CONFIG.size - 2).concat(
+          [
+            {
+              json: 'application/json+ld'
+            },
+            {
+              xml: 'application/rdf+xml'
+            }
+          ]
         )
 
-        API_MIME_TYPES                   = Parliament::Utils::Helpers::ApplicationHelper::API_MIME_TYPE_CONFIG.map { |mime_type| mime_type.values }.flatten.freeze
-        API_FILE_EXTENSIONS              = Parliament::Utils::Helpers::ApplicationHelper::API_MIME_TYPE_CONFIG.map { |mime_type| mime_type.keys   }.flatten.freeze
+        API_MIME_TYPES                   = Parliament::Utils::Helpers::ApplicationHelper::API_MIME_TYPE_CONFIG.map(&:values).flatten.freeze
+        API_FILE_EXTENSIONS              = Parliament::Utils::Helpers::ApplicationHelper::API_MIME_TYPE_CONFIG.map(&:keys).flatten.freeze
         ALTERNATIVE_MIME_TYPES_FLATTENED = Parliament::Utils::Helpers::ApplicationHelper::ALTERNATIVE_MIME_TYPE_CONFIG.reduce(:merge)
 
         # Sets the title for a page.
@@ -58,6 +58,7 @@ module Parliament
           content_for(:title) { page_title }
           page_title
         end
+
         # Before every request that provides data, see if the user is requesting a format that can be served by the data API.
         # If they are, transparently redirect them with a '302: Found' status code
         def data_check
@@ -81,7 +82,7 @@ module Parliament
           request_extension = File.extname(URI.parse(request.url).path)
           redirect_url.path = redirect_url.path + request_extension if request_extension != ''
 
-          return redirect_to(redirect_url.to_s)
+          redirect_to(redirect_url.to_s)
         end
 
         # Get the data URL for our current controller and action OR raise a StandardError
@@ -107,7 +108,7 @@ module Parliament
           alternates = []
 
           ALTERNATIVE_MIME_TYPES_FLATTENED.each do |extension, format| # (key, value)
-            uri =  URI.parse(url)
+            uri = URI.parse(url)
             uri.path = "#{uri.path}.#{extension}"
 
             alternates << { type: format, href: uri.to_s }
@@ -127,7 +128,6 @@ module Parliament
         def reset_alternates
           Pugin.alternates = []
         end
-
       end
     end
   end

data/lib/parliament/utils/helpers/filter_helper.rb

@@ -10,7 +10,7 @@ module Parliament
         #
         # @return [Parliament::Response::NTripleResponse] Ntriple response filtered by types
         def self.filter(request, *types)
-          types_to_filter = self.filter_types(*types)
+          types_to_filter = filter_types(*types)
           Parliament::Utils::Helpers::RequestHelper.filter_response_data(
             request, *types_to_filter
           )
@@ -46,10 +46,10 @@ module Parliament
         #
         # @return [Parliament::Response::NTripleResponse] Ntriple response filtered by letters
         def self.filter_sort(request, sort_type, type, letters)
-          type, letters = self.filter(request, type, letters)
+          type, letters = filter(request, type, letters)
           type = type.sort_by(sort_type)
           letters = letters.map(&:value)
-          return type, letters
+          [type, letters]
         end
       end
     end

data/lib/parliament/utils/helpers/houses_helper.rb

@@ -2,77 +2,79 @@ module Parliament
   module Utils
     module Helpers
       module HousesHelper
-        # Checks if house is the House of Commons and sets @commons_id and @lords_id if not already set.
-        #
-        # @param [Grom::Node] house a Grom::Node with type https://id.parliament.uk/schema/House.
-        # @return [Boolean] boolean depending on whether the house has the same id as the House of Commons.
-        def self.commons?(house)
-          set_ids
-
-          house.graph_id == @commons_id
-        end
-
-        # Checks if house is the House of Lords and sets @commons_id and @lords_id if not already set.
-        #
-        # @param [Grom::Node] house a Grom::Node with type https://id.parliament.uk/schema/House.
-        # @return [Boolean] boolean depending on whether the house has the same id as the House of Lords.
-        def self.lords?(house)
-          !commons?(house)
-        end
-
-        # Sets and returns the id for the House of Commons.
-        #
-        # @return [String] @commons_id the id for the House of Commons.
-        def self.commons_id
-          set_ids
-
-          @commons_id
-        end
-
-        # Sets and returns the id for the House of Lords.
-        #
-        # @return [String] @lords_id the id for the House of Lords.
-        def self.lords_id
-          set_ids
-
-          @lords_id
-        end
-
-        # Returns the current house id for the page alongside the other house id.
-        #
-        # @param [Grom::Node] house The house that a particular person is linked to.
-        # @return [Array<String, String>] The current house id and other house id.
-        def self.house_id_string(house)
-          is_commons = self.commons?(house)
-
-          house_ids = [commons_id, lords_id]
-          return house_ids if is_commons
-
-          house_ids.reverse
-        end
-
-        # Returns the current
-        #
-        # @param [Grom::Node] house The house that a particular person is linked to.
-        # @return [Array<String, String>] The current person type and other person type.
-        def self.person_type_string(house)
-          is_mp = self.commons?(house)
-
-          types = [I18n.t('mp_plural'), I18n.t('lord_plural')]
-
-          return types if is_mp
-
-          types.reverse
-        end
-
-        private_class_method
-
-        def self.set_ids
-          return if @commons_id && @lords_id
-          houses = Parliament::Utils::Helpers::ParliamentHelper.parliament_request.house_index.get.filter('https://id.parliament.uk/schema/House').sort_by(:name)
-
-          @commons_id = houses.first.graph_id
-          @lords_id = houses.last.graph_id
+        class << self
+          # Checks if house is the House of Commons and sets @commons_id and @lords_id if not already set.
+          #
+          # @param [Grom::Node] house a Grom::Node with type https://id.parliament.uk/schema/House.
+          # @return [Boolean] boolean depending on whether the house has the same id as the House of Commons.
+          def commons?(house)
+            set_ids
+
+            house.graph_id == @commons_id
+          end
+
+          # Checks if house is the House of Lords and sets @commons_id and @lords_id if not already set.
+          #
+          # @param [Grom::Node] house a Grom::Node with type https://id.parliament.uk/schema/House.
+          # @return [Boolean] boolean depending on whether the house has the same id as the House of Lords.
+          def lords?(house)
+            !commons?(house)
+          end
+
+          # Sets and returns the id for the House of Commons.
+          #
+          # @return [String] @commons_id the id for the House of Commons.
+          def commons_id
+            set_ids
+
+            @commons_id
+          end
+
+          # Sets and returns the id for the House of Lords.
+          #
+          # @return [String] @lords_id the id for the House of Lords.
+          def lords_id
+            set_ids
+
+            @lords_id
+          end
+
+          # Returns the current house id for the page alongside the other house id.
+          #
+          # @param [Grom::Node] house The house that a particular person is linked to.
+          # @return [Array<String, String>] The current house id and other house id.
+          def house_id_string(house)
+            is_commons = commons?(house)
+
+            house_ids = [commons_id, lords_id]
+            return house_ids if is_commons
+
+            house_ids.reverse
+          end
+
+          # Returns the current
+          #
+          # @param [Grom::Node] house The house that a particular person is linked to.
+          # @return [Array<String, String>] The current person type and other person type.
+          def person_type_string(house)
+            is_mp = commons?(house)
+
+            types = [I18n.t('mp_plural'), I18n.t('lord_plural')]
+
+            return types if is_mp
+
+            types.reverse
+          end
+
+          private_class_method
+
+          def set_ids
+            return if @commons_id && @lords_id
+            houses = Parliament::Utils::Helpers::ParliamentHelper.parliament_request.house_index.get.filter('https://id.parliament.uk/schema/House').sort_by(:name)
+
+            @commons_id = houses.first.graph_id
+            @lords_id = houses.last.graph_id
+          end
         end
       end
     end

data/lib/parliament/utils/helpers/postcode_helper.rb

@@ -6,7 +6,6 @@ module Parliament
   module Utils
     module Helpers
       module PostcodeHelper
-
         include Parliament::Utils::Helpers::TranslationHelper
 
         attr_accessor :previous_path

data/lib/parliament/utils/helpers/request_helper.rb

@@ -40,7 +40,7 @@ module Parliament
         #
         # @return [String] uri with specific path added for filtering parliamentary data within sparql queries
         def self.namespace_uri_path(path)
-          self.namespace_uri + path
+          namespace_uri + path
         end
 
         # Returns uri with schema path and specific type added for filtering parliamentary data within sparql queries
@@ -49,7 +49,7 @@ module Parliament
         #
         # @return [String] uri with schema path and specific type added for filtering parliamentary data within sparql queries
         def self.namespace_uri_schema_path(type)
-          self.namespace_uri_path("/schema/#{type}")
+          namespace_uri_path("/schema/#{type}")
         end
       end
     end

data/lib/parliament/utils/helpers/translation_helper.rb

@@ -3,7 +3,7 @@ module Parliament
     module Helpers
       module TranslationHelper
         require 'i18n'
-        
+
         I18n.load_path = ['config/locales/en.yml']
         I18n.backend.load_translations
       end

data/lib/parliament/utils/helpers/v_card_helper.rb

@@ -1,3 +1,5 @@
+require 'vcard'
+
 # Namespace for helper methods to generate a vcard.
 module Parliament
   module Utils
@@ -10,13 +12,15 @@ module Parliament
         def create_vcard(contact_point)
           Vcard::Vcard::Maker.make2 do |maker|
             maker.add_name do |name|
-              person_set(contact_point, name)
-              postal_address_set(contact_point, maker)
               contacts_set(contact_point, maker)
+              postal_address_set(contact_point, maker)
+              person_set(contact_point, name)
             end
           end
         end
 
+        private
+
         # Sets the contact details of a vcard.
         #
         # @param [Grom::Node] contact_point a Grom::Node with type: https://id.parliament.uk/schema/ContactPoint.

data/lib/parliament/utils/services/markdown_converter.rb

@@ -13,7 +13,7 @@ module Parliament
         #
         def autolink(link, link_type)
           if link_type == :url
-            return parliament_live_video_embed(link) if link.match(/parliamentlive.tv\/event\/index\/[a-z0-9-]{36}/i)
+            return parliament_live_video_embed(link) if link =~ /parliamentlive.tv\/event\/index\/[a-z0-9-]{36}/i
           end
 
           link # call super instead if we actually want autolinking

data/lib/parliament/utils/services/markdown_scrubber.rb

@@ -5,8 +5,8 @@ module Parliament
         # Overrides default sanitization allowing Parliament tags and/or attributes
         def initialize
           super
-          self.tags = %w(p div h1 h2 h3 h4 h5 h6 span a ol li ul strong em i itag strike del u sup sub blockquote cite table thead tbody tfoot tr th td iframe image pre code dl dt dd hr br)
-          self.attributes = %w(class href src name title allowfullscreen seamless frameborder style)
+          self.tags = %w[p div h1 h2 h3 h4 h5 h6 span a ol li ul strong em i itag strike del u sup sub blockquote cite table thead tbody tfoot tr th td iframe image pre code dl dt dd hr br]
+          self.attributes = %w[class href src name title allowfullscreen seamless frameborder style]
         end
 
         def skip_node?(node)

data/lib/parliament/utils/test_helpers/bandiera_helper.rb

@@ -6,8 +6,8 @@ module Parliament
     module TestHelpers
       module BandieraHelper
         def self.load_rspec_config(config)
-          #Stubs Bandiera::Client methods enabled? and get_features_for_group to clean up logs
-          #and streamline cassettes
+          # Stubs Bandiera::Client methods enabled? and get_features_for_group to clean up logs
+          # and streamline cassettes
           config.before(:each) do
             allow(BANDIERA_CLIENT).to receive(:enabled?).and_return(false)
             allow(Pugin::PuginBandieraClient::BANDIERA_CLIENT).to receive(:get_features_for_group).and_return({})

data/lib/parliament/utils/test_helpers/rails_helper.rb

@@ -4,33 +4,33 @@ module Parliament
       module RailsHelper
         def self.load_rspec_config(config)
           Dir[Rails.root.join('spec/support/**/*.rb')].each { |f| require f }
-#           # RSpec Rails can automatically mix in different behaviours to your tests
-#           # based on their file location, for example enabling you to call `get` and
-#           # `post` in specs under `spec/controllers`.
-#           #
-#           # You can disable this behaviour by removing the line below, and instead
-#           # explicitly tag your specs with their type, e.g.:
-#           #
-#           #     RSpec.describe UsersController, :type => :controller do
-#           #       # ...
-#           #     end
-#           #
-#           # The different available types are documented in the features, such as in
-#           # https://relishapp.com/rspec/rspec-rails/docs
+          #           # RSpec Rails can automatically mix in different behaviours to your tests
+          #           # based on their file location, for example enabling you to call `get` and
+          #           # `post` in specs under `spec/controllers`.
+          #           #
+          #           # You can disable this behaviour by removing the line below, and instead
+          #           # explicitly tag your specs with their type, e.g.:
+          #           #
+          #           #     RSpec.describe UsersController, :type => :controller do
+          #           #       # ...
+          #           #     end
+          #           #
+          #           # The different available types are documented in the features, such as in
+          #           # https://relishapp.com/rspec/rspec-rails/docs
           config.infer_spec_type_from_file_location!
-#
-#           # Filter lines from Rails gems in backtraces.
+          #
+          #           # Filter lines from Rails gems in backtraces.
           config.filter_rails_from_backtrace!
-#           # arbitrary gems may also be filtered via:
-#           # config.filter_gems_from_backtrace("gem name")
+          #           # arbitrary gems may also be filtered via:
+          #           # config.filter_gems_from_backtrace("gem name")
           config.include Parliament::Utils::Helpers::ApplicationHelper
-#
-#           # Set Parliament::Utils::Helpers::HousesHelper#set_ids instance variables to nil after each spec.
-#           # Calling certain Parliament::Utils::Helpers::HousesHelper methods (e.g. Parliament::Utils::Helpers::HousesHelper#commons?) causes
-#           # Parliament::Utils::Helpers::HousesHelper#set_ids to be called which sets @commons_id and @lords_id.
-#           # Setting these to nil causes each spec that requires them to make another
-#           # Parliament::Utils::Helpers::ParliamentHelper request and generate a VCR cassette and stops any RSpec
-#           # ordering issues where they may or may not have been set by the previous spec.
+          #
+          #           # Set Parliament::Utils::Helpers::HousesHelper#set_ids instance variables to nil after each spec.
+          #           # Calling certain Parliament::Utils::Helpers::HousesHelper methods (e.g. Parliament::Utils::Helpers::HousesHelper#commons?) causes
+          #           # Parliament::Utils::Helpers::HousesHelper#set_ids to be called which sets @commons_id and @lords_id.
+          #           # Setting these to nil causes each spec that requires them to make another
+          #           # Parliament::Utils::Helpers::ParliamentHelper request and generate a VCR cassette and stops any RSpec
+          #           # ordering issues where they may or may not have been set by the previous spec.
           config.after(:each) do
             Parliament::Utils::Helpers::HousesHelper.instance_variable_set(:@commons_id, nil)
             Parliament::Utils::Helpers::HousesHelper.instance_variable_set(:@lords_id, nil)

data/lib/parliament/utils/test_helpers/rspec_helper.rb

@@ -2,72 +2,71 @@ module Parliament
   module Utils
     module TestHelpers
       module RSpecHelper
-
         def self.load_rspec_config(config)
           # RSpec.configure do |config|
-            # rspec-expectations config goes here. You can use an alternate
-            # assertion/expectation library such as wrong or the stdlib/minitest
-            # assertions if you prefer.
-            config.expect_with :rspec do |expectations|
-              # This option will default to `true` in RSpec 4. It makes the `description`
-              # and `failure_message` of custom matchers include text for helper methods
-              # defined using `chain`, e.g.:
-              #     be_bigger_than(2).and_smaller_than(4).description
-              #     # => "be bigger than 2 and smaller than 4"
-              # ...rather than:
-              #     # => "be bigger than 2"
-              expectations.include_chain_clauses_in_custom_matcher_descriptions = true
-            end
+          # rspec-expectations config goes here. You can use an alternate
+          # assertion/expectation library such as wrong or the stdlib/minitest
+          # assertions if you prefer.
+          config.expect_with :rspec do |expectations|
+            # This option will default to `true` in RSpec 4. It makes the `description`
+            # and `failure_message` of custom matchers include text for helper methods
+            # defined using `chain`, e.g.:
+            #     be_bigger_than(2).and_smaller_than(4).description
+            #     # => "be bigger than 2 and smaller than 4"
+            # ...rather than:
+            #     # => "be bigger than 2"
+            expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+          end
 
-            # rspec-mocks config goes here. You can use an alternate test double
-            # library (such as bogus or mocha) by changing the `mock_with` option here.
-            config.mock_with :rspec do |mocks|
-              # Prevents you from mocking or stubbing a method that does not exist on
-              # a real object. This is generally recommended, and will default to
-              # `true` in RSpec 4.
-              mocks.verify_partial_doubles = true
-            end
+          # rspec-mocks config goes here. You can use an alternate test double
+          # library (such as bogus or mocha) by changing the `mock_with` option here.
+          config.mock_with :rspec do |mocks|
+            # Prevents you from mocking or stubbing a method that does not exist on
+            # a real object. This is generally recommended, and will default to
+            # `true` in RSpec 4.
+            mocks.verify_partial_doubles = true
+          end
 
-            # These two settings work together to allow you to limit a spec run
-            # to individual examples or groups you care about by tagging them with
-            # `:focus` metadata. When nothing is tagged with `:focus`, all examples
-            # get run.
-            config.filter_run :focus
-            config.run_all_when_everything_filtered = true
+          # These two settings work together to allow you to limit a spec run
+          # to individual examples or groups you care about by tagging them with
+          # `:focus` metadata. When nothing is tagged with `:focus`, all examples
+          # get run.
+          config.filter_run :focus
+          config.run_all_when_everything_filtered = true
 
-            # Disable RSpec exposing methods globally on `Module` and `main`
-            config.disable_monkey_patching!
+          # Disable RSpec exposing methods globally on `Module` and `main`
+          config.disable_monkey_patching!
 
-            # Many RSpec users commonly either run the entire suite or an individual
-            # file, and it's useful to allow more verbose output when running an
-            # individual spec file.
-            if config.files_to_run.one?
-              # Use the documentation formatter for detailed output,
-              # unless a formatter has already been configured
-              # (e.g. via a command-line flag).
-              config.default_formatter = 'doc'
-            end
+          # Many RSpec users commonly either run the entire suite or an individual
+          # file, and it's useful to allow more verbose output when running an
+          # individual spec file.
+          if config.files_to_run.one?
+            # Use the documentation formatter for detailed output,
+            # unless a formatter has already been configured
+            # (e.g. via a command-line flag).
+            config.default_formatter = 'doc'
+          end
 
-            # Print the 10 slowest examples and example groups at the
-            # end of the spec run, to help surface which specs are running
-            # particularly slow.
-            config.profile_examples = 10
+          # Print the 10 slowest examples and example groups at the
+          # end of the spec run, to help surface which specs are running
+          # particularly slow.
+          config.profile_examples = 10
 
-            config.expect_with :rspec do |c|
-              c.syntax = :expect
-            end
+          config.expect_with :rspec do |c|
+            c.syntax = :expect
+          end
 
-            # Run specs in random order to surface order dependencies. If you find an
-            # order dependency and want to debug it, you can fix the order by providing
-            # the seed, which is printed after each run.
-            #     --seed 1234
-            config.order = :random
+          # Run specs in random order to surface order dependencies. If you find an
+          # order dependency and want to debug it, you can fix the order by providing
+          # the seed, which is printed after each run.
+          #     --seed 1234
+          config.order = :random
 
-            # Seed global randomization in this process using the `--seed` CLI option.
-            # Setting this allows you to use `--seed` to deterministically reproduce
-            # test failures related to randomization by passing the same `--seed` value
-            # as the one that triggered the failure.
-            Kernel.srand config.seed
+          # Seed global randomization in this process using the `--seed` CLI option.
+          # Setting this allows you to use `--seed` to deterministically reproduce
+          # test failures related to randomization by passing the same `--seed` value
+          # as the one that triggered the failure.
+          Kernel.srand config.seed
           # end
         end
       end

data/lib/parliament/utils/test_helpers/simplecov_helper.rb

@@ -5,13 +5,17 @@ module Parliament
         require 'coveralls'
         require 'simplecov'
 
-        def self.load_rspec_config(config)
+        def self.load_rspec_config(_config)
           SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new([
-            Coveralls::SimpleCov::Formatter,
-            SimpleCov::Formatter::HTMLFormatter
-          ])
+                                                                           Coveralls::SimpleCov::Formatter,
+                                                                           SimpleCov::Formatter::HTMLFormatter
+                                                                         ])
+
           profile = defined?(Rails) ? 'rails' : nil
-          SimpleCov.start profile
+
+          SimpleCov.start profile do
+            add_filter 'spec'
+          end
         end
       end
     end

data/lib/parliament/utils/test_helpers/vcr_helper.rb

@@ -41,7 +41,7 @@ module Parliament
               parliament_match || bandiera_match || opensearch_match || hybrid_bills_match
             end
 
-            config.default_cassette_options = { match_requests_on: [:method, :filtered_uri] }
+            config.default_cassette_options = { match_requests_on: %i[method filtered_uri] }
 
             # Dynamically filter our sensitive information
             config.filter_sensitive_data('<AUTH_TOKEN>')   { ENV['PARLIAMENT_AUTH_TOKEN'] }       if ENV['PARLIAMENT_AUTH_TOKEN']
@@ -55,7 +55,7 @@ module Parliament
               should_ignore = ['_:node', '^^<http://www.w3.org/2001/XMLSchema#date>', '^^<http://www.w3.org/2001/XMLSchema#dateTime>', '^^<http://www.w3.org/2001/XMLSchema#integer>']
 
               # Check if content type header exists and if it includes application/n-triples
-              if interaction.response.headers['Content-Type'] && interaction.response.headers['Content-Type'].include?('application/n-triples')
+              if interaction.response.headers['Content-Type']&.include?('application/n-triples')
                 # Split our data by line
                 lines = interaction.response.body.split("\n")
 

data/lib/parliament/utils/test_helpers/webmock_helper.rb

@@ -2,7 +2,7 @@ module Parliament
   module Utils
     module TestHelpers
       module WebmockHelper
-        def self.load_rspec_config(config)
+        def self.load_rspec_config(_config)
           require 'webmock/rspec'
 
           WebMock.disable_net_connect!(allow_localhost: true)

data/lib/parliament/utils/version.rb

@@ -1,5 +1,5 @@
 module Parliament
   module Utils
-    VERSION = '0.8.4'.freeze
+    VERSION = '0.8.5'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: parliament-utils
 version: !ruby/object:Gem::Version
-  version: 0.8.4
+  version: 0.8.5
 platform: ruby
 authors:
 - Rebecca Appleyard
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-05-21 00:00:00.000000000 Z
+date: 2018-05-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parliament-ruby
@@ -297,7 +297,6 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".DS_Store"
 - ".gitignore"
 - ".hound.yml"
 - ".rspec"