parliament-grom-decorators 0.27.1 → 0.27.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2c866a69215ac0adf7a90e112020a6172133b5ba
-  data.tar.gz: 15fd269735a2616a26b5fb105d8ab7ea5493137b
+  metadata.gz: ccb208c684538211ff8a3fd376d2f3fae63025b1
+  data.tar.gz: f48dcbeb64ad5db77128bac885bd439adaa3095e
 SHA512:
-  metadata.gz: a7a09452f95927c69bfced55d6ed1d54fd03dc9f34725aaeb663514f62a6687dfb53bfe82572259f27ea7f81e3c3b1f0dec33d2e1c393b968d263168cef9b54d
-  data.tar.gz: 6383d980a79169160f2f7f50b213776fbf30e77f1eb24b9a4784537ab4651405272ac8abca7e630934c199b6f975c8058e56024aa603b721273baa26d0b8175d
+  metadata.gz: 891c02afa789745d5d9f73bce6eb6eae5be5a82c73f57196beffe1be89eee527078051beb2a59f84e111542005595c3ca050e0ae41f91cf6a4ad1eb54b3d9c40
+  data.tar.gz: 523446ec6616cde844ef0d9e3eb659d150b791ca9a66e470828c5d91d8fc9a694d8c294afef113b5b84160b90a78e3c6e629e97d30d18c1260887388ce04ef29

data/lib/parliament/grom/decorator/business_item.rb

@@ -18,6 +18,13 @@ module Parliament
           procedure_steps.sort_by(&:distance_from_origin)
         end
 
+        # Finds, for each of the procedure steps belonging to a business item, the shortest distance from origin
+        #
+        # @return [Integer, nil] shortest distance of procedure steps from origin or nil.
+        def shortest_distance_of_procedure_steps
+          sorted_procedure_steps_by_distance.first&.distance_from_origin
+        end
+
         # Alias businessItemDate with fallback.
         #
         # @return [Date, nil] a laying date or nil.
@@ -31,14 +38,6 @@ module Parliament
         def weblink
           respond_to?(:businessItemHasBusinessItemWebLink) ? businessItemHasBusinessItemWebLink : ''
         end
-
-        # Alias layingHasLayingBody with fallback.
-        # NB. One and only one group has to lay, so it will always be the first laying body
-        #
-        # @return [Grom::Node, nil] a Grom::Node representing the group that did the laying.
-        def laying_body
-          respond_to?(:layingHasLayingBody) ? layingHasLayingBody.first : nil
-        end
       end
     end
   end

data/lib/parliament/grom/decorator/version.rb

@@ -1,7 +1,7 @@
 module Parliament
   module Grom
     module Decorator
-      VERSION = '0.27.1'.freeze
+      VERSION = '0.27.2'.freeze
     end
   end
 end

data/lib/parliament/grom/decorator/work_package.rb

@@ -3,6 +3,7 @@ module Parliament
     module Decorator
       # Decorator namespace for Grom::Node instances with type: https://id.parliament.uk/schema/WorkPackage
       module WorkPackage
+        include Helpers::DateHelper
         # Alias workPackageHasProcedure with fallback.
         # NB: Currently, work packages only have one procedure
         #
@@ -19,6 +20,11 @@ module Parliament
           respond_to?(:workPackageHasWorkPackageableThing) ? workPackageHasWorkPackageableThing.first : nil
         end
 
+        # @return [String, nil] the name of the Grom::Node or an empty string.
+        def work_packageable_thing_name
+          work_packageable_thing&.name
+        end
+
         # Alias workPackageHasBusinessItem with fallback.
         #
         # @return [Array, Array] an array of BusinessItem Grom::Nodes or an empty array.
@@ -26,15 +32,11 @@ module Parliament
           respond_to?(:workPackageHasBusinessItem) ? workPackageHasBusinessItem : []
         end
 
-        # @return [Grom::Node, nil] a BusinessItem Grom::Node or nil.
-        def oldest_business_item
-          return unless business_items.any?
-          business_items.sort_by(&:date).last
-        end
-
-        # @return [Date, nil] an array of BusinessItem Grom::Nodes or an empty array.
+        # Alias oldestBusinessItemDate with fallback.
+        #
+        # @return [Date, nil] a date or nil.
         def oldest_business_item_date
-          oldest_business_item&.date
+          respond_to?(:oldestBusinessItemDate) ? DateTime.parse(oldestBusinessItemDate) : nil
         end
       end
     end

data/lib/parliament/grom/decorator/work_packageable_thing.rb

@@ -3,6 +3,7 @@ module Parliament
     module Decorator
       # Decorator namespace for Grom::Node instances with type: https://id.parliament.uk/schema/WorkPackageableThing
       module WorkPackageableThing
+        include Helpers::DateHelper
         # Alias workPackageableThingName with fallback.
         #
         # @return [String, String] the name of the Grom::Node or an empty string.
@@ -25,22 +26,9 @@ module Parliament
           respond_to?(:workPackageableThingHasWorkPackageableThingWebLink) ? workPackageableThingHasWorkPackageableThingWebLink : ''
         end
 
-        # Uses work_package method in this set of decorators, which could return nil.
-        # Uses business_items method in WorkPackage decorators, which could return an empty array.
-        #
-        # @return [Boolean] whether a work packageable thing has both a work package and some business items.
-        def work_package_and_business_items?
-          work_package ? work_package.business_items.any? : false
-        end
-
-        # @return [Grom::Node, nil] a BusinessItem Grom::Node or nil.
-        def oldest_business_item
-          work_package_and_business_items? ? work_package.business_items.sort_by(&:date).last : nil
-        end
-
         # @return [Date, nil] an array of BusinessItem Grom::Nodes or an empty array.
         def oldest_business_item_date
-          oldest_business_item&.date
+          work_package&.oldest_business_item_date
         end
 
         # Alias workPackageableThingComingIntoForceDate with fallback.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: parliament-grom-decorators
 version: !ruby/object:Gem::Version
-  version: 0.27.1
+  version: 0.27.2
 platform: ruby
 authors:
 - Rebecca Appleyard
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-05-24 00:00:00.000000000 Z
+date: 2018-05-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler