parameters 0.1.5 → 0.1.6

data/History.txt

@@ -1,3 +1,10 @@
+=== 0.1.6 / 2009-05-11
+
+* Fixed a bug in Parameters.params= and Parameters#params=, where they
+  were not handling Parameters::ClassParam or Parameters::InstanceParam
+  objects properly.
+* Added more specs.
+
 === 0.1.5 / 2009-05-06
 
 * Added Parameters::Parser for parsing parameter values passed in from

data/Manifest.txt

@@ -17,7 +17,8 @@ lib/parameters/parameters.rb
 lib/parameters/version.rb
 tasks/spec.rb
 spec/spec_helper.rb
-spec/helpers/test_parameters.rb
-spec/helpers/inherited_parameters.rb
+spec/classes/test_parameters.rb
+spec/classes/inherited_parameters.rb
+spec/classes/other_parameters.rb
 spec/parser_spec.rb
 spec/parameters_spec.rb

data/README.txt

@@ -16,6 +16,7 @@ have configurable default values.
     default value.
 * Change default values of parameters.
 * Give descriptions to parameters.
+* Set parameters en-mass.
 
 == EXAMPLES:
 

data/lib/parameters/parameters.rb

@@ -24,6 +24,10 @@ module Parameters
       def params=(values)
         values.each do |name,value|
           if has_param?(name)
+            if (value.kind_of?(Parameters::ClassParam) || value.kind_of?(Parameters::InstanceParam))
+              value = value.value
+            end
+
             get_param(name).value = value
           end
         end
@@ -238,8 +242,14 @@ module Parameters
   #
   def params=(values)
     values.each do |name,value|
+      name = name.to_sym
+
       if has_param?(name)
-        self.params[name.to_sym].value = value
+        if (value.kind_of?(Parameters::ClassParam) || value.kind_of?(Parameters::InstanceParam))
+          value = value.value
+        end
+
+        self.params[name].value = value
       end
     end
   end

data/lib/parameters/version.rb

@@ -1,3 +1,3 @@
 module Parameters
-  VERSION = '0.1.5'
+  VERSION = '0.1.6'
 end

data/spec/{helpers → classes}/inherited_parameters.rb

@@ -1,4 +1,4 @@
-require 'helpers/test_parameters'
+require 'classes/test_parameters'
 
 class InheritedParameters < TestParameters
 

data/spec/classes/other_parameters.rb

@@ -0,0 +1,10 @@
+class OtherParameters
+  include Parameters
+
+  parameter :var, :description => 'Test parameter'
+
+  parameter :var_with_default,
+    :default => 'other',
+    :description => 'This parameter has a default value'
+
+end

data/spec/parameters_spec.rb

@@ -2,8 +2,9 @@ require 'parameters/parameters'
 
 require 'spec_helper'
 
-require 'helpers/test_parameters'
-require 'helpers/inherited_parameters'
+require 'classes/test_parameters'
+require 'classes/inherited_parameters'
+require 'classes/other_parameters'
 
 describe Parameters do
   describe "in a Class" do
@@ -49,7 +50,7 @@ describe Parameters do
   end
 
   describe "in an Object" do
-    before(:all) do
+    before(:each) do
       @test = TestParameters.new
       @test_inherited = InheritedParameters.new
     end
@@ -59,14 +60,6 @@ describe Parameters do
       @test.params[:var_with_default].should_not be_nil
     end
 
-    it "should allow for mass assignment of parameters" do
-      test2 = TestParameters.new
-      test2.params = {:var => 5, :var_with_default => 'hello'}
-
-      test2.var.should == 5
-      test2.var_with_default.should == 'hello'
-    end
-
     it "can have default values for parameters" do
       @test.param_value(:var_with_default).should == 'thing'
     end
@@ -84,10 +77,9 @@ describe Parameters do
     end
 
     it "should allow using lambdas for the default values of parameters" do
-      test1 = TestParameters.new
       test2 = TestParameters.new
 
-      test1.var_with_lambda.should_not == test2.var_with_lambda
+      @test.var_with_lambda.should_not == test2.var_with_lambda
     end
 
     it "should contain the parameters from all ancestors" do
@@ -113,6 +105,21 @@ describe Parameters do
       @test.param_value(:var_with_default).should == 7
     end
 
+    it "should allow for setting parameters en-mass from another object" do
+      obj = TestParameters.new(:var => 5, :var_with_default => 'hello')
+      @test.params = obj.params
+
+      @test.var.should == 5
+      @test.var_with_default.should == 'hello'
+    end
+
+    it "should allow for setting parameters en-mass from another class" do
+      @test.params = OtherParameters.params
+
+      @test.var.should be_nil
+      @test.var_with_default.should == 'other'
+    end
+
     it "should provide descriptions for parameters" do
       @test.describe_param(:var).should_not be_empty
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: parameters
 version: !ruby/object:Gem::Version 
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors: 
 - Postmodern
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-05-06 00:00:00 -07:00
+date: 2009-05-11 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -53,8 +53,9 @@ files:
 - lib/parameters/version.rb
 - tasks/spec.rb
 - spec/spec_helper.rb
-- spec/helpers/test_parameters.rb
-- spec/helpers/inherited_parameters.rb
+- spec/classes/test_parameters.rb
+- spec/classes/inherited_parameters.rb
+- spec/classes/other_parameters.rb
 - spec/parser_spec.rb
 - spec/parameters_spec.rb
 has_rdoc: true