paraduct 0.0.1.beta13 → 0.0.1.beta14

data/lib/paraduct/colored_label_logger.rb

@@ -7,7 +7,8 @@ module Paraduct
       @formatter = ActiveSupport::Logger::SimpleFormatter.new
     end
 
-    [:debug, :info, :warn, :error, :fatal].each do |severity|
+    SEVERITIES = [:debug, :info, :warn, :error, :fatal]
+    SEVERITIES.each do |severity|
       define_method "#{severity}_with_label" do |message|
         message.each_line do |line|
           send "#{severity}_without_label", "#{@label} #{line.strip}" unless line.blank?

data/lib/paraduct/errors.rb

@@ -1,6 +1,7 @@
 module Paraduct
   module Errors
     class TestFailureError < StandardError; end
+    class DirtyExitError < StandardError; end
 
     class ProcessError < StandardError
       attr_reader :status

data/lib/paraduct/parallel_runner.rb

@@ -32,6 +32,7 @@ START matrix test
               stdout = runner.perform
               successful = true
             rescue Paraduct::Errors::ProcessError => e
+              runner.logger.error "exitstatus=#{e.status}, #{e.inspect}"
               stdout = e.message
               successful = false
             end
@@ -51,6 +52,8 @@ START matrix test
         pool.shutdown
       end
 
+      raise Paraduct::Errors::DirtyExitError unless test_response.jobs_count == product_variables.count
+
       test_response
     end
   end

data/lib/paraduct/runner.rb

@@ -1,6 +1,5 @@
 module Paraduct
-  require "colorize"
-  require "open3"
+  require "pty"
 
   class Runner
     attr_reader :script, :params, :base_job_dir
@@ -69,20 +68,24 @@ module Paraduct
     end
 
     private
-    def run_command(command)
-      lines = ""
 
-      IO.popen(command) do |io|
-        while line = io.gets
-          logger.info(line)
-          lines << line
+    def run_command(command)
+      full_stdout = ""
+
+      PTY.spawn(command) do |stdin, _stdout, pid|
+        begin
+          stdin.each do |line|
+            line.strip!
+            logger.info line
+            full_stdout << "#{line}\n"
+          end
+        rescue Errno::EIO
         end
+        exit_status = PTY.check(pid)
+        raise Paraduct::Errors::ProcessError.new(full_stdout, exit_status) unless exit_status.success?
       end
 
-      status = $?
-      raise Paraduct::Errors::ProcessError.new(lines, status) unless status.success?
-
-      lines
+      full_stdout
     end
   end
 end

data/lib/paraduct/test_response.rb

@@ -6,7 +6,7 @@ module Paraduct
       @jobs = []
     end
 
-    delegate :push, to: :jobs, prefix: true
+    delegate :push, :count, to: :jobs, prefix: true
 
     def successful?
       @jobs.all?{ |result| result[:successful] }

data/lib/paraduct/version.rb

@@ -1,3 +1,3 @@
 module Paraduct
-  VERSION = "0.0.1.beta13"
+  VERSION = "0.0.1.beta14"
 end

data/lib/paraduct.rb

@@ -3,6 +3,7 @@ require "active_support/deprecation"
 require "active_support/core_ext"
 require "pathname"
 require 'paraduct/version'
+require "colorize"
 
 module Paraduct
   autoload :ColoredLabelLogger, 'paraduct/colored_label_logger'

data/spec/spec_helper.rb

@@ -20,6 +20,8 @@ require 'rspec/temp_dir'
 require 'rspec/its'
 require 'pry'
 
+is_verbose = ENV["VERBOSE"].present?
+
 def spec_dir
   Pathname(File.dirname(__FILE__))
 end
@@ -118,7 +120,12 @@ RSpec.configure do |config|
   config.order = :random
 
   config.before do
-    # quiet
-    allow(Paraduct.logger).to receive(:info)
+    unless is_verbose
+      # quiet all logs
+      Paraduct::ColoredLabelLogger::SEVERITIES.each do |severity|
+        allow(Paraduct.logger).to receive(severity)
+        allow_any_instance_of(Paraduct::ColoredLabelLogger).to receive(severity)
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: paraduct
 version: !ruby/object:Gem::Version
-  version: 0.0.1.beta13
+  version: 0.0.1.beta14
   prerelease: 6
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-24 00:00:00.000000000 Z
+date: 2014-10-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -369,7 +369,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2366476400975561829
+      hash: -1455455327285807628
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: