para 0.12.8 → 0.12.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9cf58d90a0544acd64a6696d42e4fdd16a2f0aaa1af05c258fb913b6dcdba241
-  data.tar.gz: 342113700bb23860d3db7be577c56e9f757b1293201c3175b936d11eb252b160
+  metadata.gz: ebd0ada08791d045fb7437af457ce37ea4d61ffe47d6e809786ebf6ef6c6dff6
+  data.tar.gz: ee5e91c50160e3ce4d838f0c530a3917dedff1339cc16d38b64adef87f108eb1
 SHA512:
-  metadata.gz: 3d0b84d8a9e1c6bda68897498474b57d02a4f05a22137a790c302c4e4cc3a25678f9ca964d74f86bb3f729af9e723b18382b8dcecac63b58fa365d7b20654c07
-  data.tar.gz: '08f583188635a61ef257e5cfd701d39c5a3a61e773d5697da2e827498c92d05b2501db8aff8706b56c7faa1537d1573584b595b27e68ab4fe4221201d052d9eb'
+  metadata.gz: 30e5d1f8554038eebcc28d3deba64e4ec7677106b760f2e79692b8e01752c5ecbbe9008283ba79335a3229a1415c84dbe4bcc81144272be8d6fc007090e721f8
+  data.tar.gz: 2d21b1015f554e2b4c534c871996b334b1bbecf97b074bf4ece24313b77df97533236b56bcc2204509753a7612b0870858a28d519a4df62cd73f59459eca7496

data/lib/para/components_configuration.rb

@@ -3,6 +3,25 @@ module Para
     class UndefinedComponentTypeError < StandardError; end
     class ComponentTooDeepError < StandardError; end
 
+    # Errors that signal the cached component state went stale, usually after a
+    # schema migration, a database reset or when a component class was unloaded
+    # by the code reloader. When one of these is raised while resolving a
+    # component, we reset the caches (and optionally reload the tree) and retry
+    # instead of letting it bubble up and break rails commands or the server.
+    #
+    RELOADABLE_ERRORS = [
+      ActiveRecord::RecordNotFound,
+      ActiveRecord::StatementInvalid,
+      ActiveRecord::SubclassNotFound,
+      ActiveModel::MissingAttributeError,
+      NameError
+    ].freeze
+
+    # Path to the app's `config/components.rb`, set by the engine. Used to
+    # rebuild the components tree when auto-reloading after a stale lookup.
+    #
+    attr_accessor :components_config_path
+
     def draw(&block)
       return unless components_installed?
 
@@ -10,6 +29,11 @@ module Para
         log_level = Rails.logger.level
         Rails.logger.level = :fatal
 
+        # Reset any previously drawn definitions so re-drawing (e.g. on reload)
+        # rebuilds a clean tree instead of appending duplicates.
+        @sections = []
+        reset!
+
         eager_load_components!
         instance_eval(&block)
         build
@@ -25,13 +49,45 @@ module Para
     end
 
     def method_missing(method, *args, &block)
-      if (component = component_for(method))
+      if (component = resolve_component(method))
         component.tap(&ActiveDecorator::Decorator.instance.method(:decorate))
       else
         super
       end
     end
 
+    def respond_to_missing?(method, include_private = false)
+      # Answer respond_to? from the current state only: never trigger a reload
+      # just to probe whether a component exists.
+      !resolve_component(method, reload: false).nil? || super
+    end
+
+    # Clears the memoized identifier -> database id maps and the per-request
+    # resolved instance caches, so the next lookup rebuilds against fresh data.
+    # Keeps the in-memory section/component definitions (pure Ruby, schema
+    # independent) untouched.
+    #
+    def reset!
+      @sections_ids_hash = nil
+      @components_ids_hash = nil
+      RequestStore.store[:components_cache] = nil
+      RequestStore.store[:sections_cache] = nil
+    end
+
+    # Re-runs the app's `config/components.rb` to rebuild the whole components
+    # tree from scratch. Returns true on success, false if the file is missing
+    # or the reload itself fails (e.g. schema still mid-migration).
+    #
+    def reload!
+      path = components_config_path
+      return false unless path && File.exist?(path.to_s)
+
+      load(path.to_s)
+      true
+    rescue *RELOADABLE_ERRORS
+      false
+    end
+
     def section_for(identifier)
       if (section = sections_cache[identifier])
         section
@@ -44,6 +100,34 @@ module Para
       end
     end
 
+    # Resolves a component by identifier while healing stale caches. It covers
+    # both failure modes seen after a schema migration or a code reload:
+    #
+    #   * `component_for` raises a RELOADABLE_ERROR (stale id, missing column,
+    #     unloaded STI subclass) ;
+    #   * `component_for` returns nil because the ids hash is empty/stale, which
+    #     would otherwise surface as `undefined method 'xxx'` from method_missing.
+    #
+    # On the first failure it resets the caches and -- in auto-reload mode --
+    # rebuilds the tree from config/components.rb, then retries once. If the
+    # component still can't be found it returns nil, letting method_missing
+    # raise the usual NoMethodError for genuinely unknown components.
+    #
+    def resolve_component(identifier, reload: true, retried: false)
+      component = component_for(identifier)
+      return component if component
+      return nil if retried || !reload
+
+      heal_components_cache!
+      resolve_component(identifier, reload: reload, retried: true)
+    rescue *RELOADABLE_ERRORS => error
+      return nil if retried || !reload
+
+      log_components_failure(error)
+      heal_components_cache!
+      resolve_component(identifier, reload: reload, retried: true)
+    end
+
     def component_for(identifier)
       if (component = components_cache[identifier])
         component
@@ -83,6 +167,21 @@ module Para
 
     private
 
+    # Drops the stale caches and, when auto-reload is enabled, rebuilds the
+    # whole components tree before the lookup is retried.
+    #
+    def heal_components_cache!
+      reset!
+      reload! if Para.config.components_auto_reload
+    end
+
+    def log_components_failure(error)
+      Rails.logger.warn(
+        "Para components lookup failed (#{error.class}: #{error.message}).\n" \
+        'Resetting the components cache and retrying.'
+      )
+    end
+
     def build
       sections.each_with_index do |section, index|
         section.refresh(position: index)

data/lib/para/config.rb

@@ -25,6 +25,15 @@ module Para
     mattr_accessor :components_directory
     @@para_components_directory = 'components'
 
+    # When a `Para.components.xxx` lookup hits a stale cache (after a schema
+    # migration, a database reset or a code reload), Para resets its caches and
+    # -- with auto-reload enabled -- re-runs `config/components.rb` to rebuild
+    # the whole tree before retrying, so the lookup recovers transparently
+    # instead of raising. Enabled by default; set to false to opt out.
+    #
+    mattr_accessor :components_auto_reload
+    @@components_auto_reload = true
+
     mattr_reader :plugins
     @@plugins = Para::Plugins::Set.new
 

data/lib/para/engine.rb

@@ -63,6 +63,10 @@ module Para
     initializer 'Build components tree' do |app|
       components_config_path = Rails.root.join('config', 'components.rb')
 
+      # Remember the path so the components configuration can rebuild the tree
+      # by itself when auto-reloading after a stale lookup.
+      Para::Component.config.components_config_path = components_config_path
+
       app.config.to_prepare do
         require components_config_path if File.exist?(components_config_path)
       end

data/lib/para/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Para
-  VERSION = '0.12.8'
+  VERSION = '0.12.9'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: para
 version: !ruby/object:Gem::Version
-  version: 0.12.8
+  version: 0.12.9
 platform: ruby
 authors:
 - Valentin Ballestrino
@@ -790,7 +790,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 4.0.12
 specification_version: 4
 summary: Rails admin engine
 test_files: []