para 0.12.6 → 0.12.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 54ef941e16858159844a9edfc2d38bf45205c54b0de05a9138db4db9b55f9cd9
-  data.tar.gz: a3119a93739b8f5590984e0e78279258d580be453a39e880446ec9026c5f4783
+  metadata.gz: 5339b2dc5c28403fd3e4ba08fbb1bfc7b2b2196269f9927d25eb1d428eb99d71
+  data.tar.gz: 6266de04143dbd8e18aa9826e8a007d2d96909d4d4f6d9704791e30893f0cffe
 SHA512:
-  metadata.gz: a81dade0932df9173846f0d9ea7750def8140f1f2b62c88b0d5098d67cb59b05bf26053d0cc1902bcaca9743eba7b278ce472d923406e620ae3679302035302e
-  data.tar.gz: 657bef4b4cf573e663459e548bc1b198d621e517a4178f6acf3aea3520ecba5ea19b5f871561657ca704d7cb3b63cedefb228b82e280b3e422db68b0d549ea71
+  metadata.gz: aa7cfd1587567f56a06853bfc0acf74736d4082d79a59f51af90de4fc4afc4fc840085e1e4580aa8372eee4e6e2299584f262ba7d064ee47fffc4abf71ed6fd9
+  data.tar.gz: 5ad58a35c8f690c2ce70063f12cc04ebf0f2e1b812ea22c8f2918193f16e3b7f98a4758b0a780affbb3e7e72a4f319906dae122c650bd3c183aba84ac2a4db14

data/lib/para/cloneable/include_tree_builder.rb

@@ -97,10 +97,7 @@ module Para
           # This is not the most optimized solution, but works well enough as if the
           # author's posts match previously cloned posts, they won't be cloned as they'll
           # exist in the cloned resources dictionary.
-          next if path.length >= 4 &&
-                  path[-4] == path[-2] &&
-                  path[-2] == reflection_name &&
-                  path[-3] == path[-1]
+          next if circular_reference?(path, reflection_name)
 
           hash[reflection_name] = {}
 
@@ -140,6 +137,8 @@ module Para
         options = nested_resource.class.try(:cloneable_options)
         return reflection_options unless options
 
+        puts "Building cloneable options for #{nested_resource.class.name} at path #{path.join(' -> ')}"
+
         target_options = build_cloneable_options_tree(nested_resource, path)
         reflection_options.deep_merge!(target_options)
       end
@@ -191,6 +190,43 @@ module Para
 
         deep_relations.empty? ? shallow_relations : shallow_relations + [deep_relations]
       end
+
+      # Checks if adding reflection_name to the path would create a circular reference
+      # of 2 levels deep with a cycle length between 2 and 10.
+      #
+      # Examples of detected patterns:
+      #
+      #   Length 2: [:a, :b, :a, :b]
+      #   Length 3: [:a, :b, :c, :a, :b, :c]
+      #   Length 4: [:a, :b, :c, :d, :a, :b, :c, :d]
+      #
+      def circular_reference?(path, reflection_name)
+        # Check for cycle lengths from 2 to 10
+        (2..10).each do |cycle_length|
+          # We need at least 2 * cycle_length elements in the path to detect a cycle
+          required_length = cycle_length * 2
+          next if path.length < required_length
+
+          # Check if the pattern repeats exactly twice
+          # The new reflection_name would be at position -cycle_length
+          match = true
+
+          # First, check if the element at -cycle_length position matches reflection_name
+          next unless path[-cycle_length] == reflection_name
+
+          # Then check if all other elements in the first cycle match the second cycle
+          (1...cycle_length).each do |offset|
+            if path[-(cycle_length + offset)] != path[-offset]
+              match = false
+              break
+            end
+          end
+
+          return true if match
+        end
+
+        false
+      end
     end
   end
 end

data/lib/para/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Para
-  VERSION = '0.12.6'
+  VERSION = '0.12.7'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: para
 version: !ruby/object:Gem::Version
-  version: 0.12.6
+  version: 0.12.7
 platform: ruby
 authors:
 - Valentin Ballestrino
@@ -790,7 +790,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.7
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Rails admin engine
 test_files: []