paperweight 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f08760e0f79a70c76350131c65de6fcca3ed7a3366eeb3893d1f64b817ede4ee
-  data.tar.gz: 42df1435f059aab276345f12fac1c35fdce71b9bf237bd73163fa4ef3d87c5df
+  metadata.gz: 1ccf0600d57412d8ff22d523c1a5b935e2c770bc78f95de0ec310891864ac791
+  data.tar.gz: 061342fbdaf7d07e4623a9daa999f973395ca28f4ecc80a2aef1c262db7acd67
 SHA512:
-  metadata.gz: 54348c7ce20c685556a8ad1aad6e8c62abee2916091f5120cdfa4c266c5a3790ecd0a0234ec3e18a7218fb2c402aaef20b0b4484d3363dbee7ae12acdf1aec76
-  data.tar.gz: 1176e2de7cab6b5d0f8eea6e76fbfad435cc2d06fcacb633286db19c56e3937cfbf0dcdde2d19b5ab43dadbd447c461d009a3cad0e8be13796a05917d0a48692
+  metadata.gz: 3d471be00f0029ccfa2a7138d7ba353e56d117afc4926acae8510287793bd9335fb0d503d250cbbf89f25f59bb5fc71a90dd3c34480f0017999450cf6089d262
+  data.tar.gz: be97b3029bb54200f8e815645c55b71452c95137d2c47f6b9ce0dcef50e3be9ac17e6b0a0b560cbc4618451f3f8843bfa2acca990017b19ade0853020a76b47e

data/CHANGELOG.md

@@ -6,6 +6,11 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) a
 
 ## [Unreleased]
 
+## [1.0.1] - 2018-08-15
+### Changed
+- Fixed `paperweight` to not break `paperclip` functionality when a record does not contain the `#*_processing` column.
+- Simplified the post processing job to not require sending the URL manually, instead we can just use the record itself. This guaruntees that if the URL changes between the time the job is enqueued and the time the job is completed we don't end up with race conditions.
+
 ## [1.0.0] - 2018-08-15
 ### Changed
 - Changed the expected column type of `#*_processing` from a boolean to string. This allows us to use it to store the URL from the `#*_url=` method so that it can be used in the meantime before the job finishes processing.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    paperweight (1.0.0)
+    paperweight (1.0.1)
       paperclip (>= 5)
       rails (>= 5)
 

data/lib/paperweight/hooks.rb

@@ -18,6 +18,10 @@ module Paperweight
           :"#{name}_processing"
         end
 
+        def updated_at
+          :"#{name}_updated_at"
+        end
+
         def url
           :"#{name}_url"
         end
@@ -47,14 +51,16 @@ module Paperweight
         define_method(name.url_eq) do |value|
           instance_variable_set(name.url_attr, value)
           self[name.processing] = value
-          self.updated_at = Time.now if value
+
+          return unless value
+          self[name.updated_at] = Time.now
+          self.updated_at = Time.now
         end
       end
 
       def define_paperweight_after_commit_for(name)
         after_commit if: name.url do
-          attachment_url = public_send(name.url)
-          PostProcessJob.perform_later(self, name.name.to_s, attachment_url)
+          PostProcessJob.perform_later(self, name.name.to_s)
         end
       end
     end
@@ -63,7 +69,14 @@ module Paperweight
     # check the `image_processing` field and use that if it's still processing.
     module AttachmentHook
       def url(*)
-        instance.public_send(:"#{name}_processing") || super
+        processing_url || super
+      end
+
+      private
+
+      def processing_url
+        attribute = :"#{name}_processing"
+        instance.has_attribute?(attribute) && instance.public_send(attribute)
       end
     end
   end

data/lib/paperweight/post_process_job.rb

@@ -7,9 +7,11 @@ module Paperweight
 
     discard_on ActiveJob::DeserializationError
 
-    def perform(model, name, url)
-      tempfile = Download.new.download(url)
-      model.update!(name => tempfile, :"#{name}_processing" => nil)
+    def perform(model, name)
+      processing = :"#{name}_processing"
+
+      tempfile = Download.new.download(model.public_send(processing))
+      model.update!(name => tempfile, processing => nil)
     end
   end
 end

data/lib/paperweight/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Paperweight
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: paperweight
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Kevin Deisz