papercraft 0.26 → 0.27

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2b64cff374a2d8fdf50de978d3a4b0ceb6fb939741c00ed7cf63154af7cf6732
-  data.tar.gz: 67c0fc2aa65a1056f04c378ebe50a0a433bb1cabba75a1fbd522d60604ddcd1d
+  metadata.gz: bd2f4f4d1ebc2cfc5718079d68c9393b3d95def9c02b057107425ddd5b45eaf3
+  data.tar.gz: f3f82f29227e22e5e31b0d685bcab211ebbef0ecf8a4433d251cb1f204875cf7
 SHA512:
-  metadata.gz: 690eaec575b4ad635fc913609197d166841536811b1e1d4314d763c6c37fb520b9fc8f2f19d50f4a0cfd242a98b69d59aebf16eaa16f4298bfc74ac0040b516a
-  data.tar.gz: 66a468eeee29e5c2b9b9e7a2f3adc605fa2f9648ade7a0aa444a798d896de3eb8c5aa02c2e79bf27780769f86d2b1960b8a111be1d8ed6604af739cab5931adb
+  metadata.gz: 7389861bea04a92e06ce1a53a682ef3b4db1bf975bb7f5e63cef0ed6c1a4ebb4b92920a0bb4ea04eba24dc72b41c70ba8fac0d8aa605a2b5a720d7860198b7e0
+  data.tar.gz: 2a617260deef291c56cd0c3fc1b275d47dd1dc95bdeeafc69289d630260480e49126c29f0ec77c177fd6c1032c633ba2568be1ffb767e13f91e51b5a9c298831

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.27 2023-01-19
+
+- Fix rendering of HTML void element tags
+
 ## 0.26 2023-01-13
 
 - Add support for namespaced local extensions using `#extend`

data/lib/papercraft/html.rb

@@ -88,6 +88,21 @@ module Papercraft
 
     private
 
+    # Returns true if the given tag is a void element, in order to render a self
+    # closing tag. See spec: https://html.spec.whatwg.org/multipage/syntax.html#void-elements.
+    #
+    # @param text [String] tag
+    # @return [Bool] is it a void element
+    def is_void_element_tag?(tag)
+      case tag
+      # 
+      when 'area', 'base', 'br', 'col', 'embed', 'hr', 'img', 'input', 'link', 'meta', 'source', 'track', 'wbr'
+        true
+      else
+        false
+      end
+    end
+
     # Escapes the given text using HTML entities.
     #
     # @param text [String] text

data/lib/papercraft/tags.rb

@@ -10,6 +10,7 @@ module Papercraft
     S_LT_SLASH        = '</'
     S_SPACE_LT_SLASH  = ' </'
     S_SLASH_GT        = '/>'
+    S_GT_LT_SLASH     = '></'
     S_SPACE           = ' '
     S_EQUAL_QUOTE     = '="'
     S_QUOTE           = '"'
@@ -21,6 +22,36 @@ module Papercraft
       S_TAG_%<TAG>s_PRE = %<tag_pre>s
       S_TAG_%<TAG>s_CLOSE = %<tag_close>s
 
+      def %<tag>s(text = nil, **props, &block)
+        if text.is_a?(Hash) && props.empty?
+          props = text
+          text = nil
+        end
+
+        @buffer << S_TAG_%<TAG>s_PRE
+        emit_props(props) unless props.empty?
+
+        if block
+          @buffer << S_GT
+          instance_eval(&block)
+          @buffer << S_TAG_%<TAG>s_CLOSE
+        elsif Proc === text
+          @buffer << S_GT
+          emit(text)
+          @buffer << S_TAG_%<TAG>s_CLOSE
+        elsif text
+          @buffer << S_GT << escape_text(text.to_s) << S_TAG_%<TAG>s_CLOSE
+        else
+          @buffer << S_GT << S_TAG_%<TAG>s_CLOSE
+        end
+      end
+    EOF
+
+    S_VOID_TAG_METHOD_LINE = __LINE__ + 2
+    S_VOID_TAG_METHOD = <<~EOF
+      S_TAG_%<TAG>s_PRE = %<tag_pre>s
+      S_TAG_%<TAG>s_CLOSE = %<tag_close>s
+
       def %<tag>s(text = nil, **props, &block)
         if text.is_a?(Hash) && props.empty?
           props = text
@@ -149,8 +180,10 @@ module Papercraft
         @buffer << S_LT_SLASH << tag << S_GT
       elsif text
         @buffer << S_GT << escape_text(text.to_s) << S_LT_SLASH << tag << S_GT
-      else
+      elsif is_void_element_tag?(sym)
         @buffer << S_SLASH_GT
+      else
+        @buffer << S_GT_LT_SLASH << tag << S_GT
       end
     end
 
@@ -262,13 +295,20 @@ module Papercraft
     # @return [void]
     def define_tag_method(tag)
       repr = tag_repr(tag)
-      code = S_TAG_METHOD % {
+      if is_void_element_tag?(tag)
+        tmpl = S_VOID_TAG_METHOD
+        line = S_VOID_TAG_METHOD_LINE
+      else
+        tmpl = S_TAG_METHOD
+        line = S_TAG_METHOD_LINE
+      end
+      code = tmpl % {
         tag: tag,
         TAG: tag.upcase,
         tag_pre: "<#{repr}".inspect,
         tag_close: "</#{repr}>".inspect
       }
-      self.class.class_eval(code, __FILE__, S_TAG_METHOD_LINE)
+      self.class.class_eval(code, __FILE__, line)
     end
 
     # Defines a namespace referring to the given module.

data/lib/papercraft/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Papercraft
-  VERSION = '0.26'
+  VERSION = '0.27'
 end

data/lib/papercraft/xml.rb

@@ -10,7 +10,15 @@ module Papercraft
 
     private
 
-    # Converts a tag to its string representation. Underscores will be converted
+    # Returns false (no void elements in XML)
+    #
+    # @param tag [String] tag
+    # @return [false] false
+    def is_void_element_tag?(tag)
+      false
+    end
+
+      # Converts a tag to its string representation. Underscores will be converted
     # to dashes, double underscores will be converted to colon.
     #
     # @param tag [Symbol, String] tag

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: papercraft
 version: !ruby/object:Gem::Version
-  version: '0.26'
+  version: '0.27'
 platform: ruby
 authors:
 - Sharon Rosner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-01-13 00:00:00.000000000 Z
+date: 2023-01-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: escape_utils