paperclip-location 0.0.7 → 0.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7d83cfb902c31a155ba56326a8452faba62e1628
-  data.tar.gz: 7767686c871797fd35b2ad4901162e0dc74ac4f9
+  metadata.gz: 61cc4a113b560c024732791abaa7d44bc88e1620
+  data.tar.gz: dd9c3f54cd407c18e91e7fe5a7538b86299da7ee
 SHA512:
-  metadata.gz: f1afc944888f33116265fbfc6492ec7d14ee5585c9b1262ea7fb2d2b4ad876779909d7469ec1234ebac1f099da4bf708acbe5bc7576ea5697723c50b5e887d62
-  data.tar.gz: f9b3b0ba67b8e1ed87b2b3561d791f9e2d1f6fafec06ccce14138ea9a86f8e305cea924bfe283b6806dcb634db6d0fdea5ccc83f490a1ef3049852448a353eb3
+  metadata.gz: 87b9448cfbd7e7dfa5f60a7c79d6495e93d28bf87ea04ce322847548e52c51f6823f131a92a3ab1d0bdc6f61308f764688fa9b855550375b011addcc1e9e3e43
+  data.tar.gz: ee1c932e25568a1463703056758fa6174eff4307c1a2a61e2ad852bbf93c5cb2e91f0b53e734c943ca8883734e6c36eb8b2eaf4b95d2d1264a431c58c70a45fc

data/lib/paperclip/location/processor.rb

@@ -4,7 +4,7 @@ require 'paperclip'
 module Paperclip::Location
   class Processor < Paperclip::Processor
     delegate :instance, to: :attachment, allow_nil: true
-    delegate :gps, to: :exif
+    delegate :gps, to: :exif, allow_nil: true
 
     def self.register!(name = :location)
       Paperclip.configure do |c|
@@ -27,11 +27,13 @@ module Paperclip::Location
     end
 
     def can_process?
-      !location_locked? && gps.present? && instance.present?
+      !location_locked? && gps.present? && instance.present? && exif.present?
     end
 
     def exif
       @exif ||= EXIFR::JPEG.new(file.path)
+    rescue EXIFR::MalformedJPEG => ex
+      nil
     end
   end
 end

data/paperclip-location.gemspec

@@ -3,24 +3,24 @@ lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
-  spec.name          = "paperclip-location"
-  spec.version       = "0.0.7"
-  spec.authors       = ["Sean Doyle"]
-  spec.email         = ["sean.p.doyle24@gmail.com"]
+  spec.name          = 'paperclip-location'
+  spec.version       = '0.0.8'
+  spec.authors       = ['Sean Doyle']
+  spec.email         = ['sean.p.doyle24@gmail.com']
   spec.description   = %q{extract geolocation during Paperclip processing}
   spec.summary       = %q{extract geolocation EXIF data during Paperclip processing}
-  spec.homepage      = "https://github.com/seanpdoyle/paperclip-location"
-  spec.license       = "MIT"
+  spec.homepage      = 'https://github.com/seanpdoyle/paperclip-location'
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files`.split($/)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "rake", "~> 10.1"
-  spec.add_development_dependency "rspec", "~> 2.14"
+  spec.add_development_dependency 'bundler', '~> 1.3'
+  spec.add_development_dependency 'rake', '~> 10.1'
+  spec.add_development_dependency 'rspec', '~> 2.14'
 
-  spec.add_dependency "paperclip", ">= 3.5"
-  spec.add_dependency "exifr", "~> 1.1"
+  spec.add_dependency 'paperclip', '>= 3.5'
+  spec.add_dependency 'exifr', '~> 1.1'
 end

data/spec/paperclip/location/processor_spec.rb

@@ -23,7 +23,7 @@ describe Paperclip::Location::Processor, '#make' do
 
   context "when the model's location is locked" do
     let(:file){ File.new(Photos::WITH_EXIF.path) }
-    
+
     before do
       expect(model).to receive(:location_locked?) { true }
     end
@@ -66,5 +66,17 @@ describe Paperclip::Location::Processor, '#make' do
         does_nothing(model)
       end
     end
+
+    context 'given an invalid file' do
+      let(:file){ File.new(Photos::INVALID.path) }
+
+      after do
+        subject.make
+      end
+
+      it 'does not modify the Attachment model' do
+        does_nothing(model)
+      end
+    end
   end
-end
+end

data/spec/support/photos.rb

@@ -13,4 +13,10 @@ module Photos
     lat: nil,
     lng: nil
   ).freeze
-end
+
+  INVALID = OpenStruct.new(
+    path: File.join(ROOT, 'not-a-jpg.jpg'),
+    lat: nil,
+    lng: nil
+  )
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: paperclip-location
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
 platform: ruby
 authors:
 - Sean Doyle
@@ -99,6 +99,7 @@ files:
 - lib/paperclip/location/railtie.rb
 - paperclip-location.gemspec
 - spec/paperclip/location/processor_spec.rb
+- spec/photos/not-a-jpg.jpg
 - spec/photos/with-exif.jpg
 - spec/photos/without-exif.jpg
 - spec/spec_helper.rb
@@ -129,6 +130,7 @@ specification_version: 4
 summary: extract geolocation EXIF data during Paperclip processing
 test_files:
 - spec/paperclip/location/processor_spec.rb
+- spec/photos/not-a-jpg.jpg
 - spec/photos/with-exif.jpg
 - spec/photos/without-exif.jpg
 - spec/spec_helper.rb