paper_trail_manager 0.8.0 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 007f0fa99ee11e2fdd0d615ec29d66e74788062b3a8e479091c31427d54add6c
-  data.tar.gz: a71dfd4c73909f185c580a11eae304ac0fb75e8c16fe92fe890ddeb90d7ace71
+  metadata.gz: 80cf0bf04cd19250486c5f63d4c8e77550cd284660086ab3dedd0e720b876045
+  data.tar.gz: 9c1e1dac59e08f4111f3eb77eeeae8a4c7ac1cc6a162eb22f9eda673963baecb
 SHA512:
-  metadata.gz: b019f63c912f3627025427264b6b48be3347e8fe9ec1145ee1b97347e807e0d5642ff6c06ec5085635d6fe5d18354397865bc85734ade8c015284fa484287220
-  data.tar.gz: 0f60e85a369b84075a088f2e2cbca20d85895c7ff42c38fcb7d1595f7e503954bd5ea3c19cfa8b393b433ab003e4309f367caeb03dc3997e2e7f913fda167220
+  metadata.gz: 5a8551d300e427b19f5545974fac2d117e18762311b4a0934100cf9a4976088ee62d60e30d01c2630b2c6c77ad8012ebe588f048ae5c4a812eaa37c3029d6cd5
+  data.tar.gz: dbc3aa2206a36873d6f7cb06c4b15d226c3bcc86cc10a6cb80c83139a888c840d2831b3b1d2df087e0cc35361fcc0e2ff482559b465ed1633cdae7557c93977c

data/CHANGES.md

@@ -1,6 +1,17 @@
 Changes to `paper_trail_manager`
 ================================
 
+* 0.9.0
+    * Add date range filtering to changes index via `from` and `to` query parameters
+    * Add date filter UI with date inputs, filter button, and clear link
+    * Add Rails install generator (`rails generate paper_trail_manager:install`)
+    * Add I18n support for all UI strings (30 translation keys, default English locale)
+    * Add authorization integration tests (unauthorized index/show/revert, non-existent records)
+    * Add unit tests for ChangesHelper methods (text_or_nil, changes_for, change_item_types, version_reify)
+    * Add specs for JSON and Atom response formats with filter coverage
+    * Host apps can override any translation key in their own locale files
+    * Test count: 19 → 50
+
 * 0.8.0
     * Fix `allow_show?` calling `allow_index_block` instead of `allow_show_block` — `allow_show_when` configuration was previously silently ignored (security fix)
     * Fix gemspec `authors` field being overwritten by misplaced `email` assignment

data/app/controllers/paper_trail_manager/changes_controller.rb

@@ -15,7 +15,7 @@ class PaperTrailManager
     # List changes
     def index
       unless change_index_allowed?
-        flash[:error] = 'You do not have permission to list changes.'
+        flash[:error] = t('paper_trail_manager.flash.index_denied')
         return(redirect_to root_url)
       end
 
@@ -54,12 +54,12 @@ class PaperTrailManager
       begin
         @version = PaperTrail::Version.find(params[:id])
       rescue ActiveRecord::RecordNotFound
-        flash[:error] = 'No such version.'
+        flash[:error] = t('paper_trail_manager.flash.not_found')
         return(redirect_to action: :index)
       end
 
       unless change_show_allowed?(@version)
-        flash[:error] = 'You do not have permission to show that change.'
+        flash[:error] = t('paper_trail_manager.flash.show_denied')
         return(redirect_to action: :index)
       end
 
@@ -74,12 +74,12 @@ class PaperTrailManager
       begin
         @version = PaperTrail::Version.find(params[:id])
       rescue ActiveRecord::RecordNotFound
-        flash[:error] = 'No such version.'
+        flash[:error] = t('paper_trail_manager.flash.not_found')
         return(redirect_to(changes_path))
       end
 
       unless change_revert_allowed?(@version)
-        flash[:error] = 'You do not have permission to revert this change.'
+        flash[:error] = t('paper_trail_manager.flash.revert_denied')
         return(redirect_to changes_path)
       end
 
@@ -93,14 +93,14 @@ class PaperTrailManager
 
       if @result
         if @version.event == 'create'
-          flash[:notice] = 'Rolled back newly-created record by destroying it.'
+          flash[:notice] = t('paper_trail_manager.flash.rollback_create')
           redirect_to changes_path
         else
-          flash[:notice] = 'Rolled back changes to this record.'
+          flash[:notice] = t('paper_trail_manager.flash.rollback_update')
           redirect_to change_item_url(@version)
         end
       else
-        flash[:error] = "Couldn't rollback. Sorry."
+        flash[:error] = t('paper_trail_manager.flash.rollback_failed')
         redirect_to changes_path
       end
     end

data/app/views/paper_trail_manager/changes/_version.html.erb

@@ -1,6 +1,6 @@
 <tr class='change_row <%= "change_event_#{version.event} #{version.event} #{version.event}, #{version.item_type.downcase}" %>'>
   <td class='change_time'>
-    <span class='change_id'>Change #<%= version.id %></span>
+    <span class='change_id'><%= t('paper_trail_manager.changes.version.change_id', id: version.id) %></span>
     <div class='date'> <%= version.created_at.strftime('%Y-%m-%d') %> </div>
     <div class='time'> <%= version.created_at.strftime('%H:%M:%S') %> </div>
   </td>
@@ -11,16 +11,16 @@
       <% if PaperTrailManager.whodunnit_class && version.whodunnit %>
         <% if user = PaperTrailManager.whodunnit_class.find(version.whodunnit) rescue nil %>
           <% if PaperTrailManager.user_path_method && user %>
-            by <%= link_to(h(user.send(PaperTrailManager.whodunnit_name_method)), send(:user_path_method, user)) %>
+            <%= t('paper_trail_manager.changes.version.by') %> <%= link_to(h(user.send(PaperTrailManager.whodunnit_name_method)), send(:user_path_method, user)) %>
           <% else %>
-            by <%= h(user.send(PaperTrailManager.whodunnit_name_method)) %>
+            <%= t('paper_trail_manager.changes.version.by') %> <%= h(user.send(PaperTrailManager.whodunnit_name_method)) %>
           <% end %>
         <% else %>
-          by <%= version.whodunnit %>
+          <%= t('paper_trail_manager.changes.version.by') %> <%= version.whodunnit %>
         <% end %>
       <% end %>
       <% if change_revert_allowed?(version) %>
-        <%= button_to 'Roll back', change_path(version), method: :put, class: 'rollback', form: { data: { turbo_confirm: 'Are you sure?' } } %>
+        <%= button_to t('paper_trail_manager.changes.version.roll_back'), change_path(version), method: :put, class: 'rollback', form: { data: { turbo_confirm: t('paper_trail_manager.changes.version.confirm_rollback') } } %>
       <% end %>
     </p>
     <% if version.event == 'update' or version.event == 'create' %>

data/app/views/paper_trail_manager/changes/index.html.erb

@@ -1,22 +1,23 @@
-<h1>Changes</h1>
+<h1><%= t('paper_trail_manager.changes.index.title') %></h1>
 
 <p>
-  Show:
-  <%= ([link_to('All', changes_path)] + change_item_types.map { |type| link_to(type.pluralize, changes_path(type: type)) }).join(' | ').html_safe %>
+  <%= t('paper_trail_manager.changes.index.show_label') %>
+  <%= ([link_to(t('paper_trail_manager.changes.index.all'), changes_path)] + change_item_types.map { |type| link_to(type.pluralize, changes_path(type: type)) }).join(' | ').html_safe %>
 </p>
 
 <%= form_tag changes_path, method: :get, class: 'changes_date_filter' do %>
   <%= hidden_field_tag :type, params[:type] if params[:type] %>
   <%= hidden_field_tag :id, params[:id] if params[:id] %>
-  <label for="from">From:</label>
+  <label for="from"><%= t('paper_trail_manager.changes.filter.from') %></label>
   <%= date_field_tag :from, params[:from], id: 'from' %>
-  <label for="to">To:</label>
+  <label for="to"><%= t('paper_trail_manager.changes.filter.to') %></label>
   <%= date_field_tag :to, params[:to], id: 'to' %>
-  <%= submit_tag 'Filter', name: nil %>
+  <%= submit_tag t('paper_trail_manager.changes.filter.submit'), name: nil %>
   <% if params[:from].present? || params[:to].present? %>
-    <%= link_to 'Clear', changes_path(type: params[:type], id: params[:id]), class: 'clear_filter' %>
+    <%= link_to t('paper_trail_manager.changes.filter.clear'), changes_path(type: params[:type], id: params[:id]), class: 'clear_filter' %>
   <% end %>
 <% end %>
+
 <div class="table-responsive">
   <table class='changes_table table table-bordered'>
     <tfoot>
@@ -28,8 +29,8 @@
     </tfoot>
     <thead>
       <tr class='changes_header'>
-        <th class='change_time'>Time</th>
-        <th class='change_details'>Attribute with previous and current values</th>
+        <th class='change_time'><%= t('paper_trail_manager.changes.index.time') %></th>
+        <th class='change_details'><%= t('paper_trail_manager.changes.index.details') %></th>
       </tr>
     </thead>
     <tbody>
@@ -40,7 +41,7 @@
         <% end %>
       <% else %>
         <tr>
-          <td colspan='2'> &mdash; No changes found &mdash; </td>
+          <td colspan='2'> &mdash; <%= t('paper_trail_manager.changes.index.no_changes') %> &mdash; </td>
         </tr>
       <% end %>
     </tbody>

data/app/views/paper_trail_manager/changes/show.html.erb

@@ -1,10 +1,10 @@
-<h1>Change <%= @version.id %></h1>
+<h1><%= t('paper_trail_manager.changes.show.title', id: @version.id) %></h1>
 
 <table class='changes_table'>
   <thead>
     <tr class='changes_header'>
-      <th class='change_time'>Time</th>
-      <th class='change_details'>Attribute with previous and current values</th>
+      <th class='change_time'><%= t('paper_trail_manager.changes.index.time') %></th>
+      <th class='change_details'><%= t('paper_trail_manager.changes.index.details') %></th>
     </tr>
   </thead>
   <tbody>

data/config/locales/en.yml

@@ -0,0 +1,30 @@
+en:
+  paper_trail_manager:
+    changes:
+      index:
+        title: "Changes"
+        show_label: "Show:"
+        all: "All"
+        no_changes: "No changes found"
+        time: "Time"
+        details: "Attribute with previous and current values"
+      show:
+        title: "Change %{id}"
+      filter:
+        from: "From:"
+        to: "To:"
+        submit: "Filter"
+        clear: "Clear"
+      version:
+        change_id: "Change #%{id}"
+        roll_back: "Roll back"
+        confirm_rollback: "Are you sure?"
+        by: "by"
+    flash:
+      index_denied: "You do not have permission to list changes."
+      show_denied: "You do not have permission to show that change."
+      revert_denied: "You do not have permission to revert this change."
+      not_found: "No such version."
+      rollback_create: "Rolled back newly-created record by destroying it."
+      rollback_update: "Rolled back changes to this record."
+      rollback_failed: "Couldn't rollback. Sorry."

data/lib/generators/paper_trail_manager/install/install_generator.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+require 'rails/generators'
+
+class PaperTrailManager
+  class InstallGenerator < Rails::Generators::Base
+    source_root File.expand_path('templates', __dir__)
+    desc 'Install PaperTrailManager: add route and create initializer'
+
+    def add_route
+      route_string = "resources :changes, controller: 'paper_trail_manager/changes'"
+      routes_file = File.join(destination_root, 'config/routes.rb')
+
+      if File.exist?(routes_file) && File.read(routes_file).include?(route_string)
+        say_status :skip, 'Route already exists', :yellow
+      else
+        route route_string
+      end
+    end
+
+    def create_initializer
+      template 'initializer.rb', 'config/initializers/paper_trail_manager.rb'
+    end
+
+    def show_post_install
+      say ''
+      say '✅ PaperTrailManager installed!', :green
+      say ''
+      say 'Next steps:'
+      say '  1. Restart your Rails server'
+      say '  2. Visit /changes to browse your PaperTrail version history'
+      say '  3. Edit config/initializers/paper_trail_manager.rb to customize authorization'
+      say ''
+    end
+  end
+end

data/lib/generators/paper_trail_manager/install/templates/initializer.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+# PaperTrailManager configuration
+# See: https://github.com/DamageLabs/paper_trail_manager
+
+# Control who can view the changes index.
+# PaperTrailManager.allow_index_when do |controller|
+#   controller.current_user.present?
+# end
+
+# Control who can view individual change details.
+# Defaults to the allow_index rules if not set separately.
+# PaperTrailManager.allow_show_when do |controller, version|
+#   controller.current_user.present?
+# end
+
+# Control who can revert changes.
+# PaperTrailManager.allow_revert_when do |controller, version|
+#   controller.current_user&.admin?
+# end
+
+# Configure how to look up users referenced in PaperTrail's whodunnit column.
+# PaperTrailManager.whodunnit_class = User
+# PaperTrailManager.whodunnit_name_method = :name
+
+# Specify a method to identify items on the index page.
+# PaperTrailManager.item_name_method = :name
+
+# Customize the user path helper (set to nil to disable user links).
+# PaperTrailManager.user_path_method = :user_path
+
+# When embedding inside another Rails engine:
+# PaperTrailManager.base_controller = 'MyEngine::ApplicationController'
+# PaperTrailManager.route_helpers = MyEngine::Engine.routes.url_helpers
+# PaperTrailManager.layout = 'my_engine/application'

data/lib/paper_trail_manager.rb

@@ -14,6 +14,10 @@ rescue LoadError
 end
 
 class PaperTrailManager < Rails::Engine
+  initializer 'paper_trail_manager.i18n' do
+    config.i18n.load_path += Dir[root.join('config', 'locales', '*.yml')]
+  end
+
   initializer 'paper_trail_manager.pagination' do
     if defined?(WillPaginate)
       ::ActionView::Base.define_method(:paginate) { |*args, **kwargs, &block| will_paginate(*args, **kwargs, &block) }

data/paper_trail_manager.gemspec

@@ -5,7 +5,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'paper_trail_manager'
-  spec.version       = '0.8.0'
+  spec.version       = '0.9.0'
   spec.authors       = ['Igal Koshevoy', 'Reid Beels']
   spec.email         = ['mail@reidbeels.com']
   spec.summary       = 'A user interface for `paper_trail` versioning data in Rails applications.'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: paper_trail_manager
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.9.0
 platform: ruby
 authors:
 - Igal Koshevoy
@@ -208,6 +208,7 @@ files:
 - app/views/paper_trail_manager/changes/index.atom.builder
 - app/views/paper_trail_manager/changes/index.html.erb
 - app/views/paper_trail_manager/changes/show.html.erb
+- config/locales/en.yml
 - gemfiles/rails_6.1_paper_trail_12.0_kaminari.gemfile
 - gemfiles/rails_6.1_paper_trail_12.0_will_paginate.gemfile
 - gemfiles/rails_7.0_paper_trail_12.0_kaminari.gemfile
@@ -216,6 +217,8 @@ files:
 - gemfiles/rails_7.0_paper_trail_15.0_will_paginate.gemfile
 - gemfiles/rails_7.1_paper_trail_15.0_kaminari.gemfile
 - gemfiles/rails_7.1_paper_trail_15.0_will_paginate.gemfile
+- lib/generators/paper_trail_manager/install/install_generator.rb
+- lib/generators/paper_trail_manager/install/templates/initializer.rb
 - lib/paper_trail_manager.rb
 - paper_trail_manager.gemspec
 - spec/app_template.rb