pansophy_authenticator 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7af7e60f259d600f0f144d92093cf6e72281e89f
-  data.tar.gz: 19fcf4ca69a64465d75e2a963744ccff2d3738a3
+  metadata.gz: 1a3e9c1d43153905040277676f4ce886c9f80eff
+  data.tar.gz: 6dff940369d0b5c392834a841a3dfaeff29ddb08
 SHA512:
-  metadata.gz: 1aa802262c4c530e651a9a3c32b5237827181c54c550802f3087f902828ad232ac5c0ea8efb0f967d04e6c09e315b38409289b720c383f5877b483cbbf236537
-  data.tar.gz: 617e24f95dec81945c00dd7363351b1c557fcf5a8827e6dd54550699d0c5ed7244f15de7340848e345a525998414765e4ea41c54dcfc65e591e8751a5ee5cf97
+  metadata.gz: bd5fd51d19c1b774741a261307df5a83949201a2ed9c86e9337eff4f949b64af42602b7455a7a9d7189ad846a40e8947a29996a81e1c88ab4bc734fe32d01cd7
+  data.tar.gz: a636e340701b60f323deca0ee8abcb84b02b404c230ce83ab7773f48dc5623999a8b2105006d37cc623d5bfc000863923c5b8d6c6a41816f2d85a8283a1cea25

data/.rubocop.yml

@@ -9,3 +9,6 @@ Style/BlockDelimiters:
 
 Style/TrivialAccessors:
   AllowPredicates: true
+
+Style/SignalException:
+  EnforcedStyle: semantic

data/.travis.yml

@@ -8,4 +8,4 @@ notifications:
   email:
     - support@travellink.com.au
   flowdock:
-    secure: X54gP0PjRDh289791y3jqYryuiWX6RNTNvxpzMVU0l3sw4JwxgjlfGG+VCYtje06D9rd3KJeostko1dqpP6RFiZCcOgd/zjsexP0JokD1e42hM2FTFCu7cMAn+VeWSN42NWTFp+8YIpcKbITiywkIREzHjXXW6jthh6aFEoMUD7u4qUy71iL2gGLlOwIL8IfUAljn1bDAr5w5yFSQvhywldG8QDvHavlH5YEXqNnMypxQT8EGtKtHA1xO6k3JyzVYeZJxmy+ZkmsgOcEAAWSecXpNtMDQIM6V789rML3S86CtyoK3ti7ndMdYx37ff112pmANr8TjFYRBD7Zjn1xfFFd90G8mFcOiYBMKTz1rds8j2UtxcirBxR9T8Hf4xn9LurCyqhKIIml0XAE3pRs3fa4HVzNOZElf8sMPDhWCFBW/BqKlt/e/HIsBBMxZWg6i+mWMJWptkiKWTTxBQYNtoX5pscCW1xxlIM55LUJrWM88vOCaMiM3UYaDIGo35c9cXQZRa86tdjDQhWbyPExpW8L87XGByro7KrN/pQqjPHEL7GVlwGlrRSzS5f8fdLdydAWOwgy0q3D9Rsydy4WPsuVBUM6MmTAD7w41UeyF0aa/Rt8IvG8hCnr2NLS62VHx3rjnLpL4Jrz2XRUgQM/zUmWD2hb8M8iVevUMeLZTms=
+    secure: rn+Y1aDKALwrEUu9JkZCM+DWGMh1X3TKypx05Gh6PPut+DE+DocV1rmRZYgfU/Db0+UtCW27FpdbLETzBa/Z5r58aH0VMdWXpyYbYGXJi8Ff/nWogj0iswrmGoE8a+VEnwt2Z1Gz9LwwP/k7oxA2d+rqalGHNpTZbFf2SOIqq+S8A0ULvg+jTcG1S+mf6iCbAJLbRlRW+CC/dn5YPx9gGt/u9f/dnjGgYmkVuIzS0NvdzmB+lJfMTB4mt5Hbca9QEQSniBQFpI5neWqIBgCgqI9NvbV7s62sztjxnt2+VyjuiJG5IdClwQXIMTlvsgVGifAv99qXBH/Y7mpLUVzJr5uArLpasGe1wJI7xWBDsegYKiIZEYQGNUjFzQaBWwdS/roUWpt+I/FcCHCKYQZvx1OyzmndLN82mMzH7218N5CpCImroVWXZ6MjeOw/45RZPMAaShpdnw5NDHSNPpGF5e+MxqR7okIEoomIDsuGxDgqkCzjAbZETdWTsO8tKu3ZJnAxK9Lu5/iSsQvMLv4mUlL6EYGdjIxLwYtVzbFVVaf8AMdVsr+PMkzbHaqFcoxrE+VC/dFHVVd0szHX8DYs/Nvy5MiEVMVJxRIaUZgzim47I3r7nHKpA9fGh7ipM/pqMBTEnWC64sqQYZTWbFYQ18OyaRtqtdN3Ou3xDY+obPY=

data/CHANGELOG.md

@@ -1,6 +1,19 @@
+## 0.3.0 (2016-02-12)
+
+Adds:
+
+  - Configuration validation
+
+## 0.2.1 (2016-02-05)
+
+Fixes:
+
+  - Security fix: be agnostic on cause of validation failure
+  - Don't raise errors when checking validation via #valid?
+
 ## 0.2.0 (2016-02-02)
 
-Features:
+Adds:
 
   - caching via cache store
 

data/lib/pansophy_authenticator/configuration.rb

@@ -7,3 +7,4 @@ require 'pansophy_authenticator/configuration/configurator'
 require 'pansophy_authenticator/configuration/from_file'
 require 'pansophy_authenticator/configuration/from_env'
 require 'pansophy_authenticator/configuration/instance'
+require 'pansophy_authenticator/configuration/verification'

data/lib/pansophy_authenticator/configuration/instance.rb

@@ -1,9 +1,11 @@
 require 'anima'
+require 'memoizable'
 
 module PansophyAuthenticator
   module Configuration
     class Instance
       include Anima.new :local, :bucket_name, :file_path, :application, :cache_store
+      include Memoizable
 
       def local?
         @local
@@ -12,6 +14,21 @@ module PansophyAuthenticator
       def remote?
         !local?
       end
+
+      def valid?
+        verification.valid?
+      end
+
+      def errors
+        verification.errors
+      end
+
+      private
+
+      def verification
+        Verification::Verify.new(self).call
+      end
+      memoize :verification
     end
   end
 end

data/lib/pansophy_authenticator/configuration/verification.rb

@@ -0,0 +1,12 @@
+module PansophyAuthenticator
+  module Configuration
+    module Verification
+    end
+  end
+end
+
+require 'pansophy_authenticator/configuration/verification/result'
+require 'pansophy_authenticator/configuration/verification/common'
+require 'pansophy_authenticator/configuration/verification/local'
+require 'pansophy_authenticator/configuration/verification/remote'
+require 'pansophy_authenticator/configuration/verification/verify'

data/lib/pansophy_authenticator/configuration/verification/common.rb

@@ -0,0 +1,16 @@
+module PansophyAuthenticator
+  module Configuration
+    module Verification
+      class Common
+        def initialize(configuration)
+          @configuration = configuration
+        end
+
+        def verify
+          return Result.new 'Application is not defined' if @configuration.application.nil?
+          Result.new
+        end
+      end
+    end
+  end
+end

data/lib/pansophy_authenticator/configuration/verification/local.rb

@@ -0,0 +1,35 @@
+module PansophyAuthenticator
+  module Configuration
+    module Verification
+      class Local
+        def initialize(configuration)
+          @configuration = configuration
+        end
+
+        def verify
+          Result.new errors
+        end
+
+        private
+
+        def errors
+          return ['File path is not defined'] unless file_path?
+          return ["#{file_path} does not exist"] unless file_exist?
+          []
+        end
+
+        def file_path?
+          !file_path.nil?
+        end
+
+        def file_exist?
+          File.exist? file_path
+        end
+
+        def file_path
+          @configuration.file_path
+        end
+      end
+    end
+  end
+end

data/lib/pansophy_authenticator/configuration/verification/remote.rb

@@ -0,0 +1,19 @@
+module PansophyAuthenticator
+  module Configuration
+    module Verification
+      class Remote
+        def initialize(configuration)
+          @configuration = configuration
+          @result = Result.new
+        end
+
+        def verify
+          errors = []
+          errors << 'Bucket name is not defined' if @configuration.bucket_name.nil?
+          errors << 'File path is not defined' if @configuration.file_path.nil?
+          Result.new errors
+        end
+      end
+    end
+  end
+end

data/lib/pansophy_authenticator/configuration/verification/result.rb

@@ -0,0 +1,25 @@
+module PansophyAuthenticator
+  module Configuration
+    module Verification
+      class Result
+        include Adamantium
+
+        attr_reader :errors
+
+        def initialize(errors = [])
+          @errors = Array(errors)
+        end
+
+        def valid?
+          @errors.empty?
+        end
+
+        def +(other)
+          transform do
+            @errors += other.errors
+          end
+        end
+      end
+    end
+  end
+end

data/lib/pansophy_authenticator/configuration/verification/verify.rb

@@ -0,0 +1,29 @@
+module PansophyAuthenticator
+  module Configuration
+    module Verification
+      class Verify
+        def initialize(configuration)
+          @configuration = configuration
+        end
+
+        def call
+          verifiers.map { |verifier| verifier.new(@configuration).verify }.reduce(&:+)
+        end
+
+        private
+
+        def verifiers
+          [Common, specific_verifier]
+        end
+
+        def specific_verifier
+          if @configuration.local?
+            Local
+          else
+            Remote
+          end
+        end
+      end
+    end
+  end
+end

data/lib/pansophy_authenticator/matcher.rb

@@ -6,16 +6,21 @@ module PansophyAuthenticator
     end
 
     def validate!(given_key)
-      fail Error, "Invalid key for #{@application}" unless valid?(given_key)
+      fail Error, 'Invalid application or key' unless valid?(given_key)
     end
 
     def valid?(given_key)
+      return false unless valid_application?
       given_key == key
     end
 
     def key
-      fail Error, "#{@application} is not defined" unless @keys.key?(@application)
+      fail Error, "#{@application} is not defined" unless valid_application?
       @keys.fetch(@application)
     end
+
+    def valid_application?
+      @keys.key?(@application)
+    end
   end
 end

data/lib/pansophy_authenticator/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module PansophyAuthenticator
-  VERSION = '0.2.0'.freeze
+  VERSION = '0.3.0'.freeze
 end

data/pansophy_authenticator.gemspec

@@ -28,6 +28,7 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency 'memoize', '~> 1.3'
   spec.add_dependency 'anima', '~> 0.3'
+  spec.add_dependency 'adamantium', '~> 0.2'
   spec.add_dependency 'pansophy', '~> 0.3'
   spec.add_dependency 'yamload', '~> 0.2'
 
@@ -38,6 +39,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'simplecov', '~> 0.11'
   spec.add_development_dependency 'simplecov-rcov', '~> 0.2'
   spec.add_development_dependency 'coveralls', '~> 0.8'
-  spec.add_development_dependency 'rubocop', '~> 0.36'
+  spec.add_development_dependency 'rubocop', '~> 0.37'
   spec.add_development_dependency 'travis', '~> 1.8'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pansophy_authenticator
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Alessandro Berardi
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-02-02 00:00:00.000000000 Z
+date: 2016-02-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: memoize
@@ -38,6 +38,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.3'
+- !ruby/object:Gem::Dependency
+  name: adamantium
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.2'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.2'
 - !ruby/object:Gem::Dependency
   name: pansophy
   requirement: !ruby/object:Gem::Requirement
@@ -170,14 +184,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.36'
+        version: '0.37'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.36'
+        version: '0.37'
 - !ruby/object:Gem::Dependency
   name: travis
   requirement: !ruby/object:Gem::Requirement
@@ -224,6 +238,12 @@ files:
 - lib/pansophy_authenticator/configuration/from_env.rb
 - lib/pansophy_authenticator/configuration/from_file.rb
 - lib/pansophy_authenticator/configuration/instance.rb
+- lib/pansophy_authenticator/configuration/verification.rb
+- lib/pansophy_authenticator/configuration/verification/common.rb
+- lib/pansophy_authenticator/configuration/verification/local.rb
+- lib/pansophy_authenticator/configuration/verification/remote.rb
+- lib/pansophy_authenticator/configuration/verification/result.rb
+- lib/pansophy_authenticator/configuration/verification/verify.rb
 - lib/pansophy_authenticator/local.rb
 - lib/pansophy_authenticator/local/build_loader.rb
 - lib/pansophy_authenticator/local/fetcher.rb