panko_serializer 0.3.3 → 0.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eef3c77d8a03018af85326b4c07890d6d543909925c664f6baf6f20f634033e2
-  data.tar.gz: 28c88dea3cd021f1ba3cb5e31b21e03f3ddb9cdbf4851cccafa78770d742a994
+  metadata.gz: f2b1c0dbc2c75d9b48d7b2057ef66f2150702e86db83110e552ba8b99dfb7662
+  data.tar.gz: b980005c2670d69ba9093fd9aa4bee57f2f106eeedbccbd8739b64004591f62b
 SHA512:
-  metadata.gz: edbe1e16a0216d8cd9e8af32289e6b173565ad7d1b50c3177f90a2cc683fd00d26cf7248e0d563e4a76916e481d0723b23041fe6973c5df05b180227e1da82fe
-  data.tar.gz: d0883a7ba84ff19d57738d56846ca9fc9b4ed70d6343c6280225ccfa83abe6489d611b64cea4be294ce4ddccfc8e992be55545fd6ff18bf65936fae91db94ce3
+  metadata.gz: d27d528c54db62acffb611c5eba616f6346e410a78c9fe52835ccb5a60c4253e890f58dbc4aa6316f496db45fd1da7b4b79b4751fbd3898588b91efe715fb83e
+  data.tar.gz: ddf22bfc9d998fea61482a9e6ec71c460848401b7c922352f1c37395e717944c7cad77537133f90751a6cc9581e507cbb06d927af484f03bded9966a74e549e3

data/benchmarks/sanity.rb

@@ -3,6 +3,40 @@ require_relative "./benchmarking_support"
 require_relative "./app"
 require_relative "./setup"
 
+class PostWithAliasModel < ActiveRecord::Base
+  self.table_name = 'posts'
+
+  alias_attribute :new_id, :id
+  alias_attribute :new_body, :body
+  alias_attribute :new_title, :title
+  alias_attribute :new_author_id, :author_id
+  alias_attribute :new_created_at, :created_at
+end
+
+class PostWithAliasFastSerializer < Panko::Serializer
+  attributes :new_id, :new_body, :new_title, :new_author_id, :new_created_at
+end
+
+def benchmark_aliased(prefix, serializer, options = {})
+  posts = PostWithAliasModel.all.to_a
+  posts_50 = posts.first(50).to_a
+  data = { all: posts, small: posts_50 }
+
+  merged_options = options.merge(each_serializer: serializer)
+
+  Benchmark.run("Panko_#{prefix}_PostWithAliasModels_#{posts.count}") do
+    Panko::ArraySerializer.new(posts, merged_options).to_json
+  end
+
+  posts = PostWithAliasModel.all.to_a
+  posts_50 = posts.first(50).to_a
+  data = { all: posts, small: posts_50 }
+
+  Benchmark.run("Panko_#{prefix}_Posts_50") do
+    Panko::ArraySerializer.new(posts_50, merged_options).to_json
+  end
+end
+
 class AuthorFastSerializer < Panko::Serializer
   attributes :id, :name
 end
@@ -55,7 +89,7 @@ end
 
 
 
-
-benchmark 'SimpleWithMethodCall', PostFastWithMethodCallSerializer
+benchmark "SimpleWithMethodCall", PostFastWithMethodCallSerializer
 benchmark "HasOne", PostWithHasOneFastSerializer
 benchmark "Simple", PostFastSerializer
+benchmark_aliased "Simple (aliased)", PostWithAliasFastSerializer

data/ext/panko_serializer/attribute.c

@@ -1,5 +1,6 @@
 #include "attribute.h"
 
+ID attribute_aliases_id = 0;
 VALUE cAttribute;
 
 static void attribute_free(void* ptr) {
@@ -50,6 +51,23 @@ void attribute_try_invalidate(Attribute attribute, VALUE new_record_class) {
   if (rb_equal(attribute->record_class, new_record_class) == Qfalse) {
     attribute->type = Qnil;
     attribute->record_class = new_record_class;
+
+    // Once the record class is changed for this attribute, check if
+    // we attribute_aliases (from ActivRecord), if so fill in
+    // performance wise - this code should be called once (unless the serialzier
+    // is polymorphic)
+    volatile VALUE ar_aliases_hash =
+        rb_funcall(new_record_class, attribute_aliases_id, 0);
+
+    if (!panko_is_empty_hash(ar_aliases_hash)) {
+      volatile VALUE aliasedValue =
+          rb_hash_aref(ar_aliases_hash, attribute->name_str);
+      if (aliasedValue != Qnil) {
+        attribute->alias_name = attribute->name_str;
+        attribute->name_str = aliasedValue;
+        attribute->name_id = rb_intern_str(attribute->name_str);
+      }
+    }
   }
 }
 
@@ -64,6 +82,8 @@ VALUE attribute_alias_name_ref(VALUE self) {
 }
 
 void panko_init_attribute(VALUE mPanko) {
+  attribute_aliases_id = rb_intern("attribute_aliases");
+
   cAttribute = rb_define_class_under(mPanko, "Attribute", rb_cObject);
 
   rb_define_module_function(cAttribute, "new", attribute_new, -1);

data/lib/panko/serializer_resolver.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-require "byebug"
 
 class Panko::SerializerResolver
 

data/lib/panko/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Panko
-  VERSION = "0.3.3"
+  VERSION = "0.3.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: panko_serializer
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.3.4
 platform: ruby
 authors:
 - Yosi Attias
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-23 00:00:00.000000000 Z
+date: 2018-01-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -165,7 +165,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 2.7.4
 signing_key: 
 specification_version: 4
 summary: Fast serialization for ActiveModel