pandan 0.0.1 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 900b67b6cb939c129f2bf77dc1a35c310eab06fc
-  data.tar.gz: fe743a16dfd898ea146b60befdfd512b37075dc9
+SHA256:
+  metadata.gz: 7b66ee52e54b7cbf16f22755a11fdf1110daa4e93f1f17ae55794473598a0eb6
+  data.tar.gz: 697195fe39a325e97f3e53eee46c534259b9b84cb8e95f1d67e64f27a55450ca
 SHA512:
-  metadata.gz: b73adbbefe5cdca382ac34722e2fb1fb8b192e2f0892849744cb6bd2a32a67112bb924cc9ca9eb2f7aa79b9ad5a4964edf8d60ee1340fa4c29649a617bb43ec9
-  data.tar.gz: fe7aaecc55f3e6794db2f5a3259dff4525653ec6f7720bcab6e6f700472ddda6067bdc0e675e5d313458eae0f3a6a184a3e5ba60668da273f458c35f9fe9d334
+  metadata.gz: ab5c1d84f32c646eecc1351762aa753896844291193002b0f67c2b0840c0c26e04320728df03538c1a6d49509af8b95b4006ff02e39452ec96d29ed66560c4be
+  data.tar.gz: c6bb1cf22ac485a24118700d71d0d883641a05844caf2dd8d47d54b2f5d7f0316c5cce987b93e5d8c874daafc528e678a2b3e63bc2e9b8a72a2322a718a602e1

data/.rubocop.yml

@@ -1,12 +1,19 @@
-inherit_from: .rubocop_todo.yml
+AllCops:
+  TargetRubyVersion: 2.5
 
 Metrics/LineLength:
   Max: 120
+
 Metrics/MethodLength:
   Max: 20
+
 Metrics/ModuleLength:
   Exclude:
     - "**/*_spec.rb"
+
 Metrics/BlockLength:
   Exclude:
     - "**/*_spec.rb"
+
+Style/Documentation:
+  Enabled: false

data/.ruby-version

@@ -0,0 +1 @@
+ruby-2.5.1

data/.travis.yml

@@ -0,0 +1,8 @@
+language: ruby
+rvm:
+  - 2.3.7
+  - 2.4.4
+  - 2.5.1
+script:
+  - bundle exec rspec
+  - bundle exec rubocop

data/Gemfile

@@ -1,8 +1,6 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in pandan.gemspec
 gemspec
-
-group :development do
-  gem 'rubocop'
-end

data/README.md

@@ -1,5 +1,8 @@
 # Pandan
 
+[![Build Status](http://img.shields.io/travis/xing/pandan/master.svg?style=flat)](https://travis-ci.org/xing/pandan)
+[![Gem Version](http://img.shields.io/gem/v/pandan.svg?style=flat)](http://badge.fury.io/rb/pandan)
+
 > Pandanus amaryllifolius is a tropical plant in the Pandanus (screwpine) genus, which is commonly known as pandan leaves, and is used widely in South Asian and Southeast Asian cooking as a flavoring.  
 > —[Wikipedia](https://en.wikipedia.org/wiki/Pandanus_amaryllifolius)
 
@@ -15,7 +18,7 @@ $ gem install pandan
 
 ## Motivation
 
-At XING, CocoaPods helped us to manage our Objective-C and Swift dependencies for a long time. But as our team grew, it was evident to us that CocoaPods was not tool we needed anymore. We decided to migrate all our projects to different setup that uses multiple Xcode projects, targets and xcconfig files under a single workspace, but we were lacking a tool that would give us dependency information out of the settings that are already in place in Xcode.
+At XING, CocoaPods helped us manage our Objective-C and Swift dependencies for a long time. But as our team grew, it was evident to us that CocoaPods was not the tool we needed anymore. We decided to migrate all our projects to a different setup that uses multiple Xcode projects, targets and xcconfig files under a single workspace. However, we were lacking a tool that would give us dependency information based one the settings already in place in Xcode.
 
 ## Usage
 

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 

data/bin/pandan

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 $LOAD_PATH.push File.expand_path('../lib', File.dirname(__FILE__))
 require 'pandan'

data/lib/pandan.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'pandan/version'
 require 'pandan/command'
 require 'claide'

data/lib/pandan/command.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'claide'
 require 'pandan/version'
 

data/lib/pandan/command/dependency_graph.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'pandan/command'
 require 'pandan/parser'
 require 'pandan/graph'
@@ -25,6 +27,7 @@ module Pandan
       @save_gv = argv.flag?('graphviz')
       @save_png = argv.flag?('image')
       @filter = argv.option('filter')
+      @filter ||= '.*' # Match everything
       super
     end
 
@@ -64,9 +67,13 @@ module Pandan
     def graphviz_data(graph)
       graphviz = GraphViz.new(type: :digraph)
 
-      graph.nodes.each do |_, node|
+      graph.nodes.each_value do |node|
+        next unless node.name.match?(/#{@filter}/)
+
         target_node = graphviz.add_node(node.name)
         node.neighbors.each do |dependency|
+          next unless dependency.name.match?(/#{@filter}/)
+
           dep_node = graphviz.add_node(dependency.name)
           graphviz.add_edge(target_node, dep_node)
         end

data/lib/pandan/command/query.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'pandan/command'
 require 'pandan/parser'
 require 'pandan/graph'
@@ -13,6 +15,7 @@ module Pandan
       [
         ['--xcworkspace=path/to/workspace', 'If not set, Pandan will try to find a workspace'],
         ['--reverse', 'If set, pandan will output the targets that depend on the argument'],
+        ['--implicit-dependencies', 'If set, pandan will look up for linker flags in all build configurations'],
         ['--comma-separated', 'If set, Pandan outputs a comma-separated list instead of multiple lines'],
         ['--filter=expression', 'If set, pandan will select all targets whose name match the regular expression']
       ].concat(super)
@@ -27,8 +30,10 @@ module Pandan
       @xcworkspace = argv.option('xcworkspace')
       @xcworkspace ||= XCWorkspace.find_workspace
       @reverse = argv.flag?('reverse')
+      @implicit_deps = argv.flag?('implicit-dependencies')
       @comma_separated = argv.flag?('comma-separated')
       @filter = argv.option('filter')
+      @filter ||= '.*' # Match everything
       super
     end
 
@@ -41,14 +46,16 @@ module Pandan
 
     def run
       parser = Parser.new(@xcworkspace, @filter)
-      targets = parser.all_targets
       graph = Graph.new(@reverse)
+      targets = parser.all_targets
       graph.add_target_info(targets)
+      if @implicit_deps
+        ld_flags_info = parser.other_linker_flags
+        graph.add_other_ld_flags_info(ld_flags_info)
+      end
       deps = graph.resolve_dependencies(@target).map(&:name)
-      unless @filter.nil?
-        deps.select! do |dep|
-          dep.name.include? @filter
-        end
+      deps.select! do |dep|
+        dep =~ /#{@filter}/
       end
 
       if @comma_separated

data/lib/pandan/command/targets.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'pandan/command'
 require 'pandan/parser'
 require 'pandan/xcworkspace'

data/lib/pandan/graph.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'xcodeproj'
 require 'pandan/xcodeproj/user_interface.rb'
 
@@ -27,22 +29,21 @@ module Pandan
     def add_target_info(targets)
       targets.each do |target|
         linked_libraries = find_linked_libraries(target)
-        node = nodes[target.display_name]
-        if node.nil?
-          node = Node.new(target.display_name)
-          nodes[target.display_name] = node
-        end
+        node = node_for_target_display_name(target.display_name)
         linked_libraries.each do |library_name|
-          library_node = nodes[library_name]
-          if library_node.nil?
-            library_node = Node.new(library_name)
-            nodes[library_name] = library_node
-          end
-          if reverse
-            library_node.add_neighbor(node)
-          else
-            node.add_neighbor(library_node)
-          end
+          library_node = node_for_target_display_name(library_name)
+          add_neighbor(node, library_node)
+        end
+      end
+    end
+
+    def add_other_ld_flags_info(ld_flags_info)
+      ld_flags_info.each do |target, ld_flags_per_config|
+        node = node_for_target_display_name(target.display_name)
+        ld_flags_per_config.each_value do |ld_flags|
+          joined_flags = ld_flags.join(' ')
+          joined_flags.match(/-l"(.*?)"/).captures.each { |library| add_as_neighbor(node, library) }
+          joined_flags.match(/-framework "(.*?)"/).captures.each { |framework| add_as_neighbor(node, framework) }
         end
       end
     end
@@ -51,6 +52,7 @@ module Pandan
       resolved = []
       target_node = nodes[target]
       raise "Target #{target} not found" if target_node.nil?
+
       resolve(target_node, resolved)
       resolved.delete(target_node)
       resolved
@@ -58,18 +60,42 @@ module Pandan
 
     private
 
+    def add_as_neighbor(node, item)
+      add_neighbor(node, node_for_target_display_name(item))
+    end
+
+    def node_for_target_display_name(display_name)
+      node = nodes[display_name]
+      if node.nil?
+        node = Node.new(display_name)
+        nodes[display_name] = node
+      end
+      node
+    end
+
+    def add_neighbor(source, destination)
+      if reverse
+        destination.add_neighbor(source)
+      else
+        source.add_neighbor(destination)
+      end
+    end
+
     def find_linked_libraries(target)
       frameworks_build_phase = target.build_phases.find { |build_phase| build_phase.isa.eql? 'PBXFrameworksBuildPhase' }
+
+      return [] unless frameworks_build_phase
+
       frameworks_build_phase.files.map { |file| file.display_name.gsub '.framework', '' }
     end
 
     def resolve(node, resolved, resolving = [])
       resolving << node
       node.neighbors.each do |neighbor|
-        unless resolved.include? neighbor
-          raise "Found dependency cycle: #{node.name} -> #{neighbor.name}" if resolving.include? neighbor
-          resolve(neighbor, resolved, resolving)
-        end
+        next if resolved.include? neighbor
+        raise "Found dependency cycle: #{node.name} -> #{neighbor.name}" if resolving.include? neighbor
+
+        resolve(neighbor, resolved, resolving)
       end
       resolved << node
       resolving.delete(node)

data/lib/pandan/parser.rb

@@ -1,19 +1,39 @@
+# frozen_string_literal: true
+
 require 'xcodeproj'
 
 module Pandan
   class Parser
-    attr_reader :workspace, :regex
+    attr_reader :workspace, :workspace_dir, :regex
 
     def initialize(workspace_path, filter)
+      @workspace_dir = File.dirname(workspace_path)
       @workspace = Xcodeproj::Workspace.new_from_xcworkspace(workspace_path)
       @regex = filter
       @regex ||= '.*' # Match everything
     end
 
     def all_targets
-      all_project_paths = workspace.file_references.map(&:path)
-      projects = all_project_paths.map { |project_path| Xcodeproj::Project.open(project_path) }
+      @projects ||= projects
       projects.flat_map(&:targets).select { |target| target.name =~ /#{regex}/ }
     end
+
+    def other_linker_flags
+      @projects ||= projects
+      ld_flags_info = {}
+      projects.flat_map(&:targets).each do |target|
+        ld_flags_info[target] = target.resolved_build_setting('OTHER_LDFLAGS', true)
+      end
+      ld_flags_info
+    end
+
+    private
+
+    def projects
+      all_project_paths = workspace.file_references.map(&:path)
+      all_project_paths.map do |project_path|
+        Xcodeproj::Project.open(File.expand_path(project_path, @workspace_dir))
+      end
+    end
   end
 end

data/lib/pandan/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Pandan
-  VERSION = '0.0.1'.freeze
+  VERSION = '0.0.3'
 end

data/lib/pandan/xcodeproj/user_interface.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Xcodeproj
   module UserInterface
     def self.warn(_message)

data/lib/pandan/xcworkspace.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'xcodeproj'
 
 module Pandan

data/pandan.gemspec

@@ -1,5 +1,6 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'pandan/version'
 
@@ -22,11 +23,13 @@ Gem::Specification.new do |spec|
   spec.executables   = 'pandan'
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '~> 1.14'
-  spec.add_development_dependency 'rake', '~> 10.0'
-  spec.add_development_dependency 'rspec', '~> 3.0'
+  spec.add_runtime_dependency 'claide', '~> 1.0'
+  spec.add_runtime_dependency 'ruby-graphviz', '~> 1.2'
+  spec.add_runtime_dependency 'xcodeproj', '~> 1.7'
 
-  spec.add_runtime_dependency 'claide', '~> 1.0.0'
-  spec.add_runtime_dependency 'xcodeproj', '~> 1.4.0'
-  spec.add_dependency 'ruby-graphviz', '~> 1.2'
+  spec.add_development_dependency 'bundler'
+  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rspec', '~> 3.0'
+  spec.add_development_dependency 'rspec_junit_formatter'
+  spec.add_development_dependency 'rubocop', '0.63'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pandan
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.3
 platform: ruby
 authors:
 - Renzo Crisóstomo
@@ -10,92 +10,120 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-27 00:00:00.000000000 Z
+date: 2020-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: claide
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.14'
-  type: :development
+        version: '1.0'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.14'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: ruby-graphviz
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
-  type: :development
+        version: '1.2'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '1.2'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: xcodeproj
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
-  type: :development
+        version: '1.7'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '1.7'
 - !ruby/object:Gem::Dependency
-  name: claide
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.0
-  type: :runtime
+        version: '0'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: xcodeproj
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.4.0
-  type: :runtime
+        version: '0'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.4.0
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: ruby-graphviz
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.2'
-  type: :runtime
+        version: '3.0'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rspec_junit_formatter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: '0.63'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: '0.63'
 description: CLI tool that outputs dependency information from a set of Xcode projects
   with targets thatdepend on each other, it does it by creating a (reverse) dependency
   graph and doing abreadth-first search.
@@ -111,7 +139,8 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
-- ".rubocop_todo.yml"
+- ".ruby-version"
+- ".travis.yml"
 - CODE_OF_CONDUCT.md
 - CONTRIBUTING.md
 - Gemfile
@@ -152,7 +181,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Retrieve Xcode dependency information with ease.

data/.rubocop_todo.yml

@@ -1,26 +0,0 @@
-# This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2017-03-23 19:05:08 +0100 using RuboCop version 0.47.1.
-# The point is for the user to remove these configuration records
-# one by one as the offenses are removed from the code base.
-# Note that changes in the inspected code, or installation of new
-# versions of RuboCop, may require this file to be generated again.
-
-# Offense count: 1
-Metrics/AbcSize:
-  Max: 21
-
-# Offense count: 10
-Style/Documentation:
-  Exclude:
-    - 'spec/**/*'
-    - 'test/**/*'
-    - 'lib/pandan.rb'
-    - 'lib/pandan/command.rb'
-    - 'lib/pandan/command/dependency_graph.rb'
-    - 'lib/pandan/command/query.rb'
-    - 'lib/pandan/command/targets.rb'
-    - 'lib/pandan/graph.rb'
-    - 'lib/pandan/parser.rb'
-    - 'lib/pandan/xcodeproj/user_interface.rb'
-    - 'lib/pandan/xcworkspace.rb'