pakyow-assets 1.0.3 → 1.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6d835e94d5a1dc792fb8e3f0f943780e6ae6e9d477742b4a03c470a0afa664d5
-  data.tar.gz: 6b9c1c1f17ad8a054d91c1e37940d6cefbc88f9d7e2a76439bd40edce7f0dd98
+  metadata.gz: d149e9ba386ff179a2e15792fb042aa087238628605d52f92a0c298891381f8e
+  data.tar.gz: d1242979e4fe6bc16ceed07f10b9421ee3699713cc53419189d99a9c604ecf69
 SHA512:
-  metadata.gz: 39a751d90c7d04f47e2c88be8dcce709c4a809caad1c62c5e7a0df2859e7ad17f314f723e9202d087426406d6f58aa0d01d29bd17aec83eeaf56de8e0a011ee7
-  data.tar.gz: 23252b5168d08e7cbc0c8d038e21219bd81e777b3f7d2fa5ee0826f0508ecbe3bf9073d111a35a73bc37052d6cea0d78a4fc60fa4aa30fb9f097a9ff33fa0620
+  metadata.gz: 2ed2ef9b92ac7418d89c5023d938e737ddee023351c4cdd000e2e02d23b27c5e231bcb166b0f715b314ac0dca2a21368dda6ef5aa0556754c11ef81ddf9d44cd
+  data.tar.gz: 36c0fc6775e41221c840f62a0493027259e78319ea76c03f3db1c3ed2269161b0d5528edd9b8d8f963ca448381aa49a3aee4f5ea169fc3172acc36501dcfd101

data/CHANGELOG.md

@@ -1,4 +1,13 @@
-# v1.0.3 (unreleased)
+# v1.0.4
+
+  * `fix` **Escape external asset uris so they do not fail on fetch.**
+
+    *Related links:*
+    - [Commit e2d7e2e][e2d7e2e]
+
+[e2d7e2e]: https://github.com/pakyow/pakyow/commit/e2d7e2ea2f36cb0a4c7073c17a692423b5cd1efe
+
+# v1.0.3
 
   * `fix` **Make `pakyow/assets` compatible with Ruby 2.7.0.**
     - External assets used the `http` gem, which is failing on Ruby 2.7.0-preview3. We replaced it

data/lib/pakyow/assets/external.rb

@@ -58,12 +58,12 @@ module Pakyow
         Support::CLI::Runner.new(message: "Fetching #{file_with_version}").run do |runner|
           Async do
             downloader = Downloader.new(
-              File.join(@config.externals.provider, package_with_version, file.to_s)
+              File.join(@config.externals.provider, CGI.escape(package_with_version), CGI.escape(file.to_s))
             ).perform
 
             FileUtils.mkdir_p(@config.externals.path)
 
-            fetched_version = downloader.path.to_s.split(@package.to_s, 2)[1].split("/", 2)[0].split("@", 2)[1]
+            fetched_version = CGI.unescape(downloader.path.to_s).split(@package.to_s, 2)[1].split("/", 2)[0].split("@", 2)[1]
             file_basename = File.basename(file.to_s, File.extname(file.to_s))
 
             local_path = if file && file_basename != name.to_s
@@ -109,20 +109,26 @@ module Pakyow
         private def get(path)
           @path = path
           internet = Async::HTTP::Internet.new
-          response = internet.get(build_uri(path))
-          @status = response.status
-
-          if response.status == 301 || response.status == 302
-            get(response.headers["location"])
-          elsif response.status >= 500
-            raise Failed, "Unexpected response status: #{response.status}"
-          else
-            @body = response.body.read
-          end
-        rescue SocketError => error
-          raise Failed.build(error)
+
+          Async do
+            begin
+              response = internet.get(build_uri(path))
+              @status = response.status
+
+              if response.status == 301 || response.status == 302
+                get(response.headers["location"])
+              elsif response.status >= 500
+                raise Failed, "Unexpected response status: #{response.status}"
+              else
+                @body = response.body.read
+              end
+            rescue SocketError => error
+              raise Failed.build(error)
+            ensure
+              response&.close
+            end
+          end.wait
         ensure
-          response&.close
           internet&.close
         end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pakyow-assets
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.0.4
 platform: ruby
 authors:
 - Bryan Powell
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-12-15 00:00:00.000000000 Z
+date: 2020-02-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pakyow-core
@@ -16,56 +16,56 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.3
+        version: 1.0.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.3
+        version: 1.0.4
 - !ruby/object:Gem::Dependency
   name: pakyow-presenter
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.3
+        version: 1.0.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.3
+        version: 1.0.4
 - !ruby/object:Gem::Dependency
   name: pakyow-routing
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.3
+        version: 1.0.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.3
+        version: 1.0.4
 - !ruby/object:Gem::Dependency
   name: pakyow-support
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.3
+        version: 1.0.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.3
+        version: 1.0.4
 - !ruby/object:Gem::Dependency
   name: async-http
   requirement: !ruby/object:Gem::Requirement