pager_duty-connection 2.2.0 → 2.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bdd585e0292f12142b4deb85820c0bf5f9155f6d7ec607bddf53bceaf131c732
-  data.tar.gz: 8b2f1784f52e3f4d70e135b2d70eff086de47a87b6e24b0079797211634617e3
+  metadata.gz: 38445eaf7e12ef537c66dca5286ec2e35cc5b76659c1df5d0972c11479f6bb56
+  data.tar.gz: bc79b9edd688055b9fb06631cc1573bfc4a148f5994397b39b5ffe617c771e18
 SHA512:
-  metadata.gz: 857ce1740ca088180a548594f38aa8c4ab0af2bb5b3fe002bda1febd00e6a5c83bc89a01803596d5e518562a19186e0fd6c2f868a30f89827d6b39f7ca1988cf
-  data.tar.gz: 7e3f96e3ea4d2eb17714eb2deb090316817cce70c3f2c77dd3cbfe306683ae462adf9e3ec34c5ac6a204523638ad005b7626b07751adf2224dc7ce78e5d20bb6
+  metadata.gz: 57d66bf01db4ae1de573d108609503e877d77be6d2b9f31cb8d02cf45ba8e61c73154db44ec658191466042ba60932f4bfb17e3a58e63d8c844c380d86beab2f
+  data.tar.gz: 6ca00d5ce74e0cd573c052db347f7eddf371d0e80949b526d711747b04e289f61c2bc5f5977dcc85d605aad0972ed0c9d4269c108892ca10b9fc737abe369cb6

data/lib/pager_duty/connection/version.rb

@@ -1,5 +1,5 @@
 module PagerDuty
   class Connection
-    VERSION = "2.2.0"
+    VERSION = "2.3.0"
   end
 end

data/lib/pager_duty/connection.rb

@@ -12,15 +12,39 @@ module PagerDuty
     API_VERSION = 2
     API_PREFIX = "https://api.pagerduty.com/"
 
-    class FileNotFoundError < RuntimeError
-    end
+    class FileNotFoundError < RuntimeError; end
+
+    class ApiError < RuntimeError; end
+
+    class RateLimitError < RuntimeError; end
+
+    class UnauthorizedError < RuntimeError; end
+
+    class ForbiddenError < RuntimeError; end
 
-    class ApiError < RuntimeError
+    class RaiseUnauthorizedOn401 < Faraday::Middleware
+      def call(env)
+        response = @app.call(env)
+        if response.status == 401
+          raise PagerDuty::Connection::UnauthorizedError, response.env[:url].to_s
+        else
+          response
+        end
+      end
     end
 
-    class RateLimitError < RuntimeError
+    class RaiseForbiddenOn403 < Faraday::Middleware
+      def call(env)
+        response = @app.call(env)
+        if response.status == 403
+          raise PagerDuty::Connection::ForbiddenError, response.env[:url].to_s
+        else
+          response
+        end
+      end
     end
 
+
     class RaiseFileNotFoundOn404 < Faraday::Middleware
       def call(env)
         response = @app.call env
@@ -40,10 +64,13 @@ module PagerDuty
           message = "Got HTTP #{response.status}: #{response.reason_phrase}\nFrom #{url}"
 
           if error = response.body
-            # TODO May Need to check error.errors too
-            message += "\n#{JSON.parse(error)}"
+            begin
+              # TODO May Need to check error.errors too
+              message += "\n#{JSON.parse(error)}"
+            rescue JSON::ParserError
+              message += "\n#{error}"
+            end
           end
-
           raise ApiError, message
         else
           response
@@ -67,9 +94,11 @@ module PagerDuty
       def call(env)
 
         body = env[:body]
-        TIME_KEYS.each do |key|
-          if body.has_key?(key)
-            body[key] = body[key].iso8601 if body[key].respond_to?(:iso8601)
+        unless body.nil?
+          TIME_KEYS.each do |key|
+            if body.has_key?(key)
+              body[key] = body[key].iso8601 if body[key].respond_to?(:iso8601)
+            end
           end
         end
 
@@ -180,12 +209,20 @@ module PagerDuty
         conn.use RaiseApiErrorOnNon200
         conn.use RaiseFileNotFoundOn404
         conn.use RaiseRateLimitOn429
+        conn.use RaiseForbiddenOn403
+        conn.use RaiseUnauthorizedOn401
 
         conn.adapter  Faraday.default_adapter
       end
     end
 
     def get(path, request = {})
+      # The run_request() method body argument defaults to {}, which is incorrect for GET requests
+      # https://github.com/technicalpickles/pager_duty-connection/issues/56
+      # NOTE: PagerDuty support discourages GET requests with bodies, but not throwing an ArgumentError to prevent breaking
+      #   corner-case implementations.
+      request[:body] = nil if !request[:body]
+
       # paginate anything being 'get'ed, because the offset/limit isn't intuitive
       request[:query_params] = {} if !request[:query_params]
       page = request[:query_params].fetch(:page, 1).to_i

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pager_duty-connection
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 2.3.0
 platform: ruby
 authors:
 - Josh Nichols
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-08-10 00:00:00.000000000 Z
+date: 2024-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -124,7 +124,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.12
+rubygems_version: 3.4.18
 signing_key:
 specification_version: 4
 summary: Written with the power of faraday, pager_duty-connection tries to be a simple