pageflow 14.2.1 → 14.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a833a9e170837eb7903aae1c60df6839492ed569a242f93b5219d5c2b5a8fb26
-  data.tar.gz: dc50d5b61edd236c2876eb272bcbf336ad2b3f137316dd79695011e3ae5535a8
+  metadata.gz: 2b1dccc2159c3f19167d16c7e852a0a0fd3ccd4a068f01e72c060ee2b60a5e1d
+  data.tar.gz: 6a60400394872ee81248de6d251d41637630c56bacded5c9fd8b79d1f205a80b
 SHA512:
-  metadata.gz: e0eed046eba35df4410a9cbfa19ac09ff9e85279343e4bfbf23ec727e618400b560b7731e748865893abf8196fd7a2d415a43041299e9c20b7b5444930c15f1a
-  data.tar.gz: 906d8e876cc93801a49852e74eeb56c87664f8aac7995c08220e6bb9bfaebf3612345b2ac47f7430a4ab9655c11b23cbde7588940417efbea66e8cb2c44c55f4
+  metadata.gz: 4efd4cea653cb672ef04f9bcb27cd3a0b15c64d9abb162eb9dc1d845eb350ec52f8dd4048c62638a9b48253897d1afe92e63ef9570f89419a6091c5c0df62339
+  data.tar.gz: 7e8bd3b5cd259a41c69c52799ce1679b008cb48bdde5db83c94843d8316a4cc8faaf11bff6948ca1a6789eb32669b44c70525cc9b58995335350f41faee04696

data/CHANGELOG.md

@@ -1,54 +1,26 @@
 # CHANGELOG
 
-### Version 14.2.1
-
-2019-07-04
-
-[Compare changes](https://github.com/codevise/pageflow/compare/v14.2.0...v14.2.1)
-
+### Version 14.3.0
+
+2019-07-24
+
+[Compare changes](https://github.com/codevise/pageflow/compare/14-2-stable...v14.3.0)
+
+- Add text position center option
+  ([#1183](https://github.com/codevise/pageflow/pull/1183))
+- Add `failed?` method to file models
+  ([#1191](https://github.com/codevise/pageflow/pull/1191))
+- Structured data improvements
+  ([#1189](https://github.com/codevise/pageflow/pull/1189))
+- Remove margin right of links in page text
+  ([#1188](https://github.com/codevise/pageflow/pull/1188))
+- Add theme option for alternative content link icon
+  ([#1184](https://github.com/codevise/pageflow/pull/1184))
+- Support CDN that redirects to HTTPS
+  ([#1190](https://github.com/codevise/pageflow/pull/1190))
 - Bug fix: Prevent hiding links in credits menu
-  ([#1185](https://github.com/codevise/pageflow/pull/1185))
-
-### Version 14.2.0
-
-2019-06-18
-
-[Compare changes](https://github.com/codevise/pageflow/compare/14-1-stable...v14.2.0)
-
-#### Published Entries
-
-- Bug fix: Prevent duplicate network requests for video preload
-  ([#1173](https://github.com/codevise/pageflow/pull/1173))
-- Bug fix: Fix hide text on swipe
-  ([#1172](https://github.com/codevise/pageflow/pull/1172))
-
-#### Editor
-
-- Add plugin API to add common page config tabs
-  ([#1169](https://github.com/codevise/pageflow/pull/1169))
-- Add page type specific configuration editor tab translations
-  ([#1168](https://github.com/codevise/pageflow/pull/1168))
-- Make TabsView tabs scrollable
-  ([#1164](https://github.com/codevise/pageflow/pull/1164),
-   [#1174](https://github.com/codevise/pageflow/pull/1174),
-   [#1175](https://github.com/codevise/pageflow/pull/1175))
-- Add JSONInputView
-  ([#1167](https://github.com/codevise/pageflow/pull/1167))
-- Bug fix: Prevent creating storyline twice
-  ([#1171](https://github.com/codevise/pageflow/pull/1171))
-- Bug fix: Ensure remove link button is show in text editor
-  ([#1160](https://github.com/codevise/pageflow/pull/1160),
-   [#1161](https://github.com/codevise/pageflow/pull/1161))
-
-#### Internal
-
-- Fix Capybara tests in Chrome 75
-  ([#1176](https://github.com/codevise/pageflow/pull/1176))
-- Update bundler in Travis build
-  ([#1166](https://github.com/codevise/pageflow/pull/1166))
-- Fix sassc-rails development dependency
-  ([#1165](https://github.com/codevise/pageflow/pull/1165))
+  ([#1182](https://github.com/codevise/pageflow/pull/1182))
 
 See
-[14-1-stable branch](https://github.com/codevise/pageflow/blob/14-1-stable/CHANGELOG.md)
+[14-2-stable branch](https://github.com/codevise/pageflow/blob/14-2-stable/CHANGELOG.md)
 for previous changes.

data/app/assets/javascripts/pageflow/dist/react-client.js

@@ -30886,7 +30886,7 @@ pageflow = typeof pageflow === "object" ? pageflow : {}; pageflow["react"] =
 
 	  return React.createElement(
 	    _media.Page,
-	    { className: 'audio_page',
+	    { className: 'audio_page supports_text_position_center',
 	      page: props.page,
 	      file: props.audioFile,
 	      playerState: props.playerState,
@@ -30967,7 +30967,7 @@ pageflow = typeof pageflow === "object" ? pageflow : {}; pageflow["react"] =
 
 	  return React.createElement(
 	    _components.PageWrapper,
-	    null,
+	    { className: 'supports_text_position_center' },
 	    React.createElement(_media.PageBackground, { page: page }),
 	    React.createElement(
 	      _components.PageForeground,
@@ -31031,7 +31031,7 @@ pageflow = typeof pageflow === "object" ? pageflow : {}; pageflow["react"] =
 	function VideoPage(props) {
 	  return React.createElement(
 	    _media.Page,
-	    { className: 'video_page',
+	    { className: 'video_page supports_text_position_center',
 	      page: props.page,
 	      file: props.videoFile,
 	      qualities: qualities,

data/app/assets/javascripts/pageflow/dist/react-server.js

@@ -30864,7 +30864,7 @@ pageflow = typeof pageflow === "object" ? pageflow : {}; pageflow["react"] =
 
 	  return React.createElement(
 	    _media.Page,
-	    { className: 'audio_page',
+	    { className: 'audio_page supports_text_position_center',
 	      page: props.page,
 	      file: props.audioFile,
 	      playerState: props.playerState,
@@ -30945,7 +30945,7 @@ pageflow = typeof pageflow === "object" ? pageflow : {}; pageflow["react"] =
 
 	  return React.createElement(
 	    _components.PageWrapper,
-	    null,
+	    { className: 'supports_text_position_center' },
 	    React.createElement(_media.PageBackground, { page: page }),
 	    React.createElement(
 	      _components.PageForeground,
@@ -31009,7 +31009,7 @@ pageflow = typeof pageflow === "object" ? pageflow : {}; pageflow["react"] =
 	function VideoPage(props) {
 	  return React.createElement(
 	    _media.Page,
-	    { className: 'video_page',
+	    { className: 'video_page supports_text_position_center',
 	      page: props.page,
 	      file: props.videoFile,
 	      qualities: qualities,

data/app/assets/javascripts/pageflow/editor/models/page.js

@@ -104,7 +104,8 @@ function conditionMet(condition, configuration) {
 }
 
 pageflow.Page.linkedPagesLayouts = ['default', 'hero_top_left', 'hero_top_right'];
-pageflow.Page.textPositions = ['left', 'right'];
+pageflow.Page.textPositions = ['left', 'center', 'right'];
+pageflow.Page.textPositionsWithoutCenterOption = ['left', 'right'];
 
 pageflow.Page.scrollIndicatorModes = ['all', 'only_back', 'only_next', 'non'];
 pageflow.Page.scrollIndicatorOrientations = ['vertical', 'horizontal'];

data/app/assets/javascripts/pageflow/editor/views/configuration_editors/audio.js

@@ -1,7 +1,7 @@
 pageflow.ConfigurationEditorView.register('audio', {
   configure: function() {
     this.tab('general', function() {
-      this.group('general');
+      this.group('general', {supportsTextPositionCenter: true});
 
       this.input('additional_title', pageflow.TextInputView);
       this.input('additional_description', pageflow.TextAreaInputView, {size: 'short'});

data/app/assets/javascripts/pageflow/editor/views/configuration_editors/background_image.js

@@ -1,7 +1,7 @@
 pageflow.ConfigurationEditorView.register('background_image', {
   configure: function() {
     this.tab('general', function() {
-      this.group('general');
+      this.group('general', {supportsTextPositionCenter: true});
     });
 
     this.tab('files', function() {

data/app/assets/javascripts/pageflow/editor/views/configuration_editors/groups/general.js

@@ -1,4 +1,4 @@
-pageflow.ConfigurationEditorTabView.groups.define('general', function() {
+pageflow.ConfigurationEditorTabView.groups.define('general', function(options) {
   this.input('title', pageflow.TextInputView, {required: true, maxLength: 5000});
   this.input('hide_title', pageflow.CheckBoxInputView);
   this.input('tagline', pageflow.TextInputView, {maxLength: 5000});
@@ -7,7 +7,11 @@ pageflow.ConfigurationEditorTabView.groups.define('general', function() {
     fragmentLinkInputView: pageflow.PageLinkInputView,
     enableLists: true
   });
-  this.input('text_position', pageflow.SelectInputView, {values: pageflow.Page.textPositions});
+  this.input('text_position', pageflow.SelectInputView, {
+    values: options.supportsTextPositionCenter ?
+            pageflow.Page.textPositions :
+            pageflow.Page.textPositionsWithoutCenterOption
+  });
   this.input('gradient_opacity', pageflow.SliderInputView);
   this.input('invert', pageflow.CheckBoxInputView);
 });

data/app/assets/javascripts/pageflow/editor/views/configuration_editors/video.js

@@ -1,7 +1,7 @@
 pageflow.ConfigurationEditorView.register('video', {
   configure: function() {
     this.tab('general', function() {
-      this.group('general');
+      this.group('general', {supportsTextPositionCenter: true});
 
       this.input('additional_title', pageflow.TextInputView);
       this.input('additional_description', pageflow.TextAreaInputView, {size: 'short'});

data/app/assets/javascripts/pageflow/ui/views/inputs/select_input_view.js

@@ -211,8 +211,11 @@ pageflow.SelectInputView = Backbone.Marionette.ItemView.extend({
 
   load: function() {
     if (!this.isClosed) {
-      if (this.model.has(this.options.propertyName)) {
-        this.ui.select.val(this.model.get(this.options.propertyName));
+      var value = this.model.get(this.options.propertyName);
+
+      if (this.model.has(this.options.propertyName) &&
+          this.ui.select.find('option[value="' + value +'"]').length) {
+        this.ui.select.val(value);
       }
       else {
         this.ui.select.val(this.ui.select.find('option:first').val());

data/app/assets/stylesheets/pageflow/themes/default/anchors.scss

@@ -2,6 +2,8 @@
 /// color by default.
 $anchor-icon-color: null !default;
 
+$anchor-external-links-icon: false !default;
+
 %anchor {
   @include fa-caret-right-icon;
 
@@ -31,4 +33,16 @@ $anchor-icon-color: null !default;
     height: 12px;
     color: $anchor-icon-color;
   }
+
+  @if $anchor-external-links-icon {
+    &[target="_blank"] {
+      @include fa-external-link-icon;
+
+      &:before {
+        width: 18px;
+        font-size: 12px;
+        font-weight: bold;
+      }
+    }
+  }
 }

data/app/assets/stylesheets/pageflow/themes/default/page/anchors.scss

@@ -16,6 +16,7 @@ $page-anchor-typography: () !default;
     @extend %anchor;
     color: $page-anchor-color;
     pointer-events: all;
+    margin-right: 0;
     @include typography($page-anchor-typography)
   }
 

data/app/assets/stylesheets/pageflow/themes/default/page/line_lengths.scss

@@ -10,6 +10,9 @@ $page-header-title-max-width: 700px !default;
 /// Maximal width for right positioned headlines and content text.
 $page-content-position-right-max-width: 500px !default;
 
+/// Maximal width for center positioned headlines and content text.
+$page-content-position-center-max-width: $page-content-max-width !default;
+
 /// Min width the header title is supposed to have in a split layout
 /// (i.e. when the page has two columns and some kind of embed is
 /// displayed on the right) with text positioned on the left.
@@ -79,7 +82,12 @@ $page-content-width: 60% !default;
     }
   }
 
-  &.text_position_right {
+  // Not all page types support text position "center" so far. Make
+  // sure styles only apply to those that explicitly opt in by setting
+  // a class on their wrapper element.
+
+  &.text_position_right,
+  &.text_position_center .supports_text_position_center {
     .page_header-subtitle,
     .page_header-title,
     .page_header-tagline,
@@ -103,4 +111,14 @@ $page-content-width: 60% !default;
       }
     }
   }
+
+  &.text_position_center .supports_text_position_center {
+    .page_header-subtitle,
+    .page_header-title,
+    .page_header-tagline,
+    .paragraph {
+      @include margin-end(auto);
+      max-width: $page-content-position-center-max-width;
+    }
+  }
 }

data/app/assets/stylesheets/pageflow/themes/default/page/shadow.scss

@@ -11,17 +11,29 @@ $page-shadow-inverted-color: #fff !default;
     @include shadow-start($page-shadow-color);
   }
 
+  &.text_position_right .shadow {
+    @include shadow-end($page-shadow-color);
+  }
+
+  // Not all page types support text position "center" so far. Make
+  // sure styles only apply to those that explicitly opt in by setting
+  // a class on their wrapper element.
+
+  &.text_position_center .supports_text_position_center .shadow {
+    background: transparentize($page-shadow-color, 0.3);
+  }
+
   &.invert {
     .shadow {
       @include shadow-start($page-shadow-inverted-color);
     }
-  }
 
-  &.text_position_right .shadow {
-    @include shadow-end($page-shadow-color);
-  }
+    &.text_position_right .shadow {
+      @include shadow-end($page-shadow-inverted-color);
+    }
 
-  &.invert.text_position_right .shadow {
-    @include shadow-end($page-shadow-inverted-color);
+    &.text_position_center .supports_text_position_center .shadow {
+      background: transparentize($page-shadow-inverted-color, 0.3);
+    }
   }
 }

data/app/helpers/pageflow/entry_json_seed_helper.rb

@@ -15,7 +15,7 @@ module Pageflow
       {
         title: entry.title,
         slug: entry.slug,
-        published_at: entry.published_at.try(:iso8601, 0)
+        published_at: entry.published_at.try(:utc).try(:iso8601, 0)
       }
     end
 

data/app/helpers/pageflow/social_share_helper.rb

@@ -72,7 +72,7 @@ module Pageflow
     end
 
     def social_share_normalize_protocol(url)
-      url.gsub(/^(\/\/|https:\/\/)/, 'http://')
+      url.gsub(%r{^//}, 'https://')
     end
 
     private

data/app/jobs/pageflow/poll_zencoder_job.rb

@@ -41,8 +41,8 @@ module Pageflow
 
     def fetch_thumbnail(file)
       return unless file.respond_to?(:thumbnail)
-      file.thumbnail = URI.parse(file.zencoder_thumbnail.url(default_protocol: 'http'))
-      file.poster = URI.parse(file.zencoder_poster.url(default_protocol: 'http'))
+      file.thumbnail = URI.parse(file.zencoder_thumbnail.url(default_protocol: 'https'))
+      file.poster = URI.parse(file.zencoder_poster.url(default_protocol: 'https'))
     rescue OpenURI::HTTPError
       throw(:halt, :pending)
     end

data/app/models/concerns/pageflow/hosted_file.rb

@@ -66,6 +66,10 @@ module Pageflow
       attachment.present?
     end
 
+    def failed?
+      uploading_failed?
+    end
+
     def basename
       File.basename(attachment.original_filename, '.*')
     end

data/app/state_machines/pageflow/encoded_file_state_machine.rb

@@ -78,5 +78,11 @@ module Pageflow
     def ready?
       encoded?
     end
+
+    def failed?
+      super ||
+        fetching_meta_data_failed? ||
+        encoding_failed?
+    end
   end
 end

data/app/state_machines/pageflow/processed_file_state_machine.rb

@@ -34,5 +34,9 @@ module Pageflow
     def ready?
       processed?
     end
+
+    def failed?
+      super || processing_failed?
+    end
   end
 end

data/app/views/pageflow/audio_files/_audio_file.json.jbuilder

@@ -1,2 +1,2 @@
 json.call(audio_file, :duration_in_ms)
-json.created_at audio_file.created_at.try(:iso8601, 0)
+json.created_at audio_file.created_at.try(:utc).try(:iso8601, 0)

data/app/views/pageflow/image_files/_image_file.json.jbuilder

@@ -1,2 +1,2 @@
 json.call(image_file, :width, :height)
-json.created_at image_file.created_at.try(:iso8601, 0)
+json.created_at image_file.created_at.try(:utc).try(:iso8601, 0)

data/app/views/pageflow/structured_data/_entry.json.jbuilder

@@ -4,21 +4,22 @@ json.set! '@context', 'http://schema.org'
 json.set! '@type', 'Article'
 
 json.headline pretty_entry_title(entry)
+json.url structured_data_normalize_protocol(social_share_entry_url(entry))
 json.description social_share_entry_description(entry)
 
-json.keywords(meta_data[:keywords]) if meta_data[:keywords].present?
+json.keywords(meta_data[:keywords].split(',').map(&:squish)) if meta_data[:keywords].present?
 
 if meta_data[:author].present?
   json.author do
     json.set! '@type', 'Organization'
-    json.name meta_data[:author]
+    json.name meta_data[:author].split(',').map(&:squish)
   end
 end
 
 if meta_data[:publisher].present?
   json.publisher do
     json.set! '@type', 'Organization'
-    json.name meta_data[:publisher]
+    json.name meta_data[:publisher].split(',').map(&:squish)
     json.logo do
       json.set! '@type', 'ImageObject'
       json.url structured_data_normalize_protocol(asset_url(entry.theme.print_logo_path))
@@ -26,8 +27,10 @@ if meta_data[:publisher].present?
   end
 end
 
-json.date_published entry.first_published_at.try(:iso8601, 0)
-json.date_modified entry.published_at.try(:iso8601, 0)
+json.date_published entry.first_published_at.try(:utc).try(:iso8601, 0)
+json.date_modified entry.published_at.try(:utc).try(:iso8601, 0)
+
+json.article_section 'longform'
 
 json.main_entity_of_page do
   json.set! '@type', 'WebPage'
@@ -43,4 +46,8 @@ if thumbnail_file.present?
     json.width 560
     json.height 315
   end
+
+  json.thumbnail_url structured_data_normalize_protocol(
+    thumbnail_file.thumbnail_url(:thumbnail_large)
+  )
 end

data/app/views/pageflow/video_files/_video_file.json.jbuilder

@@ -1,3 +1,3 @@
 json.call(video_file, :width, :height, :duration_in_ms)
-json.created_at video_file.created_at.try(:iso8601, 0)
+json.created_at video_file.created_at.try(:utc).try(:iso8601, 0)
 json.variants video_file.present_outputs + [:poster_medium, :poster_large, :poster_ultra, :print]

data/config/locales/de.yml

@@ -462,6 +462,7 @@ de:
           internal_links: Seiten-Verweise
           video: Video
         text_position:
+          center: Mittig
           left: Links
           right: Rechts
         transition:

data/config/locales/en.yml

@@ -462,6 +462,7 @@ en:
           internal_links: Internal Links
           video: Video
         text_position:
+          center: Center
           left: Left
           right: Right
         transition:

data/lib/pageflow/version.rb

@@ -1,3 +1,3 @@
 module Pageflow
-  VERSION = '14.2.1'.freeze
+  VERSION = '14.3.0'.freeze
 end

data/spec/factories/audio_files.rb

@@ -48,6 +48,10 @@ module Pageflow
         state { 'waiting_for_confirmation' }
       end
 
+      trait :fetching_meta_data_failed do
+        state { 'fetching_meta_data_failed' }
+      end
+
       trait :encoding_failed do
         state { 'encoding_failed' }
       end

data/spec/factories/image_files.rb

@@ -40,6 +40,10 @@ module Pageflow
         state { 'uploaded' }
       end
 
+      trait :uploading_failed do
+        state { 'uploading_failed' }
+      end
+
       trait :processing do
         state { 'processing' }
       end

data/spec/factories/video_files.rb

@@ -48,6 +48,10 @@ module Pageflow
         state { 'waiting_for_confirmation' }
       end
 
+      trait :fetching_meta_data_failed do
+        state { 'fetching_meta_data_failed' }
+      end
+
       trait :encoding_failed do
         state { 'encoding_failed' }
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pageflow
 version: !ruby/object:Gem::Version
-  version: 14.2.1
+  version: 14.3.0
 platform: ruby
 authors:
 - Codevise Solutions Ltd
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-04 00:00:00.000000000 Z
+date: 2019-07-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails