pageflow-support 15.3.0 → 15.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f2e04dfc605645cbd70eb90968696b92db6715e4c61ab15f413447b34b1b7293
-  data.tar.gz: 9836b64a2fa793fc226da7a64dd75f338bfaef26b24cabc8daf040269daf0b89
+  metadata.gz: ff6e2a042c492b5d356ab03b25507bee3ef47042a3b22f6509b1634cd2363302
+  data.tar.gz: 1e50597d286d416c70c0b5b2cf2e79b7fc2a060dc06d46139324d56ab7d1924b
 SHA512:
-  metadata.gz: 2b8a45ff520268b4bab4753d3209818b38f35b4c3f419bce8c431a2221f50125263600ca8f7932444694a5f526773e1633b1b562cb749de9f65f9eaadbd40b2f
-  data.tar.gz: 3ae5cf4df43006c53f97faffaf317cbdfcf6bf85210b9a4a888bababc263abad56fa87e13ebc5bfe20857e78ba73a9e1a5c52cd0422bf199c488220545b43ca5
+  metadata.gz: 973979be6e1ca5dfb259083919c52494b4f59d711367bba48cfed2926744aabc8b978d5a8b91a8a2e61dda446eef8699866122edf01dcc7e284c7f221fe23dd9
+  data.tar.gz: 3a109fa870dc91d1267fb8e88c0887def41b5b7336043d82ab2b31a96bde1ad34279c427c01dff37989d8f72cdfcf5e3d992235225b308f6c993dc40cf565df2

data/pageflow/dummy/app.rb

@@ -1,4 +1,5 @@
 require 'pageflow/version'
+require 'pageflow/dummy/exit_on_failure_patch'
 
 module Pageflow
   module Dummy
@@ -10,7 +11,8 @@ module Pageflow
           puts("Dummy directory #{directory} exists.")
         else
           system("bundle exec rails new #{directory} " \
-                 "--template #{template_path} #{rails_new_options}")
+                 "--template #{template_path} #{rails_new_options}") ||
+            raise('Error generating dummy app.')
         end
 
         require(File.join(ENV['RAILS_ROOT'], 'config', 'environment'))

data/pageflow/dummy/exit_on_failure_patch.rb

@@ -0,0 +1,25 @@
+require 'rails/generators'
+
+# Thor exits with 0, when an error occurs. This behavior is deprecated
+# in 1.0 [1], but has not yet changed. As a result the dummy app
+# generation is not aborted and tests fail due to confusing follow up
+# errors. Rails provides an `abort_on_failure` option for `rake` and
+# `generate` actions [2], but it needs to be added to each such
+# action. In particular, generating the dummy app invokes other
+# generators, which we do not have control over.
+#
+# To work around this problem, we override the default behavior for
+# all generators and make them fail loudly.
+#
+# [1] https://github.com/erikhuda/thor/blob/master/CHANGELOG.md#100
+# [2] https://github.com/rails/rails/pull/34420/
+
+module Rails
+  module Generators
+    class Base
+      def self.exit_on_failure?
+        true
+      end
+    end
+  end
+end

data/pageflow/support/config/paperclip.rb

@@ -1,13 +1,21 @@
 RSpec.configure do |config|
-  config.before(:each) do
+  config.before(:all) do
     Dir.glob(Rails.root.join('public', 'system', 's3', '*')).each do |f|
       FileUtils.rm_r(f)
     end
   end
 
-  config.before(:each, stub_paperclip: true) do
-    allow_any_instance_of(Paperclip::Attachment).to receive(:post_process)
-    allow(Paperclip).to receive(:run).and_return('100x100')
+  config.after(:each, unstub_paperclip: true) do
+    Dir.glob(Rails.root.join('public', 'system', 's3', '*')).each do |f|
+      FileUtils.rm_r(f)
+    end
+  end
+
+  config.before(:each) do |example|
+    unless example.metadata[:unstub_paperclip] || example.metadata[:js]
+      allow_any_instance_of(Paperclip::Attachment).to receive(:post_process)
+      allow(Paperclip).to receive(:run).and_return('100x100')
+    end
   end
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pageflow-support
 version: !ruby/object:Gem::Version
-  version: 15.3.0
+  version: 15.4.0
 platform: ruby
 authors:
 - Codevise Solutions Ltd
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-08-21 00:00:00.000000000 Z
+date: 2021-01-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pageflow
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 15.3.0
+        version: 15.4.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 15.3.0
+        version: 15.4.0
 - !ruby/object:Gem::Dependency
   name: mysql2
   requirement: !ruby/object:Gem::Requirement
@@ -201,6 +201,7 @@ files:
 - pageflow/dummy.rb
 - pageflow/dummy/app.rb
 - pageflow/dummy/config/pageflow.rb
+- pageflow/dummy/exit_on_failure_patch.rb
 - pageflow/dummy/rails_template.rb
 - pageflow/dummy/templates/add_custom_fields.rb
 - pageflow/dummy/templates/create_test_multi_attachment_file.rb