pageflow-external-links 2.2.0 → 2.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1238f8a7790db04f3106262157e7de423636835b8b54d51dffb372323d95e907
-  data.tar.gz: 7fffd9d6757b2f808f839cf7bfa438228c7895293e10c0df6f62e1a218461a4d
+  metadata.gz: d667192454267997136db2359354bf6736861c4b663b4b042f3902db5be31bd0
+  data.tar.gz: 053ceeea26282f5fe1e7777e6439f24f57a92ce094ae778e6221586eedab8790
 SHA512:
-  metadata.gz: 854344f01b6c50908abe8f192a592e941481469a7dd71beb7963b59ba5f12bf27444e28c6343a1d34d5e5ed885b2d783c23d7a2cbe2a4a1aeaa6a67b5f738d8d
-  data.tar.gz: 27cd62ab68a17527325a107d66f29d5448cdbf296d71c15332143e982db211c1a7f28b34daa47218e8f6e3c0180e31a8b6033d638c199db4e3464b55e9573c78
+  metadata.gz: 14bdc1df07ec6053138e40302c8b295a8716f3af48db2b82eec89c2767e2e1d8cef8ea2d8d8a002616c17784789c117a5a5379120e86a90b68bf5dd8de9a7329
+  data.tar.gz: 5aa73cf35b0ed78de23ae36d23eb877c829291b9194c4a8014f06d5350651a4641c7727bbbbbe53ca3930a3eeb6e15a849c29f5f136dddbf8abb072459078e41

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # CHANGELOG
 
+### Version 2.2.1
+
+2020-02-11
+
+[Compare changes](https://github.com/codevise/pageflow-external-links/compare/v2.2.0...v2.2.1)
+
+- Prevent error with missing site urls in Pageflow 15.1
+  ([#45](https://github.com/codevise/pageflow-external-links/pull/45))
+
 ### Version 2.2.0
 
 2019-11-04

data/Gemfile

@@ -2,3 +2,6 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in chart.gemspec
 gemspec
+
+# Give a hint to Bundler to prevent endless loop
+gem 'rails', '~> 5.2.0'

data/Gemfile.ci

@@ -3,3 +3,6 @@ source 'https://rubygems.org'
 gemspec
 
 gem 'pageflow-theme-doc-publisher', git: 'https://github.com/tf/pageflow-theme-doc-publisher'
+
+# Give a hint to Bundler to prevent endless loop
+gem 'rails', '~> 5.2.0'

data/app/views/pageflow/external_links/sites/_site.html.erb

@@ -1,4 +1,4 @@
-<%= link_to(site.url,
+<%= link_to(site.url || '',
             class: external_links_site_css_class(site),
             target: site.open_in_new_tab? ? '_blank' : nil) do %>
 

data/lib/generators/pageflow_external_links/install/install_generator.rb

@@ -1,5 +1,30 @@
 module PageflowExternalLinks
-  class InstallGenerator < Pageflow::PageTypeInstallGenerator
+  class InstallGenerator < Rails::Generators::Base
+    desc 'Install the Pageflow plugin and the necessary migrations.'
+
+    def register_plugin
+      inject_into_file('config/initializers/pageflow.rb',
+                       after: "Pageflow.configure do |config|\n") do
+
+        "  config.plugin(Pageflow::#{engine_name_suffix.camelize}.plugin)\n"
+      end
+    end
+
+    def mount_engine
+      route("mount #{engine.name}, at: '/#{engine_name_suffix}'\n")
+    end
+
+    def install_migrations
+      rake "pageflow_#{engine_name_suffix}:install:migrations"
+      rake 'pageflow_external_links:install:migrations'
+    end
+
+    private
+
+    def engine_name_suffix
+      engine.engine_name.gsub(/^pageflow_/, '')
+    end
+
     def engine
       Pageflow::ExternalLinks::Engine
     end

data/lib/pageflow/external_links/version.rb

@@ -1,5 +1,5 @@
 module Pageflow
   module ExternalLinks
-    VERSION = '2.2.0'.freeze
+    VERSION = '2.2.1'.freeze
   end
 end

data/spec/integration/page_type_spec.rb

@@ -2,3 +2,49 @@ require 'spec_helper'
 require 'pageflow/lint'
 
 Pageflow::Lint.page_type(Pageflow::ExternalLinks.page_type)
+
+module Pageflow
+  module ExternalLinks
+    describe 'built in video page type', type: :helper do
+      include RenderPageTestHelper
+
+      it 'renders links to referenced sites' do
+        revision = FactoryBot.create(:revision, :published)
+        Site.create!(revision: revision,
+                     perma_id: 10,
+                     url: 'https://example.com',
+                     title: 'Example')
+
+        page = FactoryBot.create(:page,
+                                 template: 'external_links',
+                                 revision: revision,
+                                 configuration: {
+                                   linked_external_site_perma_ids: [10]
+                                 })
+
+        html = render_page(page)
+
+        expect(html).to have_selector('.link-title', text: 'Example')
+      end
+
+      it 'can handle sites with missing url' do
+        revision = FactoryBot.create(:revision, :published)
+        Site.create!(revision: revision,
+                     perma_id: 10,
+                     url: nil,
+                     title: 'Example')
+
+        page = FactoryBot.create(:page,
+                                 template: 'external_links',
+                                 revision: revision,
+                                 configuration: {
+                                   linked_external_site_perma_ids: [10]
+                                 })
+
+        html = render_page(page)
+
+        expect(html).to have_selector('.link-title', text: 'Example')
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pageflow-external-links
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 2.2.1
 platform: ruby
 authors:
 - Codevise Solutions Ltd
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-04 00:00:00.000000000 Z
+date: 2020-02-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pageflow