pageflow-chart 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 468db56cbd4ad18e357d70438b2b0fef4f4dcf78ff3bce4b8a3b807db2823392
-  data.tar.gz: 5052ee6ccb0760023ec96bb39db2d54f0e62e1897ac976a61afa298680897670
+  metadata.gz: 3edeadab75c938eec7fbdaeedef925d5aa79dfd758072d822f66e8f730850651
+  data.tar.gz: e9de614880042bebf4b941f70664ae0b0f7bb5a653eee29fc695f5b3f71bfdce
 SHA512:
-  metadata.gz: c1ffd7a740081216f29f415f8b1945b1ef6ecccc5049e9711dd701c0bbe646fae153937248eb5051b5406be4730233fba09edcba622cc3a5577b9ca0938a3ddb
-  data.tar.gz: 08ece544c861bbb9c4b3dc0d0fa4cb2cb9fcff824feb96ffee9541a98fb63d2c45199a7fd677c6428164ad89b07f19ceed2981e25980ea7de8bdf3c47b68b91c
+  metadata.gz: 325a81fb99b6786a72fb613c496507a62d6fa37fa8a53d342d58b85c68a246791c354b00866ae51835b6930afa087d8306a37923c5ec8f682c471878cc4dad5c
+  data.tar.gz: 14dbc39347ffdac89c0e7d5579f8ba299bc0508507de9146cccd9fc992ddd2d8d29f29101c76134cc2054b43660d07c75473d85be8e2c31de1fb5b45ef7ede67

data/CHANGELOG.md

@@ -1,18 +1,16 @@
 # CHANGELOG
 
-### Version 1.1.0
+### Version 1.2.0
 
-2017-11-08
+2018-07-30
 
-[Compare changes](https://github.com/codevise/pageflow-chart/compare/1-0-stable...v1.1.0)
+[Compare changes](https://github.com/codevise/pageflow-chart/compare/1-1-stable...v1.2.0)
 
-- Require pageflow 12.1 for split layout handling and make split
-  layout compatible with adjustable title max-widths
-  ([#31](https://github.com/codevise/pageflow-chart/pull/31),
-   [#41](https://github.com/codevise/pageflow-chart/pull/41))
-- Ignore Openuri::HttpError when downloading
-  ([#40](https://github.com/codevise/pageflow-chart/pull/40))
+- Add support for right to left layout
+  ([#44](https://github.com/codevise/pageflow-chart/pull/44))
+- Use split layout utils provided by pageflow 12.2
+  ([#42](https://github.com/codevise/pageflow-chart/pull/42))
 
 See
-[1-0-stable branch](https://github.com/codevise/pageflow-chart/blob/1-0-stable/CHANGELOG.md)
+[1-1-stable branch](https://github.com/codevise/pageflow-chart/blob/1-1-stable/CHANGELOG.md)
 for previous changes.

data/Gemfile

@@ -4,5 +4,3 @@ source 'https://rubygems.org'
 gemspec
 
 gem 'state_machine', git: 'https://github.com/codevise/state_machine.git'
-
-gem 'pageflow', git: 'https://github.com/codevise/pageflow'

data/app/assets/javascripts/pageflow/chart/page_type.js

@@ -25,7 +25,7 @@ pageflow.react.registerPageTypeWithDefaultBackground('chart', {
 
     pageElement.toggleClass('page-with_split_layout', !fullWidth);
 
-    var splitLayout = this.wideEnoughForSplitLayout(pageElement) && !fullWidth;
+    var splitLayout = pageflow.pageSplitLayout.pageIsWideEnough(pageElement) && !fullWidth;
 
     iframeWrapper.toggleClass('widescreened', splitLayout);
 
@@ -37,21 +37,6 @@ pageflow.react.registerPageTypeWithDefaultBackground('chart', {
     }
   },
 
-  wideEnoughForSplitLayout: function(pageElement) {
-    var pageTitle = pageElement.find('.page_header .title');
-
-    var pageTitleClientRect = pageTitle[0].getBoundingClientRect();
-    var pageClientRect = pageElement[0].getBoundingClientRect();
-
-    var spaceRightFromTitle = pageClientRect.right - pageTitleClientRect.right;
-    var spaceLeftFromTitle = pageTitleClientRect.left - pageClientRect.left;
-    var leftPositionedEmbedWidth = pageClientRect.width * 0.51;
-    var rightPositionedEmbedWidth = pageClientRect.width * 0.55;
-
-    return (spaceRightFromTitle >= rightPositionedEmbedWidth ||
-            spaceLeftFromTitle >= leftPositionedEmbedWidth);
-  },
-
   customizeLayout: function(pageElement, configuration) {
     var that = this;
     var iframe = pageElement.find('iframe');

data/app/assets/stylesheets/pageflow/chart.scss

@@ -27,7 +27,7 @@
       width: 45%;
       height: 95%;
       max-height: 600px;
-      right: 10%;
+      @include position-end(10%);
       margin-top: 16%;
       margin-bottom: 0;
       z-index: 1;
@@ -76,8 +76,8 @@
     }
 
     .text_position_right &.widescreened {
-      right: auto;
-      left: 8%;
+      @include position-end(auto);
+      @include position-start(8%);
       width: 42%;
     }
 

data/chart.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = '~> 2.1'
 
-  spec.add_runtime_dependency 'pageflow', '~> 12.1'
+  spec.add_runtime_dependency 'pageflow', '~> 12.2.x'
   spec.add_runtime_dependency 'nokogiri', '~> 1.0'
   spec.add_runtime_dependency 'paperclip', '~> 4.2'
   spec.add_runtime_dependency 'state_machine', '~> 1.2'

data/lib/pageflow/chart/version.rb

@@ -1,5 +1,5 @@
 module Pageflow
   module Chart
-    VERSION = '1.1.0'.freeze
+    VERSION = '1.2.0'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pageflow-chart
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Codevise Solutions Ltd
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-08 00:00:00.000000000 Z
+date: 2018-07-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pageflow
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.1'
+        version: 12.2.x
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.1'
+        version: 12.2.x
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -338,7 +338,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.0
+rubygems_version: 2.7.5
 signing_key: 
 specification_version: 4
 summary: Pagetype for Embedded Datawrapper Charts