pageflow-before-after 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4ef58fe60813a3aa8419c775c50935babbd7369cf5fbd44cb95e2879e69827e1
-  data.tar.gz: 044a0b8a6d12d0a7496c76a91496ca1c59ff6af3179039e93fc89c0516a2366e
+  metadata.gz: 1e1eab8cb1cdabfac12b7170127f2b4522e2b444bc7262f634f650e324da1339
+  data.tar.gz: fa8e76828a91cccda21ffc3d34c9a1390ad31202f4da3b2ed6809b7e3a024582
 SHA512:
-  metadata.gz: 35a1385435ec14e1076191059b03c8e239b0f87e37a87b2fe421751de21e341eb521b8e4e2df921acb3285107507d4b9e427bd3892dea5fd8e9f9c4617adad19
-  data.tar.gz: fd23506ee916156bcaa02f4e011fe9f0e6a03337cd1027cb0e363862193b83d8cd192b451e15f43169d0dc7fbd56ab6517e2e97a141552af41a1994e6a4e0da4
+  metadata.gz: 3ce3949db87a3413a651b2da7b155f593dab4151b9ef0178dfc3fd87570b8de937e42d274653f7b0f0a91b59a6d14a408cdf0b27a4e3b09fc2eadca1762e00c2
+  data.tar.gz: e2ec3960250087b8a3ed438cbd19ee3d8d389eb673c484493884a26ed427e21d5f54dcc3fbaed2e050921c2c02aa7ff7db95443847f04b7a22f3730c85346325

data/.gitignore

@@ -13,6 +13,7 @@ lib/bundler/man
 pkg
 rdoc
 spec/reports
+spec/dummy
 test/tmp
 test/version_tmp
 tmp

data/.travis.yml

@@ -0,0 +1,10 @@
+language: ruby
+rvm: 2.5
+
+# User container based travis infrastructure which allows caching
+# features for open source projects.
+sudo: false
+cache: bundler
+
+script:
+  - bin/rspec

data/CHANGELOG.md

@@ -1,14 +1,16 @@
 # CHANGELOG
 
-### Version 1.1.0
+### Version 1.2.0
 
-2018-12-07
+2019-04-08
 
-[Compare changes](https://github.com/codevise/pageflow-before-after/compare/1-0-stable...v1.1.0)
+[Compare changes](https://github.com/codevise/pageflow-before-after/compare/1-1-stable...v1.2.0)
 
-- Add support for Pageflow 13
-  ([#22](https://github.com/codevise/pageflow-before-after/pull/22))
+- Adapt page dom for pageflow 14
+  ([#24](https://github.com/codevise/pageflow-before-after/pull/24))
+- Setup page type lint specs
+  ([#23](https://github.com/codevise/pageflow-before-after/pull/23))
 
 See
-[1-0-stable branch](https://github.com/codevise/pageflow-before-after/blob/1-0-stable/CHANGELOG.md)
+[1-1-stable branch](https://github.com/codevise/pageflow-before-after/blob/1-1-stable/CHANGELOG.md)
 for previous changes.

data/README.md

@@ -1,6 +1,7 @@
 # Pageflow Before After
 
 [![Gem Version](https://badge.fury.io/rb/pageflow-before-after.svg)](http://badge.fury.io/rb/pageflow-before-after)
+[![Build Status](https://travis-ci.org/codevise/pageflow-before-after.svg?branch=master)](https://travis-ci.org/codevise/pageflow-before-after)
 
 Page type showing before/after image sliders (Digit style).
 

data/app/assets/javascripts/pageflow/before_after.js

@@ -60,11 +60,7 @@ pageflow.pageType.register('before_after', _.extend({
   deactivated: function(pageElement, configuration) {},
 
   update: function(pageElement, configuration) {
-
-    pageElement.find('h2 .tagline').text(configuration.get('tagline') || '');
-    pageElement.find('h2 .title').text(configuration.get('title') || '');
-    pageElement.find('h2 .subtitle').text(configuration.get('subtitle') || '');
-    pageElement.find('p').html(configuration.get('text') || '');
+    this.updateDefaultPageContent(pageElement, configuration);
     pageElement.find('.control_bar_text').text(configuration.get('control_bar_text') ||
                                                I18n.t('pageflow.public.before_after.start', {
                                                  locale: pageflow.seed.locale
@@ -89,4 +85,4 @@ pageflow.pageType.register('before_after', _.extend({
       }
     };
   }
-}, pageflow.commonPageCssClasses, pageflow.infoBox));
+}, pageflow.commonPageCssClasses, pageflow.infoBox, pageflow.defaultPageContent));

data/app/assets/javascripts/pageflow/before_after/widget.js

@@ -34,7 +34,7 @@
       var beforeImg = $('.before_image', obj);
       var afterImg = $('.after_image', obj);
 
-      var section = $(obj).parentsUntil(".backgroundArea").last();
+      var section = $(obj).parentsUntil(".page_background").last();
 
       var imgWidth;
       var imgHeight;

data/app/assets/stylesheets/pageflow/before_after.scss

@@ -56,15 +56,13 @@
 }
 
 .page .beforeAfterPage {
-
-  .videoWrapper {
+  .uncropped_media_wrapper {
     height: 100%;
   }
 
   .shadow {
     z-index: 1;
   }
-
 }
 
 .hideText .beforeAfterPage  .before_wrapper {
@@ -78,8 +76,7 @@
 }
 
 .js .beforeAfterPage {
-
-  .contentText {
+  .page_text {
     margin-bottom: 200px;
 
     @include phone {

data/app/views/pageflow/before_after/page.html.erb

@@ -1,4 +1,4 @@
-<div class="blackLayer"></div>
+<div class="black_layer"></div>
 <div class="content_and_background beforeAfterPage">
   <div class="close_button text_hidden_only" tabindex="4" title="<%= t('pageflow.public.before_after.leave_view') %>">
     <div class="label">
@@ -6,8 +6,8 @@
     </div>
   </div>
 
-  <div class="backgroundArea page_background page_background-for_page_with_player_controls">
-    <div class="videoWrapper">
+  <div class="page_background page_background-for_page_with_player_controls">
+    <div class="uncropped_media_wrapper">
       <div class="before_after_container">
         <div class="before_after">
           <div class="before_wrapper">
@@ -38,18 +38,8 @@
 
     <div class="scroller">
       <div>
-        <div class="contentWrapper">
-          <div class="page_header">
-            <h2>
-              <span class="tagline"><%= configuration['tagline'] %></span>
-              <span class="title"><%= configuration['title'] %></span>
-              <span class="subtitle"><%= configuration['subtitle'] %></span>
-            </h2>
-            <%= background_image_tag(configuration['background_image_id'], {:class => "print_image"}) %>
-          </div>
-          <div class="contentText">
-            <p><%= raw configuration['text'] %></p>
-          </div>
+        <div class="content_wrapper">
+          <%= page_default_content(page) %>
         </div>
       </div>
     </div>

data/bin/rspec

@@ -0,0 +1,29 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'rspec' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+require "pathname"
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
+  Pathname.new(__FILE__).realpath)
+
+bundle_binstub = File.expand_path("../bundle", __FILE__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 150) =~ /This file was generated by Bundler/
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("rspec-core", "rspec")

data/lib/pageflow/before_after/version.rb

@@ -1,5 +1,5 @@
 module Pageflow
   module BeforeAfter
-    VERSION = '1.1.0'.freeze
+    VERSION = '1.2.0'.freeze
   end
 end

data/pageflow-before-after.gemspec

@@ -18,11 +18,14 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = '~> 2.1'
 
-  spec.add_dependency 'pageflow', ['>= 0.11', '< 14']
+  spec.add_dependency 'pageflow', '~> 14.x'
   spec.add_dependency 'pageflow-public-i18n', '~> 1.8'
 
   spec.add_dependency 'jquery-ui-rails', '~> 5.0'
 
+  spec.add_development_dependency 'pageflow-support', '~> 14.x'
+  spec.add_development_dependency 'rspec-rails', '~> 3.0'
+
   # Semantic versioning rake tasks
   spec.add_development_dependency 'semmy', '~> 1.0'
 end

data/spec/integration/page_type_spec.rb

@@ -0,0 +1,4 @@
+require 'spec_helper'
+require 'pageflow/lint'
+
+Pageflow::Lint.page_type(Pageflow::BeforeAfter.page_type)

data/spec/spec_helper.rb

@@ -0,0 +1,14 @@
+ENV['RAILS_ENV'] ||= 'test'
+ENV['PAGEFLOW_PLUGIN_ENGINE'] = 'pageflow_before_after'
+
+require 'pageflow/support'
+Pageflow::Dummy.setup
+
+require 'rspec/rails'
+
+engine_root = File.join(File.dirname(__FILE__), '..')
+Dir[File.join(engine_root, 'spec/support/**/*.rb')].each { |file| require(file) }
+
+RSpec.configure do |config|
+  config.use_transactional_fixtures = true
+end

metadata

@@ -1,35 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: pageflow-before-after
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Codevise Solutions
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-07 00:00:00.000000000 Z
+date: 2019-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pageflow
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0.11'
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '14'
+        version: 14.x
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0.11'
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '14'
+        version: 14.x
 - !ruby/object:Gem::Dependency
   name: pageflow-public-i18n
   requirement: !ruby/object:Gem::Requirement
@@ -58,6 +52,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '5.0'
+- !ruby/object:Gem::Dependency
+  name: pageflow-support
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 14.x
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 14.x
+- !ruby/object:Gem::Dependency
+  name: rspec-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: semmy
   requirement: !ruby/object:Gem::Requirement
@@ -80,6 +102,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - README.md
@@ -101,6 +124,7 @@ files:
 - app/assets/stylesheets/pageflow/before_after.scss
 - app/assets/stylesheets/pageflow/before_after/themes/default.scss
 - app/views/pageflow/before_after/page.html.erb
+- bin/rspec
 - config/locales/de.yml
 - config/locales/en.yml
 - lib/pageflow-before-after.rb
@@ -108,6 +132,8 @@ files:
 - lib/pageflow/before_after/page_type.rb
 - lib/pageflow/before_after/version.rb
 - pageflow-before-after.gemspec
+- spec/integration/page_type_spec.rb
+- spec/spec_helper.rb
 homepage: https://github.com/codevise/pageflow-before-after
 licenses:
 - MIT
@@ -128,8 +154,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.0
+rubygems_version: 2.7.5
 signing_key: 
 specification_version: 4
 summary: Pageflow page type for before/after image slider.
-test_files: []
+test_files:
+- spec/integration/page_type_spec.rb
+- spec/spec_helper.rb