page_record 1.0.1 → 1.0.3

data/CHANGES.md

@@ -1,28 +1,39 @@
 #Changes
 
-##V0.2.0
-* __BREAKING CHANGE__ Changed class name `PageRecord::PageRecord` to `PageRecord::Base`. Just a rename should be enough.
-* Added `add_attributes` class method. This allows you to just add extra attributes instead of specifying them all
-* Added `host_class` class method. Now you are able to set any class as a host class instead of beeing glued to xxxxPage`
+##V1.0.3
+* Added support for getting the Capybara element of a record.
+* #id now returns an integer 
 
-##V0.2.1
-* Fixed a bug. PageRecord stack dumped when the class contained the name `Page` 
+##V1.0.2
+* Added the id of the record to the inspector.
+* inspecting uses the Array variant of Capybara and doesn't wait. 
 
-##V0.3.0
-* Added rails helpers to make it easy in rails to have a form, recognised by PageRecord
-* Added other helpers to mke it easy to add `actions` and `attribute` tags
+##V1.0.1
+* Fixed a bug in action handling that causes page actions aoutside of a record te be noticed. Refactored the action handling.
 
-##V0.4.0
-* Added support for Formtasic
-* Added spec's for rails helpers
+##V1.0.0
+Released to production
 
 ##V0.5.0
 * Added a rails project containing some cucumber features to demonstrate how it works. The example also shows how to use the rails and Formtastic helpers.
 * Added support for form validations. Both in formtastic and in reading the errors
 * added a `inspect` for both the class and for the instances. This is __very__ helpfull when dubugging.
 
-##V1.0.0
-Released to production
+##V0.4.0
+* Added support for Formtasic
+* Added spec's for rails helpers
+
+##V0.3.0
+* Added rails helpers to make it easy in rails to have a form, recognised by PageRecord
+* Added other helpers to mke it easy to add `actions` and `attribute` tags
+
+##V0.2.1
+* Fixed a bug. PageRecord stack dumped when the class contained the name `Page` 
+
+##V0.2.0
+* __BREAKING CHANGE__ Changed class name `PageRecord::PageRecord` to `PageRecord::Base`. Just a rename should be enough.
+* Added `add_attributes` class method. This allows you to just add extra attributes instead of specifying them all
+* Added `host_class` class method. Now you are able to set any class as a host class instead of beeing glued to xxxxPage`
+
+
 
-##V1.0.1
-Fixed a bug in action handling that causes page actions aoutside of a record te be noticed. Refactored the action handling.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    page_record (1.0.1)
+    page_record (1.0.3)
       activemodel
       activesupport
       capybara (~> 2.1.0)
@@ -31,7 +31,7 @@ GEM
       thread_safe (~> 0.1)
       tzinfo (~> 0.3.37)
     arel (4.0.0)
-    atomic (1.1.10)
+    atomic (1.1.13)
     builder (3.1.4)
     capybara (2.1.0)
       mime-types (>= 1.16)
@@ -51,7 +51,7 @@ GEM
     erubis (2.7.0)
     ffi (1.9.0)
     formatador (0.2.4)
-    guard (1.8.1)
+    guard (1.8.2)
       formatador (>= 0.2.4)
       listen (>= 1.0.0)
       lumberjack (>= 1.0.2)
@@ -60,17 +60,17 @@ GEM
     guard-rspec (3.0.2)
       guard (>= 1.8)
       rspec (~> 2.13)
-    i18n (0.6.4)
-    listen (1.2.2)
+    i18n (0.6.5)
+    listen (1.3.0)
       rb-fsevent (>= 0.9.3)
       rb-inotify (>= 0.9)
       rb-kqueue (>= 0.2)
     lumberjack (1.0.4)
     method_source (0.8.2)
-    mime-types (1.23)
+    mime-types (1.24)
     mini_portile (0.5.1)
     minitest (4.7.5)
-    multi_json (1.7.7)
+    multi_json (1.7.9)
     nokogiri (1.6.0)
       mini_portile (~> 0.5.0)
     pry (0.9.12.2)
@@ -89,7 +89,7 @@ GEM
       thor (>= 0.18.1, < 2.0)
     rake (10.1.0)
     rb-fsevent (0.9.3)
-    rb-inotify (0.9.0)
+    rb-inotify (0.9.1)
       ffi (>= 0.5.0)
     rb-kqueue (0.2.0)
       ffi (>= 0.5.0)
@@ -99,10 +99,10 @@ GEM
       rspec-core (~> 2.14.0)
       rspec-expectations (~> 2.14.0)
       rspec-mocks (~> 2.14.0)
-    rspec-core (2.14.4)
-    rspec-expectations (2.14.0)
+    rspec-core (2.14.5)
+    rspec-expectations (2.14.2)
       diff-lcs (>= 1.1.3, < 2.0)
-    rspec-mocks (2.14.2)
+    rspec-mocks (2.14.3)
     rspec-rails (2.14.0)
       actionpack (>= 3.0)
       activesupport (>= 3.0)

data/lib/page_record/attributes.rb

@@ -25,7 +25,11 @@ module PageRecord
     # @raise [AttributeNotFound] when the attribute is not found in the record
     #
     def read_attribute(attribute)
-      element = send("#{attribute}?")
+      if block_given?
+        element = yield
+      else
+        element = send("#{attribute}?")
+      end
       tag = element.tag_name
       input_field?(tag) ? element.value : element.text
     end

data/lib/page_record/base.rb

@@ -13,10 +13,25 @@ module PageRecord
     def initialize(id = nil, selector = nil, filter = nil)
       @page = self.class.page
       @type = self.class.instance_variable_get('@type')
-      @id = id.to_s
+      @id = id.to_i if id 
       find_record(selector, filter)
     end
 
+    ##
+    # Return the Capybara element containg the record
+    #
+    # Example:
+    #
+    # ```ruby
+    #   team_1 = TeamPage.find(1) # Get the first team
+    #   team_1.element? # access the Capybara context
+    # end
+    # ```
+    #
+    def element?
+      @record
+    end
+
     ##
     # Set's the default selector for this class
     #
@@ -274,7 +289,7 @@ module PageRecord
       begin
         context = self.class.context_for_selector(selector)
         @record = context.find("[data-#{@type}-id#{id_text}]#{filter}")
-        @id = @record["data-#{@type}-id"] if @id.blank?
+        @id = @record["data-#{@type}-id"].to_i if @id.blank?
       rescue Capybara::Ambiguous
         raise MultipleRecords, "Found multiple #{@type} record with id #{@id} on page"
       rescue Capybara::ElementNotFound

data/lib/page_record/inspector.rb

@@ -20,12 +20,15 @@ module PageRecord
       attributes = {}
       self.class.attributes.each do | attribute|
         begin
-          attributes[attribute] = send(attribute)
-        rescue AttributeNotFound
+          attributes[attribute] = read_attribute(attribute) do
+            @record.all("[data-attribute-for='#{attribute}']").first
+          end
+        rescue NoMethodError
           attributes[attribute] = '--not found on page--'
         end
       end
-      attributes
+     attributes['id'] = id
+     attributes
     end
 
     module ClassMethods

data/lib/page_record/version.rb

@@ -1,3 +1,3 @@
 module PageRecord
-  VERSION = '1.0.1'
+  VERSION = '1.0.3'
 end

data/spec/attributes_spec.rb

@@ -4,6 +4,16 @@ describe PageRecord::Attributes do
 
   include_context "default context"
 
+  describe "#id" do
+
+    subject { TeamPage.find(1) }
+    include_context "page with single table with 3 records"
+
+    it "returns the id as an integer" do
+      expect(subject.id).to eq 1
+    end
+  end
+
   describe "#... valid attribute getter" do
 
     subject { TeamPage.find(1) }

data/spec/base_spec.rb

@@ -207,6 +207,23 @@ describe PageRecord::Base do
 
   end
 
+  describe "record.element?" do
+
+    subject { TeamPage.find().element? }
+
+    context "record on the page" do
+      before do
+        visit '/page-one-record'
+      end
+
+      it "returns the capybara element containing the record" do
+        expect(subject.class).to eq Capybara::Node::Element
+      end
+
+    end
+  end
+
+
   describe "found bugs" do
 
     describe "class name contains word page but doens't exist" do

data/spec/inspector_spec.rb

@@ -61,6 +61,7 @@ describe PageRecord::Inspector do
 	  subject { TeamPage.find(1).inspect }
 
 	  it 'returns all attributes' do
+	  	expect(subject[:attributes]['id']).to eq 1
 	  	expect(subject[:attributes]['ranking']).to eq '1'
 	  	expect(subject[:attributes]['name']).to eq 'Ajax'
 	  	expect(subject[:attributes]['points']).to eq '10'

data/spec/support/shared_examples.rb

@@ -26,7 +26,7 @@ shared_examples "a valid single record finder" do
     end
 
     it "returns the record identified by the id" do
-      expect(subject.id).to eq '1'
+      expect(subject.id).to eq 1
     end
 
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: page_record
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-17 00:00:00.000000000 Z
+date: 2013-09-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -293,7 +293,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1859319199446950175
+      hash: 1953905507343366230
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -302,7 +302,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1859319199446950175
+      hash: 1953905507343366230
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24