page_record 1.0.0 → 1.0.1

data/CHANGES.md

@@ -20,3 +20,9 @@
 * Added a rails project containing some cucumber features to demonstrate how it works. The example also shows how to use the rails and Formtastic helpers.
 * Added support for form validations. Both in formtastic and in reading the errors
 * added a `inspect` for both the class and for the instances. This is __very__ helpfull when dubugging.
+
+##V1.0.0
+Released to production
+
+##V1.0.1
+Fixed a bug in action handling that causes page actions aoutside of a record te be noticed. Refactored the action handling.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    page_record (1.0.0)
+    page_record (1.0.1)
       activemodel
       activesupport
       capybara (~> 2.1.0)

data/lib/page_record/actions.rb

@@ -2,58 +2,31 @@ module PageRecord
   module Actions
 
     def self.included(base)
+      base.class_eval do
+        include(ActionHandler)
+      end
+      base.extend(ActionHandler)
       base.extend(ClassMethods)
     end
 
-    ##
-    # This is the implementation of the record action routine. It has two variants.
-    # it has a `?` variant and a `normal` variant.
-    #
-    # normal variant:
-    # It checks the page for a data-action-for='action' tag somewhere on the page.
-    # If it finds it, it clicks it.
-    #
-    # `?` variant:
-    # It checks the page for a data-action-for='action' tag somewhere on the page.
-    # If it finds it, returns the Capybara element.
-    #
-    # @param action [Symbol] this is the name of the action
-    #
-    # @return [Capybara::Result]
-    #
-    # @raise [PageRecord::MultipleRecords] when there are more actions with
-    #   this name on the page
-    #
-    def method_missing(action)
-      self.class.method_missing(action)
-    end
-
     protected
 
     # @private
     def actions
-      self.class.send('actions_on?', @record)
+      actions_on?(@record)
     end
 
     private
 
-    # @private
-    def action_for(action)
-      element = action_for?(action)
-      element.click
-      element
-    end
-
     # @private
     def action_for?(action)
       @record.find("[data-action-for='#{action}']")
     end
 
-    module ClassMethods
-
+    module ActionHandler
       ##
       #
-      # This is the implementation of the page action routine. It has two variants.
+      # This is the implementation of the page and record action routine. It has two variants.
       # it has a `?` variant and a `normal` variant.
       #
       # normal variant:
@@ -69,9 +42,9 @@ module PageRecord
       # @return [Capybara::Element]
       #
       # @raise [PageRecord::MultipleRecords] when there are more actions with
-      #   this name on the page
+      #   this name on the page/record
       #
-      def method_missing(action)
+      def method_missing(action, message = nil)
         raw_action = /(.*)\?/.match(action)
         begin
           if raw_action
@@ -80,17 +53,20 @@ module PageRecord
             action_for(action)
           end
         rescue Capybara::Ambiguous
-          raise MultipleRecords, "Found multiple #{action} tags for #{@type} on page"
+          message ||= "Found multiple #{action} tags for #{@type} on page"
+          raise MultipleRecords, message
         rescue Capybara::ElementNotFound
           super
         end
       end
 
-      protected
+      private
 
       # @private
-      def actions
-        actions_on?(page)
+      def action_for(action)
+        element = action_for?(action)
+        element.click
+        element
       end
 
       # @private
@@ -104,15 +80,19 @@ module PageRecord
         action_hash
       end
 
-      private
+    end
+
+    module ClassMethods
+
+      protected
 
       # @private
-      def action_for(action)
-        element = action_for?(action)
-        element.click
-        element
+      def actions
+        actions_on?(page)
       end
 
+      private
+
       # @private
       def action_for?(action)
         page.find("[data-action-for='#{action}']")

data/lib/page_record/version.rb

@@ -1,3 +1,3 @@
 module PageRecord
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'
 end

data/spec/actions_spec.rb

@@ -18,7 +18,7 @@ describe PageRecord::Actions do
 
     it_behaves_like "a valid action finder" do
       let(:valid_action) { record.create}
-      let(:invalid_action) { record.unkown_action }
+      let(:invalid_action) { record.page_action } # It should not see the page action
       let(:multiple_actions) { record.multiple_action }
     end
   end
@@ -29,7 +29,7 @@ describe PageRecord::Actions do
 
     it_behaves_like "a valid action finder" do
       let(:valid_action) { record.create?}
-      let(:invalid_action) { record.unkown_action?}
+      let(:invalid_action) { record.page_action?} # It should not see the page action
       let(:multiple_actions) { record.multiple_action? }
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: page_record
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-01 00:00:00.000000000 Z
+date: 2013-08-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -293,7 +293,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2075293908552709034
+      hash: -1859319199446950175
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -302,7 +302,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2075293908552709034
+      hash: -1859319199446950175
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24