page_magic 2.0.4 → 2.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ccc04854912ddcf2dd95b493fea787c32a5b4b26f0029a477f06a398d7ae0b00
-  data.tar.gz: 8d57827aca461954a62e446937f7b58fa27ecda1ac9ac35841aab78cb3120701
+  metadata.gz: 7cd51a69161a6e25593df1ee746057e38a23dbd5debcc5d22ea66cd0376df4c5
+  data.tar.gz: aea97edeac9689e324e7077fcd208091b5704bd2efb2cc6d62b9980d2f9f15cd
 SHA512:
-  metadata.gz: 341434bd29979c0a7d03a97775ed4d1dd173541bb25e67f65afd833caac81f3a917b3b468036f381f64d0a55e2c7d8facbc61ecebef72bc228d85b1de621bf10
-  data.tar.gz: 66128a080b1337fe28a130e322b712d05ff0a7f1b96c16c77a3c1d3a0c9070222e48712f44ca07175339b3b76b979a0d55b5e8546f7774a31669b60c8862ba2e
+  metadata.gz: 47914506ca6a1eaa24bacb0c83a0a8ff750bdf2a7a11bc5d3822218f75e9da0bca9a949b263d6beead2c549c740392ea431ff53bc1cc14cbae1b84b1426f8fea
+  data.tar.gz: 2a4c5ae39523e8835321d53ab463ca9d20fe9fe3ec0ddf0b30fb22fbf11d201f2be0e7642c337c4d4f4e9fd19a7cedc64a89d45bbee363296a05b9ead5e0bb51

data/VERSION

@@ -1 +1 @@
-2.0.4
+2.0.5

data/lib/page_magic/session.rb

@@ -18,6 +18,8 @@ module PageMagic
     # Create a new session instance
     # @param [Object] capybara_session an instance of a capybara session
     # @param [String] base_url url to start the session at.
+    #
+
     def initialize(capybara_session, base_url = nil)
       @raw_session = capybara_session
       @base_url = base_url
@@ -44,6 +46,12 @@ module PageMagic
       @transitions = Transitions.new(transitions)
     end
 
+    def is_a?(klass)
+      return true if klass == Capybara::Session
+
+      super
+    end
+
     # proxies unknown method calls to the currently loaded page object
     # @return [Object] returned object from the page object method call
     def method_missing(name, *args, &block)
@@ -75,13 +83,14 @@ module PageMagic
     # @raise [InvalidURLException] if a page is supplied and there isn't a mapped path for it
     # @raise [InvalidURLException] if neither a page or url are supplied
     # @raise [InvalidURLException] if the mapped path for a page is a Regexp
-    def visit(page = nil, url: nil)
-      url ||= transitions.url_for(page, base_url: base_url)
+    # @return [PageMagic::Session] - returns self
+    def visit(page_or_url = nil, url: nil)
+      url ||= page_or_url.is_a?(String) ? page_or_url : transitions.url_for(page_or_url, base_url: base_url)
 
       raise InvalidURLException, URL_MISSING_MSG unless url
 
       raw_session.visit(url)
-      @current_page = initialize_page(page) if page
+      @current_page = initialize_page(page_or_url) unless page_or_url.is_a?(String)
       self
     end
 

data/spec/page_magic/session_spec.rb

@@ -79,6 +79,14 @@ RSpec.describe PageMagic::Session do
     end
   end
 
+  describe '#is_a?' do
+    context 'when other is a `Capybara::Session`' do
+      it 'returns true' do
+        expect(described_class.new(browser).is_a?(Capybara::Session)).to eq(true)
+      end
+    end
+  end
+
   describe '#respond_to?' do
     it 'checks self' do
       session = described_class.new(browser)
@@ -138,10 +146,17 @@ RSpec.describe PageMagic::Session do
       end
     end
 
+    context 'when a page and `:url` supplied' do
+      it 'uses the url' do
+        session.visit(page, url: 'http://other.url/')
+        expect(session.current_url).to eq('http://other.url/')
+      end
+    end
+
     context 'when `url` is supplied' do
       it 'visits that url' do
         expected_url = 'http://base.url/page'
-        session.visit(url: expected_url)
+        session.visit(expected_url)
         expect(browser.current_url).to eq(expected_url)
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: page_magic
 version: !ruby/object:Gem::Version
-  version: 2.0.4
+  version: 2.0.5
 platform: ruby
 authors:
 - Leon Davis
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-07-04 00:00:00.000000000 Z
+date: 2021-07-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport