page_magic 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 92b6df866c2bbcae9351e24417bf141c50101f96b74ce6a1225318998c30da9b
-  data.tar.gz: 2a605e1c74eda006717474066d6824806a20f35ca05ddeef75d684951ebea257
+  metadata.gz: a818b71ddcc138a95601f724bcae9b6631bf87431a9bbd7edb0816f1bdac5fb8
+  data.tar.gz: 2d6a165aec8c854e49496c6375154c90aa714b97e28f00fa5cefc5d954fe8dd0
 SHA512:
-  metadata.gz: 773b643dcf348bd77718e53e924754dd47d23e2edc1bbc1c904a82d332a66b00f9d7285c409a91be37d7ecca27cdbb11f62d6b938ea47e7a9396a2dd97a724d3
-  data.tar.gz: 7864c97e2e3b196809835ad8a9d4ede8fd44a7ad84276a3bd06d72fb706b2400437ded32301f5e5bb299d13cbfbe2314d606c57fc1de809dfa396e3d8070de85
+  metadata.gz: 6145762ea0b3ddc8cea37e04957a95873b6d892798efe051d1f3e3937ebc9c6487e1ab9123dc02544190cf77ac3957197dcd0eaf14e87ce5b104c682aee21696
+  data.tar.gz: d5fc4d9729c2a68bab771e0f4538ed4346daa91a23a53b65cacbe8b75fff02e1ee83e68eef87f77bc5925852a2b1fbd0520e0f3bff2b85f5a2653f408c231faf

data/README.md

@@ -56,6 +56,8 @@ Check it out :)
   - [Helper Methods](#helper-methods)
   - [Dynamic Selectors](#dynamic-selectors)
 - [Starting a session](#starting-a-session)
+  - [Using an existing session](#using-an-existing-session)
+  - [Rack applications and Rack::Test](#rack-applications-and-racktest)
 - [Page mapping](#page-mapping)
   - [Mapping against query string parameters](#mapping-against-query-string-parameters)
   - [Mapping against fragment identifiers](#mapping-against-fragment-identifiers)
@@ -325,9 +327,16 @@ session = PageMagic.session(browser: :chrome, url: 'https://www.github.com')
 ```
 
 Your session won't do much besides navigating to the given url until you have [mapped pages](#page-mapping) to it, so 
-take a look at this next! 
+take a look at this next!
 
 **Note** PageMagic supports having multiple sessions using different browsers at the same time :)
+
+## Using an existing session
+If you are introducing PageMagic in to a test suite that already makes use of Capybara, PageMagic can be configured to 
+make use of the session that is already configure like this:
+```ruby
+session = PageMagic.session(session: Capybara.current_session)
+```
  
 ## Rack applications and Rack::Test
 To run a session against a rack application instead of a live site, simply supply the rack application when creating 

data/VERSION

@@ -1 +1 @@
-2.0.0
+2.0.1

data/lib/page_magic.rb

@@ -50,16 +50,21 @@ module PageMagic
     # @param [Symbol] browser name of browser
     # @param [String] url url to start the session on
     # @param [Hash] options browser driver specific options
+    # @param [Capybara::Session] session - use you own already configure capybara session e.g. Capybara.current_session
     # @return [Session] configured session
-    def session(url: nil, application: nil, browser: :rack_test, options: {})
-      driver = drivers.find(browser)
-      raise UnsupportedBrowserException unless driver
+    def session(session: nil, url: nil, application: nil, browser: :rack_test, options: {})
+      session ||= begin
+        driver = drivers.find(browser)
+        raise UnsupportedBrowserException unless driver
 
-      Capybara.register_driver browser do |app|
-        driver.build(app, browser: browser, options: options)
+        Capybara.register_driver browser do |app|
+          driver.build(app, browser: browser, options: options)
+        end
+
+        Capybara::Session.new(browser, application)
       end
 
-      Session.new(Capybara::Session.new(browser, application), url)
+      Session.new(session, url)
     end
   end
 end

data/spec/page_magic_spec.rb

@@ -89,6 +89,13 @@ RSpec.describe PageMagic do
       end
     end
 
+    context 'when `session` is specified' do
+      it 'uses it' do
+        session = described_class.session(session: :custom_session)
+        expect(session.raw_session).to be(:custom_session)
+      end
+    end
+
     context 'when `:options` is specified' do
       it 'passes the options to the browser driver' do
         options = { option: :config }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: page_magic
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - Leon Davis