pag_seguro 0.5.3 → 0.5.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6c0937b68bd3486b76533ac074e27c701f0bf774
-  data.tar.gz: 8b67ac524102ac11165316d175a174cc85d40cea
+  metadata.gz: 3bbfb84a631ab24786de12bc5e7a16a107d09790
+  data.tar.gz: a9c38a18d3194f2962e58d9813597c162aac5cc6
 SHA512:
-  metadata.gz: 0c8812098218850c3a40e7c462820b6f0463b45b26dcdc7b41e56e2dae8f2b84f61086aae1d12023e85f6ac0ed7a81bbc6adff5574bac2eef55bff8855132d03
-  data.tar.gz: 098eb62f65f0e469e29d6f5144de0a64e7ac1694523119c62c948d07fb544169a2c369e797fa47b9118f09ee6a2d8b011604188c4b107c9ad5767bd9f4a53672
+  metadata.gz: bf1a7901bec996be24ca3b9f85adde8508a7cea7a5e0c05ba143c086a628be9cc110aa7976861a5251dab76107ad5eba3bf8ad6f890307ecc894615fe0b31e50
+  data.tar.gz: 0438005dd35769dc354816e7be964d892e68b4e2c60d444ca2bfeea5a8c2c8b9f3088b7344cbfebbc16ecfed5dd707f696052edc9fbaaaa6b12b823d3bc27d8c

data/lib/pag_seguro/checkout.xml.haml

@@ -79,4 +79,4 @@
       - if pre_approval.initial_date.present?
         %initialDate= pre_approval.initial_date.iso8601
       - if pre_approval.review_URL.present?
-        %reviewURL= pre_approval.review_URL
+        %reviewURL= pre_approval.review_URL

data/lib/pag_seguro/day_of_year.rb

@@ -21,15 +21,16 @@ module PagSeguro
       "#{"%02d" % @month}-#{"%02d" % @day}"
     end
 
+    # very simple date validation, just to smoke test possible
+    # errors of switching day with month
     def valid?
-      # very simple date validation, just to smoke test possible errors of switching day with month
       @day < 31 && @month < 12
     end
 
     def <=>(other_day_of_the_year)
-      return 1  if @month > other_day_of_the_year.month
+      return  1 if @month > other_day_of_the_year.month
       return -1 if @month < other_day_of_the_year.month
       @day <=> other_day_of_the_year.day
     end
   end
-end
+end

data/lib/pag_seguro/errors/unauthorized.rb

@@ -6,4 +6,4 @@ module PagSeguro
       end
     end
   end
-end
+end

data/lib/pag_seguro/errors/unknown_error.rb

@@ -6,4 +6,4 @@ module PagSeguro
       end
     end
   end
-end
+end

data/lib/pag_seguro/item.rb

@@ -2,17 +2,17 @@ module PagSeguro
   class Item
     include ActiveModel::Validations
     extend PagSeguro::ConvertFieldToDigit
-    
+
     attr_accessor :id, :description, :amount, :quantity, :shipping_cost, :weight
     attr_reader_as_digit :amount, :shipping_cost
-        
+
     validates :id, presence: true
     validates :description, presence: true
     validates :amount, pagseguro_decimal: true, presence: true
     validates :shipping_cost, pagseguro_decimal: true
     validates :weight, numericality: { only_integer: true, greater_than: 0, allow_blank: true }
     validates :quantity, presence: true, numericality: { only_integer: true, greater_than: 0, less_than: 1000 }
-    
+
     def initialize(attributes = {})
       @id = attributes[:id]
       @description = attributes[:description]
@@ -21,9 +21,9 @@ module PagSeguro
       @shipping_cost = attributes[:shipping_cost]
       @weight = attributes[:weight]
     end
-    
+
     def description
       @description.present? && @description.size > 100 ? @description[0..99] : @description
     end
   end
-end
+end

data/lib/pag_seguro/notification.rb

@@ -1,16 +1,17 @@
 module PagSeguro
   class Notification < Transaction
-  
-    def initialize(email = nil, token = nil, notification_code=nil)
+
+    def initialize(email, token, notification_code)
       raise "Needs a notification code" if notification_code.blank?
       raise "Needs an email" if email.blank?
       raise "Needs a token" if token.blank?
       @data = transaction_data(email, token, notification_code)
     end
-      
+
     private
       def transaction_data(email, token, notification_code)
-        super RestClient.get "#{PAGSEGURO_TRANSACTIONS_URL}/notifications/#{notification_code}", params: {email: email, token: token}
+        notification_url = "#{PAGSEGURO_TRANSACTIONS_URL}/notifications/#{notification_code}"
+        super RestClient.get notification_url, params: {email: email, token: token}
       end
   end
 end

data/lib/pag_seguro/payment.rb

@@ -3,15 +3,17 @@ module PagSeguro
     include ActiveModel::Validations
     extend PagSeguro::ConvertFieldToDigit
 
-    attr_accessor :id, :email, :token, :items, :sender, :shipping, :extra_amount,
-      :redirect_url, :max_uses, :max_age, :response, :pre_approval
+    attr_accessor :id, :email, :token, :items, :sender, :shipping,
+                  :extra_amount, :redirect_url, :max_uses, :max_age,
+                  :response, :pre_approval
+
     attr_reader_as_digit :extra_amount
-    
+
     validates_presence_of :email, :token
     validates :extra_amount, pagseguro_decimal: true
     validates_format_of :redirect_url, with: URI::regexp(%w(http https)), message: " must give a correct url for redirection", allow_blank: true
     validate :max_uses_number, :max_age_number, :valid_pre_approval, :valid_items
-    
+
     def initialize(email = nil, token = nil, options = {})
       @email        = email unless email.nil?
       @token        = token unless token.nil?
@@ -25,60 +27,74 @@ module PagSeguro
       @max_age      = options[:max_age]
       @pre_approval = options[:pre_approval]
     end
-    
+
     def self.checkout_payment_url(code)
       "https://pagseguro.uol.com.br/v2/checkout/payment.html?code=#{code}"
     end
-    
+
     def checkout_xml
       xml_content = File.open( File.dirname(__FILE__) + "/checkout.xml.haml" ).read
       haml_engine = Haml::Engine.new(xml_content)
-      haml_engine.render(Object.new, items: @items, payment: self, sender: @sender, shipping: @shipping, pre_approval: @pre_approval)
+
+      haml_engine.render Object.new,
+                         items: @items,
+                         payment: self,
+                         sender: @sender,
+                         shipping: @shipping,
+                         pre_approval: @pre_approval
     end
-    
+
     def checkout_url_with_params
       "https://ws.pagseguro.uol.com.br/v2/checkout?email=#{@email}&token=#{@token}"
     end
-    
+
     def checkout_payment_url
       self.class.checkout_payment_url(code)
     end
-    
+
     def code
       response || parse_checkout_response
       parse_code
     end
-    
+
     def date
       response || parse_checkout_response
       parse_date
     end
-    
+
     def reset!
       @response = nil
     end
-    
+
     protected
       def max_uses_number
-        errors.add(:max_uses, " must be an integer greater than 0") if @max_uses.present? && @max_uses.to_i <= 0
+        if @max_uses.present? && @max_uses.to_i <= 0
+          errors.add(:max_uses, " must be an integer greater than 0")
+        end
       end
-      
+
       def max_age_number
-        errors.add(:max_age, " must be an integer grater or equal to 30") if @max_age.present? && @max_age.to_i < 30
+        if @max_age.present? && @max_age.to_i < 30
+          errors.add(:max_age, " must be an integer grater or equal to 30")
+        end
       end
 
       def valid_pre_approval
-        errors.add(:pre_approval, " must be valid") if pre_approval && !pre_approval.valid?
+        if pre_approval && !pre_approval.valid?
+          errors.add(:pre_approval, " must be valid")
+        end
       end
 
       def valid_items
-        errors.add(:items, " must be all valid") if items.blank? || !items.all?(&:valid?)
+        if items.blank? || !items.all?(&:valid?)
+          errors.add(:items, " must be all valid")
+        end
       end
-            
+
       def send_checkout
         RestClient.post(checkout_url_with_params, checkout_xml, content_type: "application/xml"){|resp, request, result| resp }
       end
-      
+
       def parse_checkout_response
         res = send_checkout
         raise Errors::Unauthorized if res.code == 401
@@ -86,11 +102,11 @@ module PagSeguro
         raise Errors::UnknownError.new(res) if res.code != 200
         @response = res.body
       end
-      
+
       def parse_date
-        DateTime.iso8601( Nokogiri::XML(response.body).css("checkout date").first.content )
+        DateTime.iso8601(Nokogiri::XML(response.body).css("checkout date").first.content)
       end
-      
+
       def parse_code
         Nokogiri::XML(response.body).css("checkout code").first.content
       end

data/lib/pag_seguro/payment_method.rb

@@ -2,47 +2,47 @@
 module PagSeguro
   class PaymentMethod
     attr_accessor :code, :type
-    
+
     # Payment Method types
     CREDIT_CARD        = 1
     BANK_BILL          = 2
     ONLINE_DEBIT       = 3
     PAG_SEGURO_BALANCE = 4
     OI_PAGGO           = 5
-    
+
     def initialize(options = {})
       @code = options[:code]
       @type = options[:type]
     end
-    
+
     def code
       @code.to_i
     end
-    
+
     def type
       @type.to_i
     end
-    
+
     def credit_card?
       CREDIT_CARD == type
     end
-    
+
     def bank_bill?
       BANK_BILL == type
     end
-    
+
     def online_debit?
       ONLINE_DEBIT == type
     end
-    
+
     def pag_seguro_balance?
       PAG_SEGURO_BALANCE == type
     end
-    
+
     def oi_paggo?
       OI_PAGGO == type
     end
-    
+
     def name
       case code
       when 101 then "Cartão de crédito Visa"
@@ -61,7 +61,7 @@ module PagSeguro
       when 303 then "Débito online Unibanco"
       when 304 then "Débito online Banco do Brasil"
       when 305 then "Débito online Banco Real"
-      when 306 then "Débito online Banrisul"        
+      when 306 then "Débito online Banrisul"
       when 307 then "Débito online HSBC"
       when 401 then "Saldo PagSeguro"
       when 501 then "Oi Paggo"
@@ -69,4 +69,4 @@ module PagSeguro
       end
     end
   end
-end
+end

data/lib/pag_seguro/pre_approval.rb

@@ -7,8 +7,11 @@ module PagSeguro
     DAYS_OF_WEEK = %w(monday tuesday wednesday thursday friday saturday sunday)
     DATE_RANGE = 17856.hours
 
-    attr_accessor :name, :details, :amount_per_payment, :period, :day_of_week, :day_of_month,
-      :day_of_year, :initial_date, :final_date, :max_amount_per_period, :max_total_amount, :review_URL
+    attr_accessor :name, :details, :amount_per_payment, :period,
+                  :day_of_week, :day_of_month, :day_of_year, :initial_date,
+                  :final_date, :max_amount_per_period, :max_total_amount,
+                  :review_URL
+
     attr_reader_as_digit :amount_per_payment, :max_amount_per_period, :max_total_amount
 
     validates_presence_of :name, :period, :final_date, :max_total_amount, :max_amount_per_period
@@ -16,7 +19,7 @@ module PagSeguro
     validates_inclusion_of :day_of_week, in: DAYS_OF_WEEK, if: :weekly?
     validates_inclusion_of :day_of_month, in: (1..28), if: :monthly?
     validates_presence_of :day_of_year, if: :yearly?
-    validates_format_of :day_of_year, with: /^\d{2}-\d{2}$/, if: :yearly?
+    validates_format_of :day_of_year, with: /\A\d{2}-\d{2}\z/, if: :yearly?
     validate :initial_date_range, :final_date_range
     validates :max_amount_per_period, pagseguro_decimal: true
     validates :max_total_amount, pagseguro_decimal: true
@@ -81,4 +84,4 @@ module PagSeguro
         errors.add(:final_date) if final_date > (initial_date || Time.now) + DATE_RANGE
       end
   end
-end
+end

data/lib/pag_seguro/query.rb

@@ -1,25 +1,28 @@
 module PagSeguro
   class Query < Transaction
-  
-    def initialize(email = nil, token = nil, transaction_code=nil)
+
+    def initialize(email, token, transaction_code)
       raise "Needs a transaction code" if transaction_code.blank?
       raise "Needs an email" if email.blank?
       raise "Needs a token" if token.blank?
       @data = transaction_data(email, token, transaction_code)
     end
-      
+
     def self.find(email, token, options={})
       url = Transaction::PAGSEGURO_TRANSACTIONS_URL
       url += "/abandoned" if options[:abandoned]
+
       transactions_data = Nokogiri::XML(RestClient.get url, params: search_params(email, token, options))
-      transactions_data.css("transaction").map{|transaction_xml| Transaction.new(transaction_xml) }
+      transactions_data.css("transaction").map do |transaction_xml|
+        Transaction.new(transaction_xml)
+      end
     end
 
     def self.search_params(email, token, options={})
       params = {email: email, token: token}
       params[:initialDate], params[:finalDate] = parse_dates(options)
-      params[:page]                            = options[:page] if options[:page]
-      params[:maxPageResults]                  = options[:max_page_results] if options[:max_page_results]
+      params[:page] = options[:page] if options[:page]
+      params[:maxPageResults] = options[:max_page_results] if options[:max_page_results]
       params
     end
 
@@ -34,10 +37,11 @@ module PagSeguro
 
       return initial_date.to_time.iso8601, final_date.to_time.iso8601
     end
- 
+
     private
       def transaction_data(email, token, transaction_code)
-        super RestClient.get "#{PAGSEGURO_TRANSACTIONS_URL}/#{transaction_code}", params: {email: email, token: token}
+        transaction_url = "#{PAGSEGURO_TRANSACTIONS_URL}/#{transaction_code}"
+        super RestClient.get transaction_url, params: {email: email, token: token}
       end
   end
 end

data/lib/pag_seguro/sender.rb

@@ -1,37 +1,37 @@
 module PagSeguro
   class Sender
     attr_accessor :name, :email, :phone_ddd, :phone_number
-    
+
     def initialize(options = {})
       @name         = options[:name]
       @email        = options[:email]
       @phone_ddd    = options[:phone_ddd]
       @phone_number = options[:phone_number]
     end
-    
+
     def email
       valid_email? ? @email : nil
     end
 
     def valid_email?
-      @email =~ /\A([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\Z/i && @email.size <= 60
+      @email =~ /\A([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\z/i && @email.size <= 60
     end
-    
+
     def name
       return nil unless valid_name?
       @name.gsub(/ +/, " ")[0..49]
     end
-    
+
     def valid_name?
       @name =~ /\S+ +\S+/
     end
-    
+
     def phone_ddd
-      @phone_ddd if @phone_ddd.to_s =~ /^\d{2}$/
+      @phone_ddd if @phone_ddd.to_s =~ /\A\d{2}\z/
     end
-    
+
     def phone_number
-      @phone_number if @phone_number.to_s =~/^\d{8,9}$/
+      @phone_number if @phone_number.to_s =~/\A\d{8,9}\z/
     end
   end
-end
+end

data/lib/pag_seguro/shipping.rb

@@ -1,15 +1,16 @@
 module PagSeguro
   class Shipping
     include ActiveModel::Validations
-    
+
     PAC = 1
     SEDEX = 2
     UNIDENTIFIED = 3
-    
+
     validates :postal_code, numericality: true, length: {is: 8}
-    
-    attr_accessor :type, :state, :city, :postal_code, :district, :street, :number, :complement, :cost
-    
+
+    attr_accessor :type, :state, :city, :postal_code, :district,
+                  :street, :number, :complement, :cost
+
     def initialize(attributes = {})
       @type = attributes[:type] || UNIDENTIFIED
       @state = attributes[:state]
@@ -21,25 +22,25 @@ module PagSeguro
       @complement = attributes[:complement]
       @cost = attributes[:cost]
     end
-    
+
     def postal_code
       @postal_code if @postal_code.present? && @postal_code.to_s.size == 8
     end
-    
+
     def type
       @type.to_i
     end
-    
+
     def pac?
       PAC == type
     end
-    
+
     def sedex?
       SEDEX == type
     end
-    
+
     def unidentified?
       UNIDENTIFIED == type
     end
   end
-end
+end

data/lib/pag_seguro/transaction.rb

@@ -6,7 +6,7 @@ module PagSeguro
     attr_accessor :data
 
     PAGSEGURO_TRANSACTIONS_URL  = "https://ws.pagseguro.uol.com.br/v2/transactions"
-    
+
     # possible status values
     PAGSEGURO_PROCESSING        = 1
     PAGSEGURO_IN_ANALYSIS       = 2
@@ -15,14 +15,14 @@ module PagSeguro
     PAGSEGURO_DISPUTED          = 5
     PAGSEGURO_RETURNED          = 6
     PAGSEGURO_CANCELLED         = 7
-    
+
     # possible type values
     PAGSEGURO_PAYMENT           = 1
     PAGSEGURO_TRANSFER          = 2
     PAGSEGURO_ADDITION_OF_FUNDS = 3
     PAGSEGURO_CHARGE            = 4
     PAGSEGURO_BONUS             = 5
-  
+
     def self.status_for(status_code)
       case status_code
       when PAGSEGURO_PROCESSING  then :processing
@@ -42,7 +42,7 @@ module PagSeguro
     def id
       @data.css("reference").first.content
     end
-    
+
     def gross_amount
       @data.css("grossAmount").first.content
     end
@@ -66,29 +66,33 @@ module PagSeguro
     def installment_count
       @data.css("installmentCount").first.content.to_i
     end
-    
+
     def item_count
       @data.css("itemCount").first.content.to_i
     end
-    
+
     def transaction_id
       @data.css("code").first.content
     end
-    
+
     def date
       DateTime.iso8601( @data.css("date").first.content )
     end
-  
+
     def items
       @data.css("items item").map do |i|
-        Item.new(id: parse_item(i, "id"), description: parse_item(i, "description"), quantity: parse_item(i, "quantity"), amount: parse_item(i, "amount"))
+        Item.new id: parse_item(i, "id"),
+                 description: parse_item(i, "description"),
+                 quantity: parse_item(i, "quantity"),
+                 amount: parse_item(i, "amount")
       end
     end
-    
+
     def payment_method
-      PaymentMethod.new code: parse_css("paymentMethod code"), type: parse_css("paymentMethod type")
+      PaymentMethod.new code: parse_css("paymentMethod code"),
+                        type: parse_css("paymentMethod type")
     end
-    
+
     def sender
       sn = Sender.new
       sn.name = parse_css("sender name")
@@ -97,7 +101,7 @@ module PagSeguro
       sn.phone_number = parse_css("sender phone number")
       sn
     end
-    
+
     def shipping
       sh = Shipping.new
       sh.type = parse_css("shipping type")
@@ -111,7 +115,7 @@ module PagSeguro
       sh.complement = parse_css("shipping address complement")
       sh
     end
-    
+
     def status
       @data.css("status").first.content.to_i
     end
@@ -123,7 +127,7 @@ module PagSeguro
     def processing?
       PAGSEGURO_PROCESSING == status
     end
-    
+
     def in_analysis?
       PAGSEGURO_IN_ANALYSIS == status
     end
@@ -131,43 +135,43 @@ module PagSeguro
     def approved?
       PAGSEGURO_APPROVED == status
     end
-    
+
     def available?
       PAGSEGURO_AVAILABLE == status
     end
-    
+
     def disputed?
       PAGSEGURO_DISPUTED == status
     end
-    
+
     def returned?
       PAGSEGURO_RETURNED == status
     end
-    
+
     def cancelled?
       PAGSEGURO_CANCELLED == status
     end
-    
+
     def payment?
       PAGSEGURO_PAYMENT == type
     end
-    
+
     def transfer?
       PAGSEGURO_TRANSFER == type
     end
-    
+
     def addition_of_funds?
       PAGSEGURO_ADDITION_OF_FUNDS == type
     end
-    
+
     def charge?
       PAGSEGURO_CHARGE == type
     end
-    
+
     def bonus?
       PAGSEGURO_BONUS == type
     end
-  
+
     protected
       def transaction_data(transaction_xml)
         transaction_xml.instance_of?(Nokogiri::XML::Element) ? transaction_xml : Nokogiri::XML(transaction_xml)
@@ -176,10 +180,10 @@ module PagSeguro
       def parse_item(data, attribute)
         data.css(attribute).first.content
       end
-      
+
       def parse_css(selector)
         value = @data.css(selector).first
         value.nil? ? nil : value.content
-      end      
+      end
   end
 end

data/lib/pag_seguro/version.rb

@@ -1,3 +1,3 @@
 module PagSeguro
-  VERSION = "0.5.3"
+  VERSION = "0.5.4"
 end

data/lib/pagseguro_decimal_validator.rb

@@ -1,9 +1,11 @@
 class PagseguroDecimalValidator < ActiveModel::EachValidator
   def validate_each(object, attribute, value)
-    object.errors.add(attribute, error_message) unless value.nil? || value =~ /^\d+\.\d{2}$/
+    unless value.nil? || value =~ /\A\d+\.\d{2}\z/
+      object.errors.add(attribute, error_message)
+    end
   end
 
   def error_message
     " must be a decimal and have 2 digits after the dot"
   end
-end
+end

data/spec/factories.rb

@@ -134,4 +134,4 @@ FactoryGirl.define do
     phone_ddd             11
     phone_number          993430994
   end
-end
+end

data/spec/pag_seguro/checkout_xml_spec.rb

@@ -18,9 +18,9 @@ describe PagSeguro::Payment do
     it 'should be a valid xml' do
       expect { Nokogiri::XML(payment.checkout_xml) { |config| config.options = Nokogiri::XML::ParseOptions::STRICT } }.to_not raise_error
     end
-    
+
     its(:checkout_xml){ should match(/^<\?xml.+encoding="UTF-8".+\?>$/) }
-    
+
     describe 'settings' do
       it { xml_content('checkout reference').should be_empty }
       it { xml_content('checkout extraAmount').should be_empty }
@@ -33,22 +33,22 @@ describe PagSeguro::Payment do
         before{ payment.id = 305 }
         it { xml_content('checkout reference').should == '305' }
       end
-      
+
       context 'with extra amount' do
         before{ payment.extra_amount = '10.50' }
         it { xml_content('checkout extraAmount').should == '10.50' }
       end
-      
+
       context 'with redirect url' do
         before{ payment.redirect_url = 'http://heavenstudio.com.br' }
         it { xml_content('checkout redirectURL').should == 'http://heavenstudio.com.br' }
       end
-      
+
       context 'with max uses' do
         before{ payment.max_uses = '10' }
         it { xml_content('checkout maxUses').should == '10' }
       end
-      
+
       context 'with max age' do
         before{ payment.max_age = '5000' }
         it { xml_content('checkout maxAge').should == '5000' }
@@ -65,12 +65,12 @@ describe PagSeguro::Payment do
       it { xml_collection('checkout items item quantity').should == ['4', '1', '2', '89'] }
       it { xml_collection('checkout items item shippingCost').should == ['1.00', '12.00'] }
       it { xml_collection('checkout items item weight').should == ['10', '300', '400'] }
-      
+
       it 'should escape html in item description' do
         payment.checkout_xml.should include('A Book &amp; Cover')
       end
     end
-    
+
     describe 'sender info' do
       context 'without sender' do
         it { xml_content('checkout sender name').should be_empty }
@@ -88,7 +88,7 @@ describe PagSeguro::Payment do
         it { xml_content('checkout sender phone number').should == '993430994' }
       end
     end
-    
+
     describe 'shipping info' do
       context 'without shipping' do
         it { xml_content('checkout shipping').should be_empty }

data/spec/pag_seguro/convert_field_to_digit_spec.rb

@@ -7,7 +7,7 @@ end
 describe PagSeguro::ConvertFieldToDigit do
   subject{ MyObject.new }
 
-  context "normal object" do  
+  context "normal object" do
     context "with numeric price" do
       before{ subject.price = 10.02 }
       its(:price){ should == 10.02 }
@@ -65,4 +65,4 @@ describe PagSeguro::ConvertFieldToDigit do
       its(:amount){ should == nil }
     end
   end
-end
+end

data/spec/pag_seguro/day_of_year_spec.rb

@@ -46,4 +46,4 @@ describe PagSeguro::DayOfYear do
       build(:day_of_year).should be == build(:day_of_year)
     end
   end
-end
+end

data/spec/pag_seguro/errors/unknown_error_spec.rb

@@ -4,7 +4,7 @@ class MockResponse
   def code
     10000
   end
-  
+
   def body
     " error description"
   end
@@ -14,4 +14,4 @@ describe PagSeguro::Errors::UnknownError do
   it "should be able to raise an unknown error" do
     lambda { raise PagSeguro::Errors::UnknownError.new(MockResponse.new) }.should raise_error(PagSeguro::Errors::UnknownError, "Unknown response code (10000):\n error description")
   end
-end
+end

data/spec/pag_seguro/integration/checkout_spec.rb

@@ -9,7 +9,7 @@ describe PagSeguro::Payment do
       pending "You need to set your token for your PagSeguro account in spec/pag_seguro/integration/config.yml in order to run this spec"
     end
   end
-  
+
   context "with all fields" do
     let(:payment){ build :payment_with_all_fields, email: EMAIL, token: TOKEN }
     subject { payment }
@@ -37,7 +37,7 @@ describe PagSeguro::Payment do
   context "with items" do
     let(:payment){ build :payment_with_items, email: EMAIL, token: TOKEN }
     subject { payment }
-    
+
     its('code.size'){ should == 32 }
     its(:date){ should be_an_instance_of(DateTime) }
 
@@ -52,9 +52,9 @@ describe PagSeguro::Payment do
       expect { payment.code }.to raise_error(PagSeguro::Errors::InvalidData)
     end
   end
-    
+
   it "should raise unauthorized error if email and token do not match" do
     payment = build :payment, email: "not_a_user@not_an_email.com", token: "NOTATOKEN7F048A09A8AEFDD1E5A7B91"
     expect { payment.code }.to raise_error(PagSeguro::Errors::Unauthorized)
   end
-end
+end

data/spec/pag_seguro/integration/notification_spec.rb

@@ -13,7 +13,7 @@ describe PagSeguro::Notification do
       @notification = PagSeguro::Notification.new(EMAIL, TOKEN, NOTIFICATION_CODE)
     end
   end
-  
+
   it { @notification.transaction_id.should be_present }
   it { @notification.date.should be_present }
   it { @notification.id.should be_present }
@@ -38,7 +38,7 @@ describe PagSeguro::Notification do
       item.quantity.should be_present
     end
   end
-  
+
   it { @notification.sender.email.should be_present }
   it { @notification.shipping.type.should be_present }
-end
+end

data/spec/pag_seguro/integration/query_spec.rb

@@ -14,7 +14,7 @@ describe PagSeguro::Query do
         @query = PagSeguro::Query.new(EMAIL, TOKEN, TRANSACTION_ID)
       end
     end
-    
+
     it { @query.transaction_id.should be_present }
     it { @query.date.should be_present }
     it { @query.id.should be_present }
@@ -39,7 +39,7 @@ describe PagSeguro::Query do
         item.quantity.should be_present
       end
     end
-    
+
     it { @query.sender.email.should be_present }
     it { @query.shipping.type.should be_present }
   end

data/spec/pag_seguro/item_spec.rb

@@ -15,7 +15,7 @@ describe PagSeguro::Item do
   it { should validate_presence_of :id }
   it { should validate_presence_of :description }
   it { should validate_presence_of :amount }
-  
+
   it { should_not allow_value(nil).for(:quantity) }
   it { should_not allow_value(0).for(:quantity) }
   it { should_not allow_value(1000).for(:quantity) }
@@ -25,13 +25,15 @@ describe PagSeguro::Item do
   it { should_not allow_value("10,50").for(:amount) }
   it { should_not allow_value("R$ 10.50").for(:amount) }
   it { should_not allow_value("-10.50").for(:amount) }
+  it { should_not allow_value("10.50\nanything").for(:amount) }
   it { should allow_value("10.50").for(:amount) }
   it { should allow_value(10).for(:amount) }
   it { should allow_value(BigDecimal.new("10.5")).for(:amount) }
-  
+
   it { should_not allow_value("10,50").for(:shipping_cost) }
   it { should_not allow_value("R$ 10.50").for(:shipping_cost) }
   it { should_not allow_value("-10.50").for(:shipping_cost) }
+  it { should_not allow_value("10.50\nanything").for(:shipping_cost) }
   it { should allow_value("10.50").for(:shipping_cost) }
   it { should allow_value(10).for(:shipping_cost) }
   it { should allow_value(BigDecimal.new("10.5")).for(:shipping_cost) }
@@ -41,7 +43,7 @@ describe PagSeguro::Item do
   it { should_not allow_value("0").for(:quantity) }
   it { should_not allow_value("-1").for(:quantity) }
   it { should allow_value("1").for(:quantity) }
-    
+
   it { should_not allow_value("-10").for(:weight) }
   it { should_not allow_value("10.5").for(:weight) }
   it { should_not allow_value("10,5").for(:weight) }
@@ -50,4 +52,4 @@ describe PagSeguro::Item do
   it "should trim description to 100 characters if it has more than 100 characters" do
     PagSeguro::Item.new(description: "-" * 101).description.size.should == 100
   end
-end
+end

data/spec/pag_seguro/payment_method_spec.rb

@@ -3,28 +3,28 @@ require 'spec_helper'
 
 describe PagSeguro::PaymentMethod do
   it { should have_attribute_accessor(:code) }
-  it { should have_attribute_accessor(:type) }      
-    
+  it { should have_attribute_accessor(:type) }
+
   context "initalized with code and type" do
     subject { build :payment_method, code: "101", type: "1" }
 
     its(:code){ should == 101 }
     its(:type){ should == 1 }
   end
-    
+
   describe "types" do
     let(:payment_method){ PagSeguro::PaymentMethod.new }
-    
+
     context "with type 1" do
       subject { build :payment_method, type: 1 }
       it { should be_credit_card }
     end
-    
+
     context "with if type 2" do
       subject { build :payment_method, type: 2 }
       it { should be_bank_bill }
     end
-    
+
     context "with if type 3" do
       subject { build :payment_method, type: 3 }
       it { should be_online_debit }
@@ -34,18 +34,18 @@ describe PagSeguro::PaymentMethod do
       subject { build :payment_method, type: 4 }
       it { should be_pag_seguro_balance }
     end
-    
+
     context "with type 5" do
       subject { build :payment_method, type: 5 }
       it { should be_oi_paggo }
     end
   end
-    
+
   describe "codes" do
     def should_have_meaning_for_code(meaning, code)
       PagSeguro::PaymentMethod.new(code: code).name.should be == meaning
     end
-    
+
     it { should_have_meaning_for_code("Cartão de crédito Visa", 101) }
     it { should_have_meaning_for_code("Cartão de crédito MasterCard", 102) }
     it { should_have_meaning_for_code("Cartão de crédito American Express", 103) }
@@ -68,4 +68,4 @@ describe PagSeguro::PaymentMethod do
     it { should_have_meaning_for_code("Oi Paggo", 501) }
     it { should_have_meaning_for_code("Desconhecido", 0) }
   end
-end
+end

data/spec/pag_seguro/payment_spec.rb

@@ -48,14 +48,15 @@ describe PagSeguro::Payment do
 
     it { validate_presence_of :email }
     it { validate_presence_of :token }
-    
+
     it { should_not allow_value('10,50').for(:extra_amount) }
     it { should_not allow_value('R$ 10.50').for(:extra_amount) }
     it { should_not allow_value('-10.50').for(:extra_amount) }
+    it { should_not allow_value('10.50\nanything').for(:extra_amount) }
     it { should allow_value('10.50').for(:extra_amount) }
     it { should allow_value(10).for(:extra_amount) }
     it { should allow_value(BigDecimal.new('10.5')).for(:extra_amount) }
-        
+
     it { should_not allow_value('something.com.br').for(:redirect_url)}
     it { should allow_value('http://something.com.br').for(:redirect_url)}
 
@@ -85,17 +86,17 @@ describe PagSeguro::Payment do
       subject { build :payment_with_item }
       it { should be_valid }
     end
-  
+
     context 'checking out' do
       let(:payment){ build(:payment) }
       it 'should generate a checkout url with an external code' do
         PagSeguro::Payment.checkout_payment_url('aabbcc').should == 'https://pagseguro.uol.com.br/v2/checkout/payment.html?code=aabbcc'
       end
-      
+
       it 'should have a checkout_url_with_params' do
         payment.checkout_url_with_params.should == 'https://ws.pagseguro.uol.com.br/v2/checkout?email=myemail&token=mytoken'
       end
-      
+
       it 'should generate a checkout url based on the received response' do
         payment.stub code: 'aabbcc'
         payment.checkout_payment_url.should == 'https://pagseguro.uol.com.br/v2/checkout/payment.html?code=aabbcc'
@@ -109,18 +110,18 @@ describe PagSeguro::Payment do
         PagSeguro::Payment.any_instance.stub_chain(:send_checkout, :body){ 'some body info' }
         expect { payment.send(:parse_checkout_response) }.to_not raise_error
       end
-      
+
       it 'should raise PagSeguro::Errors::InvalidData if response code is 400' do
         PagSeguro::Payment.any_instance.stub_chain(:send_checkout, :code){ 400 }
         PagSeguro::Payment.any_instance.stub_chain(:send_checkout, :body){ 'some error description' }
         expect { payment.send(:parse_checkout_response) }.to raise_error(PagSeguro::Errors::InvalidData)
       end
-      
+
       it 'should raise PagSeguro::Errors::Unauthorized if response code is 400' do
         PagSeguro::Payment.any_instance.stub_chain(:send_checkout, :code){ 401 }
         expect { payment.send(:parse_checkout_response) }.to raise_error(PagSeguro::Errors::Unauthorized)
       end
-            
+
       it 'should raise PagSeguro::Errors::UnknownError if response code is not 200, 400 or 401' do
         PagSeguro::Payment.any_instance.stub_chain(:send_checkout, :code){ 300 }
         PagSeguro::Payment.any_instance.stub_chain(:send_checkout, :body){ 'some response body' }
@@ -132,7 +133,7 @@ describe PagSeguro::Payment do
         PagSeguro::Payment.any_instance.stub_chain(:send_checkout, :body){ 'some response body' }
         expect { payment.send(:parse_checkout_response) }.to change { payment.response }.from(nil).to('some response body')
       end
-      
+
       it 'should be able to reset response' do
         payment.response = 'something'
         expect { payment.reset! }.to change{ payment.response }.from('something').to(nil)
@@ -179,4 +180,4 @@ describe PagSeguro::Payment do
       payment.date
     end
   end
-end
+end

data/spec/pag_seguro/pre_approval_spec.rb

@@ -47,7 +47,7 @@ describe PagSeguro::PreApproval do
     it { should_not allow_value( Time.now - 10.minutes + 5.days ).for(:final_date) }
     it { should allow_value( Time.now + 5.days ).for(:final_date) }
     it { should allow_value( (PagSeguro::PreApproval::DATE_RANGE - 5.minutes + 5.days).from_now ).for(:final_date) }
-    it { should_not allow_value( PagSeguro::PreApproval::DATE_RANGE.from_now + 5.minutes + 5.days ).for(:final_date) }    
+    it { should_not allow_value( PagSeguro::PreApproval::DATE_RANGE.from_now + 5.minutes + 5.days ).for(:final_date) }
   end
 
   describe "initialized with minimum attributes" do
@@ -101,6 +101,7 @@ describe PagSeguro::PreApproval do
       it { should allow_value('01-01').for(:day_of_year) }
       it { should allow_value(PagSeguro::DayOfYear.new(month: 1, day: 1)).for(:day_of_year) }
       it { should_not allow_value('1-1').for(:day_of_year) }
+      it { should_not allow_value("10-22\nanything").for(:day_of_year) }
 
       its(:period){ should == 'yearly' }
       its(:day_of_year){ should == '03-01' }
@@ -109,4 +110,4 @@ describe PagSeguro::PreApproval do
       it { should be_yearly }
     end
   end
-end
+end

data/spec/pag_seguro/query_spec.rb

@@ -33,7 +33,7 @@ describe PagSeguro::Query do
         PagSeguro::Query.stub(search_params: params)
         RestClient.should_receive(:get).with("https://ws.pagseguro.uol.com.br/v2/transactions/abandoned", params: params)
         PagSeguro::Query.find "email", "token", abandoned: true
-      end      
+      end
     end
 
     context "with a stubbed response" do
@@ -60,7 +60,7 @@ describe PagSeguro::Query do
       it { search_params.keys.should_not include :page }
       it { search_params[:finalDate].should include Date.today.iso8601 }
       it { search_params[:initialDate].should include Date.yesterday.iso8601 }
-      
+
       it "should call parse_dates" do
         PagSeguro::Query.should_receive(:parse_dates)
         search_params

data/spec/pag_seguro/sender_spec.rb

@@ -2,12 +2,12 @@
 require "spec_helper"
 
 describe PagSeguro::Sender do
-  context "instance" do    
+  context "instance" do
     it { should have_attribute_accessor(:email) }
     it { should have_attribute_accessor(:name) }
     it { should have_attribute_accessor(:phone_ddd) }
     it { should have_attribute_accessor(:phone_number) }
-    
+
     context "initialized with all attributes" do
       subject { PagSeguro::Sender.new attributes_for(:sender) }
       its(:name){ should == "Stefano Diem Benatti" }
@@ -15,7 +15,7 @@ describe PagSeguro::Sender do
       its(:phone_ddd){ should == 11 }
       its(:phone_number){ should == 993430994 }
     end
-    
+
     context "with invalid e-mail" do
       subject { build :sender, email: "nothing" }
       its(:email){ should be_nil }
@@ -50,7 +50,7 @@ describe PagSeguro::Sender do
       it { should be_a_valid_name }
       its(:name){ should == "a" * 50 }
     end
-        
+
     context "with double spaces in name" do
       subject { build :sender, name: "Stefano   Benatti" }
       it { should be_a_valid_name }
@@ -67,4 +67,4 @@ describe PagSeguro::Sender do
       its(:phone_number){ should be_nil }
     end
   end
-end
+end

data/spec/pag_seguro/shipping_spec.rb

@@ -18,14 +18,14 @@ describe PagSeguro::Shipping do
 
   describe "instance" do
     subject{ build(:shipping) }
-    
+
     it { should be_valid }
     its(:cost){ should == "12.13" }
     its(:postal_code){ should == "05363000" }
 
     context "with invalid postal_code" do
       subject{ build(:shipping, postal_code: 1234567) }
-      its(:postal_code){ should be_blank }  
+      its(:postal_code){ should be_blank }
     end
 
     context "with type 1" do
@@ -43,4 +43,4 @@ describe PagSeguro::Shipping do
       it { should be_unidentified }
     end
   end
-end
+end

data/spec/pag_seguro/transaction_spec.rb

@@ -5,6 +5,6 @@ require 'spec_helper'
 describe PagSeguro::Transaction do
   let(:transaction){ PagSeguro::Transaction.new(transaction_xml) }
   subject{ PagSeguro::Transaction }
-  
+
   it_behaves_like "a transaction"
-end
+end

data/spec/pag_seguro/version_spec.rb

@@ -4,4 +4,4 @@ describe PagSeguro do
   it "should have a version" do
     PagSeguro::VERSION.should_not be_empty
   end
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pag_seguro
 version: !ruby/object:Gem::Version
-  version: 0.5.3
+  version: 0.5.4
 platform: ruby
 authors:
 - Stefano Diem Benatti
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-04 00:00:00.000000000 Z
+date: 2013-05-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel