pact_broker 2.62.0 → 2.63.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0d90410ba82c9f6ee8681073d1a9435660abf73045fa4ea08658294512771106
-  data.tar.gz: ff2c697fa385d574c26225ebf3aa6bb93276a749bfc6851685dc17728aa18fb0
+  metadata.gz: 61338a93bd65ffa3ec70f4fdfd9b509a0d5c0608dce8cea3f779e3ac22151412
+  data.tar.gz: 99819023ba051657020d314fe6d3005a04660d70467a57c5b5369a08a5525e2a
 SHA512:
-  metadata.gz: 95c87ab86bd54c472362e678a8fd6307637ad34059beb390baf59fa33456014ed47bd725940fe792ffd7151c80201baf9c063d670b7ed4c857708c22e60e352a
-  data.tar.gz: 3c101564948c497f80d286eccfd70cc92734c5a94b280825bd437c3a6ab4141caf7e98fefb6594b230d0021bba732c44704e9338df081c630d752f0bbb3140cc
+  metadata.gz: 7da446c51346413782377eb409c2d3159fcb322147d675324126243bfb8b115ff042d210b3cf25ee46ebe73093611e4de85db03f243c5ffb06299239d6aff637
+  data.tar.gz: 6b191f39b782bf811d58e15d149fa5e786227e6a86d93c0f8888a6134b992d6f60ad58ff2b2b6cf84ba612b72368cf569471b9214b85f7ce173e18872e89ddec

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+<a name="v2.63.0"></a>
+### v2.63.0 (2020-09-25)
+
+#### Features
+
+* allow label of can-i-deploy badge to be customised by setting the label query parameter	 ([ed544f94](/../../commit/ed544f94))
+* add badges for can-i-deploy	 ([887a9ca3](/../../commit/887a9ca3))
+
 <a name="v2.62.0"></a>
 ### v2.62.0 (2020-09-23)
 

data/lib/pact_broker/api.rb

@@ -71,6 +71,7 @@ module PactBroker
         add ['pacticipants', :pacticipant_name, 'versions'], Api::Resources::Versions, {resource_name: "pacticipant_versions"}
         add ['pacticipants', :pacticipant_name, 'versions', :pacticipant_version_number], Api::Resources::Version, {resource_name: "pacticipant_version"}
         add ['pacticipants', :pacticipant_name, 'latest-version', :tag], Api::Resources::Version, {resource_name: "latest_tagged_pacticipant_version"}
+        add ['pacticipants', :pacticipant_name, 'latest-version', :tag, 'can-i-deploy', 'to', :to, 'badge'], Api::Resources::CanIDeployBadge, { resource_name: "can_i_deploy_badge" }
         add ['pacticipants', :pacticipant_name, 'latest-version'], Api::Resources::Version, {resource_name: "latest_pacticipant_version"}
         add ['pacticipants', :pacticipant_name, 'versions', :pacticipant_version_number, 'tags', :tag_name], Api::Resources::Tag, {resource_name: "pacticipant_version_tag"}
         add ['pacticipants', :pacticipant_name, 'labels', :label_name], Api::Resources::Label, {resource_name: "pacticipant_label"}

data/lib/pact_broker/api/decorators/pacticipant_decorator.rb

@@ -58,6 +58,22 @@ module PactBroker
           }
         end
 
+        link :'pb:can-i-deploy-badge' do | options |
+          {
+            title: "Can I Deploy #{represented.name} badge",
+            href: templated_can_i_deploy_badge_url(represented.name, options[:base_url]),
+            templated: true
+          }
+        end
+
+        curies do | options |
+          [{
+            name: :pb,
+            href: options[:base_url] + '/doc/{rel}?context=pacticipant',
+            templated: true
+          }]
+        end
+
         def to_hash options
           h = super
           dasherized = DasherizedVersionDecorator.new(represented).to_hash(options)

data/lib/pact_broker/api/pact_broker_urls.rb

@@ -197,11 +197,15 @@ module PactBroker
       end
 
       def templated_tag_url_for_pacticipant pacticipant_name, base_url = ""
-        pacticipant_url_from_params({pacticipant_name: pacticipant_name}, base_url) + "/versions/{version}/tags/{tag}"
+        pacticipant_url_from_params({ pacticipant_name: pacticipant_name }, base_url) + "/versions/{version}/tags/{tag}"
       end
 
       def templated_label_url_for_pacticipant pacticipant_name, base_url = ""
-        pacticipant_url_from_params({pacticipant_name: pacticipant_name}, base_url) + "/labels/{label}"
+        pacticipant_url_from_params({ pacticipant_name: pacticipant_name }, base_url) + "/labels/{label}"
+      end
+
+      def templated_can_i_deploy_badge_url pacticipant_name, base_url = ""
+        pacticipant_url_from_params({ pacticipant_name: pacticipant_name }, base_url) + "/latest-version/{tag}/can-i-deploy/to/{environmentTag}/badge"
       end
 
       def label_url label, base_url

data/lib/pact_broker/api/resources/can_i_deploy_badge.rb

@@ -0,0 +1,85 @@
+require 'pact_broker/matrix/can_i_deploy_query_schema'
+require 'pact_broker/matrix/parse_can_i_deploy_query'
+
+module PactBroker
+  module Api
+    module Resources
+      class CanIDeployBadge < BaseResource
+        def initialize
+          super
+          selector = PactBroker::Matrix::UnresolvedSelector.new(pacticipant_name: pacticipant_name, latest: true, tag: identifier_from_path[:tag])
+          @options = {
+            latestby: 'cvp',
+            latest: true,
+            tag: identifier_from_path[:to]
+          }
+          @selectors = [selector]
+        end
+
+        def allowed_methods
+          ["GET", "OPTIONS"]
+        end
+
+        def content_types_provided
+          [['image/svg+xml', :to_svg]]
+        end
+
+        def resource_exists?
+          false
+        end
+
+        # Only called if resource_exists? returns false
+        def previously_existed?
+          true
+        end
+
+        def is_authorized?(authorization_header)
+          super || PactBroker.configuration.enable_public_badge_access
+        end
+
+        def forbidden?
+          false
+        end
+
+        def moved_temporarily?
+          response.headers['Cache-Control'] = 'no-cache'
+          begin
+            if pacticipant
+              if version
+                badge_service.can_i_deploy_badge_url(pacticipant_name, identifier_from_path[:tag], identifier_from_path[:to], label, results.deployable?)
+              else
+                badge_service.error_badge_url("version", "not found")
+              end
+            else
+              badge_service.error_badge_url(selectors.first.pacticipant_name, "not found")
+            end
+          rescue StandardError => e
+            # Want to render a badge, even if there's an error
+            badge_service.error_badge_url("error", ErrorHandler.display_message(e, "reference: #{ErrorHandler.generate_error_reference}"))
+          end
+        end
+
+        def policy_name
+          :'badges::badge'
+        end
+
+        private
+
+        attr_reader :selectors, :options
+
+        def results
+          @results ||= matrix_service.find(selectors, options)
+        end
+
+        def version
+          @version ||= version_service.find_by_pacticipant_name_and_latest_tag(identifier_from_path[:pacticipant_name], identifier_from_path[:tag])
+        end
+
+        def label
+          lab = request.query['label']
+          lab && !lab.empty? ? lab : nil
+        end
+      end
+    end
+  end
+end

data/lib/pact_broker/api/resources/error_handler.rb

@@ -32,11 +32,11 @@ module PactBroker
           PactBroker.configuration.warning_error_classes.any? { |clazz| e.is_a?(clazz) }
         end
 
-        def self.display_message(e, error_reference)
+        def self.display_message(e, obfuscated_message)
           if PactBroker.configuration.show_backtrace_in_error_response?
-            e.message || obfuscated_error_message(error_reference)
+            e.message || obfuscated_message
           else
-           reportable?(e) ? obfuscated_error_message(error_reference) : e.message
+           reportable?(e) ? obfuscated_message : e.message
           end
         end
 
@@ -47,7 +47,7 @@ module PactBroker
         def self.response_body_hash e, error_reference
           response_body = {
             error: {
-              message: display_message(e, error_reference),
+              message: display_message(e, obfuscated_error_message(error_reference)),
               reference: error_reference
             }
           }

data/lib/pact_broker/api/resources/version.rb

@@ -6,7 +6,6 @@ module PactBroker
   module Api
     module Resources
       class Version < BaseResource
-
         def content_types_provided
           [["application/hal+json", :to_json]]
         end
@@ -20,7 +19,7 @@ module PactBroker
         end
 
         def to_json
-          Decorators::VersionDecorator.new(version).to_json(user_options: {base_url: base_url})
+          Decorators::VersionDecorator.new(version).to_json(decorator_options)
         end
 
         def delete_resource
@@ -35,12 +34,12 @@ module PactBroker
         private
 
         def version
-          if path_info[:tag]
-            @version ||= version_service.find_by_pacticipant_name_and_latest_tag(path_info[:pacticipant_name], path_info[:tag])
-          elsif path_info[:pacticipant_version_number]
-            @version ||= version_service.find_by_pacticipant_name_and_number path_info
+          if identifier_from_path[:tag]
+            @version ||= version_service.find_by_pacticipant_name_and_latest_tag(identifier_from_path[:pacticipant_name], identifier_from_path[:tag])
+          elsif identifier_from_path[:pacticipant_version_number]
+            @version ||= version_service.find_by_pacticipant_name_and_number(identifier_from_path)
           else
-            @version ||= version_service.find_latest_by_pacticpant_name path_info
+            @version ||= version_service.find_latest_by_pacticpant_name(identifier_from_path)
           end
         end
       end

data/lib/pact_broker/badges/service.rb

@@ -33,6 +33,17 @@ module PactBroker
         build_shield_io_uri(title, status, color)
       end
 
+      def can_i_deploy_badge_url(pacticipant_name, tag, environment_tag, label, deployable)
+        title = label || "Can I deploy #{tag} #{pacticipant_name} to #{environment_tag}?"
+        status = deployable ? "yes" : "no"
+        color = deployable ? "brightgreen" : "red"
+        build_shield_io_uri(title, status, color)
+      end
+
+      def error_badge_url(left_text, right_text)
+        build_shield_io_uri(left_text, right_text, "lightgrey")
+      end
+
       def clear_cache
         CACHE.clear
       end

data/lib/pact_broker/doc/views/pacticipant/can-i-deploy-badge.markdown

@@ -0,0 +1,9 @@
+# Can I Deploy Badge
+
+Allowed methods: `GET`
+
+Path: `/pacticipants/{pacticipant}/latest-version/{tag}/can-i-deploy/to/{environmentTag}/badge`
+
+Returns a status badge that can be displayed in a README file that indicates whether the specified version of a pacticipant can be deployed to the specified environment.
+
+To set a custom label for the badge, set the `label` query parameter. eg `?label=my+custom+label+here`.

data/lib/pact_broker/version.rb

@@ -1,3 +1,3 @@
 module PactBroker
-  VERSION = '2.62.0'
+  VERSION = '2.63.0'
 end

data/spec/features/get_can_i_deploy_badge_spec.rb

@@ -0,0 +1,13 @@
+RSpec.describe "can i deploy badge" do
+  before do
+    td.create_pact_with_hierarchy("Foo", "1.2.3", "Bar")
+      .create_consumer_version_tag("main")
+  end
+
+  subject { get("/pacticipants/Foo/latest-version/main/can-i-deploy/to/prod/badge", nil, { 'HTTP_ACCEPT' => 'image/svg+xml'}) }
+
+  it "returns a redirect response" do
+    expect(subject.status).to eq 307
+    expect(subject.headers['Location']).to start_with "https://img.shields.io/badge"
+  end
+end

data/spec/features/get_matrix_badge_spec.rb

@@ -24,7 +24,7 @@ describe "get latest matrix badge with tags" do
   # In the full app, the .svg extension is turned into an Accept header
   # by ConvertFileExtensionToAcceptHeader
 
-  subject { get path, nil, {'HTTP_ACCEPT' => "image/svg+xml"}; last_response  }
+  subject { get(path, nil, {'HTTP_ACCEPT' => "image/svg+xml"}) }
 
   it "returns a 200 status" do
     expect(subject.status).to eq 200

data/spec/lib/pact_broker/api/resources/can_i_deploy_badge_spec.rb

@@ -0,0 +1,80 @@
+require 'pact_broker/api/resources/can_i_deploy_badge'
+
+module PactBroker
+  module Api
+    module Resources
+      describe CanIDeployBadge do
+        before do
+          allow_any_instance_of(described_class).to receive(:badge_service).and_return(badge_service)
+          allow_any_instance_of(described_class).to receive(:matrix_service).and_return(matrix_service)
+          allow_any_instance_of(described_class).to receive(:pacticipant_service).and_return(pacticipant_service)
+          allow_any_instance_of(described_class).to receive(:version_service).and_return(version_service)
+          allow(badge_service).to receive(:can_i_deploy_badge_url).and_return("http://badge")
+          allow(badge_service).to receive(:error_badge_url).and_return("http://error")
+          allow(matrix_service).to receive(:find).and_return(results)
+          allow(pacticipant_service).to receive(:find_pacticipant_by_name).and_return(pacticipant)
+          allow(version_service).to receive(:find_by_pacticipant_name_and_latest_tag).and_return(version)
+          allow(PactBroker.configuration).to receive(:show_backtrace_in_error_response?).and_return(false)
+          allow(ErrorHandler).to receive(:generate_error_reference).and_return("abcd")
+        end
+
+        let(:pacticipant_service) { class_double("PactBroker::Pacticipant::Service").as_stubbed_const }
+        let(:badge_service) { class_double("PactBroker::Badges::Service").as_stubbed_const }
+        let(:matrix_service) { class_double("PactBroker::Matrix::Service").as_stubbed_const }
+        let(:version_service) { class_double("PactBroker::Version::Service").as_stubbed_const }
+        let(:results) { double('results', deployable?: true) }
+        let(:pacticipant) { double('pacticipant') }
+        let(:version) { double('version') }
+
+        let(:path) { "/pacticipants/Foo/latest-version/main/can-i-deploy/to/prod/badge"}
+
+        subject { get(path) }
+
+        context "when the pacticipant exists" do
+          it "returns a redirect to the badge" do
+            expect(badge_service).to receive(:can_i_deploy_badge_url).with("Foo", "main", "prod", nil, true)
+            expect(subject.status).to eq 307
+          end
+        end
+
+        context "when the pacticipant does not exist" do
+          let(:pacticipant) { nil }
+
+          it "returns a redirect to a 'not found' badge" do
+            expect(badge_service).to receive(:error_badge_url).with("Foo", "not found")
+            expect(subject.status).to eq 307
+          end
+        end
+
+        context "when the version does not exist" do
+          let(:version) { nil }
+
+          it "returns a redirect to a 'not found' badge" do
+            expect(badge_service).to receive(:error_badge_url).with("version", "not found")
+            expect(subject.status).to eq 307
+          end
+        end
+
+        context "with a custom label" do
+          subject { get(path, label: "some custom label") }
+
+          it "returns a redirect to a badge with a custom label" do
+            expect(badge_service).to receive(:can_i_deploy_badge_url).with("Foo", "main", "prod", "some custom label", true)
+            subject
+          end
+        end
+
+        context "when there is an error" do
+          before do
+            allow(matrix_service).to receive(:find).and_raise("foo error")
+          end
+
+          it "returns a redirect to a badge with an error message" do
+            expect(badge_service).to receive(:error_badge_url).with("error", "reference: abcd")
+            expect(subject.status).to eq 307
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pact_broker
 version: !ruby/object:Gem::Version
-  version: 2.62.0
+  version: 2.63.0
 platform: ruby
 authors:
 - Bethany Skurrie
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-09-24 00:00:00.000000000 Z
+date: 2020-09-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -642,6 +642,7 @@ files:
 - lib/pact_broker/api/resources/badge.rb
 - lib/pact_broker/api/resources/base_resource.rb
 - lib/pact_broker/api/resources/can_i_deploy.rb
+- lib/pact_broker/api/resources/can_i_deploy_badge.rb
 - lib/pact_broker/api/resources/dashboard.rb
 - lib/pact_broker/api/resources/default_base_resource.rb
 - lib/pact_broker/api/resources/error_handler.rb
@@ -761,6 +762,7 @@ files:
 - lib/pact_broker/doc/views/pact/publish-verification-results.markdown
 - lib/pact_broker/doc/views/pact/tag-prod-version.markdown
 - lib/pact_broker/doc/views/pact/tag-version.markdown
+- lib/pact_broker/doc/views/pacticipant/can-i-deploy-badge.markdown
 - lib/pact_broker/doc/views/pending-provider-pacts.markdown
 - lib/pact_broker/doc/views/provider-pacts-for-verification.markdown
 - lib/pact_broker/doc/views/provider.markdown
@@ -1052,6 +1054,7 @@ files:
 - spec/features/edit_webhook_spec.rb
 - spec/features/execute_unsaved_webhook_spec.rb
 - spec/features/execute_webhook_spec.rb
+- spec/features/get_can_i_deploy_badge_spec.rb
 - spec/features/get_dashboard_spec.rb
 - spec/features/get_diff_spec.rb
 - spec/features/get_integrations_dot_file_spec.rb
@@ -1166,6 +1169,7 @@ files:
 - spec/lib/pact_broker/api/renderers/integrations_dot_renderer_spec.rb
 - spec/lib/pact_broker/api/resources/all_webhooks_spec.rb
 - spec/lib/pact_broker/api/resources/badge_spec.rb
+- spec/lib/pact_broker/api/resources/can_i_deploy_badge_spec.rb
 - spec/lib/pact_broker/api/resources/dashboard_spec.rb
 - spec/lib/pact_broker/api/resources/default_base_resource_spec.rb
 - spec/lib/pact_broker/api/resources/error_handler_spec.rb
@@ -1438,6 +1442,7 @@ test_files:
 - spec/features/edit_webhook_spec.rb
 - spec/features/execute_unsaved_webhook_spec.rb
 - spec/features/execute_webhook_spec.rb
+- spec/features/get_can_i_deploy_badge_spec.rb
 - spec/features/get_dashboard_spec.rb
 - spec/features/get_diff_spec.rb
 - spec/features/get_integrations_dot_file_spec.rb
@@ -1552,6 +1557,7 @@ test_files:
 - spec/lib/pact_broker/api/renderers/integrations_dot_renderer_spec.rb
 - spec/lib/pact_broker/api/resources/all_webhooks_spec.rb
 - spec/lib/pact_broker/api/resources/badge_spec.rb
+- spec/lib/pact_broker/api/resources/can_i_deploy_badge_spec.rb
 - spec/lib/pact_broker/api/resources/dashboard_spec.rb
 - spec/lib/pact_broker/api/resources/default_base_resource_spec.rb
 - spec/lib/pact_broker/api/resources/error_handler_spec.rb