pact_broker 2.16.1 → 2.17.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c6d42dce83b4aaa14296c6a4121ca30a2490601d
-  data.tar.gz: 2ba4c1581817b500fd971a3828582e97a4957542
+  metadata.gz: 4a081cfe7629357b678f7769d2fdcf69b75e8e27
+  data.tar.gz: 9c8913b7ad996fb1b7d59429cd47f3451bcb5c5e
 SHA512:
-  metadata.gz: c2ea3e29cdcdbbc7c9317550824ecb8a908476888b591d299269414d4a6286fb8e52585ad21f2893a88a5e49f40b6b8c150c578d40a92fbf8519c2743afa710d
-  data.tar.gz: af24759022fc72eee95eef7840cfb123af22d37f7c3a183af985391b0b0c2632f310eafe92f881b8a59517ee0b0b358b22512455078898e82c879ad951ee8e72
+  metadata.gz: f227bb7729f0a18640ba8faffe8432ceb8ad4d6a4e07a491dd0a8443fc351c76140c54ec31143640e37bc8dec9903297eca011bc5e5a882c6fcf74aadcf33317
+  data.tar.gz: d241902a991c46875e6c396ce407a135d40a2a7318039827f624d3425a53516543ff7f9c37b79f8f27bae153fb01faefa4953c52c5419fb8dce553e3498cee7d

data/.github/ISSUE_TEMPLATE.md

@@ -0,0 +1,22 @@
+## Software versions
+
+* **pact-broker gem version:** eg 2.3.1
+* **pact-broker docker version:** eg 2.3.1-1
+* **OS**: e.g. Mac OSX 10.11.5
+* **pact broker client details:** eg. pact-ruby-standalone CLI v 1.23.0
+
+## Expected behaviour
+
+TBC
+
+## Actual behaviour
+
+TBC
+
+## Steps to reproduce
+
+Provide a repository, gist or reproducable code snippet so that we can test the problem.
+
+## Relevent log files
+
+Please ensure you set logging to `DEBUG` and attach any relevant log files here (or link from a gist).

data/.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,9 @@
+# Pull request guidelines
+
+* Please [squash your commits](squash) into one commit.
+* Please use [semantic commit messages](semantic-commit-messages) so that your changes will show up correctly in the generated change log.
+* Please ensure you have followed the guidelines in [CONTRIBUTING.md](./CONTRIBUTING.md)
+* And please remove this text before opening a PR
+
+[semantic-commit-messages]: http://karma-runner.github.io/2.0/dev/git-commit-msg.html
+[squash]: https://github.com/todotxt/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit

data/CHANGELOG.md

@@ -1,3 +1,31 @@
+<a name="v2.17.0"></a>
+### v2.17.0 (2018-03-30)
+
+
+#### Features
+
+* ensure migrations in optimise_head_matrix work on mysql	 ([35874a9](/../../commit/35874a9))
+* show verification number in matrix when viewing all results	 ([5693430](/../../commit/5693430))
+* redact auth headers from rack env used to report errors	 ([94f8f13](/../../commit/94f8f13))
+* add api error reporters	 ([579fa39](/../../commit/579fa39))
+* log debug message when loading configuration setting from database	 ([9ffcc1a](/../../commit/9ffcc1a))
+* optimise head matrix refresh when adding or deleting tags	 ([263c2a4](/../../commit/263c2a4))
+* disable sinatra dump_errors	 ([d59c7e5](/../../commit/d59c7e5))
+* send padrino logs to a file in the log dir by default	 ([7408be0](/../../commit/7408be0))
+
+* **matrix ui**
+  * add tooltip explaining the situation when verification date is before pact publication date	 ([fd6e1c9](/../../commit/fd6e1c9))
+  * change default to show all results	 ([f7bea07](/../../commit/f7bea07))
+
+
+#### Bug Fixes
+
+* ensure publishing a verification does not cause a unique constraint violation	 ([ecfb385](/../../commit/ecfb385))
+* optimize matrix query to speed up lengthy pact publication times	 ([e09d528](/../../commit/e09d528))
+* ensure matrix is updated when pacticipant is deleted	 ([6c11cbe](/../../commit/6c11cbe))
+* delete pacticipant labels before deleting pacticipant	 ([18b9b7e](/../../commit/18b9b7e))
+
+
 <a name="v2.16.1"></a>
 ### v2.16.1 (2018-03-08)
 

data/DEVELOPER_DOCUMENTATION.md

@@ -86,3 +86,8 @@ materialized_head_matrix table (is populated from...)
             -> versions table
       -> latest_verification_id_for_consumer_version_and_provider_version view
       -> latest_pact_publication_revision_numbers view
+
+### Useful to know stuff
+
+* The supported database types are Postgres (recommended), MySQL (sigh) and Sqlite (just for testing, not recommended for production). Check the travis.yml file for the supported database versions.
+* Any migration that uses the "order" column has to be defined using the Sequel DSL rather than pure SQL, because the word "order" is a key word, and it has to be escaped correctly and differently on each database (Postgres, MySQL, Sqlite).

data/db/migrations/000046_recreate_latest_verifications.rb

@@ -5,8 +5,8 @@ Sequel.migration do
           FROM verifications
           GROUP BY pact_version_id")
 
-    # The most recent verification for each pact version
-    # provider_version is DEPRECATED, use provider_version_number
+    # The most recent verification for each pact_version
+    # provider_version column is DEPRECATED, use provider_version_number
     create_or_replace_view(:latest_verifications,
       "SELECT v.id, v.number, v.success, s.number as provider_version, v.build_url, v.pact_version_id, v.execution_date, v.created_at, v.provider_version_id, s.number as provider_version_number
         FROM verifications v

data/db/migrations/20180311_optimise_head_matrix.rb

@@ -0,0 +1,80 @@
+require_relative 'migration_helper'
+
+Sequel.migration do
+  up do
+    pp = :pact_publications
+    # For each consumer_id/provider_id/tag_name, the version order of the latest version that has a pact
+    create_or_replace_view(:latest_tagged_pact_consumer_version_orders,
+      from(:pact_publications)
+        .select_group(
+          Sequel[pp][:provider_id],
+          Sequel[:cv][:pacticipant_id].as(:consumer_id),
+          Sequel[:t][:name].as(:tag_name))
+        .select_append{ max(order).as(latest_consumer_version_order) }
+        .join(:versions, { Sequel[pp][:consumer_version_id] => Sequel[:cv][:id] }, { table_alias: :cv} )
+        .join(:tags, { Sequel[:t][:version_id] => Sequel[pp][:consumer_version_id] }, { table_alias: :t })
+    )
+
+    # Add provider_version_order to original definition
+    v = :verifications
+    create_or_replace_view(:latest_verifications,
+      from(v)
+        .select(
+          Sequel[v][:id],
+          Sequel[v][:number],
+          Sequel[v][:success],
+          Sequel[:s][:number].as(:provider_version),
+          Sequel[v][:build_url],
+          Sequel[v][:pact_version_id],
+          Sequel[v][:execution_date],
+          Sequel[v][:created_at],
+          Sequel[v][:provider_version_id],
+          Sequel[:s][:number].as(:provider_version_number),
+          Sequel[:s][:order].as(:provider_version_order))
+        .join(:latest_verification_numbers,
+          {
+            Sequel[v][:pact_version_id] => Sequel[:lv][:pact_version_id],
+            Sequel[v][:number] => Sequel[:lv][:latest_number]
+          }, { table_alias: :lv })
+        .join(:versions,
+          {
+            Sequel[v][:provider_version_id] => Sequel[:s][:id]
+          }, { table_alias: :s })
+    )
+
+
+    create_or_replace_view(:head_matrix,
+      "
+      select
+        p.consumer_id, p.consumer_name, p.consumer_version_id, p.consumer_version_number, p.consumer_version_order,
+        p.id as pact_publication_id, p.pact_version_id, p.pact_version_sha, p.revision_number as pact_revision_number,
+        p.created_at as pact_created_at,
+        p.provider_id, p.provider_name, lv.provider_version_id, lv.provider_version_number, lv.provider_version_order,
+        lv.id as verification_id, lv.success, lv.number as verification_number, lv.execution_date as verification_executed_at,
+        lv.build_url as verification_build_url,
+        null as consumer_version_tag_name
+      from latest_pact_publications p
+      left outer join latest_verifications lv
+        on p.pact_version_id = lv.pact_version_id
+
+      union all
+
+      select
+        p.consumer_id, p.consumer_name, p.consumer_version_id, p.consumer_version_number, p.consumer_version_order,
+        p.id as pact_publication_id, p.pact_version_id, p.pact_version_sha, p.revision_number as pact_revision_number,
+        p.created_at as pact_created_at,
+        p.provider_id, p.provider_name, lv.provider_version_id, lv.provider_version_number, lv.provider_version_order,
+        lv.id as verification_id, lv.success, lv.number as verification_number, lv.execution_date as verification_executed_at,
+        lv.build_url as verification_build_url,
+        lt.tag_name as consumer_version_tag_name
+      from latest_tagged_pact_consumer_version_orders lt
+      inner join latest_pact_publications_by_consumer_versions p
+        on lt.consumer_id = p.consumer_id
+        and lt.provider_id = p.provider_id
+        and lt.latest_consumer_version_order = p.consumer_version_order
+      left outer join latest_verifications lv
+        on p.pact_version_id = lv.pact_version_id
+      "
+    )
+  end
+end

data/db/migrations/20180315_create_verification_sequence.rb

@@ -0,0 +1,14 @@
+Sequel.migration do
+  up do
+    create_table(:verification_sequence_number) do
+      Integer :value, null: false
+    end
+
+    start = (from(:verifications).max(:number) || 0) + 100
+    from(:verification_sequence_number).insert(value: start)
+  end
+
+  down do
+    drop_table(:verification_sequence_number)
+  end
+end

data/db/migrations/migration_helper.rb

@@ -24,7 +24,7 @@ module PactBroker
 
     def sqlite_safe string
       if adapter == 'sqlite'
-        string.gsub(/\border\b/, '`order`')
+        string.gsub(/(?:\b|")order(?:"|\b)/, '`order`')
       else
         string
       end

data/lib/db.rb

@@ -35,8 +35,9 @@ module DB
   end
 
   def self.connection_for_env env
-    logger.info "Connecting to #{env} database."
-    connect configuration_for_env(env)
+    config = configuration_for_env(env)
+    logger.info "Connecting to #{env} #{config['adapter']} database #{config['database']}."
+    connect config
   end
 
   def self.configuration_for_env env

data/lib/pact_broker/api/resources/base_resource.rb

@@ -1,4 +1,5 @@
 require 'webmachine'
+require 'pact_broker/api/resources/error_handler'
 require 'pact_broker/services'
 require 'pact_broker/api/decorators'
 require 'pact_broker/logging'
@@ -15,17 +16,6 @@ module PactBroker
 
       class InvalidJsonError < StandardError ; end
 
-      class ErrorHandler
-
-        include PactBroker::Logging
-
-        def self.handle_exception e, response
-          logger.error e
-          logger.error e.backtrace
-          response.body = {:message => e.message, :backtrace => e.backtrace }.to_json
-        end
-      end
-
       class BaseResource < Webmachine::Resource
 
         include PactBroker::Services
@@ -40,8 +30,12 @@ module PactBroker
           PactBroker.configuration.before_resource.call(self)
         end
 
+        def update_matrix_after_request?
+          false
+        end
+
         def finish_request
-          if !request.get? && !request.head?
+          if update_matrix_after_request?
             matrix_service.refresh(identifier_from_path)
           end
           PactBroker.configuration.after_resource.call(self)
@@ -86,7 +80,7 @@ module PactBroker
         end
 
         def handle_exception e
-          PactBroker::Api::Resources::ErrorHandler.handle_exception(e, response)
+          PactBroker::Api::Resources::ErrorHandler.call(e, request, response)
         end
 
         def params
@@ -155,6 +149,9 @@ module PactBroker
           invalid
         end
 
+        def with_matrix_refresh &block
+          matrix_service.refresh(identifier_from_path, &block)
+        end
       end
     end
   end

data/lib/pact_broker/api/resources/error_handler.rb

@@ -0,0 +1,30 @@
+require 'webmachine/convert_request_to_rack_env'
+require 'pact_broker/configuration'
+
+module PactBroker
+  module Api
+    module Resources
+      class ErrorHandler
+
+        include PactBroker::Logging
+
+        def self.call e, request, response
+          logger.error e
+          logger.error e.backtrace
+          response.body = {:message => e.message, :backtrace => e.backtrace }.to_json
+          report e, request
+        end
+
+        def self.report e, request
+          PactBroker.configuration.api_error_reporters.each do | error_notifier |
+            begin
+              error_notifier.call(e, env: Webmachine::ConvertRequestToRackEnv.call(request))
+            rescue StandardError => e
+              log_error(e, "Error executing api_error_reporter")
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/pact_broker/api/resources/pact.rb

@@ -87,7 +87,9 @@ module PactBroker
         end
 
         def delete_resource
-          pact_service.delete(pact_params)
+          with_matrix_refresh do
+            pact_service.delete(pact_params)
+          end
           true
         end
 
@@ -101,6 +103,9 @@ module PactBroker
           @pact_params ||= PactBroker::Pacts::PactParams.from_request request, path_info
         end
 
+        def update_matrix_after_request?
+          request.put? || request.patch?
+        end
       end
     end
   end

data/lib/pact_broker/api/resources/pacticipant.rb

@@ -45,7 +45,9 @@ module PactBroker
         end
 
         def delete_resource
-          pacticipant_service.delete pacticipant_name
+          with_matrix_refresh do
+            pacticipant_service.delete pacticipant_name
+          end
           true
         end
 
@@ -60,7 +62,11 @@ module PactBroker
         end
 
         def pacticipant_name
-          identifier_from_path[:name]
+          identifier_from_path[:pacticipant_name]
+        end
+
+        def update_matrix_after_request?
+          request.patch?
         end
       end
     end

data/lib/pact_broker/api/resources/tag.rb

@@ -22,6 +22,7 @@ module PactBroker
             @tag = tag_service.create identifier_from_path
             # Make it return a 201 by setting the Location header
             response.headers["Location"] = tag_url(base_url, tag)
+            matrix_service.refresh_tags(identifier_from_path)
           end
           response.body = to_json
         end
@@ -39,10 +40,11 @@ module PactBroker
         end
 
         def delete_resource
-          tag_service.delete identifier_from_path
+          matrix_service.refresh_tags(identifier_from_path) do
+            tag_service.delete identifier_from_path
+          end
           true
         end
-
       end
     end
 

data/lib/pact_broker/api/resources/verifications.rb

@@ -55,12 +55,16 @@ module PactBroker
         end
 
         def next_verification_number
-          @next_verification_number ||= verification_service.next_number_for(pact)
+          @next_verification_number ||= verification_service.next_number
         end
 
         def decorator_for model
           PactBroker::Api::Decorators::VerificationDecorator.new(model)
         end
+
+        def update_matrix_after_request?
+          request.post?
+        end
       end
     end
   end

data/lib/pact_broker/api/resources/version.rb

@@ -25,7 +25,9 @@ module PactBroker
         end
 
         def delete_resource
-          version_service.delete version
+          with_matrix_refresh do
+            version_service.delete version
+          end
           true
         end
 

data/lib/pact_broker/api.rb

@@ -41,7 +41,7 @@ module PactBroker
         # Pacticipants
         add ['pacticipants'], Api::Resources::Pacticipants, {resource_name: "pacticipants"}
         add ['pacticipants', 'label', :label_name], PactBroker::Api::Resources::PacticipantsForLabel, {resource_name: "pacticipants_for_label"}
-        add ['pacticipants', :name], Api::Resources::Pacticipant, {resource_name: "pacticipant"}
+        add ['pacticipants', :pacticipant_name], Api::Resources::Pacticipant, {resource_name: "pacticipant"}
         add ['pacticipants', :pacticipant_name, 'versions'], Api::Resources::Versions, {resource_name: "pacticipant_versions"}
         add ['pacticipants', :pacticipant_name, 'versions', :pacticipant_version_number], Api::Resources::Version, {resource_name: "pacticipant_version"}
         add ['pacticipants', :pacticipant_name, 'latest-version', :tag], Api::Resources::Version, {resource_name: "latest_tagged_pacticipant_version"}

data/lib/pact_broker/config/load.rb

@@ -32,6 +32,7 @@ module PactBroker
 
       def set_value_on_configuration setting
         if configuration_attribute_exists? setting
+          logger.debug("Loading #{setting.name} configuration from database.")
           configuration.send("#{setting.name}=", get_value_from_setting(setting))
         else
           logger.warn("Could not load configuration setting \"#{setting.name}\" as there is no matching attribute on the Configuration class")

data/lib/pact_broker/configuration.rb

@@ -1,5 +1,9 @@
+require 'pact_broker/error'
+
 module PactBroker
 
+  class ConfigurationError < PactBroker::Error; end
+
   def self.configuration
     @@configuration ||= Configuration.default_configuration
   end
@@ -30,6 +34,7 @@ module PactBroker
     attr_accessor :enable_public_badge_access, :shields_io_base_url
     attr_accessor :webhook_retry_schedule
     attr_accessor :disable_ssl_verification
+    attr_reader :api_error_reporters
     attr_writer :logger
 
     def initialize
@@ -37,6 +42,7 @@ module PactBroker
       @after_resource_hook = ->(resource){}
       @authenticate_with_basic_auth = nil
       @authorize = nil
+      @api_error_reporters = []
     end
 
     def logger
@@ -121,6 +127,16 @@ module PactBroker
       end
     end
 
+    def add_api_error_reporter &block
+      if block_given?
+        unless block.arity == 2
+          raise ConfigurationError.new("api_error_notfifier block must accept two arguments, 'error' and 'options'")
+        end
+        @api_error_reporters << block
+        nil
+      end
+    end
+
     def enable_badge_resources= enable_badge_resources
       puts "Pact Broker configuration property `enable_badge_resources` is deprecated. Please use `enable_public_badge_access`"
       self.enable_public_badge_access = enable_badge_resources

data/lib/pact_broker/matrix/head_row.rb

@@ -6,6 +6,25 @@ module PactBroker
     # Rows with a nil consumer_tag_name are the overall latest
     class HeadRow < Row
       set_dataset(:materialized_head_matrix)
+
+      dataset_module do
+        include PactBroker::Repositories::Helpers
+        include PactBroker::Logging
+
+        def refresh ids
+          return super unless ids[:tag_name]
+
+          logger.debug("Refreshing #{model.table_name} for #{ids}")
+          db = model.db
+          table_name = model.table_name
+          criteria = { consumer_id: ids[:pacticipant_id], consumer_version_tag_name: ids[:tag_name] }
+          db.transaction do
+            db[table_name].where(criteria).delete
+            new_rows = db[source_view_name].where(criteria)
+            db[table_name].insert(new_rows)
+          end
+        end
+      end
     end
   end
 end

data/lib/pact_broker/matrix/repository.rb

@@ -22,9 +22,46 @@ module PactBroker
       GROUP_BY_PROVIDER = [:consumer_name, :consumer_version_number, :provider_name]
       GROUP_BY_PACT = [:consumer_name, :provider_name]
 
+      # Use a block when the refresh is caused by a resource deletion
+      # This allows us to store the correct object ids for use afterwards
       def refresh params
-        PactBroker::Matrix::Row.refresh(params)
-        PactBroker::Matrix::HeadRow.refresh(params)
+        criteria = find_ids_for_pacticipant_names(params)
+        yield if block_given?
+        PactBroker::Matrix::Row.refresh(criteria)
+        PactBroker::Matrix::HeadRow.refresh(criteria)
+      end
+
+      # Only need to update the HeadRow table when tags change
+      # because it only changes which rows are the latest tagged ones -
+      # it doesn't change the actual values in the underlying matrix.
+      def refresh_tags params
+        criteria = find_ids_for_pacticipant_names(params)
+        yield if block_given?
+        PactBroker::Matrix::HeadRow.refresh(criteria)
+      end
+
+      def find_ids_for_pacticipant_names params
+        criteria  = {}
+
+        if params[:consumer_name] || params[:provider_name]
+          if params[:consumer_name]
+            pacticipant = PactBroker::Domain::Pacticipant.where(name_like(:name, params[:consumer_name])).single_record
+            criteria[:consumer_id] = pacticipant.id if pacticipant
+          end
+
+          if params[:provider_name]
+            pacticipant = PactBroker::Domain::Pacticipant.where(name_like(:name, params[:provider_name])).single_record
+            criteria[:provider_id] = pacticipant.id if pacticipant
+          end
+        end
+
+        if params[:pacticipant_name]
+          pacticipant = PactBroker::Domain::Pacticipant.where(name_like(:name, params[:pacticipant_name])).single_record
+          criteria[:pacticipant_id] = pacticipant.id if pacticipant
+        end
+
+        criteria[:tag_name] = params[:tag_name] if params[:tag_name].is_a?(String) # Could be a sym from resource parameters in api.rb
+        criteria
       end
 
       # Return the latest matrix row (pact/verification) for each consumer_version_number/provider_version_number

data/lib/pact_broker/matrix/row.rb

@@ -19,42 +19,30 @@ module PactBroker
         include PactBroker::Repositories::Helpers
         include PactBroker::Logging
 
-        def refresh params
-          logger.debug("Refreshing #{model.table_name} for #{params}")
+        def refresh ids
+          logger.debug("Refreshing #{model.table_name} for #{ids}")
 
           db = model.db
           table_name = model.table_name
 
-          source_view_name = model.table_name.to_s.gsub('materialized_', '').to_sym
-          if params[:consumer_name] || params[:provider_name]
-            criteria = {}
-            if params[:consumer_name]
-              pacticipant = PactBroker::Domain::Pacticipant.where(name_like(:name, params[:consumer_name])).single_record
-              criteria[:consumer_id] = pacticipant.id if pacticipant
+          if ids[:pacticipant_id]
+            db.transaction do
+              db[table_name].where(consumer_id: ids[:pacticipant_id]).or(provider_id: ids[:pacticipant_id]).delete
+              new_rows = db[source_view_name].where(consumer_id: ids[:pacticipant_id]).or(provider_id: ids[:pacticipant_id]).distinct
+              db[table_name].insert(new_rows)
             end
-
-            if params[:provider_name]
-              pacticipant = PactBroker::Domain::Pacticipant.where(name_like(:name, params[:provider_name])).single_record
-              criteria[:provider_id] = pacticipant.id if pacticipant
-            end
-            if criteria.any?
-              db.transaction do
-                db[table_name].where(criteria).delete
-                db[table_name].insert(db[source_view_name].where(criteria).distinct)
-              end
+          elsif ids.any?
+            accepted_columns = [:consumer_id, :consumer_name, :provider_id, :provider_name]
+            criteria = ids.reject{ |k, v| !accepted_columns.include?(k) }
+            db.transaction do
+              db[table_name].where(criteria).delete
+              db[table_name].insert(db[source_view_name].where(criteria))
             end
           end
+        end
 
-          if params[:pacticipant_name]
-            pacticipant = PactBroker::Domain::Pacticipant.where(name_like(:name, params[:pacticipant_name])).single_record
-            if pacticipant
-              db.transaction do
-                db[table_name].where(consumer_id: pacticipant.id).or(provider_id: pacticipant.id).delete
-                new_rows = db[source_view_name].where(consumer_id: pacticipant.id).or(provider_id: pacticipant.id).distinct
-                db[table_name].insert(new_rows)
-              end
-            end
-          end
+        def source_view_name
+          model.table_name.to_s.gsub('materialized_', '').to_sym
         end
 
         def matching_selectors selectors

data/lib/pact_broker/matrix/service.rb

@@ -9,8 +9,12 @@ module PactBroker
       extend PactBroker::Repositories
       extend PactBroker::Services
 
-      def refresh params
-        matrix_repository.refresh params
+      def refresh params, &block
+        matrix_repository.refresh(params, &block)
+      end
+
+      def refresh_tags params, &block
+        matrix_repository.refresh_tags(params, &block)
       end
 
       def find criteria, options = {}

data/lib/pact_broker/pacticipants/service.rb

@@ -86,6 +86,7 @@ module PactBroker
         connection.run("delete from pact_versions where consumer_id = #{pacticipant.id}")
         connection.run("delete from versions where pacticipant_id = #{pacticipant.id}")
         version_repository.delete_by_id version_ids
+        label_repository.delete_by_pacticipant_id(pacticipant.id)
         connection.run("delete from pacticipants where id = #{pacticipant.id}")
       end
 

data/lib/pact_broker/ui/controllers/base_controller.rb

@@ -9,8 +9,9 @@ module PactBroker
 
         set :root, File.join(File.dirname(__FILE__), '..')
         set :show_exceptions, ENV['RACK_ENV'] != 'production'
+        set :dump_errors, false # The padrino logger logs these for us. If this is enabled we get duplicate logging.
 
       end
     end
   end
-end
+end

data/lib/pact_broker/ui/controllers/error_test.rb

@@ -7,7 +7,6 @@ module PactBroker
     module Controllers
       class ErrorTest < Base
         include PactBroker::Services
-        include PactBroker::Logging
 
         get "/" do
           raise PactBroker::Error.new("Don't panic. This is a test UI error.")