pact_broker 2.0.4 → 2.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8b8b4752ea480c1accb24a8ac99986695d2927e1
-  data.tar.gz: d6cd4104ef81b44b089ee51f37d28d46de6edc11
+  metadata.gz: a2edb308c7e322351a0d87be210ccd4c9eaf4153
+  data.tar.gz: 24b63e6f8b5806bb363391f7b862ee3537855076
 SHA512:
-  metadata.gz: a3369dc3103dc71184db705883000d0ac6a522ca1f7450bf9635ae0976be70eff8a655be909d002c3157a5d7955ab991f3ccd348fc2eedf4960d04548eb43184
-  data.tar.gz: 7d863d3a17c5d4aa0dcf05fcbe7584a085792894263e1486db6d90570e5aa8d6341eea39e6f06d6b622332363c03c02f84d5f3c497f116bc8c9ed15d0632009f
+  metadata.gz: dc2bf80f0f162989597ff0046c506ba67d0020b4cf0210ac33bca85221e8bc1ca54ef59bd7b356915daeb533e041e45eafdf2e39b2823c54ffc7ab25506b2c20
+  data.tar.gz: 9c81983d516bb00fc61d6dae594b33c9202c3b2ba4e33d7ef6901d25800615c574578e9701c3ea16b8f70b526cdf8d9dc70ba61d16ec139232d31f9beb08b668

data/.travis.yml

@@ -6,6 +6,8 @@ rvm:
 services:
   - postgresql
   - mysql
+addons:
+  postgresql: "9.5"
 env:
   - DATABASE_ADAPTER=default RUBYOPT="-W0"
   - DATABASE_ADAPTER=postgres RUBYOPT="-W0"

data/CHANGELOG.md

@@ -2,6 +2,9 @@ Do this to generate your change history
 
     $ git log --pretty=format:'  * %h - %s (%an, %ad)'
 
+#### 2.0.5 (2017-06-15)
+* e924c96 - Fixed webhook deletion bug (Beth Skurrie, Tue Jun 13 10:04:33 2017 +1000)
+
 #### 2.0.4 (2017-06-02)
 * 99e1c25 - Turn off http_origin checking for https://github.com/pact-foundation/pact_broker/issues/108 (Beth Skurrie, Fri Jun 2 16:27:38 2017 +1000)
 * e58f609 - Add favicon.ico (Beth Skurrie, Mon May 29 15:02:22 2017 +1000)

data/README.md

@@ -18,8 +18,9 @@ Features:
 * An embedded HAL browser for navigating the API.
 * Autogenerated documentation for each pact.
 * Dynamically generated network diagrams.
+* Displays provider verificaton results.
 * Enables a pact version to be tagged (ie. "prod") so a provider can verify itself against a fixed version of a pact to ensure backwards compatibility.
-* Webhooks to trigger a provider build when a consumer publishes a change to a pact.
+* Provides webhooks to trigger a provider build when a consumer publishes a change to a pact.
 * Tracks changes between Pact versions so you can tell when a consumer has changed its expectations.
 * [Docker Pact Broker][docker]
 
@@ -30,12 +31,14 @@ Travis CI Status: [![Build Status](https://travis-ci.org/pact-foundation/pact_br
 #### Step 1. Consumer CI build
 1. The consumer project runs its tests using the [Pact][pact] library to provide a mock service.
 2. While the tests run, the mock service writes the requests and the expected responses to a JSON "pact" file - this is the consumer contract.
-3. The generated pact is then published to the Pact Broker. This is simply a PUT to a resource that specifies the consumer name and version, and the provider name. eg `http://my-pact-broker/pacts/provider/Animal%20Service/consumer/Zoo%20App/version/1.0.0`
+3. The generated pact is then published to the Pact Broker. This is simply a `PUT` to a resource that specifies the consumer name and version, and the provider name. eg `http://my-pact-broker/pacts/provider/Animal%20Service/consumer/Zoo%20App/version/1.0.0`
+4. When a pact is published, a webhook in the Pact Broker kicks off a build of the provider project if the pact content has changed since the previous version.
 
 #### Step 2. Provider CI build
-1. The provider has a verification task that is configured with the URL to retrieve the dynamically calculated latest pact between itself and the consumer. eg `http://my-pact-broker/pacts/provider/Animal%20Service/consumer/Zoo%20App/latest`. The "latest" version is determined by the Pact Broker by inspecting the consumer version number specified when each pact was published.
+1. The provider has a verification task that is configured with the URL to retrieve the latest pact between itself and the consumer. eg `http://my-pact-broker/pacts/provider/Animal%20Service/consumer/Zoo%20App/latest`.
 2. The provider build runs the pact verification task, which retrieves the pact from the Pact Broker, replays each request against the provider, and checks that the responses match the expected responses.
 3. If the pact verification fails, the build fails. The [Pact Broker CI Nerf Gun][nerf] magically determines who caused the verification to fail, and shoots them.
+4. The results of the verification are published back to the Pact Broker by the pact verification tool, so the consumer team will know if the code they have written will work IRL.
 
 If you don't have a [Pact Broker CI Nerf Gun][nerf], you'll probably want to read about using pact when the consumer and provider are being written by [different teams][different-teams].
 

data/lib/pact_broker/version.rb

@@ -1,3 +1,3 @@
 module PactBroker
-  VERSION = '2.0.4'
+  VERSION = '2.0.5'
 end

data/lib/pact_broker/webhooks/service.rb

@@ -31,7 +31,7 @@ module PactBroker
       end
 
       def self.delete_by_uuid uuid
-        webhook_repository.delete_executions_by_webhook_uuid uuid
+        webhook_repository.unlink_executions_by_webhook_uuid uuid
         webhook_repository.delete_by_uuid uuid
       end
 

data/spec/features/delete_webhook_spec.rb

@@ -0,0 +1,30 @@
+require 'support/provider_state_builder'
+
+describe "Delete a webhook" do
+
+  let!(:webhook) do
+    ProviderStateBuilder.new
+      .create_consumer("Some Consumer")
+      .create_consumer_version("Some Provider")
+      .create_provider
+      .create_pact
+      .create_webhook
+      .create_webhook_execution
+      .and_return(:webhook)
+  end
+
+  let(:path) { "/webhooks/#{webhook.uuid}" }
+  let(:response_body) { JSON.parse(last_response.body, symbolize_names: true)}
+  let(:webhook_json) { webhook_hash.to_json }
+
+  subject { delete path }
+
+  it "deletes the webhook" do
+    expect { subject }.to change { PactBroker::Webhooks::Webhook.count }.by(-1)
+  end
+
+  it "returns a 204 response" do
+    subject
+    expect(last_response.status).to eq 204
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pact_broker
 version: !ruby/object:Gem::Version
-  version: 2.0.4
+  version: 2.0.5
 platform: ruby
 authors:
 - Bethany Skurrie
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-02 00:00:00.000000000 Z
+date: 2017-06-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -670,6 +670,7 @@ files:
 - spec/features/create_webhook_spec.rb
 - spec/features/delete_pact_spec.rb
 - spec/features/delete_version_spec.rb
+- spec/features/delete_webhook_spec.rb
 - spec/features/get_diff_spec.rb
 - spec/features/get_pact_spec.rb
 - spec/features/get_pact_versions_spec.rb
@@ -854,7 +855,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: See description
@@ -862,6 +863,7 @@ test_files:
 - spec/features/create_webhook_spec.rb
 - spec/features/delete_pact_spec.rb
 - spec/features/delete_version_spec.rb
+- spec/features/delete_webhook_spec.rb
 - spec/features/get_diff_spec.rb
 - spec/features/get_pact_spec.rb
 - spec/features/get_pact_versions_spec.rb