pact_broker 1.13.0 → 1.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 294af60b2b620028e089b70e4b2cb6b679f80258
-  data.tar.gz: 6fbf2858e2c429ecbe0e77a1380b33da6cfd590b
+  metadata.gz: 082fae49739e644a0b575b9242ac248f63606e04
+  data.tar.gz: 19c28520e5b3076c27d7e5f806f8aafae3ba0c1d
 SHA512:
-  metadata.gz: 632f9bbd33da917be4ffa13af123b88e62f248f01b66b9dfae3e61758a37980b6727e5b643583edd393aa77c58dcfbc02e92e14a3b898660a9ec3a92968ac7cb
-  data.tar.gz: 04078604d77fd13715d2b7c73f67123129a56c1028319e7d7f248ac9ef6e42259c58efeac437de71b7c745702424b4121416b745707cb5ca76cfd0295b8f11b9
+  metadata.gz: be084a3e0fb139081fdb05acd03317cd0a7b7b9617196a0a8f2c1accd2b5df18d94cc4532f4e4ac03c6613c3acaf60f8cebc5f2fc1806674f1d0c7c33049b25e
+  data.tar.gz: 0bfcd1da43d8f1ebb81fa5b5661d5632a0c82be9383b1dfc0217c338386cf4b337be32c488a41a13853e600ae647475ae0f92ac971d4f6ec5ba946deaf13b0ac

data/CHANGELOG.md

@@ -2,6 +2,9 @@ Do this to generate your change history
 
     $ git log --pretty=format:'  * %h - %s (%an, %ad)' vX.Y.Z..HEAD
 
+#### 1.14.0 (2017-01-30)
+* 83ac7a5 - Adds ability to delete tags (Ivan Vojinovic, Fri Jan 27 15:19:51 2017 -0500)
+
 #### 1.13.0 (2017-01-18)
 * b9b67b3 - Adds the spec for pact versions endpoint, and corrects the file name for the provider pacts spec (Ivan Vojinovic, Tue Jan 17 23:43:03 2017 -0500)
 * ace427e - Adds the spec for pact versions endpoint, and corrects the file name for the provider pacts spec (Ivan Vojinovic, Tue Jan 17 23:36:33 2017 -0500)

data/lib/pact_broker/api/resources/tag.rb

@@ -15,7 +15,7 @@ module PactBroker
         end
 
         def allowed_methods
-          ["GET","PUT"]
+          ["GET","PUT","DELETE"]
         end
 
         def from_json
@@ -39,6 +39,11 @@ module PactBroker
           @tag ||= tag_service.find identifier_from_path
         end
 
+        def delete_resource
+          tag_service.delete identifier_from_path
+          true
+        end
+
       end
     end
 

data/lib/pact_broker/services/tag_service.rb

@@ -19,6 +19,12 @@ module PactBroker
         tag_repository.find args
       end
 
+      def delete args
+        version = version_repository.find_by_pacticipant_name_and_number args.fetch(:pacticipant_name), args.fetch(:pacticipant_version_number)
+        connection = PactBroker::Domain::Tag.new.db
+        connection.run("delete from tags where name = '#{args.fetch(:tag_name)}' and version_id = '#{version.id}'")
+      end
+
     end
   end
 

data/lib/pact_broker/version.rb

@@ -1,3 +1,3 @@
 module PactBroker
-  VERSION = '1.13.0'
+  VERSION = '1.14.0'
 end

data/spec/lib/pact_broker/api/resources/tag_spec.rb

@@ -19,6 +19,60 @@ module PactBroker
           }
         }
 
+        describe "DELETE" do
+          before do
+            allow(Services::TagService).to receive(:find).and_return(tag)
+            allow(Services::TagService).to receive(:delete)
+          end
+
+          subject { delete("/pacticipants/Condor/versions/1.3.0/tags/prod" ) }
+
+          context "when the tag exists" do
+            it "deletes the tag by name" do
+              expect(Services::TagService).to receive(:delete) .with(tag_attributes)
+              subject
+            end
+
+            it "returns a 204 OK" do
+              subject
+              expect(last_response.status).to eq 204
+            end
+          end
+
+          context "when the tag doesn't exist" do
+
+            let(:tag) { nil }
+
+            it "returns a 404 Not Found" do
+              subject
+              expect(last_response.status).to eq 404
+            end
+          end
+
+          context "when an error occurs" do
+            before do
+              allow(Services::TagService).to receive(:delete).and_raise("An error")
+            end
+
+            let(:response_body) { JSON.parse(last_response.body, symbolize_names: true) }
+
+            it "returns a 500 Internal Server Error" do
+              subject
+              expect(last_response.status).to eq 500
+            end
+
+            it "returns an error message" do
+              subject
+              expect(response_body[:message]).to eq "An error"
+            end
+
+            it "returns the backtrace" do
+              subject
+              expect(response_body[:backtrace]).to be_instance_of(Array)
+            end
+          end
+        end
+
         describe "GET" do
           before do
             allow(Services::TagService).to receive(:find).and_return(tag)

data/spec/lib/pact_broker/services/tag_service_spec.rb

@@ -5,14 +5,14 @@ module PactBroker
   module Services
     describe TagService do
 
-      describe ".create" do
+      let(:pacticipant_name) { "test_pacticipant" }
+      let(:version_number) { "1.2.3" }
+      let(:tag_name) { "prod" }
 
-        let(:pacticipant_name) { "test_pacticipant" }
-        let(:version_number) { "1.2.3" }
-        let(:tag_name) { "prod" }
+      let(:options) { {pacticipant_name: pacticipant_name, pacticipant_version_number: version_number, tag_name: tag_name}}
+      let(:provider_state_builder) { ProviderStateBuilder.new }
 
-        let(:options) { {pacticipant_name: pacticipant_name, pacticipant_version_number: version_number, tag_name: tag_name}}
-        let(:provider_state_builder) { ProviderStateBuilder.new }
+      describe ".create" do
 
         subject { TagService.create(options) }
 
@@ -26,6 +26,26 @@ module PactBroker
 
       end
 
+      describe "delete" do
+
+        let(:second_pacticipant_name) { "second_test_pacticipant" }
+        let(:second_version_number) { "4.5.6" }
+        let(:second_options_same_tag_name) { {pacticipant_name: second_pacticipant_name, pacticipant_version_number: second_version_number, tag_name: tag_name}}
+
+        before do
+          TagService.create(options)
+          TagService.create(second_options_same_tag_name)
+        end
+
+        let(:delete_tag_for_particpant_and_version) { subject.delete second_options_same_tag_name}
+
+        it "deletes the tag for the particpiant and the version" do
+          expect{ delete_tag_for_particpant_and_version }.to change{
+            PactBroker::Domain::Tag.all.count
+          }.by(-1)
+        end
+      end
+
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pact_broker
 version: !ruby/object:Gem::Version
-  version: 1.13.0
+  version: 1.14.0
 platform: ruby
 authors:
 - Bethany Skurrie
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-18 00:00:00.000000000 Z
+date: 2017-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty