pact_broker-client 1.35.0 → 1.38.1

data/pact-broker-client.gemspec

@@ -32,5 +32,5 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'webmock', '~> 3.0'
   gem.add_development_dependency 'conventional-changelog', '~>1.3'
   gem.add_development_dependency 'pact', '~> 1.16'
-  gem.add_development_dependency 'pact-support', '1.15.0'
+  gem.add_development_dependency 'pact-support', '~> 1.16'
 end

data/script/publish-pact.sh

@@ -1 +1,7 @@
-bundle exec bin/pact-broker publish spec/pacts/pact_broker_client-pact_broker.json --consumer-app-version 1.2.3 --broker-base-url http://localhost:9292 --tag-with-git-branch --broker-username localhost --broker-password localhost
+bundle exec bin/pact-broker publish spec/pacts/pact_broker_client-pact_broker.json \
+  --consumer-app-version 1.2.7 \
+  --broker-base-url http://localhost:9292 \
+   --broker-username localhost --broker-password localhost \
+    --auto-detect-branch \
+    --build-url http://mybuild
+

data/script/record-deployment.sh

@@ -0,0 +1,4 @@
+PACT_BROKER_FEATURES=deployments bundle exec bin/pact-broker record-deployment \
+   --pacticipant Foo --version 1.0.0 --environment prod --broker-base-url http://localhost:9292
+
+

data/script/trigger-release.sh

@@ -19,7 +19,7 @@ output=$(curl -v -X POST https://api.github.com/repos/${repository_slug}/dispatc
       -H "Authorization: Bearer $GITHUB_ACCESS_TOKEN_FOR_PF_RELEASES" \
       -d "{\"event_type\": \"release-triggered\", \"client_payload\": {\"increment\": ${increment}}}" 2>&1)
 
-if  ! echo "${output}" | grep "HTTP\/1.1 204" > /dev/null; then
+if  ! echo "${output}" | grep "HTTP\/.* 204" > /dev/null; then
   echo "$output" | sed  "s/${GITHUB_ACCESS_TOKEN_FOR_PF_RELEASES}/********/g"
   echo "Failed to trigger release"
   exit 1

data/spec/lib/pact_broker/client/cli/broker_can_i_deploy_spec.rb

@@ -1,4 +1,6 @@
 require 'pact_broker/client/cli/broker'
+require 'pact_broker/client/cli/version_selector_options_parser'
+require 'pact_broker/client/can_i_deploy'
 
 module PactBroker
   module Client
@@ -35,7 +37,7 @@ module PactBroker
         end
 
         it "invokes the CanIDeploy service" do
-          expect(CanIDeploy).to receive(:call).with('http://pact-broker', version_selectors, {to_tag: nil, limit: 1000}, {output: 'table', retry_while_unknown: 1, retry_interval: 2}, {verbose: 'verbose'})
+          expect(CanIDeploy).to receive(:call).with('http://pact-broker', version_selectors, {to_tag: nil, to_environment: nil, limit: 1000}, {output: 'table', retry_while_unknown: 1, retry_interval: 2}, {verbose: 'verbose'})
           invoke_can_i_deploy
         end
 
@@ -53,7 +55,18 @@ module PactBroker
           end
 
           it "passes the value as the matrix options" do
-            expect(CanIDeploy).to receive(:call).with(anything, anything, {to_tag: 'prod', limit: 1000}, anything, anything)
+            expect(CanIDeploy).to receive(:call).with(anything, anything, {to_tag: 'prod', to_environment: nil, limit: 1000}, anything, anything)
+            invoke_can_i_deploy
+          end
+        end
+
+        context "with --to-environment" do
+          before do
+            subject.options.to_environment = 'prod'
+          end
+
+          it "passes the value as the matrix options" do
+            expect(CanIDeploy).to receive(:call).with(anything, anything, {to_tag: nil, to_environment: 'prod', limit: 1000}, anything, anything)
             invoke_can_i_deploy
           end
         end
@@ -100,13 +113,45 @@ module PactBroker
           end
 
           it "exits with code 1" do
-            exited_with_error = false
+            exited_explicitly = false
+            exited_explicitlyerror = nil
             begin
               invoke_can_i_deploy
-            rescue SystemExit
-              exited_with_error = true
+            rescue SystemExit => e
+              exited_explicitly = true
+              error = e
+            end
+            expect(exited_explicitly).to be true
+            expect(error.status).to be 1
+          end
+
+          context "when an exit status is specified" do
+            before do
+              allow(ENV).to receive(:fetch).and_call_original
+              allow(ENV).to receive(:fetch).with('PACT_BROKER_CAN_I_DEPLOY_EXIT_CODE_BETA', '').and_return("0")
+            end
+
+            it "exits with the specified code" do
+              exited_explicitly = false
+              error = nil
+              begin
+                invoke_can_i_deploy
+              rescue SystemExit => e
+                exited_explicitly = true
+                error = e
+              end
+              expect(exited_explicitly).to be true
+              expect(error.status).to be 0
+            end
+
+            it "prints the configured exit code" do
+              expect($stderr).to receive(:puts).with("Exiting can-i-deploy with configured exit code 0")
+              expect($stdout).to receive(:puts).with(message)
+              begin
+                invoke_can_i_deploy
+              rescue SystemExit
+              end
             end
-            expect(exited_with_error).to be true
           end
         end
       end

data/spec/lib/pact_broker/client/cli/broker_publish_spec.rb

@@ -27,9 +27,8 @@ module PactBroker::Client::CLI
           expect(PactBroker::Client::PublishPacts).to receive(:call).with(
             "http://pact-broker",
             ["spec/support/cli_test_pacts/foo.json"],
-            "1.2.3",
-            [],
-            {verbose: nil}
+            { number: "1.2.3", tags: [], version_required: false },
+            { }
           )
           invoke_broker
         end
@@ -43,7 +42,6 @@ module PactBroker::Client::CLI
             anything,
             ["spec/support/cli_test_pacts/bar.json", "spec/support/cli_test_pacts/foo.json"],
             anything,
-            anything,
             anything
           )
           invoke_broker
@@ -58,7 +56,6 @@ module PactBroker::Client::CLI
             anything,
             ["spec/support/cli_test_pacts/bar.json", "spec/support/cli_test_pacts/foo.json"],
             anything,
-            anything,
             anything
           )
           invoke_broker
@@ -73,7 +70,6 @@ module PactBroker::Client::CLI
             anything,
             ["spec/support/cli_test_pacts/bar.json", "spec/support/cli_test_pacts/foo.json"],
             anything,
-            anything,
             anything
           )
           invoke_broker
@@ -89,8 +85,7 @@ module PactBroker::Client::CLI
           expect(PactBroker::Client::PublishPacts).to receive(:call).with(
             anything,
             anything,
-            anything,
-            ['foo'],
+            hash_including(tags: ['foo']),
             anything
           )
           invoke_broker
@@ -100,7 +95,7 @@ module PactBroker::Client::CLI
       context "with tag-with-git-branch" do
         before do
           subject.options = OpenStruct.new(
-            minimum_valid_options.merge(tag_with_git_branch: true)
+            minimum_valid_options.merge(tag_with_git_branch: true, tag: ['foo'])
           )
         end
 
@@ -112,9 +107,111 @@ module PactBroker::Client::CLI
         it "adds it to the list of tags when publishing" do
           expect(PactBroker::Client::PublishPacts).to receive(:call).with(
             anything,
+            anything,
+            hash_including(tags: ['foo', 'bar']),
+            anything
+          )
+          invoke_broker
+        end
+      end
+
+      context "with a branch specified" do
+        before do
+          subject.options = OpenStruct.new(
+            minimum_valid_options.merge(branch: "main")
+          )
+        end
+
+        it "passes in the branch option" do
+          expect(PactBroker::Client::PublishPacts).to receive(:call).with(
+            anything,
+            anything,
+            hash_including(branch: "main", version_required: true),
+            anything
+          )
+          invoke_broker
+        end
+      end
+
+      context "with --auto-detect-version-properties on by default" do
+        before do
+          subject.options = OpenStruct.new(
+            minimum_valid_options.merge(auto_detect_version_properties: true)
+          )
+          allow(subject).to receive(:explict_auto_detect_version_properties).and_return(false)
+        end
+
+        it "determines the git branch name" do
+          expect(PactBroker::Client::Git).to receive(:branch).with(raise_error: false)
+          invoke_broker
+        end
+
+        it "passes in the auto detected branch option with version_required: false" do
+          expect(PactBroker::Client::PublishPacts).to receive(:call).with(
+            anything,
+            anything,
+            hash_including(branch: "bar", version_required: false),
+            anything
+          )
+          invoke_broker
+        end
+      end
+
+
+      context "with --auto-detect-version-properties specified explicitly" do
+        before do
+          subject.options = OpenStruct.new(
+            minimum_valid_options.merge(auto_detect_version_properties: true)
+          )
+          allow(subject).to receive(:explict_auto_detect_version_properties).and_return(true)
+        end
+
+        it "determines the git branch name" do
+          expect(PactBroker::Client::Git).to receive(:branch).with(raise_error: true)
+          invoke_broker
+        end
+
+        it "passes in the auto detected branch option with version_required: true" do
+          expect(PactBroker::Client::PublishPacts).to receive(:call).with(
             anything,
             anything,
-            ['bar'],
+            hash_including(branch: "bar", version_required: true),
+            anything
+          )
+          invoke_broker
+        end
+
+        context "with the branch specified as well" do
+          before do
+            subject.options = OpenStruct.new(
+              minimum_valid_options.merge(branch: "specified-branch", auto_detect_version_properties: true)
+            )
+          end
+
+          it "uses the specified branch" do
+            expect(PactBroker::Client::PublishPacts).to receive(:call).with(
+              anything,
+              anything,
+              hash_including(branch: "specified-branch", version_required: true),
+              anything
+            )
+            invoke_broker
+          end
+        end
+      end
+
+      context "with the build_url specified" do
+        before do
+          subject.options = OpenStruct.new(
+            minimum_valid_options.merge(build_url: "http://ci")
+          )
+        end
+
+        it "passes in the branch option" do
+          expect(PactBroker::Client::PublishPacts).to receive(:call).with(
+            anything,
+            anything,
+            hash_including(build_url: "http://ci"),
             anything
           )
           invoke_broker
@@ -133,8 +230,7 @@ module PactBroker::Client::CLI
             anything,
             anything,
             anything,
-            anything,
-            hash_including({basic_auth: {username: 'foo', password: 'bar'}})
+            hash_including(basic_auth: { username: 'foo', password: 'bar' })
           )
           invoke_broker
         end

data/spec/lib/pact_broker/client/cli/custom_thor_spec.rb

@@ -52,12 +52,9 @@ module PactBroker::Client::CLI
         ENV['PACT_BROKER_TOKEN'] = 'token'
       end
 
-      it "populates the options from the environment variables" do
+      it "populates the base URL from the environment variables" do
         expect(Delegate).to receive(:call) do | options |
           expect(options.broker_base_url).to eq 'http://foo'
-          expect(options.broker_username).to eq 'username'
-          expect(options.broker_password).to eq 'password'
-          expect(options.broker_token).to eq 'token'
         end
         TestThor.start(%w{test_using_env_vars})
       end
@@ -65,9 +62,6 @@ module PactBroker::Client::CLI
       it "does not override a value specifed on the command line" do
         expect(Delegate).to receive(:call) do | options |
           expect(options.broker_base_url).to eq 'http://bar'
-          expect(options.broker_username).to eq 'username'
-          expect(options.broker_password).to eq 'password'
-          expect(options.broker_token).to eq 'token'
         end
         TestThor.start(%w{test_using_env_vars --broker-base-url http://bar})
       end

data/spec/lib/pact_broker/client/git_spec.rb

@@ -9,9 +9,20 @@ module PactBroker
           Git::BRANCH_ENV_VAR_NAMES.each do | env_var_name|
             allow(ENV).to receive(:[]).with(env_var_name).and_return(nil)
           end
+          allow(Git).to receive(:execute_git_command).and_return(" origin/HEAD \n origin/foo")
         end
 
-        subject { Git.branch }
+        let(:raise_exception) { true }
+
+        subject { Git.branch(raise_error: raise_exception) }
+
+        shared_examples_for "when raise_error is false" do
+          context "when raise_error is false" do
+            let(:raise_exception) { false }
+
+            it { is_expected.to be nil }
+          end
+        end
 
         context "when there is a known environment variable for the branch" do
           before do
@@ -24,8 +35,28 @@ module PactBroker
           end
         end
 
+        context "when there is one environment variable ending with _BRANCH" do
+          before do
+            allow(ENV).to receive(:keys).and_return(%w{FOO_BRANCH BAR_BRANCH BLAH})
+            allow(ENV).to receive(:[]).with("FOO_BRANCH").and_return("")
+            allow(ENV).to receive(:[]).with("BAR_BRANCH").and_return("meep")
+          end
+
+          it "returns the value of that environment variable" do
+            expect(subject).to eq "meep"
+          end
+        end
+
+        context "when there is more than one environment variable ending with _BRANCH" do
+          it "attempts to execute a git command to determine the value" do
+            expect(Git).to receive(:execute_git_command)
+            expect(subject).to_not be_empty
+          end
+        end
+
         context "when there is no known environment variable for the branch", skip_ci: true do
           it "attempts to execute a git command to determine the value" do
+            expect(Git).to receive(:execute_git_command)
             expect(subject).to_not be_empty
           end
         end
@@ -35,7 +66,7 @@ module PactBroker
             allow(Git).to receive(:execute_git_command).and_return(" origin/HEAD \n origin/foo")
           end
 
-          it "raises an error" do
+          it "returns the branch" do
             expect(subject).to eq "foo"
           end
         end
@@ -48,6 +79,8 @@ module PactBroker
           it "raises an error" do
             expect { subject }.to raise_error PactBroker::Client::Error, /returned multiple branches: foo, bar/
           end
+
+          include_examples "when raise_error is false"
         end
 
 
@@ -59,6 +92,8 @@ module PactBroker
           it "raises an error" do
             expect { subject }.to raise_error PactBroker::Client::Error, /didn't return anything/
           end
+
+          include_examples "when raise_error is false"
         end
 
         context "when there is an error executing the git command" do
@@ -69,6 +104,8 @@ module PactBroker
           it "raises an error" do
             expect { subject }.to raise_error PactBroker::Client::Error, /some error/
           end
+
+          include_examples "when raise_error is false"
         end
       end
     end

data/spec/lib/pact_broker/client/hal/entity_spec.rb

@@ -9,8 +9,9 @@ module PactBroker::Client
       end
 
       let(:provider_response) do
-        double('response', body: provider_hash, success?: true)
+        double('response', body: provider_hash, success?: true, status: status)
       end
+      let(:status) { 200 }
 
       let(:provider_hash) do
         {
@@ -72,12 +73,12 @@ module PactBroker::Client
           subject(:entity) { ErrorEntity.new("http://pact", pact_hash, http_client) }
 
           it "raises an error" do
-            expect { entity.assert_success! }.to raise_error ErrorResponseReturned, "Error retrieving http://pact status= "
+            expect { entity.assert_success! }.to raise_error ErrorResponseReturned, "Error retrieving http://pact status="
           end
         end
 
         context "when the response is not successful and there is a response" do
-          let(:response) { double('response', code: 200, raw_body: "body") }
+          let(:response) { double('response', status: 200, raw_body: "body") }
 
           subject(:entity) { ErrorEntity.new("http://pact", pact_hash, http_client, response) }
 

data/spec/lib/pact_broker/client/publish_pacts_spec.rb

@@ -23,6 +23,7 @@ module PactBroker
         File.open("spec/pacts/consumer-provider.json", "w") { |file| file << pact_hash.to_json }
         File.open("spec/pacts/consumer-provider-2.json", "w") { |file| file << pact_hash.to_json }
         File.open("spec/pacts/foo-bar.json", "w") { |file| file << pact_hash_2.to_json }
+        allow_any_instance_of(PublishPacts).to receive(:create_index_entry_point).and_return(index_entry_point)
       end
 
       after do
@@ -34,11 +35,23 @@ module PactBroker
       let(:pact_file_paths) { ['spec/pacts/consumer-provider.json']}
       let(:consumer_version) { "1.2.3" }
       let(:tags) { nil }
-      let(:pact_hash) { {consumer: {name: 'Consumer'}, provider: {name: 'Provider'}, interactions: [] } }
-      let(:pact_hash_2) { {consumer: {name: 'Foo'}, provider: {name: 'Bar'}, interactions: [] } }
+      let(:branch) { nil }
+      let(:build_url) { nil }
+      let(:version_required) { false }
+      let(:pact_hash) { { consumer: { name: 'Consumer'}, provider: { name: 'Provider' }, interactions: [] } }
+      let(:pact_hash_2) { {consumer: { name: 'Foo' }, provider: { name: 'Bar' }, interactions: [] } }
       let(:pacts_client) { instance_double("PactBroker::ClientSupport::Pacts")}
       let(:pact_versions_client) { instance_double("PactBroker::Client::Versions", tag: false) }
       let(:pact_broker_base_url) { 'http://some-host'}
+      let(:consumer_version_params) do
+        {
+          number: consumer_version,
+          branch: branch,
+          tags: tags,
+          build_url: build_url,
+          version_required: version_required
+        }
+      end
       let(:pact_broker_client_options) do
         {
           basic_auth: {
@@ -47,8 +60,11 @@ module PactBroker
           }
         }
       end
+      let(:index_entry_point) { instance_double("PactBroker::Client::Hal::EntryPoint", :get! => index_resource )}
+      let(:index_resource) { instance_double("PactBroker::Client::Hal::Entity", can?: can_create_version ) }
+      let(:can_create_version) { false }
 
-      subject { PublishPacts.new(pact_broker_base_url, pact_file_paths, consumer_version, tags, pact_broker_client_options) }
+      subject { PublishPacts.new(pact_broker_base_url, pact_file_paths, consumer_version_params, pact_broker_client_options) }
 
       describe "call" do
         it "creates a PactBroker Client" do
@@ -184,7 +200,6 @@ module PactBroker
           end
 
           context "when an error occurs tagging the pact" do
-
             before do
               allow(pact_versions_client).to receive(:tag).and_raise("an error")
               allow(Retry).to receive(:sleep)
@@ -203,7 +218,6 @@ module PactBroker
         end
 
         context "when an error occurs every time while publishing a pact" do
-
           before do
             allow(Retry).to receive(:sleep)
             allow(pacts_client).to receive(:publish).and_raise("an error")
@@ -221,7 +235,6 @@ module PactBroker
         end
 
         context "when an error occurs less than the maximum number of retries" do
-
           before do
             allow(Retry).to receive(:sleep)
             tries = 0
@@ -245,6 +258,86 @@ module PactBroker
             expect(subject.call).to eq true
           end
         end
+
+        context "when the broker does not support creation of a version with a branch but a branch is specified" do
+          let(:branch) { "main" }
+
+          context "when version_required is true" do
+            let(:version_required) { true }
+
+            it "raises an error" do
+              expect { subject.call }.to raise_error PactBroker::Client::Error
+            end
+          end
+        end
+
+        context "when the broker supports creation of a version with a branch" do
+          before do
+            allow(version_link).to receive(:expand).and_return(version_link)
+            allow(version_resource).to receive(:assert_success!).and_return(version_resource)
+            allow(version_resource).to receive_message_chain(:response, :status).and_return(version_creation_response_status)
+          end
+          let(:can_create_version) { true }
+          let(:version_link) { instance_double("PactBroker::Client::Hal::Link", put: version_resource) }
+          let(:version_resource) { instance_double("PactBroker::Client::Hal::Entity") }
+          let(:version_creation_response_status) { 201 }
+
+          before do
+            allow(index_resource).to receive(:_link).and_return(version_link)
+          end
+
+          context "when there is a branch, build_url or tags specified" do
+            let(:tags) { ["dev"] }
+            let(:branch) { ["main"] }
+            let(:build_url) { "build_url" }
+
+            it "creates a version with the branch, build_url and tags" do
+              expect(index_resource).to receive(:_link)
+              expect(version_link).to receive(:expand).with(pacticipant: "Consumer", version: "1.2.3")
+              expect(version_link).to receive(:put).with(branch: branch, buildUrl: build_url)
+              subject.call
+            end
+
+            context "when there is a branch but no tags" do
+              let(:tags) { [] }
+
+              it "does not set the tags, as this would overwrite the existing ones - not sure about this implementation" do
+                expect(version_link).to receive(:put).with(branch: branch, buildUrl: build_url)
+                subject.call
+              end
+            end
+
+            context "when the version response status is 201" do
+              it "puts a message indicating the version was created" do
+                expect($stdout).to receive(:puts).with(/Created/)
+                subject.call
+              end
+            end
+
+            context "when the version response status is 200" do
+              let(:version_creation_response_status) { 200 }
+
+              it "puts a message indicating the version was replaced" do
+                expect($stdout).to receive(:puts).with(/Replaced/)
+                subject.call
+              end
+            end
+          end
+
+          context "when there is no branch, tags or build_url specified" do
+            before do
+              allow(Retry).to receive(:while_error) { |&block| block.call }
+            end
+            let(:tags) { [] }
+            let(:branch) { nil }
+            let(:build_url) { nil }
+
+            it "does not create a version resource" do
+              expect(index_resource).to_not receive(:_link)
+              subject.call
+            end
+          end
+        end
       end
     end
   end