pact 1.36.2 → 1.37.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3e598b19223be35dd3c6f476b889e8eabe6e69e6
-  data.tar.gz: 03bede44787e3804e70de0d31b46748331a6567f
+  metadata.gz: baaed0d9726daedaae9ffc9bfd27d8df34c2511d
+  data.tar.gz: 2af96d9cff46c3afba7d9cfc15d65af6d56ebd0b
 SHA512:
-  metadata.gz: 6b6f487d9d12536fbd90fea3c0051cd7923b7f525fa7da37fb1b8c45936227d95ce74b51a2eb87359c2baae5f8215dd0ebbcad7be8199413a63839e58e5807dd
-  data.tar.gz: 9774362b1afff2002d2bda5949ed0f1e439b590d205a0742bdeaa6ea37bc357a18b906ccfedf16cdd7c51618fc7900693d8075c4e9238616b41a74438c12f8c0
+  metadata.gz: 19a5b152314f0af37d2aa3cf52c6d41c6cef75289eedb05deef0daffdcee4a3b6f2dbcf7e9270c9cac630f236937a6ff5cf75f87ccfeadd991494325a76f4784
+  data.tar.gz: b2a78e5985c137f49c1fa673911125934463edc0b9442dfea58d1fe2cbc408e8618e3ffa77e7b6e09818e611a4862815fbc9baf39b9d89a5cc3c995a075347d4

data/CHANGELOG.md

@@ -1,3 +1,18 @@
+<a name="v1.37.0"></a>
+### v1.37.0 (2018-11-15)
+
+
+#### Features
+
+* **hal client**
+  * ensure meaningful error is displayed when HTTP errors are returned	 ([9244c14](/../../commit/9244c14))
+
+
+#### Bug Fixes
+
+* correct url encoding for expanded HAL links	 ([4abfe7d](/../../commit/4abfe7d))
+
+
 <a name="v1.36.2"></a>
 ### v1.36.2 (2018-10-22)
 

data/lib/pact/hal/entity.rb

@@ -7,6 +7,8 @@ module Pact
   module Hal
     class RelationNotFoundError < ::Pact::Error; end
 
+    class ErrorResponseReturned < ::Pact::Error; end
+
     class Entity
 
       def initialize(href, data, http_client, response = nil)
@@ -76,6 +78,10 @@ module Pact
       def respond_to_missing?(method_name, include_private = false)
         @data.key?(method_name) || @links.key?(method_name)
       end
+
+      def assert_success!
+        self
+      end
     end
 
     class ErrorEntity < Entity
@@ -91,6 +97,10 @@ module Pact
       def success?
         false
       end
+
+      def assert_success!
+        raise ErrorResponseReturned.new("Error retrieving #{@href} status=#{response ? response.code: nil} #{response ? response.raw_body : ''}")
+      end
     end
   end
 end

data/lib/pact/hal/link.rb

@@ -1,4 +1,4 @@
-require 'uri'
+require 'erb'
 require 'delegate'
 
 module Pact
@@ -54,11 +54,9 @@ module Pact
       end
 
       def expand_url(params, url)
-        new_url = url
-        params.each do | key, value |
-          new_url = new_url.gsub('{' + key.to_s + '}', URI.escape(value))
+        params.inject(url) do | url, (key, value) |
+          url.gsub('{' + key.to_s + '}', ERB::Util.url_encode(value))
         end
-        new_url
       end
     end
   end

data/lib/pact/pact_broker/fetch_pacts.rb

@@ -72,16 +72,16 @@ module Pact
       end
 
       def index
-        @index_entity ||= Pact::Hal::Link.new({ "href" => broker_base_url }, http_client).get
+        @index_entity ||= Pact::Hal::Link.new({ "href" => broker_base_url }, http_client).get.assert_success!
       end
 
       def latest_pacts_for_provider
         link = index_entity._link!(LATEST_PROVIDER_RELATION)
-        pact_urls(link.expand(provider: provider).get)
+        pact_urls(link.expand(provider: provider).get.assert_success!)
       end
 
       def pact_urls(link_by_provider)
-        link_by_provider.fetch(PB_PACTS, PACTS).collect do |pact|
+        link_by_provider.assert_success!.fetch(PB_PACTS, PACTS).collect do |pact|
           Pact::Provider::PactURI.new(pact[HREF], http_client_options)
         end
       end

data/lib/pact/pact_broker/fetch_pending_pacts.rb

@@ -36,7 +36,7 @@ module Pact
       private
 
       def index
-        @index_entity ||= Pact::Hal::Link.new({ "href" => broker_base_url }, http_client).get
+        @index_entity ||= Pact::Hal::Link.new({ "href" => broker_base_url }, http_client).get.assert_success!
       end
 
       def pending_pacts_for_provider

data/lib/pact/version.rb

@@ -1,4 +1,4 @@
 # Remember to bump pact-provider-proxy when this changes major version
 module Pact
-  VERSION = "1.36.2"
+  VERSION = "1.37.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pact
 version: !ruby/object:Gem::Version
-  version: 1.36.2
+  version: 1.37.0
 platform: ruby
 authors:
 - James Fraser
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-29 00:00:00.000000000 Z
+date: 2018-11-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: randexp