pact-mock_service 3.2.1 → 3.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8f5c4344c8cd4ad35c428bba1596877909fc81cfda1eaae0a71e80521d3129f2
-  data.tar.gz: 436534d7b43f1f60917c050abae962104dcc9650b6eb2d3df55e3dbc73509b44
+  metadata.gz: 70978afac2d8baa00d8723c1852b88652bb9988498adc9ea1077aa6f11a0e5d1
+  data.tar.gz: 2d328532b86c3b2deb265b26770a6c2b72282e3d6fd4fdfeff6237fe0f1a965d
 SHA512:
-  metadata.gz: c45bb5349e99a7ae0b51ec8e281491f5c8075686d5bf91aa4d4ea89646fee9948339fdccab42d3fb01234cf83aa2241faf8d4c301f533fc9c70b6c9f4210c430
-  data.tar.gz: 3eab8a731f151768b7fc7bab4f7002ec947a0f38c59aca9bef54a856cf4535a5de2ec665aef8b54c9cae966f6cfdfa78e7319770d09e28e82cbf738612654949
+  metadata.gz: 4621e740a4d865554ab7186547275b079955277d0c1883f31cde9c5932e56b1f3f17226edb8cd82738790b81c86cae28070f3c636c2041357a125915af55ec8e
+  data.tar.gz: bb71b263fd9663676f90a58f8b5198f7bebcc346677151269eba80c9c5d0a3a4bc8bf9d434d4a354e09c57515c4233ef6ee467e5126c35a3b59ecb1d31ccbd9a

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+<a name="v3.3.0"></a>
+### v3.3.0 (2020-01-16)
+
+
+#### Features
+
+* log a warning when too many interactions are set on the mock service at once	 ([0ce6bef](/../../commit/0ce6bef))
+
+
 <a name="v3.2.1"></a>
 ### v3.2.1 (2020-01-11)
 

data/lib/pact/mock_service/app.rb

@@ -15,12 +15,12 @@ module Pact
     end
 
     class App
-
       def initialize options = {}
         logger = Logger.from_options(options)
+        stubbing = options[:stub_pactfile_paths] && options[:stub_pactfile_paths].any?
         @name = options.fetch(:name, "MockService")
-        @session = Session.new(options.merge(logger: logger))
-        setup_stub(options[:stub_pactfile_paths]) if options[:stub_pactfile_paths]
+        @session = Session.new(options.merge(logger: logger, warn_on_too_many_interactions: !stubbing))
+        setup_stub(options[:stub_pactfile_paths]) if stubbing
         request_handlers = RequestHandlers.new(@name, logger, @session, options)
         @app = Rack::Builder.app do
           use Pact::Consumer::MockService::ErrorHandler, logger

data/lib/pact/mock_service/session.rb

@@ -17,6 +17,8 @@ module Pact
         @expected_interactions = Interactions::ExpectedInteractions.new
         @actual_interactions = Interactions::ActualInteractions.new
         @verified_interactions = Interactions::VerifiedInteractions.new
+        @warn_on_too_many_interactions = options[:warn_on_too_many_interactions] || false
+        @max_concurrent_interactions_before_warning = get_max_concurrent_interactions_before_warning
         @consumer_contract_details = {
           pact_dir: options[:pact_dir],
           consumer: {name: options[:consumer]},
@@ -64,10 +66,15 @@ module Pact
 
       private
 
+      attr_reader :warn_on_too_many_interactions, :max_concurrent_interactions_before_warning
+
       def really_add_expected_interaction interaction
         expected_interactions << interaction
         logger.info "Registered expected interaction #{interaction.request.method_and_path}"
         logger.debug JSON.pretty_generate InteractionDecorator.new(interaction)
+        if warn_on_too_many_interactions && expected_interactions.size > max_concurrent_interactions_before_warning
+          logger.warn "You currently have #{expected_interactions.size} interactions mocked at the same time. This suggests the scope of your consumer tests is larger than recommended, and you may find them hard to debug and maintain. See https://pact.io/too-many-interactions for more information."
+        end
       end
 
       def handle_almost_duplicate_interaction previous_interaction, interaction
@@ -81,6 +88,9 @@ module Pact
         other && other != interaction ? other : nil
       end
 
+      def get_max_concurrent_interactions_before_warning
+        ENV['PACT_MAX_CONCURRENT_INTERACTIONS_BEFORE_WARNING'] ? ENV['PACT_MAX_CONCURRENT_INTERACTIONS_BEFORE_WARNING'].to_i : 3
+      end
     end
   end
 end

data/lib/pact/mock_service/version.rb

@@ -1,5 +1,5 @@
 module Pact
   module MockService
-    VERSION = "3.2.1"
+    VERSION = "3.3.0"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pact-mock_service
 version: !ruby/object:Gem::Version
-  version: 3.2.1
+  version: 3.3.0
 platform: ruby
 authors:
 - James Fraser
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-11 00:00:00.000000000 Z
+date: 2020-01-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack