packer-config 1.6.0 → 1.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bdd9616df0548b2607fc93a93880270f58ca46fa
-  data.tar.gz: 9a184d7d17f0a6682aefd1f17fbf3d66a53978ff
+  metadata.gz: e83b6084bc9fc5e7f733b5cd914555e1f5ec5b21
+  data.tar.gz: 58691f783c9828674fa806d3c14ca589f4b01269
 SHA512:
-  metadata.gz: c3b494a1807f093cd67c9e700d9c622941cef01b5c3d613aa74f59d55ada1665372deac186da75fbc224c49adbc31d6a8f636a3509e3993804729de9465cd2df
-  data.tar.gz: d93976dd629da5c2437d2f071e51ad4db552fe886adf388a231de2a015f8db473216deb74e4950bba610a9187e1f460c140902ddcd9a488f380929c0768c4f50
+  metadata.gz: 485f6738bda938b9ca79e9f594df1e0daab586380a0cd51a8b3747ccf1338784d1751d92a02c9229608614f892528964f68146ebc8aaa2af64659d782333896f
+  data.tar.gz: aa530dfdd9d9ce3024c2498c0d64ecfafc38467ff9ab8bf1a1f2946a6046d74b7d4ee1f901551a21982d3b9908a9fbcbc89e21890041fba010d6e05d2b1d4f6c

data/.rubocop.yml

@@ -38,10 +38,21 @@ Lint/EndAlignment:
 Lint/Loop:
   Enabled: false
 
+Lint/UnusedMethodArgument:
+  Exclude:
+    - 'lib/packer/dataobject.rb'
+    - 'lib/packer/envvar.rb'
+    - 'lib/packer/macro.rb'
+    - 'lib/packer/provisioners/powershell.rb'
+
 Lint/Void:
   Exclude:
     - dashboard/spec/**/*
 
+Style/FileName:
+  Exclude:
+    - 'lib/packer-config.rb'
+
 Style/AccessModifierIndentation:
   Enabled: false
 
@@ -60,6 +71,15 @@ Style/AlignParameters:
 Metrics/BlockNesting:
   Enabled: false
 
+Metrics/AbcSize:
+  Max: 30
+
+Metrics/ClassLength:
+  Max: 150
+
+Metrics/MethodLength:
+  Max: 27
+
 Style/BracesAroundHashParameters:
   Enabled: false
 
@@ -171,6 +191,9 @@ Style/WhileUntilDo:
 Style/WhileUntilModifier:
   Enabled: false
 
+Style/IndentHash:
+  Enabled: false
+
 # As of rubocop 0.21, it thinks kwargs are useless assignments
 UselessAssignment:
   Enabled: false

data/.rubocop_todo.yml

@@ -6,84 +6,6 @@
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 3
-Lint/IneffectiveAccessModifier:
-  Exclude:
-    - 'lib/packer/builder.rb'
-    - 'lib/packer/postprocessor.rb'
-    - 'lib/packer/provisioner.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: IgnoreEmptyBlocks.
-Lint/UnusedBlockArgument:
-  Exclude:
-    - 'lib/packer/runner.rb'
-
-# Offense count: 8
-# Cop supports --auto-correct.
-# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
-Lint/UnusedMethodArgument:
-  Exclude:
-    - 'lib/packer/dataobject.rb'
-    - 'lib/packer/envvar.rb'
-    - 'lib/packer/macro.rb'
-    - 'lib/packer/provisioners/powershell.rb'
-
-# Offense count: 2
-Lint/UselessAccessModifier:
-  Exclude:
-    - 'lib/packer/postprocessor.rb'
-    - 'lib/packer/provisioner.rb'
-
-# Offense count: 8
-Metrics/AbcSize:
-  Max: 30
-
-# Offense count: 4
-# Configuration parameters: CountComments.
-Metrics/ClassLength:
-  Max: 150
-
-# Offense count: 7
-# Configuration parameters: CountComments.
-Metrics/MethodLength:
-  Max: 27
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: SingleLineConditionsOnly.
-Style/ConditionalAssignment:
-  Exclude:
-    - 'lib/packer/dataobject.rb'
-
-# Offense count: 9
-# Cop supports --auto-correct.
-Style/DeprecatedHashMethods:
-  Exclude:
-    - 'lib/packer-config.rb'
-    - 'lib/packer/dataobject.rb'
-    - 'lib/packer/postprocessor.rb'
-    - 'lib/packer/provisioner.rb'
-
-# Offense count: 1
-# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts.
-Style/FileName:
-  Exclude:
-    - 'lib/packer-config.rb'
-
-# Offense count: 1
-Style/IfInsideElse:
-  Exclude:
-    - 'lib/packer/dataobject.rb'
-
-# Offense count: 6
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
-# SupportedStyles: special_inside_parentheses, consistent, align_braces
-Style/IndentHash:
-  Enabled: false
-
 # Offense count: 31
 # Cop supports --auto-correct.
 Style/MutableConstant:
@@ -97,55 +19,8 @@ Style/MutableConstant:
     - 'spec/packer/postprocessor_spec.rb'
     - 'spec/packer/provisioner_spec.rb'
 
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/NegatedIf:
-  Exclude:
-    - 'lib/packer/dataobject.rb'
-
-# Offense count: 9
-Style/NestedParenthesizedCalls:
-  Exclude:
-    - 'spec/packer/envvar_spec.rb'
-    - 'spec/packer/macro_spec.rb'
-    - 'spec/packer/runner_spec.rb'
-    - 'spec/packer_config_spec.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
-# SupportedStyles: skip_modifier_ifs, always
-Style/Next:
-  Exclude:
-    - 'lib/packer/dataobject.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/NumericLiterals:
-  MinDigits: 6
-
 # Offense count: 34
 # Cop supports --auto-correct.
 # Configuration parameters: PreferredDelimiters.
 Style/PercentLiteralDelimiters:
   Enabled: false
-
-# Offense count: 6
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: space, no_space
-Style/SpaceBeforeBlockBraces:
-  Enabled: false
-
-# Offense count: 5
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
-# SupportedStyles: space, no_space
-Style/SpaceInsideBlockBraces:
-  Enabled: false
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/UnneededInterpolation:
-  Exclude:
-    - 'lib/packer/runner.rb'

data/README.md

@@ -69,27 +69,27 @@ The following [Packer post-processors](http://www.packer.io/docs/templates/post-
 
 ### Packing a Vagrant Basebox from a CentOS ISO Using VirtualBox
 
-This example is based on the integration test [spec/integration/centos_vagrant_spec.rb](spec/integration/centos_vagrant_spec.rb). It produces a Vagrant Basebox that's provisionable with [Chef](http://www.getchef.com/) and the packer config and provisioning is taken from the [Bento](https://github.com/opscode/bento) project from the OpsCode crew.
+This example is based on the integration test [spec/integration/centos_vagrant_spec.rb](spec/integration/centos_vagrant_spec.rb). It produces a Vagrant Basebox that's provisionable with [Chef](http://www.getchef.com/) and the packer config and provisioning is based on work done in the [Bento](https://github.com/opscode/bento) project from the OpsCode crew.
 
-    OS = 'centos-6.6'
+    CENTOS_VERSION = '6.8'
 
-    pconfig = Packer::Config.new "#{OS}-vagrant.json"
-    pconfig.description "#{OS} VirtualBox Vagrant"
+    pconfig = Packer::Config.new "centos-#{CENTOS_VERSION}-vagrant.json"
+    pconfig.description "CentOS #{CENTOS_VERSION} VirtualBox Vagrant"
     pconfig.add_variable 'mirror', 'http://mirrors.sonic.net/centos/'
     pconfig.add_variable 'my_version', '0.0.1'
     pconfig.add_variable 'chef_version', 'latest'
 
     builder = pconfig.add_builder Packer::Builder::VIRTUALBOX_ISO
-    builder.boot_command ["<tab> text ks=http://#{pconfig.macro.HTTPIP}:#{pconfig.macro.HTTPPort}/#{OS}-ks.cfg<enter><wait>"]
+    builder.boot_command ["<tab> text ks=http://#{pconfig.macro.HTTPIP}:#{pconfig.macro.HTTPPort}/centos-#{CENTOS_VERSION}-ks.cfg<enter><wait>"]
     builder.boot_wait '10s'
-    builder.disk_size 40960
+    builder.disk_size 40_960
     builder.guest_additions_path "VBoxGuestAdditions_#{pconfig.macro.Version}.iso"
     builder.guest_os_type "RedHat_64"
     builder.http_directory "scripts/kickstart"
-    builder.iso_checksum '7bb8c1c23a4fdef93e6f0a6347d570e5764d0b38'
+    builder.iso_checksum 'afab3a588cda94cd768826e77ad4db2b5ee7c485'
     builder.iso_checksum_type 'sha1'
-    builder.iso_url "#{pconfig.variable 'mirror'}/6.7/isos/x86_64/CentOS-6.7-x86_64-bin-DVD1.iso"
-    builder.output_directory "#{OS}-x86_64-virtualbox"
+    builder.iso_url "#{pconfig.variable 'mirror'}/6/isos/x86_64/CentOS-#{CENTOS_VERSION}-x86_64-bin-DVD1.iso"
+    builder.output_directory "centos-#{CENTOS_VERSION}-x86_64-virtualbox"
     builder.shutdown_command "echo 'vagrant'|sudo -S /sbin/halt -h -p"
     builder.communicator "ssh"
     builder.ssh_password "vagrant"
@@ -111,7 +111,7 @@ This example is based on the integration test [spec/integration/centos_vagrant_s
       ]
     ]
     builder.virtualbox_version_file ".vbox_version"
-    builder.vm_name "packer-#{OS}-x86_64"
+    builder.vm_name "packer-centos-#{CENTOS_VERSION}-x86_64"
 
     provisioner = pconfig.add_provisioner Packer::Provisioner::FILE
     provisioner.source 'scripts/hello.sh'
@@ -129,12 +129,12 @@ This example is based on the integration test [spec/integration/centos_vagrant_s
     ]
     provisioner.environment_vars [
       "CHEF_VERSION=#{pconfig.variable 'chef_version'}",
-      "MY_VERSION=#{pconfig.variable 'my_version'}"
+      "MY_CENTOS_VERSION=#{pconfig.variable 'my_version'}"
     ]
     provisioner.execute_command "echo 'vagrant' | #{pconfig.macro.Vars} sudo -S -E bash '#{pconfig.macro.Path}'"
 
     postprocessor = pconfig.add_postprocessor Packer::PostProcessor::VAGRANT
-    postprocessor.output File.join('builds', pconfig.macro.Provider, "#{OS}-x86_64-#{pconfig.variable 'my_version'}.box")
+    postprocessor.output File.join('builds', pconfig.macro.Provider, "centos-#{CENTOS_VERSION}-x86_64-#{pconfig.variable 'my_version'}.box")
 
     pconfig.validate
     pconfig.build

data/RELEASENOTES.md

@@ -1,5 +1,9 @@
 # packer-config Release Notes
 
+## 1.6.1
+
+* Added a verbose option to the `verify` method on `Packer::Config`. Closes issue #19.
+
 ## 1.6.0
 
 * Support for running Packer on Windows!

data/lib/packer-config.rb

@@ -36,8 +36,8 @@ module Packer
       self.envvar = EnvVar.new
     end
 
-    def validate
-      super
+    def validate(verbose: false)
+      super()
       verify_packer_version
       if self.builders.empty?
         raise DataValidationError.new("At least one builder is required")
@@ -49,7 +49,7 @@ module Packer
       stdout = nil
       Dir.chdir(File.dirname(self.output_file)) do
         begin
-          stdout = Packer::Runner.run! self.packer, 'validate', File.basename(self.output_file), quiet: true
+          stdout = Packer::Runner.run! self.packer, 'validate', File.basename(self.output_file), quiet: !verbose
         rescue Packer::Runner::CommandExecutionError => e
           raise PackerBuildError.new(e.to_s)
         end
@@ -153,7 +153,7 @@ module Packer
     end
 
     def variable(name)
-      unless self.variables.has_key? name
+      unless self.variables.key? name
         raise UndefinedVariableError.new("No variable named #{name} has been defined -- did you forget to call add_variable?")
       end
       "{{user `#{name}`}}"

data/lib/packer/builder.rb

@@ -144,5 +144,7 @@ module Packer
     def self.validate_type(type)
       VALID_BUILDER_TYPES.include? type
     end
+
+    private_class_method :validate_type
   end
 end

data/lib/packer/dataobject.rb

@@ -25,26 +25,23 @@ module Packer
     def validate_required
       self.required.each do |r|
         if (r.is_a? Array) && !r.empty?
-          if r.length - (r - self.data.keys).length == 0
+          if (r.length - (r - self.data.keys).length).zero?
             raise DataValidationError.new("Missing one required setting from the set #{r}")
           end
           if r.length - (r - self.data.keys).length > 1
             raise DataValidationError.new("Found more than one exclusive setting in data from set #{r}")
           end
-        else
-          if ! self.data.keys.include? r
-            raise DataValidationError.new("Missing required setting #{r}")
-          end
+        elsif ! self.data.keys.include? r
+          raise DataValidationError.new("Missing required setting #{r}")
         end
       end
     end
 
     def validate_key_dependencies
       self.data.keys.each do |data_key|
-        if self.key_dependencies.has_key? data_key
-          if ! (self.key_dependencies[data_key] - self.data.keys).empty?
-            raise DataValidationError.new("Key #{data_key} requires that keys be defined: #{self.key_dependencies[data_key]}")
-          end
+        next unless self.key_dependencies.key? data_key
+        unless (self.key_dependencies[data_key] - self.data.keys).empty?
+          raise DataValidationError.new("Key #{data_key} requires that keys be defined: #{self.key_dependencies[data_key]}")
         end
       end
     end
@@ -68,7 +65,7 @@ module Packer
 
     def __exclusive_key_error(key, exclusives)
       exclusives.each do |e|
-        if self.data.has_key? e
+        if self.data.key? e
           raise ExclusiveKeyError.new("Only one of #{exclusives} can be used at a time")
         end
       end
@@ -123,11 +120,7 @@ module Packer
 
     def __add_boolean(key, bool, exclusives = [])
       self.__exclusive_key_error(key, exclusives)
-      if bool
-        self.data[key.to_s] = true
-      else
-        self.data[key.to_s] = false
-      end
+      self.data[key.to_s] = bool ? true : false
     end
 
     def __add_hash(key, data, exclusives = [])

data/lib/packer/envvar.rb

@@ -1,10 +1,16 @@
 # Encoding: utf-8
+# rubocop:disable Style/MethodMissing
+
 module Packer
   class EnvVar
     def method_missing(method_name, *args)
       "{{env `#{method_name}`}}"
     end
 
+    def respond_to_missing?(method_name, include_private = false)
+      true
+    end
+
     def respond_to?(symbol, include_private=false)
       # We literally respond to everything...
       true

data/lib/packer/macro.rb

@@ -1,4 +1,6 @@
 # Encoding: utf-8
+# rubocop:disable Style/MethodMissing
+
 module Packer
   class Macro
     def method_missing(method_name, *args)
@@ -6,6 +8,10 @@ module Packer
       "{{ .#{name} }}"
     end
 
+    def respond_to_missing?(method_name, include_private = false)
+      true
+    end
+
     def respond_to?(symbol, include_private=false)
       # We literally respond to everything...
       true

data/lib/packer/postprocessor.rb

@@ -44,14 +44,14 @@ module Packer
     end
 
     def only(buildname)
-      unless self.data.has_key? 'only'
+      unless self.data.key? 'only'
         self.data['only'] = []
       end
       self.data['only'] << buildname.to_s
     end
 
     def except(buildname)
-      unless self.data.has_key? 'except'
+      unless self.data.key? 'except'
         self.data['except'] = []
       end
       self.data['except'] << buildname.to_s
@@ -61,9 +61,10 @@ module Packer
       self.__add_boolean('keep_input_artifact', bool)
     end
 
-    private
     def self.validate_type(type)
       VALID_POST_PROCESSOR_TYPES.include? type
     end
+
+    private_class_method :validate_type
   end
 end

data/lib/packer/provisioner.rb

@@ -62,14 +62,14 @@ module Packer
     end
 
     def only(buildname)
-      unless self.data.has_key? 'only'
+      unless self.data.key? 'only'
         self.data['only'] = []
       end
       self.data['only'] << buildname.to_s
     end
 
     def except(buildname)
-      unless self.data.has_key? 'except'
+      unless self.data.key? 'except'
         self.data['except'] = []
       end
       self.data['except'] << buildname.to_s
@@ -81,19 +81,20 @@ module Packer
 
     def override(builddefinition, values)
       raise TypeError.new() unless values.is_a?(Hash)
-      unless self.data.has_key? 'override'
+      unless self.data.key? 'override'
         self.data['override'] = {}
       end
-      if self.data.has_key? @data['override'][builddefinition]
+      if self.data.key? @data['override'][builddefinition]
         self.data['override'][builddefinition].merge! values
       else
         self.data['override'][builddefinition] = values
       end
     end
 
-    private
     def self.validate_type(type)
       VALID_PROVISIONER_TYPES.include? type
     end
+
+    private_class_method :validate_type
   end
-end
+end

data/lib/packer/runner.rb

@@ -17,12 +17,12 @@ module Packer
       else
         # Run but stream as well as capture stdout to the screen
         # see: http://stackoverflow.com/a/1162850/83386
-        Open3.popen3(cmd) do |std_in, std_out, std_err, thread|
+        Open3.popen3(cmd) do |_std_in, std_out, std_err, thread|
           # read each stream from a new thread
           Thread.new do
             until (raw = std_out.getc).nil? do
               stdout << raw
-              $stdout.write "#{raw}"
+              $stdout.write raw.to_s
             end
           end
           Thread.new do
@@ -35,6 +35,7 @@ module Packer
           status = thread.value
         end
       end
+      # rubocop:disable Style/NumericPredicate
       raise CommandExecutionError.new(stderr) unless status == 0
       stdout
     end

data/lib/packer/version.rb

@@ -1,3 +1,3 @@
 module Packer
-  VERSION = "1.6.0"
+  VERSION = '1.6.1'.freeze
 end

data/packer-config.gemspec

@@ -18,7 +18,7 @@ correct JSON format. It also saved me having to remember the esoteric Packer
 syntax for referencing variables and whatnot in the JSON.
 END
   spec.homepage      = 'https://github.com/ianchesal/packer-config'
-  spec.license       = 'Apache 2.0'
+  spec.license       = 'Apache-2.0'
   spec.required_ruby_version = '>= 2.0.0'
 
   spec.files         = `git ls-files -z`.split("\x0")

data/spec/integration/centos_vagrant_spec.rb

@@ -2,26 +2,26 @@
 require 'spec_helper'
 
 RSpec.describe Packer::Config do
-  it 'can build a centos-6.5 Vagrant base box' do
-    OS = 'centos-6.6'
+  it 'can build a centos-6.7 Vagrant base box' do
+    CENTOS_VERSION = '6.8'
 
-    pconfig = Packer::Config.new "#{OS}-vagrant.json"
-    pconfig.description "#{OS} VirtualBox Vagrant"
+    pconfig = Packer::Config.new "centos-#{CENTOS_VERSION}-vagrant.json"
+    pconfig.description "CentOS #{CENTOS_VERSION} VirtualBox Vagrant"
     pconfig.add_variable 'mirror', 'http://mirrors.sonic.net/centos/'
     pconfig.add_variable 'my_version', '0.0.1'
     pconfig.add_variable 'chef_version', 'latest'
 
     builder = pconfig.add_builder Packer::Builder::VIRTUALBOX_ISO
-    builder.boot_command ["<tab> text ks=http://#{pconfig.macro.HTTPIP}:#{pconfig.macro.HTTPPort}/#{OS}-ks.cfg<enter><wait>"]
+    builder.boot_command ["<tab> text ks=http://#{pconfig.macro.HTTPIP}:#{pconfig.macro.HTTPPort}/centos-#{CENTOS_VERSION}-ks.cfg<enter><wait>"]
     builder.boot_wait '10s'
-    builder.disk_size 40960
+    builder.disk_size 40_960
     builder.guest_additions_path "VBoxGuestAdditions_#{pconfig.macro.Version}.iso"
     builder.guest_os_type "RedHat_64"
     builder.http_directory "scripts/kickstart"
-    builder.iso_checksum '7bb8c1c23a4fdef93e6f0a6347d570e5764d0b38'
+    builder.iso_checksum 'afab3a588cda94cd768826e77ad4db2b5ee7c485'
     builder.iso_checksum_type 'sha1'
-    builder.iso_url "#{pconfig.variable 'mirror'}/6.7/isos/x86_64/CentOS-6.7-x86_64-bin-DVD1.iso"
-    builder.output_directory "#{OS}-x86_64-virtualbox"
+    builder.iso_url "#{pconfig.variable 'mirror'}/6/isos/x86_64/CentOS-#{CENTOS_VERSION}-x86_64-bin-DVD1.iso"
+    builder.output_directory "centos-#{CENTOS_VERSION}-x86_64-virtualbox"
     builder.shutdown_command "echo 'vagrant'|sudo -S /sbin/halt -h -p"
     builder.communicator "ssh"
     builder.ssh_password "vagrant"
@@ -43,7 +43,7 @@ RSpec.describe Packer::Config do
       ]
     ]
     builder.virtualbox_version_file ".vbox_version"
-    builder.vm_name "packer-#{OS}-x86_64"
+    builder.vm_name "packer-centos-#{CENTOS_VERSION}-x86_64"
 
     provisioner = pconfig.add_provisioner Packer::Provisioner::FILE
     provisioner.source 'scripts/hello.sh'
@@ -61,12 +61,12 @@ RSpec.describe Packer::Config do
     ]
     provisioner.environment_vars [
       "CHEF_VERSION=#{pconfig.variable 'chef_version'}",
-      "MY_VERSION=#{pconfig.variable 'my_version'}"
+      "MY_CENTOS_VERSION=#{pconfig.variable 'my_version'}"
     ]
     provisioner.execute_command "echo 'vagrant' | #{pconfig.macro.Vars} sudo -S -E bash '#{pconfig.macro.Path}'"
 
     postprocessor = pconfig.add_postprocessor Packer::PostProcessor::VAGRANT
-    postprocessor.output File.join('builds', pconfig.macro.Provider, "#{OS}-x86_64-#{pconfig.variable 'my_version'}.box")
+    postprocessor.output File.join('builds', pconfig.macro.Provider, "centos-#{CENTOS_VERSION}-x86_64-#{pconfig.variable 'my_version'}.box")
 
     Dir.chdir('spec/integration')
     expect(pconfig.validate).to be_truthy

data/spec/packer/envvar_spec.rb

@@ -19,7 +19,7 @@ RSpec.describe Packer::EnvVar do
   end
 
   it 'responds to anything' do
-    expect(envvar.respond_to? 'anything').to       be_truthy
-    expect(envvar.respond_to? 'anything_else').to  be_truthy
+    expect(envvar.respond_to?('anything')).to       be_truthy
+    expect(envvar.respond_to?('anything_else')).to  be_truthy
   end
 end

data/spec/packer/macro_spec.rb

@@ -19,7 +19,7 @@ RSpec.describe Packer::Macro do
   end
 
   it 'responds to anything' do
-    expect(macro.respond_to? 'anything').to       be_truthy
-    expect(macro.respond_to? 'anything_else').to  be_truthy
+    expect(macro.respond_to?('anything')).to       be_truthy
+    expect(macro.respond_to?('anything_else')).to  be_truthy
   end
 end

data/spec/packer/provisioners/ansible_spec.rb

@@ -23,7 +23,7 @@ RSpec.describe Packer::Provisioner::Ansible do
   end
 
   it 'requires a playbook_file setting' do
-    expect{ provisioner.validate }.to raise_error
+    expect { provisioner.validate }.to raise_error
   end
 
   describe '#initialize' do

data/spec/packer/provisioners/chef/client_spec.rb

@@ -23,7 +23,7 @@ RSpec.describe Packer::Provisioner::Chef::Client do
   end
 
   it 'requires a server_url setting' do
-    expect{ provisioner.validate }.to raise_error
+    expect { provisioner.validate }.to raise_error
   end
 
   describe '#initialize' do

data/spec/packer/provisioners/puppet/masterless_spec.rb

@@ -71,7 +71,7 @@ RSpec.describe Packer::Provisioner do
     end
 
     it 'raises an error if arguments cannot be made into a hash' do
-      expect{ provisioner.facter(some_string) }.to raise_error
+      expect { provisioner.facter(some_string) }.to raise_error
     end
   end
 

data/spec/packer/provisioners/salt_spec.rb

@@ -23,7 +23,7 @@ RSpec.describe Packer::Provisioner::Salt do
   end
 
   it 'requires a local_state_tree setting' do
-    expect{ provisioner.validate }.to raise_error
+    expect { provisioner.validate }.to raise_error
   end
 
   describe '#initialize' do

data/spec/packer/runner_spec.rb

@@ -7,13 +7,13 @@ RSpec.describe Packer::Runner do
     it 'returns stdout on success' do
       open3 = class_double("Open3").as_stubbed_const(:transfer_nested_constants => true)
       expect(open3).to receive(:capture3).and_return(['output', 'error', 0])
-      expect(described_class.run! 'true', quiet: true).to eq('output')
+      expect(described_class.run!('true', quiet: true)).to eq('output')
     end
 
     it 'raises an error on failure' do
       open3 = class_double("Open3").as_stubbed_const(:transfer_nested_constants => true)
       expect(open3).to receive(:capture3).and_return(['output', 'error', 1])
-      expect{ described_class.run! 'false', quiet: true }.to raise_error
+      expect { described_class.run!('false', quiet: true) }.to raise_error
     end
   end
 end

data/spec/packer_config_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 require 'fakefs/spec_helpers'
 
 RSpec.describe Packer::Config do
-  let(:config_file) { 'config.json'}
+  let(:config_file) { 'config.json' }
   let(:packer) { Packer::Config.new(config_file) }
   let(:builder_type) { Packer::Builder::VIRTUALBOX_ISO }
   let(:provisioner_type) { Packer::Provisioner::FILE }
@@ -97,33 +97,33 @@ RSpec.describe Packer::Config do
 
   describe "#add_builder" do
     it 'returns a builder for a valid type' do
-      expect(packer.add_builder builder_type).to be_a_kind_of(Packer::Builder)
+      expect(packer.add_builder(builder_type)).to be_a_kind_of(Packer::Builder)
       expect(packer.builders.length).to eq(1)
       packer.builders = []
     end
 
     it 'raises an error for an invalid type' do
-      expect { packer.add_builder 'invalid' }.to raise_error
+      expect { packer.add_builder('invalid') }.to raise_error
       expect(packer.builders.length).to eq(0)
     end
   end
 
   describe "#add_provisioner" do
     it 'returns a provisioner for a valid type' do
-      expect(packer.add_provisioner provisioner_type).to be_a_kind_of(Packer::Provisioner)
+      expect(packer.add_provisioner(provisioner_type)).to be_a_kind_of(Packer::Provisioner)
       expect(packer.provisioners.length).to eq(1)
       packer.provisioners = []
     end
 
     it 'raises an error for an invalid type' do
-      expect { packer.add_provisioner 'invalid' }.to raise_error
+      expect { packer.add_provisioner('invalid') }.to raise_error
       expect(packer.provisioners.length).to eq(0)
     end
   end
 
   describe "#add_postprocessor" do
     it 'returns a post-processor for a valid type' do
-      expect(packer.add_postprocessor postprocessor_type).to be_a_kind_of(Packer::PostProcessor)
+      expect(packer.add_postprocessor(postprocessor_type)).to be_a_kind_of(Packer::PostProcessor)
       expect(packer.postprocessors.length).to eq(1)
       packer.postprocessors = []
     end
@@ -149,7 +149,7 @@ RSpec.describe Packer::Config do
     it 'creates a packer reference to a variable in the configuration' do
       expect(packer.variables).to eq({})
       packer.add_variable('key1', 'value1')
-      expect(packer.variable 'key1').to eq('{{user `key1`}}')
+      expect(packer.variable('key1')).to eq('{{user `key1`}}')
       packer.data['variables'] = {}
     end
 
@@ -180,7 +180,7 @@ RSpec.describe Packer::Config do
 
     it 'raises an error if the version of Packer is not high enough' do
       expect(Packer::Runner).to receive(:run!).and_return('Packer v0.0.1')
-      expect{ packer.verify_packer_version }.to raise_error
+      expect { packer.verify_packer_version }.to raise_error
     end
   end
 end

data/tasks/clean.rake

@@ -6,10 +6,10 @@ task :clean do
   FileList['spec/integration/packer_cache/*'].each do |f|
     FileUtils.rm_f(f)
   end
-  Dir.glob('spec/integration/builds/*').select {|f| File.directory? f}.each do |d|
+  Dir.glob('spec/integration/builds/*').select { |f| File.directory? f }.each do |d|
     FileUtils.rm_rf(d)
   end
-  Dir.glob('spec/integration/*.json').select {|f| File.file? f}.each do |d|
+  Dir.glob('spec/integration/*.json').select { |f| File.file? f }.each do |d|
     FileUtils.rm_f(d)
   end
 end

data/tasks/rspec.rake

@@ -2,7 +2,7 @@ require 'rspec/core/rake_task'
 
 namespace :test do
   RSpec::Core::RakeTask.new(:spec) do |t|
-    t.pattern = Dir['spec/**/*_spec.rb'].reject{ |f| f['/integration'] }
+    t.pattern = Dir['spec/**/*_spec.rb'].reject { |f| f['/integration'] }
   end
 
   RSpec::Core::RakeTask.new(:integration) do |t|

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: packer-config
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.6.1
 platform: ruby
 authors:
 - Ian Chesal
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-08 00:00:00.000000000 Z
+date: 2016-09-15 00:00:00.000000000 Z
 dependencies: []
 description: |
   Building the Packer JSON configurations in raw JSON can be quite an adventure.
@@ -79,7 +79,7 @@ files:
 - spec/integration/scripts/cleanup.sh
 - spec/integration/scripts/fix-slow-dns.sh
 - spec/integration/scripts/hello.sh
-- spec/integration/scripts/kickstart/centos-6.6-ks.cfg
+- spec/integration/scripts/kickstart/centos-6.8-ks.cfg
 - spec/integration/scripts/minimize.sh
 - spec/integration/scripts/sshd.sh
 - spec/integration/scripts/vagrant.sh
@@ -122,7 +122,7 @@ files:
 - tasks/rubygems.rake
 homepage: https://github.com/ianchesal/packer-config
 licenses:
-- Apache 2.0
+- Apache-2.0
 metadata: {}
 post_install_message: 
 rdoc_options: []
@@ -140,7 +140,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: An object model to build packer.io configurations in Ruby.
@@ -153,7 +153,7 @@ test_files:
 - spec/integration/scripts/cleanup.sh
 - spec/integration/scripts/fix-slow-dns.sh
 - spec/integration/scripts/hello.sh
-- spec/integration/scripts/kickstart/centos-6.6-ks.cfg
+- spec/integration/scripts/kickstart/centos-6.8-ks.cfg
 - spec/integration/scripts/minimize.sh
 - spec/integration/scripts/sshd.sh
 - spec/integration/scripts/vagrant.sh